Re: [Python-Dev] PEP 485: math.isclose()

2015-05-25 Thread Tal Einat
On Mon, May 25, 2015 at 9:45 AM, Chris Barker wrote: > And a few comments on the patch ( I have not idea how to patch a patch...) > Is there a branch somewhere with this patch applied? Not at the moment. But if you click the "review" link next to the patch on the tracker then you can leave commen

Re: [Python-Dev] PEP 485: math.isclose()

2015-05-24 Thread Chris Barker
And a few comments on the patch ( I have not idea how to patch a patch...) Is there a branch somewhere with this patch applied? I'm going through PEP 7, and cleaned up the docstring a bit: diff -r 15af4f58d143 Modules/mathmodule.c --- a/Modules/mathmodule.c Sun May 24 22:27:00 2015 -0700 +++

Re: [Python-Dev] PEP 485: math.isclose()

2015-05-24 Thread Tal Einat
On Mon, May 25, 2015 at 7:53 AM, Chris Barker wrote: > I don't think I have permissions to comment on the issue,so I'm posting > here. If there is a way for me to post to the issue, someone let me know... You just need to register on the issue tracker. On bugs.python.org, there is a "register" li

[Python-Dev] PEP 485: math.isclose()

2015-05-24 Thread Chris Barker
I don't think I have permissions to comment on the issue,so I'm posting here. If there is a way for me to post to the issue, someone let me know... In the issue (http://bugs.python.org/issue24270) Tal wrote """ I have a question regarding complex values. The code (from Chris Barker) doesn't suppo