Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-09 Thread Ben Hoyt
> > os.walk took 0.061s, scandir.walk took 0.012s -- 5.2x as fast > Great, looks much better. :-) Even a bit better than what I'm seeing -- possibly due to your SSD. -Ben ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/

Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-09 Thread Ryan Stuart
Hi Ben, On Mon, 9 Mar 2015 at 21:58 Ben Hoyt wrote: > Note that this benchmark is invalid for a couple of reasons. (...) > Thanks a lot for the guidance Ben, greatly appreciated. Just starting to take an interest in the development of CPython and so something like running a benchmark seemed lik

Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-09 Thread Ben Hoyt
Hi Ryan, > ./configure --with-pydebug && make -j7 > > I then ran ./python.exe ~/Workspace/python/scandir/benchmark.py and I got: > > Creating tree at /Users/rstuart/Workspace/python/scandir/benchtree: depth=4, > num_dirs=5, num_files=50 > Using slower ctypes version of scandir > Comparing against

Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-09 Thread Larry Hastings
On 03/07/2015 06:13 PM, Victor Stinner wrote: Hi, FYI I commited the implementation of os.scandir() written by Ben Hoyt. I hope that it will be part of Python 3.5 alpha 2 It is. //arry/ ___ Python-Dev mailing list Python-Dev@python.org https://mail

Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-08 Thread Tim Delaney
On 8 March 2015 at 13:31, Ben Hoyt wrote: > Thanks for committing this, Victor! And fixing the d_type issue on funky > platforms. > > Others: if you want to benchmark this, the simplest way is to use my > os.walk() benchmark.py test program here: > https://github.com/benhoyt/scandir -- it compare

Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-08 Thread Paul Moore
On 8 March 2015 at 02:13, Victor Stinner wrote: > FYI I commited the implementation of os.scandir() written by Ben Hoyt. > I hope that it will be part of Python 3.5 alpha 2 (Ben just sent the > final patch today). Yay! Great news. Paul ___ Python-Dev ma

Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-08 Thread Nick Coghlan
On 8 March 2015 at 12:13, Victor Stinner wrote: > Hi, > > FYI I commited the implementation of os.scandir() written by Ben Hoyt. > I hope that it will be part of Python 3.5 alpha 2 (Ben just sent the > final patch today). Thanks to everyone that worked on getting this PEP through to Final status!

Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-07 Thread Ryan Stuart
Hi, On Sun, 8 Mar 2015 at 12:33 Ben Hoyt wrote: > Others: if you want to benchmark this, the simplest way is to use my > os.walk() benchmark.py test program here: > https://github.com/benhoyt/scandir -- it compares the built-in os.walk() > implemented with os.listdir() with a version of walk() i

Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-07 Thread Victor Stinner
2015-03-08 3:31 GMT+01:00 Ben Hoyt : > Thanks for committing this, Victor! And fixing the d_type issue on funky > platforms. You're welcome. > Note that the actual CPython version of os.walk() doesn't yet use > os.scandir(). I intend to open a separate issue for that shortly (or Victor > can). Bu

Re: [Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-07 Thread Ben Hoyt
Thanks for committing this, Victor! And fixing the d_type issue on funky platforms. Others: if you want to benchmark this, the simplest way is to use my os.walk() benchmark.py test program here: https://github.com/benhoyt/scandir -- it compares the built-in os.walk() implemented with os.listdir()

[Python-Dev] PEP 471 Final: os.scandir() merged into Python 3.5

2015-03-07 Thread Victor Stinner
Hi, FYI I commited the implementation of os.scandir() written by Ben Hoyt. I hope that it will be part of Python 3.5 alpha 2 (Ben just sent the final patch today). Please test this new feature. You may benchmark here. http://bugs.python.org/issue22524 contains some benchmark tools and benchmark r