Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-06 Thread Neil Toronto
Kevin Jacobs <[EMAIL PROTECTED]> wrote: > On Dec 6, 2007 1:35 AM, Neil Toronto <[EMAIL PROTECTED] > > wrote: > > So I've applied Armin's patch to 2.6 (it was nearly clean) and am > playing with it. cls.name lookups are 15-20% > faster than m

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-06 Thread Kevin Jacobs <[EMAIL PROTECTED]>
On Dec 6, 2007 1:35 AM, Neil Toronto <[EMAIL PROTECTED]> wrote: > So I've applied Armin's patch to 2.6 (it was nearly clean) and am > playing with it. cls.name lookups are 15-20% faster than mine, and > inst.name lookups are 5-10% faster. His is also winning on hasattr calls > (succeeding and fail

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Neil Toronto
Phillip J. Eby wrote: > At 07:43 PM 12/5/2007 -0700, Neil Toronto wrote: >> FWIW, I like it. Though the hash should really incorporate the hash of >> the type name as well as the attribute's so that sometype.method calling >> othertype.method doesn't invalidate the cache. Locality makes the global

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Phillip J. Eby
At 07:43 PM 12/5/2007 -0700, Neil Toronto wrote: >Phillip J. Eby wrote: > > At 10:48 PM 12/5/2007 +0100, Georg Brandl wrote: > >> Neil Toronto schrieb: > >>> So Jim and PJE finally convinced me to do it the right way. :) Thanks > >>> guys - it turned out very nice. > >> How does this relate to Armi

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Neil Toronto
Phillip J. Eby wrote: > At 10:48 PM 12/5/2007 +0100, Georg Brandl wrote: >> Neil Toronto schrieb: >>> So Jim and PJE finally convinced me to do it the right way. :) Thanks >>> guys - it turned out very nice. >> How does this relate to Armin Rigo's method cache patch? >> >> (http://bugs.python.org/i

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Raymond Hettinger
> Hm... [EMAIL PROTECTED] bounced. I wonder what's going on there.. I'm now in an EWT spin-off company. The new email address is [EMAIL PROTECTED] Also, I frequently check the [EMAIL PROTECTED] account too. Raymond ___ Python-Dev mailing list Python

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Raymond Hettinger
> I never even saw that one. I'm hoping Raymond will have another look. Great. Will review it this week. Raymond ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Guido van Rossum
Hm... [EMAIL PROTECTED] bounced. I wonder what's going on there... On Dec 5, 2007 4:11 PM, Guido van Rossum <[EMAIL PROTECTED]> wrote: > On Dec 5, 2007 4:08 PM, Kevin Jacobs <[EMAIL PROTECTED]> > > <[EMAIL PROTECTED]> wrote: > > On Dec 5, 2007 5:50 PM, Phillip J. Eby <[EMAIL PROTECTED]> wrote: > >

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Guido van Rossum
On Dec 5, 2007 4:08 PM, Kevin Jacobs <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> wrote: > On Dec 5, 2007 5:50 PM, Phillip J. Eby <[EMAIL PROTECTED]> wrote: > > At 10:48 PM 12/5/2007 +0100, Georg Brandl wrote: > > >Neil Toronto schrieb: > > > > So Jim and PJE finally convinced me to do it the right way.

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Kevin Jacobs <[EMAIL PROTECTED]>
On Dec 5, 2007 5:50 PM, Phillip J. Eby <[EMAIL PROTECTED]> wrote: > At 10:48 PM 12/5/2007 +0100, Georg Brandl wrote: > >Neil Toronto schrieb: > > > So Jim and PJE finally convinced me to do it the right way. :) Thanks > > > guys - it turned out very nice. > > > >How does this relate to Armin Rigo'

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Phillip J. Eby
At 10:48 PM 12/5/2007 +0100, Georg Brandl wrote: >Neil Toronto schrieb: > > So Jim and PJE finally convinced me to do it the right way. :) Thanks > > guys - it turned out very nice. > >How does this relate to Armin Rigo's method cache patch? > >(http://bugs.python.org/issue1685986) Interesting. A

Re: [Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Georg Brandl
Neil Toronto schrieb: > So Jim and PJE finally convinced me to do it the right way. :) Thanks > guys - it turned out very nice. How does this relate to Armin Rigo's method cache patch? (http://bugs.python.org/issue1685986) Georg ___ Python-Dev mailin

[Python-Dev] PATCH: attribute lookup caching for 2.6

2007-12-05 Thread Neil Toronto
So Jim and PJE finally convinced me to do it the right way. :) Thanks guys - it turned out very nice. http://bugs.python.org/issue1560 http://spreadsheets.google.com/ccc?key=pHIJrYc_pnIUpTm6QSG2gZg&hl=en_US It caches type/metatype attribute lookups, including missing attributes. Summary of the