Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-26 Thread Brett Cannon
On Mon, 26 Jun 2017 at 14:28 Terry Reedy wrote: > On 6/25/2017 4:09 PM, Guido van Rossum wrote: > > On Sun, Jun 25, 2017 at 12:23 PM, Brett Cannon > > wrote: > > > > > > > > On Sun, Jun 25, 2017, 11:24 Terry Reedy, > > wrote: > > > > >

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-26 Thread Terry Reedy
On 6/25/2017 4:09 PM, Guido van Rossum wrote: On Sun, Jun 25, 2017 at 12:23 PM, Brett Cannon > wrote: On Sun, Jun 25, 2017, 11:24 Terry Reedy, mailto:tjre...@udel.edu>> wrote: I was not aware that PRs could be edited via a web UI and have no ide

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-26 Thread Brett Cannon
On Sun, 25 Jun 2017 at 20:56 Nick Coghlan wrote: > On 26 June 2017 at 02:39, Brett Cannon wrote: > > On Sat, Jun 24, 2017, 23:45 Nick Coghlan, wrote: > >> I was mainly referring to cases where either an initial commit (with a > >> complete NEWS entry) requires follow-up fixes (no NEWS edit > >>

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Nick Coghlan
On 26 June 2017 at 02:39, Brett Cannon wrote: > On Sat, Jun 24, 2017, 23:45 Nick Coghlan, wrote: >> I was mainly referring to cases where either an initial commit (with a >> complete NEWS entry) requires follow-up fixes (no NEWS edit >> necessary). >> >> However, another case did occur to me, whi

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Guido van Rossum
On Sun, Jun 25, 2017 at 12:23 PM, Brett Cannon wrote: > > > On Sun, Jun 25, 2017, 11:24 Terry Reedy, wrote: > >> On 6/25/2017 12:39 PM, Brett Cannon wrote: >> >> > The entire reason I want to have this check is I don't want or have to >> > ask another PR submitter to include a draft of a news it

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Brett Cannon
On Sun, Jun 25, 2017, 11:24 Terry Reedy, wrote: > On 6/25/2017 12:39 PM, Brett Cannon wrote: > > > The entire reason I want to have this check is I don't want or have to > > ask another PR submitter to include a draft of a news item. It's much > > easier to edit an existing news entry through the

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Terry Reedy
On 6/25/2017 12:39 PM, Brett Cannon wrote: The entire reason I want to have this check is I don't want or have to ask another PR submitter to include a draft of a news item. It's much easier to edit an existing news entry through the web UI than either ask for it and deal with the turnaround t

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Donald Stufft
> On Jun 25, 2017, at 12:39 PM, Brett Cannon wrote: > > > > On Sat, Jun 24, 2017, 23:45 Nick Coghlan, > wrote: > On 25 June 2017 at 16:31, Terry Reedy > wrote: > >> 25.06.17 06:04, Nick Coghlan пише: > >>> All the PRs share an issue number

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Brett Cannon
On Sat, Jun 24, 2017, 23:45 Nick Coghlan, wrote: > On 25 June 2017 at 16:31, Terry Reedy wrote: > >> 25.06.17 06:04, Nick Coghlan пише: > >>> All the PRs share an issue number in that case, so Bedevere should be > >>> able to pick up that there's a pre-existing NEWS entry (even if it > >>> isn't

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Terry Reedy
On 6/25/2017 12:16 PM, Terry Reedy wrote: On 6/25/2017 8:06 AM, Serhiy Storchaka wrote: 24.06.17 18:57, Larry Hastings пише: On 06/24/2017 01:53 AM, Antoine Pitrou wrote: Would you like to make it 3.5-compatible? 3.6 is quite young and not all systems have it (e.g. Ubuntu 16.04, which many pe

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Terry Reedy
On 6/25/2017 8:06 AM, Serhiy Storchaka wrote: 24.06.17 18:57, Larry Hastings пише: On 06/24/2017 01:53 AM, Antoine Pitrou wrote: Would you like to make it 3.5-compatible? 3.6 is quite young and not all systems have it (e.g. Ubuntu 16.04, which many people use, has 3.5). Well, tbh I think tha

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Serhiy Storchaka
24.06.17 18:57, Larry Hastings пише: On 06/24/2017 01:53 AM, Antoine Pitrou wrote: Would you like to make it 3.5-compatible? 3.6 is quite young and not all systems have it (e.g. Ubuntu 16.04, which many people use, has 3.5). Well, tbh I think that's a bit silly. First of all, it shouldn't be

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Nick Coghlan
On 25 June 2017 at 16:31, Terry Reedy wrote: >> 25.06.17 06:04, Nick Coghlan пише: >>> All the PRs share an issue number in that case, so Bedevere should be >>> able to pick up that there's a pre-existing NEWS entry (even if it >>> isn't being added by that particular PR). > > You seem to be sugge

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Terry Reedy
On 6/25/2017 12:30 AM, Serhiy Storchaka wrote: 25.06.17 06:04, Nick Coghlan пише: On 25 June 2017 at 11:56, Terry Reedy wrote: On 6/24/2017 7:48 PM, Brett Cannon wrote: I should also mention that after Larry blows up Misc/NEWS into individual files in about a week I will add a check to Bedeve

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Terry Reedy
On 6/25/2017 12:19 AM, Serhiy Storchaka wrote: 25.06.17 04:51, Nick Coghlan пише: So count me in as a +1 for standardising on a model where: - client-side core-workflow tools are free to use features from the latest released version of Python - we expect core devs to set up a venv or conda env

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Larry Hastings
On 06/24/2017 09:14 PM, Serhiy Storchaka wrote: Not only core developers make PRs for CPython. Since all non-trivial changes need to be mentioned in Misc/NEWS, blurb becomes a required tool for all committers. Well, no. *Writing blurb-compatible files* becomes a required step for all committ

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Serhiy Storchaka
25.06.17 06:04, Nick Coghlan пише: On 25 June 2017 at 11:56, Terry Reedy wrote: On 6/24/2017 7:48 PM, Brett Cannon wrote: I should also mention that after Larry blows up Misc/NEWS into individual files in about a week I will add a check to Bedevere for a news file unless the PR is labeled as t

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Serhiy Storchaka
25.06.17 04:51, Nick Coghlan пише: So count me in as a +1 for standardising on a model where: - client-side core-workflow tools are free to use features from the latest released version of Python - we expect core devs to set up a venv or conda env to run those tools if their system Python is too

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Serhiy Storchaka
24.06.17 18:57, Larry Hastings пише: On 06/24/2017 01:53 AM, Antoine Pitrou wrote: Would you like to make it 3.5-compatible? 3.6 is quite young and not all systems have it (e.g. Ubuntu 16.04, which many people use, has 3.5). Well, tbh I think that's a bit silly. First of all, it shouldn't be

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Nick Coghlan
On 25 June 2017 at 11:56, Terry Reedy wrote: > On 6/24/2017 7:48 PM, Brett Cannon wrote: > >> I should also mention that after Larry blows up Misc/NEWS into individual >> files in about a week I will add a check to Bedevere for a news file unless >> the PR is labeled as trivial. > > > And what if

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Larry Hastings
On 06/24/2017 06:56 PM, Terry Reedy wrote: And what if there isn't? There are sometimes good reasons to have multiple patches on an issue, whereas an issue usually gets only one news item. There's nothing about blurb--or anything else in the workflow IIUC--that says you can't have multiple

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Terry Reedy
On 6/24/2017 7:48 PM, Brett Cannon wrote: I should also mention that after Larry blows up Misc/NEWS into individual files in about a week I will add a check to Bedevere for a news file unless the PR is labeled as trivial. And what if there isn't? There are sometimes good reasons to have mul

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Nick Coghlan
On 25 June 2017 at 02:10, Antoine Pitrou wrote: > On Sat, 24 Jun 2017 08:57:24 -0700 > Larry Hastings wrote: >> On 06/24/2017 01:53 AM, Antoine Pitrou wrote: >> > Would you like to make it 3.5-compatible? 3.6 is quite young and not >> > all systems have it (e.g. Ubuntu 16.04, which many people u

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Antoine Pitrou
On Sat, 24 Jun 2017 23:48:03 + Brett Cannon wrote: > On Sat, 24 Jun 2017 at 10:07 Antoine Pitrou wrote: > > > > > Larry, > > > > I have just used blurb on https://github.com/python/cpython/pull/2010 > > and it was absolutely painless. Thank you! > > > > One minor thing: `make patchcheck` do

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Brett Cannon
On Sat, 24 Jun 2017 at 10:07 Antoine Pitrou wrote: > > Larry, > > I have just used blurb on https://github.com/python/cpython/pull/2010 > and it was absolutely painless. Thank you! > > One minor thing: `make patchcheck` doesn't know to examine the NEWS.d > directory when checking for NEWS entrie

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Antoine Pitrou
Larry, I have just used blurb on https://github.com/python/cpython/pull/2010 and it was absolutely painless. Thank you! One minor thing: `make patchcheck` doesn't know to examine the NEWS.d directory when checking for NEWS entries. Regards Antoine. On Fri, 23 Jun 2017 20:24:05 -0700 Larry

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Terry Reedy
On 6/24/2017 11:57 AM, Larry Hastings wrote: On 06/24/2017 01:53 AM, Antoine Pitrou wrote: Would you like to make it 3.5-compatible? 3.6 is quite young and not all systems have it (e.g. Ubuntu 16.04, which many people use, has 3.5). Well, tbh I think that's a bit silly. First of all, it shou

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Antoine Pitrou
On Sat, 24 Jun 2017 08:57:24 -0700 Larry Hastings wrote: > On 06/24/2017 01:53 AM, Antoine Pitrou wrote: > > Would you like to make it 3.5-compatible? 3.6 is quite young and not > > all systems have it (e.g. Ubuntu 16.04, which many people use, has 3.5). > > Well, tbh I think that's a bit sill

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Larry Hastings
On 06/23/2017 10:55 PM, Nick Coghlan wrote: Aye, towncrier and OpenStack's reno were the two main alternatives we looked at in addition to Larry's offer of creating a tool specifically for CPython: https://github.com/python/core-workflow/issues/6 Fun fact: all three tools started at about the s

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Larry Hastings
On 06/24/2017 01:53 AM, Antoine Pitrou wrote: Would you like to make it 3.5-compatible? 3.6 is quite young and not all systems have it (e.g. Ubuntu 16.04, which many people use, has 3.5). Well, tbh I think that's a bit silly. First of all, it shouldn't be installed in your system-wide python

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Serhiy Storchaka
24.06.17 11:53, Antoine Pitrou пише: On Fri, 23 Jun 2017 20:24:05 -0700 Larry Hastings wrote: We've been talking about addressing this for years. Fixing this was one of the goals of the new workflow. And finally, as of right now, the future is here. Ladies and gentlemen, I present: blurb.

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-24 Thread Antoine Pitrou
On Fri, 23 Jun 2017 20:24:05 -0700 Larry Hastings wrote: > > We've been talking about addressing this for years. Fixing this was one > of the goals of the new workflow. And finally, as of right now, the > future is here. Ladies and gentlemen, I present: blurb. > > https://github.com/pyt

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-23 Thread Nick Coghlan
On 24 June 2017 at 14:01, Craig Rodrigues wrote: > On Fri, Jun 23, 2017 at 8:24 PM, Larry Hastings wrote: >> >> >> >> We've been talking about addressing this for years. Fixing this was one >> of the goals of the new workflow. And finally, as of right now, the future >> is here. Ladies and gen

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-23 Thread Steve Dower
From: Larry Hastings Sent: Friday, June 23, 2017 20:26 To: Python Dev; python-committers Subject: [Python-Dev] New workflow change: Welcome to blurb One minor but ongoing problem we've had in CPython core development has been the mess of updating Misc/NEWS.  Day-to-day developers may have a c

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-23 Thread Craig Rodrigues
On Fri, Jun 23, 2017 at 8:24 PM, Larry Hastings wrote: > > > We've been talking about addressing this for years. Fixing this was one > of the goals of the new workflow. And finally, as of right now, the future > is here. Ladies and gentlemen, I present: blurb. > > https://github.com/python/cor

[Python-Dev] New workflow change: Welcome to blurb

2017-06-23 Thread Larry Hastings
One minor but ongoing problem we've had in CPython core development has been the mess of updating Misc/NEWS. Day-to-day developers may have a conflict if they lose a push race, which means a little editing. You'll have a similar, if slightly worse, problem when cherry-picking a fix between