Re: [Python-Dev] Missing *-unpacking generalizations (issue 2292)

2015-03-21 Thread Benjamin Peterson
On Fri, Mar 20, 2015, at 19:16, Neil Girdhar wrote: > Wow, this is an excellent review. Thank you. > > My only question is with respect to this: > > I think there ought to be two opcodes; one for unpacking maps in > function calls and another for literals. The whole function location > thing i

Re: [Python-Dev] Missing *-unpacking generalizations (issue 2292)

2015-03-20 Thread Neil Girdhar
Wow, this is an excellent review. Thank you. My only question is with respect to this: I think there ought to be two opcodes; one for unpacking maps in function calls and another for literals. The whole function location thing is rather hideous. What are the two opcodes? BUILD_MAP_UNPACK and B