On 6/1/07, Fred L. Drake, Jr. <[EMAIL PROTECTED]> wrote:
> Changes in general are a source of risk; they have to be considered carefully.
> We've seen too many cases in which a change was thought to be safe, but broke
> something for someone. Avoiding style-only changes helps avoid introducing
> p
On Friday 01 June 2007, BJörn Lindqvist wrote:
> Patches are applied once, but thousands of people read the code in the
> standard library each month. The standard library should be as
> readable as possible to make it as easy as possible to maintain. It is
> just good software development meth
Patches are applied once, but thousands of people read the code in the
standard library each month. The standard library should be as
readable as possible to make it as easy as possible to maintain. It is
just good software development methodology.
Many parts of the standard library are arcane an
Fred,
My only motivation was style.
As per your comment:
"In general, we try to avoid making style changes to the code since that can
increase the maintenance burden (patches can be harder to produce that can
be
cleanly applied to multiple versions)."
I will keep this in mind when supplying fu
On Saturday 26 May 2007, Joseph Armbruster wrote:
> I noticed that one of the parts of ConfigParser was not using "for line
> in fp" style of readline-ing :-) So, this will reduce the SLOC by 3
> lines and improve readability. However, I did a quick grep and this
> type of practice appears in
Kristján,
Whoops! My apologies. In any case, I created the bugs in the sf issue
tracker for proper CM practice. Look under the patches section within
sf.net.
You should go ahead and close out the 2005 build ones then, once applied :-)
Thank you again,
Joseph Armbruster
Kristján Valur Jó
> -Original Message-
> From: Joseph Armbruster [mailto:[EMAIL PROTECTED]
>
> I noticed that one of the parts of ConfigParser was not using "for line
> in fp" style of readline-ing
I'm afraid my authority is limited to .c stuff having to do with pcbuild8,
but I'm sure someone else here wo
Kristján,
Here is a part of the patch that I was referring to. Something to that
effect.
Joseph Armbruster
Index: Lib/ConfigParser.py
===
--- Lib/ConfigParser.py (revision 55600)
+++ Lib/ConfigParser.py (working copy)
@@ -441,10
Kristján,
While we are on the topic of minor changes... :-)
I noticed that one of the parts of ConfigParser was not using "for line
in fp" style of readline-ing :-) So, this will reduce the SLOC by 3
lines and improve readability. However, I did a quick grep and this
type of practice appear
