Re: [Python-Dev] Merging the implementation of PEP 563

2018-01-25 Thread Yury Selivanov
I looked at the PR and I think the code is fine. Yury On Thu, Jan 25, 2018 at 4:39 PM, Victor Stinner wrote: > Hi, > > If nobody is available to review your PR, I suggest to push it anyway, > to get it merged before the feature freeze. The code can be reviewed > later. Merging it sooner gives mo

Re: [Python-Dev] Merging the implementation of PEP 563

2018-01-25 Thread Victor Stinner
Hi, If nobody is available to review your PR, I suggest to push it anyway, to get it merged before the feature freeze. The code can be reviewed later. Merging it sooner gives more time to test it and spot bugs. It also gives more time to fix bugs ;-) Well, at the end, it's up to you. Victor 2018

[Python-Dev] Merging the implementation of PEP 563

2018-01-25 Thread Lukasz Langa
Hi all, Serhiy looks busy these days. I'd appreciate somebody looking at and hopefully merging https://github.com/python/cpython/pull/4390 . Everything there was reviewed by Serhiy except for the latest commit. This should be ready to merge and maybe