Re: [Python-Dev] Location of tests for packages

2011-01-25 Thread Nick Coghlan
On Wed, Jan 26, 2011 at 4:16 AM, Alexander Belopolsky wrote: > FWIW, I am +0 on consolidating tests under Lib/test.  One of the > reasons that I have not seen mentioned is that it is well-known that > test package is not part of the official stdlib API and can be > changes/restructured in backward

Re: [Python-Dev] Location of tests for packages

2011-01-25 Thread Alexander Belopolsky
On Tue, Jan 25, 2011 at 12:38 PM, Brett Cannon wrote: >.. If we move some modules and not others purely because some > distros choose not to ship e.g., ctypes and sqlite3 I don't see why this is a problem. Regrtest already has a mechanism that allows skipping tests based on various criteria. Th

Re: [Python-Dev] Location of tests for packages

2011-01-25 Thread Brett Cannon
On Mon, Jan 24, 2011 at 17:19, Raymond Hettinger wrote: > > On Jan 24, 2011, at 3:40 PM, Michael Foord wrote: >> It isn't just unittest, it seems that all *test packages* are in their >> respective package and not Lib/test except for the json module where Raymond >> already moved the tests: >> >

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Georg Brandl
Am 25.01.2011 02:19, schrieb Raymond Hettinger: > > On Jan 24, 2011, at 3:40 PM, Michael Foord wrote: >> It isn't just unittest, it seems that all *test packages* are in their >> respective package and not Lib/test except for the json module where Raymond >> already moved the tests: >> >>di

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Georg Brandl
Am 25.01.2011 00:14, schrieb "Martin v. Löwis": >>> This isn't a critical issue (nothing is broken) but we're a week >>> from another release candidate, so the new Py3.2 package >>> organization (unittest was flat in Py3.1 and its test were under >>> Lib/test) is about to become a de-facto decision

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Raymond Hettinger
On Jan 24, 2011, at 3:40 PM, Michael Foord wrote: > It isn't just unittest, it seems that all *test packages* are in their > respective package and not Lib/test except for the json module where Raymond > already moved the tests: > >distutils/tests >email/test >ctypes/test >impor

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Michael Foord
On 24/01/2011 23:14, "Martin v. Löwis" wrote: This isn't a critical issue (nothing is broken) but we're a week from another release candidate, so the new Py3.2 package organization (unittest was flat in Py3.1 and its test were under Lib/test) is about to become a de-facto decision that will be ha

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Michael Foord
On 24/01/2011 19:46, Raymond Hettinger wrote: Right now, the tests for the unittest package are under the package directory instead of Lib/test where we have most of the other tests. There are some other packages that do the same thing, each for their own reason. I think we should develop a st

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Antoine Pitrou
Le mardi 25 janvier 2011 à 00:14 +0100, "Martin v. Löwis" a écrit : > >> This isn't a critical issue (nothing is broken) but we're a week > >> from another release candidate, so the new Py3.2 package > >> organization (unittest was flat in Py3.1 and its test were under > >> Lib/test) is about to be

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Martin v. Löwis
>> This isn't a critical issue (nothing is broken) but we're a week >> from another release candidate, so the new Py3.2 package >> organization (unittest was flat in Py3.1 and its test were under >> Lib/test) is about to become a de-facto decision that will be hard >> to undo. > > Well can we stop

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Benjamin Peterson
2011/1/24 Éric Araujo : >> Right now, the tests for the unittest package are under the >> package directory instead of Lib/test where we have most of the >> other tests. >> >> There are some other packages that do the same thing, each for >> their own reason. > > The corresponding bug report is #10

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Antoine Pitrou
On Mon, 24 Jan 2011 11:46:45 -0800 Raymond Hettinger wrote: > > This isn't a critical issue (nothing is broken) but we're a week from another > release candidate, so the new Py3.2 package organization (unittest was flat > in Py3.1 and its test were under Lib/test) is about to become a de-facto

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Barry Warsaw
On Jan 24, 2011, at 11:46 AM, Raymond Hettinger wrote: >P.S. I've discussed this with Michael and his preference is against going >back to the Py3.1 style where the tests were under Lib/test. He thinks the >current tree makes it easier to sync with Py2.7 and the unittest2 third-party >module. A

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Fred Drake
On Mon, Jan 24, 2011 at 2:46 PM, Raymond Hettinger wrote: > P.S.  I've discussed this with Michael and his preference is against > going back to the Py3.1 style where the tests were under Lib/test.  He > thinks the current tree makes it easier to sync with Py2.7 and the > unittest2 third-party mod

Re: [Python-Dev] Location of tests for packages

2011-01-24 Thread Éric Araujo
> Right now, the tests for the unittest package are under the > package directory instead of Lib/test where we have most of the > other tests. > > There are some other packages that do the same thing, each for > their own reason. The corresponding bug report is #10572 (opened by Michael Foord).

[Python-Dev] Location of tests for packages

2011-01-24 Thread Raymond Hettinger
Right now, the tests for the unittest package are under the package directory instead of Lib/test where we have most of the other tests. There are some other packages that do the same thing, each for their own reason. I think we should develop a strong preference for tests going under Lib/test