Re: [Python-Dev] Cleanup of abstract.h header

2016-12-19 Thread Victor Stinner
2016-12-16 11:24 GMT+01:00 Antoine Pitrou : > Since you are cleaning up, you could remove the whole "PROPOSAL: A > Generic Python Object Interface for Python C Modules" introduction, > which isn't very interesting to read today. Done: hg.python.org/cpython/rev/3ab0a6692e25 Victor

Re: [Python-Dev] Cleanup of abstract.h header

2016-12-16 Thread Guido van Rossum
Many eons ago, Jim created abstract.h. The proposal comment (which you're right to be cutting out now) was his and at some point it was accepted, but I just copied-pasted the whole text into abstract.h. So yes, please keep the "many thanks to Jim Fulton" in there! On Fri, Dec 16, 2016 at 7:03 AM,

Re: [Python-Dev] Cleanup of abstract.h header

2016-12-16 Thread Victor Stinner
2016-12-16 11:24 GMT+01:00 Antoine Pitrou : > Since you are cleaning up, you could remove the whole "PROPOSAL: A > Generic Python Object Interface for Python C Modules" introduction, > which isn't very interesting to read today. Ah right, I noticed this huge comment but I didn't understand the pur

Re: [Python-Dev] Cleanup of abstract.h header

2016-12-16 Thread Antoine Pitrou
On Thu, 15 Dec 2016 11:22:10 +0100 Victor Stinner wrote: > > Before: > https://hg.python.org/cpython/file/f692dafe6797/Include/abstract.h > > Now: > https://hg.python.org/cpython/file/c4bcca326c0a/Include/abstract.h Since you are cleaning up, you could remove the whole "PROPOSAL: A Generic Pyth

Re: [Python-Dev] Cleanup of abstract.h header

2016-12-15 Thread Benjamin Peterson
I think it looks better. Thank you. On Thu, Dec 15, 2016, at 02:22, Victor Stinner wrote: > Hi, > > I made multiple changes to the Include/abstract.h header file, because > it was inconsistent in different manners: > > * Parameter names of functions of the PyObject_Call family were > inconsisten

[Python-Dev] Cleanup of abstract.h header

2016-12-15 Thread Victor Stinner
Hi, I made multiple changes to the Include/abstract.h header file, because it was inconsistent in different manners: * Parameter names of functions of the PyObject_Call family were inconsistent: "func" versus "callable" for a Python callable object for example (sometimes, .c and .h files were inc