[Tim]
>> Given that, the assert() in question looks fine to me:
>> ...
|>> Either that, or the original author (and me, just above) made an error
>> in analyzing what must be true at this point.
|
[David Hopwood]
> You omitted to state an assumption that sizeof(errTxt) >= 4, since size_t
> (and t
I wrote:
> You omitted to state an assumption that sizeof(errTxt) >= 4, since size_t
> (and the constant 4) are unsigned.
Sorry, the constant '4' is signed, but sizeof(errTxt) - 4 can nevertheless
wrap around unless sizeof(errTxt) >= 4.
--
David Hopwood <[EMAIL PROTECTED]>
Tim Peters wrote:
> Given that, the assert() in question looks fine to me:
>
> if (_db_errmsg[0] && bytes_left < (sizeof(errTxt) - 4)) {
> bytes_left = sizeof(errTxt) - bytes_left - 4 - 1;
> assert(bytes_left >= 0);
>
> We can't get into the block unless
>
> b
[Gregory P. Smith]
> It seems bad form to C assert() within a python extension. crashing
> is bad. Just code it to not copy the string in that case. The
> exception type should convey enough info alone and if someone actually
> looks at the string description of the exception they're welcome to
On Mon, Oct 09, 2006 at 08:11:59PM -0400, Tim Peters wrote:
> [Tim]
> > I just noticed that the bsddb portion of Python fails to compile on
> > the 2.4 Windows buildbots, but for some reason the buildbot machinery
> > doesn't notice the failure:
>
> But it does now. This is the revision that brok
Tim Peters schrieb:
> [Martin v. Löwis]
>> It's been a while that a failure to build some extension modules doesn't
>> cause the "compile" step to fail; this just happened with the _ssl.pyd
>> module before.
>
> I'm guessing only on the release24-maint branch?
Yes. I backported some change which
[Tim]
> I just noticed that the bsddb portion of Python fails to compile on
> the 2.4 Windows buildbots, but for some reason the buildbot machinery
> doesn't notice the failure:
But it does now. This is the revision that broke the Windows build:
"""
r52170 | andrew.kuchling | 2006-10-05 14:49:36
[Tim Peters]
>> I just noticed that the bsddb portion of Python fails to compile on
>> the 2.4 Windows buildbots, but for some reason the buildbot machinery
>> doesn't notice the failure:
[Martin v. Löwis]
> It's been a while that a failure to build some extension modules doesn't
> cause the "comp
Tim Peters schrieb:
> I just noticed that the bsddb portion of Python fails to compile on
> the 2.4 Windows buildbots, but for some reason the buildbot machinery
> doesn't notice the failure:
It's been a while that a failure to build some extension modules doesn't
cause the "compile" step to fail;
I just noticed that the bsddb portion of Python fails to compile on
the 2.4 Windows buildbots, but for some reason the buildbot machinery
doesn't notice the failure:
"""
Compiling...
_bsddb.c
Linking...
Creating library .\./_bsddb_d.lib and object .\./_bsddb_d.exp
_bsddb.obj : warning LNK4217:
10 matches
Mail list logo
