Re: [Python-Dev] [Python-checkins] cpython: avoid unitialized memory

2012-05-04 Thread Benjamin Peterson
2012/5/4 Eric V. Smith : > On 5/4/2012 1:14 AM, benjamin.peterson wrote: >> http://hg.python.org/cpython/rev/b0deafca6c02 >> changeset:   76743:b0deafca6c02 >> user:        Benjamin Peterson >> date:        Fri May 04 01:14:03 2012 -0400 >> summary: >>   avoid unitialized memory >> >> files: >>  

Re: [Python-Dev] [Python-checkins] cpython: avoid unitialized memory

2012-05-04 Thread Stephen J. Turnbull
Eric V. Smith writes: > > -PyObject *divmod; > > +PyObject *divmod = NULL; > > divmod = PyNumber_Divmod(py_long, billion); > > How is that uninitialized if it's being set on the next line? Maybe they finally developed a Sufficiently Stupid Compiler? ___

Re: [Python-Dev] [Python-checkins] cpython: avoid unitialized memory

2012-05-04 Thread Stefan Krah
benjamin.peterson wrote: > summary: > avoid unitialized memory > > diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c > --- a/Modules/posixmodule.c > +++ b/Modules/posixmodule.c > @@ -3576,7 +3576,7 @@ > split_py_long_to_s_and_ns(PyObject *py_long, time_t *s, long *ns) > { > int

Re: [Python-Dev] [Python-checkins] cpython: avoid unitialized memory

2012-05-04 Thread Eric V. Smith
On 5/4/2012 1:14 AM, benjamin.peterson wrote: > http://hg.python.org/cpython/rev/b0deafca6c02 > changeset: 76743:b0deafca6c02 > user:Benjamin Peterson > date:Fri May 04 01:14:03 2012 -0400 > summary: > avoid unitialized memory > > files: > Modules/posixmodule.c | 2 +- > 1