Re: [Python-Dev] [Python-checkins] cpython: Fix email post-commit review comments.

2012-04-18 Thread R. David Murray
We're seeing segfuilts on the buildbots now. Example: http://www.python.org/dev/buildbot/all/builders/x86%20Ubuntu%20Shared%203.x/builds/5715 On Wed, 18 Apr 2012 23:39:34 +1000, Nick Coghlan wrote: > On Wed, Apr 18, 2012 at 11:31 PM, brian.curtin > wrote: > > -    if (name == NULL) > > +  

Re: [Python-Dev] [Python-checkins] cpython: Fix email post-commit review comments.

2012-04-18 Thread Nick Coghlan
On Wed, Apr 18, 2012 at 11:31 PM, brian.curtin wrote: > -    if (name == NULL) > +    if (name == NULL) { > +        Py_INCREF(Py_None); >         name = Py_None; > +    } A slightly more traditional way to write that would be: name = Py_None; Py_INCREF(name); > -    if (path == NULL) >