Re: [Python-Dev] [Python-checkins] Daily reference leaks (8391f99208f6): sum=181

2014-05-29 Thread Eric Snow
Fixed! (test_site and test_functools are still leaking sporadically, but it looks unrelated to the import.c leak). -eric On Thu, May 29, 2014 at 10:34 AM, Eric Snow wrote: > Good catch. I'll look into it. > > -eric > > On Thu, May 29, 2014 at 8:49 AM, Brett Cannon wrote: >> I think the memory

Re: [Python-Dev] [Python-checkins] Daily reference leaks (8391f99208f6): sum=181

2014-05-29 Thread Eric Snow
Good catch. I'll look into it. -eric On Thu, May 29, 2014 at 8:49 AM, Brett Cannon wrote: > I think the memory leak was caused by > http://hg.python.org/cpython/rev/7d20e30bd540 because > http://hg.python.org/cpython/file/0eedac3d0b0a/Python/import.c#l903 sets the > 'res' variable and then over

[Python-Dev] [Python-checkins] Daily reference leaks (8391f99208f6): sum=181

2014-05-29 Thread Brett Cannon
I think the memory leak was caused by http://hg.python.org/cpython/rev/7d20e30bd540 because http://hg.python.org/cpython/file/0eedac3d0b0a/Python/import.c#l903 sets the 'res' variable and then overwrites it unconditionally w/o PY_DECREF beforehand. On Thu May 29 2014 at 4:02:17 AM, wrote: > resu