Re: [Python-Dev] [Python-3000] inst_persistent_id

2008-01-20 Thread Jim Fulton
I took Python-3000 out of the cc list as I originally just wanted to make them aware of this issue. On Jan 14, 2008, at 12:59 PM, Armin Rigo wrote: > Hi, > > On Sat, Jan 12, 2008 at 07:33:38PM -0500, Alexandre Vassalotti wrote: >> Well, in Python 3K, inst_persistent_id() won't be usable, since

Re: [Python-Dev] [Python-3000] inst_persistent_id

2008-01-14 Thread Alexandre Vassalotti
Oh, you are right. I thought that save_inst() used inst_persistent_id, but that isn't the case. Now, I have checked more thoroughly and found the relevant piece of code: if (!pers_save && self->inst_pers_func) { if ((tmp = save_pers(self, args, self->inst_pers_func)) != 0)

Re: [Python-Dev] [Python-3000] inst_persistent_id

2008-01-14 Thread Armin Rigo
Hi, On Sat, Jan 12, 2008 at 07:33:38PM -0500, Alexandre Vassalotti wrote: > Well, in Python 3K, inst_persistent_id() won't be usable, since > PyInstance_Type was removed. Looking at the code, inst_persistent_id() is just a confusing name. It has got nothing to do with PyInstance_Type; it's calle

Re: [Python-Dev] [Python-3000] inst_persistent_id

2008-01-12 Thread Alexandre Vassalotti
On Jan 12, 2008 12:25 PM, Jim Fulton <[EMAIL PROTECTED]> wrote: > If there are no objections, I'll update the Python 2 documentation to > describe this and add a test. The comment above suggests that this > hook is in pickle and cPickle. It is in cPickle, but was removed from > pickle. I propose