Re: [Python-Dev] "make touch" replaced with "make regen-all"

2017-05-09 Thread Jeremy Kloth
On Tue, May 9, 2017 at 5:20 AM, Victor Stinner wrote: > This change broke the Coverage job on Travis CI, because sysconfig.py > uses get_config_var('AST_H_DIR') to build sysconfig.get_python_inc(): > http://bugs.python.org/issue30273 > > sysconfig was modified in 2012. "Include" was replaced with

Re: [Python-Dev] "make touch" replaced with "make regen-all"

2017-05-09 Thread Victor Stinner
2017-05-04 19:51 GMT+02:00 Raymond Hettinger : > Yes. It is perfectly reasonable to backport improvements to the tooling as > long as it doesn't break anyone's existing build process. I pushed my change to 2.7, 3.5, 3.6 and master (3.7) branches: "make" doesn't try to regenerate generated files

Re: [Python-Dev] "make touch" replaced with "make regen-all"

2017-05-05 Thread Victor Stinner
2017-05-05 6:31 GMT+02:00 Nick Coghlan : > For the benefit of Linux distros attempting to ensure they're doing > full "from source" builds, it would be good to note this in a "Notable > changes in maintenance releases", akin to the existing ones for 3.4 > and 2.7 (perhaps retitling the latter accor

Re: [Python-Dev] "make touch" replaced with "make regen-all"

2017-05-04 Thread Nick Coghlan
On 5 May 2017 at 16:01, Victor Stinner wrote: > Le 5 mai 2017 6:31 AM, "Nick Coghlan" a écrit : > > The note just needs to say that folks that care about doing "complete" > builds need to adjust their command sequence to be "./configure > && make regen-all && make install", rather than the previ

Re: [Python-Dev] "make touch" replaced with "make regen-all"

2017-05-04 Thread Victor Stinner
Le 5 mai 2017 6:31 AM, "Nick Coghlan" a écrit : The note just needs to say that folks that care about doing "complete" builds need to adjust their command sequence to be "./configure && make regen-all && make install", rather than the previous pattern of "./configure && make install". Hum, yo

Re: [Python-Dev] "make touch" replaced with "make regen-all"

2017-05-04 Thread Nick Coghlan
On 5 May 2017 at 03:40, Brett Cannon wrote: > I see no issue backporting since I don't think we have any compatibility > promises when it comes to Makefile commands. Plus if the perf changes to add > PGO support could be backported then I don't see why this shouldn't be > allowed. For the benefit

Re: [Python-Dev] "make touch" replaced with "make regen-all"

2017-05-04 Thread Ryan Gonzalez
FWIW this will also make cross-compiling a lot easier, since you can't accidentally overwrite the cross-compiled pgen as easily. On Thu, May 4, 2017 at 12:13 PM, Victor Stinner wrote: > Hi, > > tl;dr Are you ok to backport my change replacing "make touch" with > "make regen-all"? (commit a5c62a8e

Re: [Python-Dev] "make touch" replaced with "make regen-all"

2017-05-04 Thread Raymond Hettinger
Yes. It is perfectly reasonable to backport improvements to the tooling as long as it doesn't break anyone's existing build process. Sent from my iPhone > On May 4, 2017, at 10:13 AM, Victor Stinner wrote: > > tl;dr Are you ok to backport my change replacing "make touch" with > "make regen-a

Re: [Python-Dev] "make touch" replaced with "make regen-all"

2017-05-04 Thread Brett Cannon
I see no issue backporting since I don't think we have any compatibility promises when it comes to Makefile commands. Plus if the perf changes to add PGO support could be backported then I don't see why this shouldn't be allowed. On Thu, 4 May 2017 at 10:15 Victor Stinner wrote: > Hi, > > tl;dr

[Python-Dev] "make touch" replaced with "make regen-all"

2017-05-04 Thread Victor Stinner
Hi, tl;dr Are you ok to backport my change replacing "make touch" with "make regen-all"? (commit a5c62a8e) Since the creation of CPython, generated files were regenerated depending on file modification time. For development, that's a convenient feature. But in practice, it caused a long list of