[Python-Dev] Re: Increase of Spammy PRs and PR reviews

2022-01-30 Thread Ethan Smith
On Sat, Jan 29, 2022 at 7:38 PM Inada Naoki wrote: > On Sun, Jan 30, 2022 at 12:03 PM Ethan Smith wrote: > > > > As a non-committer, I want to make a plea for non-committer approval > reviews, or at least that they have a place. When asked how outsiders can > contribute I f

[Python-Dev] Re: Increase of Spammy PRs and PR reviews

2022-01-29 Thread Ethan Smith
As a non-committer, I want to make a plea for non-committer approval reviews, or at least that they have a place. When asked how outsiders can contribute I frequently see "review open PRs" as a suggested way of contributing to CPython. Not being able to approve PRs that are good would be a barrier

[Python-Dev] Re: Need help with test_ctypes failing on Windows (test_load_dll_with_flags)

2020-04-06 Thread Ethan Smith
(Trusty assistant reporting in) I should also note that further up the output there is a FileNotFoundError for sqlite3.dll, perhaps it isn't built or is in the wrong place? Ethan On Mon, Apr 6, 2020, 7:19 PM Guido van Rossum wrote: > I have a large PR (https://github.com/python/cpython/pull/18

[Python-Dev] Re: PEP 585: Type Hinting Generics In Standard Collections

2020-02-24 Thread Ethan Smith
The discussion on the name change came from Łukasz https://github.com/python/cpython/pull/18239#discussion_r380996908 I suggested "GenericType" to be in line with other things in types.py. On Mon, Feb 24, 2020 at 8:39 PM Guido van Rossum wrote: > I can't find it right now, but IIRC somebody com

[Python-Dev] Re: PEP 585: Type Hinting Generics In Standard Collections

2020-02-23 Thread Ethan Smith
While working on the implementation with Guido I made a list of things that inherit from typing.Generic in typeshed that haven't been listed/implemented yet. https://github.com/gvanrossum/cpython/pull/1#issuecomment-582781121 On Sat, Feb 22, 2020, 3:50 PM Nick Coghlan wrote: > This looks like

[Python-Dev] Re: Stalemate on bringing back PEP 523 support into Python 3.8

2019-11-21 Thread Ethan Smith
(Replying here since b.p.o doesn't seem to want to let me log in) I've used the PEP 523 API several times for multiple projects, from analyzing bytecode frequency (which probably could be done with other means) to inspecting type information from function calls. I could probably do such analysis a

[Python-Dev] PEP 561 implemented and minor clarification

2018-04-12 Thread Ethan Smith
lways, the PEP text is replicated below. Cheers! Ethan == PEP: 561 Title: Distributing and Packaging Type Information Author: Ethan Smith Status: Draft Type: Standards Track Content-Type: text/x-rst Created: 09-Sep-2017 Python-Version: 3.7 Post-History: 10-Sep-2017, 12-Sep-2017, 06-Oc

Re: [Python-Dev] libxml2 installation/binding issue

2018-02-05 Thread Ethan Smith
This list is for the discussion of development *of* Python. For discussion of development *with* Python, you want python-list. On Mon, Feb 5, 2018 at 2:41 PM, Priest, Matt wrote: > Hello, > > > > I am not sure if this is the correct place to post an issue/question like > this, but here goes… > >

Re: [Python-Dev] Concerns about method overriding and subclassing with dataclasses

2018-01-01 Thread Ethan Smith
ht" __repr__ now if you derive a datacalss from a > dataclass? That would be a nice feature. > The __repr__ will be generated by the child dataclass unless the user overrides it. So I believe this is the "right" __repr__. ~>Ethan Smith > > -CHB > > -- > > Christ

Re: [Python-Dev] Concerns about method overriding and subclassing with dataclasses

2017-12-29 Thread Ethan Smith
Okay, I think Guido's proposal is a good compromise. I already have a branch of dataclasses that should implement that behavior, so perhaps it was meant to be. :) ~>Ethan Smith On Fri, Dec 29, 2017 at 5:13 PM, Nick Coghlan wrote: > > > On 30 Dec. 2017 11:01 am, &qu

Re: [Python-Dev] Concerns about method overriding and subclassing with dataclasses

2017-12-29 Thread Ethan Smith
On Fri, Dec 29, 2017 at 4:52 PM, Guido van Rossum wrote: > I still think it should overrides anything that's just inherited but > nothing that's defined in the class being decorated. > > Could you explain why you are of this opinion? Is it a concern about complexity of implementation? > On Dec

Re: [Python-Dev] Concerns about method overriding and subclassing with dataclasses

2017-12-29 Thread Ethan Smith
attrs just silently overwrites any user provided __repr__ unless you provide repr=False to attr.s. I think we can all agree that if nothing else, silently overwriting unconditionally is not what we want for dataclasses. On Fri, Dec 29, 2017 at 4:38 PM, Nathaniel Smith wrote: > On Fri, Dec 29, 2

Re: [Python-Dev] Concerns about method overriding and subclassing with dataclasses

2017-12-29 Thread Ethan Smith
On Fri, Dec 29, 2017 at 12:30 PM, Ethan Furman wrote: > On 12/29/2017 11:55 AM, Ethan Smith wrote: > >> On Fri, Dec 29, 2017 at 11:37 AM, Ethan Furman wrote: >> > > It is possible to determine whether an existing __repr__ is from 'object' >>> >&g

Re: [Python-Dev] Concerns about method overriding and subclassing with dataclasses

2017-12-29 Thread Ethan Smith
On Fri, Dec 29, 2017 at 11:37 AM, Ethan Furman wrote: > On 12/29/2017 02:23 AM, Ethan Smith wrote: > > The first is that needing both a keyword and method is duplicative and >> unnecessary. Eric agreed it was a hassle, but >> felt it was justified considering someone may ac

Re: [Python-Dev] Concerns about method overriding and subclassing with dataclasses

2017-12-29 Thread Ethan Smith
On Fri, Dec 29, 2017 at 2:45 AM, Antoine Pitrou wrote: > On Fri, 29 Dec 2017 02:23:56 -0800 > Ethan Smith wrote: > > > > In a few cases I want to override the repr of the AST nodes. I wrote a > > __repr__ and ran the code but lo and behold I got a type error. I >

Re: [Python-Dev] Supporting functools.singledispatch with classes.

2017-12-29 Thread Ethan Smith
On Fri, Dec 29, 2017 at 7:02 AM, Nick Coghlan wrote: > On 28 December 2017 at 04:22, Ethan Smith wrote: > > Okay, if there is no further feedback, I will work on a > singledispatchmethod > > decorator like partialmethod. > > > > For the future perhaps, would it no

[Python-Dev] Concerns about method overriding and subclassing with dataclasses

2017-12-29 Thread Ethan Smith
lks have related to this. Cheers, ~>Ethan Smith ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] Supporting functools.singledispatch with classes.

2017-12-27 Thread Ethan Smith
mber 2017 at 12:32, Ethan Smith wrote: >> > So at the moment, I don't think it is possible to implement >> singledispatch >> > on classmethod or staticmethod decorated functions. >> >> I've posted this to the PR, but adding it here as well: I

[Python-Dev] Supporting functools.singledispatch with classes.

2017-12-24 Thread Ethan Smith
patch needs to be called as the __func__ in classmethod, but __func__ is readonly. So at the moment, I don't think it is possible to implement singledispatch on classmethod or staticmethod decorated functions. I look forward to people's thoughts on these issues. Cheers, Ethan Smith _

Re: [Python-Dev] PEP 561 rework

2017-11-14 Thread Ethan Smith
A note was added [1] about the solution for module only distributions and is live on Python.org. [1] https://github.com/python/peps/pull/468 Ethan Smith On Tue, Nov 14, 2017 at 1:02 AM, Sebastian Rittau wrote: > Am 14.11.2017 um 02:38 schrieb Guido van Rossum: > > On Mon, Nov 13, 201

Re: [Python-Dev] PEP 561 rework

2017-11-13 Thread Ethan Smith
On Mon, Nov 13, 2017 at 3:50 PM, Sebastian Rittau wrote: > Hello everyone, > > > Am 14.11.2017 um 00:29 schrieb Guido van Rossum: > >> This is a nice piece of work. I expect to accept it pretty much verbatim >> (with some small edits, see https://github.com/python/peps/pull/467). I >> agree with

Re: [Python-Dev] PEP 561 rework

2017-11-12 Thread Ethan Smith
On Sun, Nov 12, 2017 at 8:07 PM, Nathaniel Smith wrote: > On Sun, Nov 12, 2017 at 11:21 AM, Ethan Smith wrote: > > > > > > On Sun, Nov 12, 2017 at 9:53 AM, Jelle Zijlstra < > jelle.zijls...@gmail.com> > > wrote: > >> > >> 2017-11-12 3

Re: [Python-Dev] PEP 561 rework

2017-11-12 Thread Ethan Smith
On Sun, Nov 12, 2017 at 9:53 AM, Jelle Zijlstra wrote: > > > 2017-11-12 3:40 GMT-08:00 Ethan Smith : > >> Hello, >> >> I re-wrote my PEP to have typing opt-in be per-package rather than >> per-distribution. This greatly simplifies things, and thanks to the

[Python-Dev] PEP 561 rework

2017-11-12 Thread Ethan Smith
below. Cheers, Ethan Smith --- PEP: 561 Title: Distributing and Packaging Type Information Author: Ethan Smith Status: Draft Type: Standards Track Content-Type: text/x-rst Created: 09-Sep-2017 Python-Version: 3.7 Post-History: 10-Sep-2017, 12-Sep

Re: [Python-Dev] Remove typing from the stdlib

2017-11-06 Thread Ethan Smith
> Beyond the API already proposed in PEP 557, this would mean adding: > > * dataclasses.ClassVar (as proposed above) > * dataclasses.Any (probably just set to the literal string > "dataclasses.Any") > * dataclasses.NamedTuple (as a replacement for typing.NamedTuple) > * potentially dataclasses.is_c

Re: [Python-Dev] PEP 561: Distributing and Packaging Type Information

2017-10-29 Thread Ethan Smith
On Fri, Oct 27, 2017 at 12:44 AM, Nathaniel Smith wrote: > On Thu, Oct 26, 2017 at 3:42 PM, Ethan Smith wrote: > > However, the stubs may be put in a sub-folder > > of the Python sources, with the same name the ``*.py`` files are in. For > > example, the ``flyingcircus`` p

Re: [Python-Dev] PEP 561: Distributing and Packaging Type Information

2017-10-26 Thread Ethan Smith
On Thu, Oct 26, 2017 at 4:48 PM, Mariatta Wijaya wrote: > Not sure if postings to python-ideas count, > > > PEP 1 says: > > Post-History is used to record the dates of when new versions of the PEP > are posted to python-list and/or python-dev. > > So, no ? > Reading PEP 12, https://www.python.o

[Python-Dev] PEP 561: Distributing and Packaging Type Information

2017-10-26 Thread Ethan Smith
Information V3 The live version is here: https://www.python.org/dev/peps/pep-0561/ As always, duplicated below. Ethan Smith --- PEP: 561 Title: Distributing and Packaging Type Information Author: Ethan Smith Status: Draft Type: Standards Track

Re: [Python-Dev] Compiling without multithreading support -- still useful?

2017-09-06 Thread Ethan Smith
Certainly, I understand it can be burdensome. I suppose I can use 3.6 branch for the initial port, so it shouldn't be an issue. On Wed, Sep 6, 2017 at 11:13 AM, Antoine Pitrou wrote: > On Wed, 6 Sep 2017 10:50:11 -0700 > Ethan Smith wrote: > > I think this is useful as it

Re: [Python-Dev] Compiling without multithreading support -- still useful?

2017-09-06 Thread Ethan Smith
I think this is useful as it can make porting easier. I am using it in my attempts to cross compile CPython to WebAssembly (since WebAssembly in its MVP does not support threading). On Wed, Sep 6, 2017 at 10:15 AM, Antoine Pitrou wrote: > > I made an experimental PR to remove support for threads