[Python-Dev] Re: Merging PRs without CLA signed

2020-02-23 Thread Ethan Furman
On 02/23/2020 08:44 PM, Guido van Rossum wrote: (What is it with typos anyway? Why do people feel the need to invoke megabytes if not gigabytes of internet traffic to correct a word that every reader can easily correct in their mind?) Typos are like skate boarding on fresh asphalt and then h

[Python-Dev] Re: Merging PRs without CLA signed

2020-02-23 Thread Kyle Stanley
> In that case I'm not sure the author ought to get credit for the PR. They can file a bug pointing out the typo and someone else can submit a fix. That sounds like a reasonable solution to me; even for more substantial issues (if signing the CLA is a genuine issue). I think there are a fair numbe

[Python-Dev] Re: Merging PRs without CLA signed

2020-02-23 Thread Kyle Stanley
> Note that if you open a PR, and _then_ sign the CLA, the label is not updated (at least, that's what I experienced before I did). So this list is likely inaccurate. I believe that I might have seen this happen a few times, but in the majority cases the label is updated from "CLA not signed" => "

[Python-Dev] Re: Merging PRs without CLA signed

2020-02-23 Thread Guido van Rossum
On Sun, Feb 23, 2020 at 8:11 PM Kyle Stanley wrote: > In a recently opened typo fixing PR [1], an issue came up regarding the > lack of a signed CLA, where the author specifically mentioned they did not > want to sign it for privacy concerns. > In that case I'm not sure the author ought to get c

[Python-Dev] Re: Merging PRs without CLA signed

2020-02-23 Thread Ivan Pozdeev via Python-Dev
On 24.02.2020 7:07, Kyle Stanley wrote: For a full list of merged PRs to CPython with a "CLA not signed" label, see the following: https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Apr+state%3Amerged+label%3A%22CLA+not+signed%22 Note that if you open a PR, and _then_ sign the CLA

[Python-Dev] Merging PRs without CLA signed

2020-02-23 Thread Kyle Stanley
In a recently opened typo fixing PR [1], an issue came up regarding the lack of a signed CLA, where the author specifically mentioned they did not want to sign it for privacy concerns. In the past, I've seen several PRs with similarly minimal [2] changes (such as typo fixes, grammar fixes, link fi

[Python-Dev] Re: Accepting PEP 584: Add Union Operators To dict

2020-02-23 Thread Guido van Rossum
On Sat, Feb 22, 2020 at 10:09 PM Steven D'Aprano wrote: > On Tue, Feb 18, 2020 at 05:35:38PM -, Brandt Bucher wrote: > > > I am accepting this PEP. Congratulations Steven and Brandt! > > > > Thank you for your guidance, especially the suggestions late last > > year. And thanks Steven for taki

[Python-Dev] Re: Accepting PEP 584: Add Union Operators To dict

2020-02-23 Thread Guido van Rossum
On Sat, Feb 22, 2020 at 4:45 PM Brandt Bucher wrote: > [quoting Nick] > > collections.Mapping and collections.MutableMapping could provide > concrete method implementations that make subclasses behave in a way that's > similar to built-in dicts > > Hm, haven't thought too much about this (I don't

[Python-Dev] Re: Accepting PEP 584: Add Union Operators To dict

2020-02-23 Thread Guido van Rossum
On Sat, Feb 22, 2020 at 11:28 AM Brandt Bucher wrote: > Just to follow up on this, here are the subclasses I've found. > > Should be updated: > - collections.OrderedDict > - collections.defaultdict > SGTM. - http.cookies.BaseCookie > - http.cookies.Morsel > - http.cookies.SimpleCookie > Are th

[Python-Dev] Re: PEP 585: Type Hinting Generics In Standard Collections

2020-02-23 Thread Batuhan Taskaya
This issue might be useful about it: https://bugs.python.org/issue39019 On Sun, Feb 23, 2020 at 2:12 PM Ethan Smith wrote: > > While working on the implementation with Guido I made a list of things that > inherit from typing.Generic in typeshed that haven't been listed/implemented > yet. > > ht

[Python-Dev] Re: PEP 585: Type Hinting Generics In Standard Collections

2020-02-23 Thread Ethan Smith
While working on the implementation with Guido I made a list of things that inherit from typing.Generic in typeshed that haven't been listed/implemented yet. https://github.com/gvanrossum/cpython/pull/1#issuecomment-582781121 On Sat, Feb 22, 2020, 3:50 PM Nick Coghlan wrote: > This looks like