> That was Brett's bot for backfilling the "awaiting ..." label to PRs
created before we had any "awaiting .." label. A script was used to
> automatically determine the stage of the PR and apply appropriate label.
Ah, that makes sense. I wasn't aware that personal GitHub accounts were
previously u
>
> That was my previous impression, but then I saw that Brett applied it
> manually in this older PR to check if the author was still active:
> https://github.com/python/cpython/pull/117#issuecomment-367187316.
That was Brett's bot for backfilling the "awaiting ..." label to PRs
created before w
Mariatta wrote:
> It still requires earning trust from at least one core developer who will
approve their request, which I don't actually believe is an easy > thing to
do.
Agreed, it may be a low bar in comparison to the 66% approval required for
becoming a core developer, but it's definitely not
>
> The capabilities of a triager mostly look good except for "closing PRs and
> issues". This is a superpower that has traditionally been reserved for
> more senior developers because it grants the ability to shut-down the work
> of another aspiring contributor. Marking someone else's suggestion
Kyle Stanley wrote:
> as it has been awaiting changes since Feb 20, 2018
Clarification: The author addressed the suggested changes on Feb 19, 2017
but had made no response after Brett added the ``awaiting changes`` label.
As a related question, would it be okay for triagers to manually add the
"a
Abhilash Raj wrote:
> What I am coming from is that what one has permissions to do and what one
> should do has been different. We caution people with permissions to use
them
> judiciously.
>From my understanding, triagers should only close PRs or issues when they
are entirely invalid (for non-sub
Abhilash Raj wrote:
> On Thu, Aug 22, 2019, at 6:06 AM, Victor Stinner wrote:
> > Hi,
> > Oh, I just wrote a similar email to python-committers, I didn't notice
> > that Mariatta wrote to python-dev and python-committers.
> > https://mail.python.org/archives/list/python-committ...@python.org/messa
On Thu, Aug 22, 2019, at 6:06 AM, Victor Stinner wrote:
> Hi,
>
> Oh, I just wrote a similar email to python-committers, I didn't notice
> that Mariatta wrote to python-dev and python-committers.
>
> https://mail.python.org/archives/list/python-committ...@python.org/message/53K5MJAKLRGY2F34ZCY
On Wed, 21 Aug 2019 at 22:17, Raymond Hettinger
wrote:
> Thanks for doing this. I hope it encourages more participation.
>
> The capabilities of a triager mostly look good except for "closing PRs and
> issues". This is a superpower that has traditionally been reserved for
> more senior develope
I think it's fine for triagers to have the close permission, and there's
actually a good reason to give it to them, which is that often the
easiest way to trigger a new CI run is to close and re-open a PR. It
will be very helpful for triagers to be able to do this to fix
intermittent build problems
Hi,
Oh, I just wrote a similar email to python-committers, I didn't notice
that Mariatta wrote to python-dev and python-committers.
https://mail.python.org/archives/list/python-committ...@python.org/message/53K5MJAKLRGY2F34ZCYGL3WPWSJ4C5M2/
My worry is more about closing pull requests.
Le 2
11 matches
Mail list logo
