I pushed many changes. I moved most of the Py_BUILD_CORE code out of
Include/ header files.
Le jeu. 1 nov. 2018 à 02:35, Eric Snow a écrit :
> On the one hand dropping redundancy in the filename is fine. On the other
> having the names mirror the public header files is valuable.
Current conten
On the one hand dropping redundancy in the filename is fine. On the other
having the names mirror the public header files is valuable. How about
leaving the base names alone and change the directory to "pyinternal"?
-eric
On Wed, Oct 31, 2018, 17:36 Victor Stinner Ok, thanks. I decided to remo
Ok, thanks. I decided to remove the redundant "py", so I renamed
"pystate.h" to "pycore_state.h" (single "py", instead of
"pycore_pystate.h", double "py py").
I updated my PR:
https://github.com/python/cpython/pull/10263
* Rename Include/internal/ header files:
* pyatomic.h -> pycore_atomic.h
B
On Wed, Oct 31, 2018 at 4:28 PM Victor Stinner wrote:
>
> Le mer. 31 oct. 2018 à 22:19, Eric Snow a écrit
> :
> > > Maybe we can keep "Include/internal/" directory name, but add
> > > "pycore_" rather than "internal_" to header filenames?
> >
> > this sounds good to me. thanks for chasing thi
Le mer. 31 oct. 2018 à 22:19, Eric Snow a écrit :
> > Maybe we can keep "Include/internal/" directory name, but add
> > "pycore_" rather than "internal_" to header filenames?
>
> this sounds good to me. thanks for chasing this down.
What do you prefer?
(A Include/internal/internal_pystate.h
(B)
On Wed, Oct 31, 2018 at 2:05 PM Victor Stinner wrote:
>
> Le mer. 31 oct. 2018 à 20:40, Eric Snow a écrit
> :
> > On Mon, Oct 29, 2018 at 6:39 AM Victor Stinner wrote:
> > > Le lun. 29 oct. 2018 à 06:32, Benjamin Peterson a
> > > écrit :
> > > > How does the current Include/internal/ director
On Wed, Oct 31, 2018 at 1:57 PM Victor Stinner wrote:
>
> Ok, I proposed to rename internal header files, add an "internal_"
> prefix, to avoid this issue:
> https://github.com/python/cpython/pull/10263
>
> My PR also adds Include/internal/ to search paths of header files.
>
> Extract of the chang
Le mer. 31 oct. 2018 à 20:40, Eric Snow a écrit :
> On Mon, Oct 29, 2018 at 6:39 AM Victor Stinner wrote:
> > Le lun. 29 oct. 2018 à 06:32, Benjamin Peterson a
> > écrit :
> > > How does the current Include/internal/ directory fail at accomplishing
> > > your goal?
> >
> > Hum, let me understa
Ok, I proposed to rename internal header files, add an "internal_"
prefix, to avoid this issue:
https://github.com/python/cpython/pull/10263
My PR also adds Include/internal/ to search paths of header files.
Extract of the change:
diff --git a/Include/internal/pystate.h b/Include/internal/intern
On Mon, Oct 29, 2018 at 6:39 AM Victor Stinner wrote:
> Le lun. 29 oct. 2018 à 06:32, Benjamin Peterson a écrit
> :
> > How does the current Include/internal/ directory fail at accomplishing your
> > goal?
>
> Hum, let me understand how I came into this issue. I tried to convert
> _PyObject_GC_
Le mer. 31 oct. 2018 à 19:22, Eric Snow a écrit :
> > I propose a practical solution for that: Include/*.h files would only
> > be be public API.
>
> As we've already discussed, I'm entirely in favor of this. :) In
> fact, I was thinking along those same lines when I originally created
> "Include
On Sun, Oct 28, 2018 at 10:20 AM Victor Stinner wrote:
> Python C API has no strict separation between the 3 levels of API:
>
> * core: Py_BUILD_CORE define
> * stable: Py_LIMITED_API define (it has a value)
> * regular: no define
>
> IMHO the current design of header files is done backward: by de
12 matches
Mail list logo
