Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Nick Coghlan
On 26 June 2017 at 07:39, Paul Moore wrote: > On 25 June 2017 at 18:31, Donald Stufft wrote: >> >> I have used it. I don’t use it every day but I’ve never had it fail on me >> unless the contributor has unchecked the flag. I just ``git remote add >> `` then checkout their branch, add more >> com

Re: [Python-Dev] PEP 538 warning at startup: please remove it

2017-06-25 Thread Nick Coghlan
On 12 June 2017 at 22:24, Nick Coghlan wrote: > On 12 June 2017 at 18:56, Victor Stinner wrote: >> Hi, >> >> Nick Coghlan pushed his implementation of his PEP 538: nice! Nice step >> forward to UTF-8 everywhere ;-) >> >> I would prefer to not be annoyed by warning messages about encodings >> at s

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Nick Coghlan
On 26 June 2017 at 02:39, Brett Cannon wrote: > On Sat, Jun 24, 2017, 23:45 Nick Coghlan, wrote: >> I was mainly referring to cases where either an initial commit (with a >> complete NEWS entry) requires follow-up fixes (no NEWS edit >> necessary). >> >> However, another case did occur to me, whi

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Donald Stufft
> On Jun 25, 2017, at 5:39 PM, Paul Moore wrote: > > On 25 June 2017 at 18:31, Donald Stufft wrote: >> >> I have used it. I don’t use it every day but I’ve never had it fail on me >> unless the contributor has unchecked the flag. I just ``git remote add >> `` then checkout their branch, add m

Re: [Python-Dev] PEP 538 warning at startup: please remove it

2017-06-25 Thread Glenn Linderman
On 6/25/2017 8:14 AM, Terry Reedy wrote: On 6/12/2017 4:30 PM, Glenn Linderman wrote: On 6/12/2017 1:11 PM, Terry Reedy wrote: I do not have any locale-related env vars. You should check whether the warning is off on all Win10 systems, as well as Win7 and Win8. Many Windows users know nothin

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Tim Delaney
On 26 June 2017 at 08:20, Tim Delaney wrote: > > 2. Last I checked hggit can't force-push to a git repository after > history-modifying actions (e.g. rebase) so after such actions it's > necessary to delete any existing branch in a local git repo, hg push to > that then force-push to Github. This

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Tim Delaney
On 26 June 2017 at 07:39, Paul Moore wrote: > On 25 June 2017 at 18:31, Donald Stufft wrote: > > > > I have used it. I don’t use it every day but I’ve never had it fail on me > > unless the contributor has unchecked the flag. I just ``git remote add > > `` then checkout their branch, add more >

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Oleg Broytman
On Sun, Jun 25, 2017 at 10:39:36PM +0100, Paul Moore wrote: > for someone coming from a familiarity with Mercurial (which means many > core devs) the learning curve is pretty steep (I'd consider that I switched to git after had been using hg for about 3 years. The first few months after the s

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Paul Moore
On 25 June 2017 at 18:31, Donald Stufft wrote: > > I have used it. I don’t use it every day but I’ve never had it fail on me > unless the contributor has unchecked the flag. I just ``git remote add > `` then checkout their branch, add more > commits, and push to their branch. That's relatively s

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Guido van Rossum
On Sun, Jun 25, 2017 at 12:23 PM, Brett Cannon wrote: > > > On Sun, Jun 25, 2017, 11:24 Terry Reedy, wrote: > >> On 6/25/2017 12:39 PM, Brett Cannon wrote: >> >> > The entire reason I want to have this check is I don't want or have to >> > ask another PR submitter to include a draft of a news it

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Brett Cannon
On Sun, Jun 25, 2017, 11:24 Terry Reedy, wrote: > On 6/25/2017 12:39 PM, Brett Cannon wrote: > > > The entire reason I want to have this check is I don't want or have to > > ask another PR submitter to include a draft of a news item. It's much > > easier to edit an existing news entry through the

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Antoine Pitrou
On Sun, 25 Jun 2017 20:38:51 +0200 Stefan Krah wrote: > On Sun, Jun 25, 2017 at 10:02:44AM -0700, Nathaniel Smith wrote: > > https://help.github.com/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork/ > > > > However, like Antoine, when I've tried to do this then all I've ma

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Larry Hastings
On 06/25/2017 11:01 AM, Nathaniel Smith wrote: On Jun 25, 2017 10:27, "Larry Hastings" > wrote: On 06/25/2017 10:02 AM, Nathaniel Smith wrote: My dudes, in a previous life I helped invent distributed VCS, but I still get confused by fiddly git BS just l

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Stefan Krah
On Sun, Jun 25, 2017 at 10:02:44AM -0700, Nathaniel Smith wrote: > https://help.github.com/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork/ > > However, like Antoine, when I've tried to do this then all I've managed is > to get obscure errors from GitHub. Did I have the wr

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Terry Reedy
On 6/25/2017 12:39 PM, Brett Cannon wrote: The entire reason I want to have this check is I don't want or have to ask another PR submitter to include a draft of a news item. It's much easier to edit an existing news entry through the web UI than either ask for it and deal with the turnaround t

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Nathaniel Smith
On Jun 25, 2017 10:27, "Larry Hastings" wrote: On 06/25/2017 10:02 AM, Nathaniel Smith wrote: My dudes, in a previous life I helped invent distributed VCS, but I still get confused by fiddly git BS just like everyone else. Really? I thought Bitkeeper was out before the monotone project even

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Donald Stufft
> On Jun 25, 2017, at 1:02 PM, Nathaniel Smith wrote: > > However, like Antoine, when I've tried to do this then all I've managed is to > get obscure errors from GitHub. Did I have the wrong incantations? Was the > permissions toggle set wrong? (I thought the web ui said it wasn't, but maybe

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Donald Stufft
> On Jun 25, 2017, at 12:39 PM, Brett Cannon wrote: > > > > On Sat, Jun 24, 2017, 23:45 Nick Coghlan, > wrote: > On 25 June 2017 at 16:31, Terry Reedy > wrote: > >> 25.06.17 06:04, Nick Coghlan пише: > >>> All the PRs share an issue number

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Larry Hastings
On 06/25/2017 10:02 AM, Nathaniel Smith wrote: My dudes, in a previous life I helped invent distributed VCS, but I still get confused by fiddly git BS just like everyone else. Really? I thought Bitkeeper was out before the monotone project even started--and TeamWare had monotone beat by mos

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Larry Hastings
On 06/25/2017 01:33 AM, Antoine Pitrou wrote: On Sat, 24 Jun 2017 21:37:46 -0700 Larry Hastings wrote: Well, no. *Writing blurb-compatible files* becomes a required step for all committers. And blurb makes that easy. But it's pretty easy to write them by hand; that's why we pre-created the

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Nathaniel Smith
On Jun 25, 2017 08:12, "Jakub Wilk" wrote: * Paul Sokolovsky , 2017-06-25, 11:47: A GitHub PR is just a git branch (in somebody else's repository, but also > in the repository it's submitted to). So, like any git branch, you can > fetch it, re-branch to your local branch, apply any changes to it

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Brett Cannon
On Sat, Jun 24, 2017, 23:45 Nick Coghlan, wrote: > On 25 June 2017 at 16:31, Terry Reedy wrote: > >> 25.06.17 06:04, Nick Coghlan пише: > >>> All the PRs share an issue number in that case, so Bedevere should be > >>> able to pick up that there's a pre-existing NEWS entry (even if it > >>> isn't

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Terry Reedy
On 6/25/2017 12:16 PM, Terry Reedy wrote: On 6/25/2017 8:06 AM, Serhiy Storchaka wrote: 24.06.17 18:57, Larry Hastings пише: On 06/24/2017 01:53 AM, Antoine Pitrou wrote: Would you like to make it 3.5-compatible? 3.6 is quite young and not all systems have it (e.g. Ubuntu 16.04, which many pe

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Terry Reedy
On 6/25/2017 8:06 AM, Serhiy Storchaka wrote: 24.06.17 18:57, Larry Hastings пише: On 06/24/2017 01:53 AM, Antoine Pitrou wrote: Would you like to make it 3.5-compatible? 3.6 is quite young and not all systems have it (e.g. Ubuntu 16.04, which many people use, has 3.5). Well, tbh I think tha

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Stefan Krah
On Sun, Jun 25, 2017 at 05:52:49PM +0200, Antoine Pitrou wrote: > On Mon, 26 Jun 2017 01:27:20 +1000 > Chris Angelico wrote: > > In the web programming bootcamp that I'm involved with, git is taught > > in the very first week. It's not some arcane and hostile thing; the > > command line is a funda

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Chris Angelico
On Mon, Jun 26, 2017 at 1:52 AM, Antoine Pitrou wrote: > On Mon, 26 Jun 2017 01:27:20 +1000 > Chris Angelico wrote: >> On Sun, Jun 25, 2017 at 7:25 PM, Antoine Pitrou wrote: >> >> There're also various tools for dealing specifically with git branch >> >> layout as used by Github, and every real

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Antoine Pitrou
On Mon, 26 Jun 2017 01:27:20 +1000 Chris Angelico wrote: > On Sun, Jun 25, 2017 at 7:25 PM, Antoine Pitrou wrote: > >> There're also various tools for dealing specifically with git branch > >> layout as used by Github, and every real man writes their own (because > >> it's easier to shoot a 5-lin

Re: [Python-Dev] __qualname__ format question

2017-06-25 Thread Christian Tismer
On 25.06.17 14:41, Serhiy Storchaka wrote: > 25.06.17 15:06, Christian Tismer пише: >> by chance, I stumbled over >> >> meth_get__qualname__ >> >> in methodobject.c and >> >> calculate_qualname >> >> in descrobject.c . >> >> The first uses >> >> res = PyUnicode_FromFormat("%S.%s", ty

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Chris Angelico
On Sun, Jun 25, 2017 at 7:25 PM, Antoine Pitrou wrote: >> There're also various tools for dealing specifically with git branch >> layout as used by Github, and every real man writes their own (because >> it's easier to shoot a 5-liner than to review whether somebody else's >> tool do what you need

Re: [Python-Dev] PEP 538 warning at startup: please remove it

2017-06-25 Thread Terry Reedy
On 6/12/2017 4:30 PM, Glenn Linderman wrote: On 6/12/2017 1:11 PM, Terry Reedy wrote: I do not have any locale-related env vars. You should check whether the warning is off on all Win10 systems, as well as Win7 and Win8. Many Windows users know nothing about ENV VARS, and even if they do, th

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Jakub Wilk
* Paul Sokolovsky , 2017-06-25, 11:47: A GitHub PR is just a git branch (in somebody else's repository, but also in the repository it's submitted to). So, like any git branch, you can fetch it, re-branch to your local branch, apply any changes to it, rebase, push anywhere. Right, this is docu

Re: [Python-Dev] __qualname__ format question

2017-06-25 Thread Serhiy Storchaka
25.06.17 15:06, Christian Tismer пише: by chance, I stumbled over meth_get__qualname__ in methodobject.c and calculate_qualname in descrobject.c . The first uses res = PyUnicode_FromFormat("%S.%s", type_qualname, m->m_ml->ml_name); and the latter uses res = PyUnicode_F

[Python-Dev] __qualname__ format question

2017-06-25 Thread Christian Tismer
Hi friends, by chance, I stumbled over meth_get__qualname__ in methodobject.c and calculate_qualname in descrobject.c . The first uses res = PyUnicode_FromFormat("%S.%s", type_qualname, m->m_ml->ml_name); and the latter uses res = PyUnicode_FromFormat("%S.%S", type_qualname

Re: [Python-Dev] New workflow change: Welcome to blurb

2017-06-25 Thread Serhiy Storchaka
24.06.17 18:57, Larry Hastings пише: On 06/24/2017 01:53 AM, Antoine Pitrou wrote: Would you like to make it 3.5-compatible? 3.6 is quite young and not all systems have it (e.g. Ubuntu 16.04, which many people use, has 3.5). Well, tbh I think that's a bit silly. First of all, it shouldn't be

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Antoine Pitrou
On Sun, 25 Jun 2017 11:47:10 +0300 Paul Sokolovsky wrote: > > > > This is touching a more general problem, though. Before GitHub, we > > (core developers) would take the patch submitted by a contributor, > > make whatever minor changes were needed (e.g. Misc/NEWS) and push the > > aggregate ours

Re: [Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Paul Sokolovsky
Hello, On Sun, 25 Jun 2017 10:33:20 +0200 Antoine Pitrou wrote: [] > Hmm. If it were so easy, you wouldn't have felt the need to add that > functionality to blurb, right? :-) > > This is touching a more general problem, though. Before GitHub, we > (core developers) would take the patch submi

[Python-Dev] Helping contributors with chores (do we have to?)

2017-06-25 Thread Antoine Pitrou
On Sat, 24 Jun 2017 21:37:46 -0700 Larry Hastings wrote: > On 06/24/2017 09:14 PM, Serhiy Storchaka wrote: > > Not only core developers make PRs for CPython. Since all non-trivial > > changes need to be mentioned in Misc/NEWS, blurb becomes a required > > tool for all committers. > > Well, no