Re: [Python-Dev] Needed reviews

2015-03-26 Thread Victor Stinner
2015-03-19 10:28 GMT+01:00 Serhiy Storchaka : > https://bugs.python.org/issue23681 > Have -b warn when directly comparing ints and bytes closed > https://bugs.python.org/issue23676 > Add support of UnicodeTranslateError in standard error handlers commented > https://bugs.python.org/issu

Re: [Python-Dev] peps: New PEP 490: Chain exceptions at C level

2015-03-26 Thread Andrew Svetlov
I think setting context in exception constructor would be fine. On Thu, Mar 26, 2015 at 1:36 PM, Victor Stinner wrote: > 2015-03-26 11:52 GMT+01:00 Andrew Svetlov : >> There is another issue: exception chain is not set up on exception >> creation in python code, only on throwing. > > I'm not supr

Re: [Python-Dev] peps: New PEP 490: Chain exceptions at C level

2015-03-26 Thread Victor Stinner
Thanks Serhiy for your review, I modified the PEP. I just sent a first draft (including your suggestions) to python-dev. Victor ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://ma

[Python-Dev] RFC: PEP 490 - Chain exceptions at C level

2015-03-26 Thread Victor Stinner
Hi, Here is the first draft of my PEP to chain automatically exceptions at C level in Python 3.5. Plain text version of the PEP below. HTML version of the PEP: https://www.python.org/dev/peps/pep-0490/ It has already an implementation, the pyerr_chain.patch file attached to http://bugs.python

Re: [Python-Dev] peps: New PEP 490: Chain exceptions at C level

2015-03-26 Thread Victor Stinner
2015-03-26 11:52 GMT+01:00 Andrew Svetlov : > There is another issue: exception chain is not set up on exception > creation in python code, only on throwing. I'm not suprised of that. > Thus I have to assign `__context__` and `__cause__` attributes > manually if I want to call `future.set_excepti

Re: [Python-Dev] peps: New PEP 490: Chain exceptions at C level

2015-03-26 Thread Andrew Svetlov
There is another issue: exception chain is not set up on exception creation in python code, only on throwing. Thus I have to assign `__context__` and `__cause__` attributes manually if I want to call `future.set_exception(exc)` instead of `raise exc`. See aiohttp code for usage example: https://gi

Re: [Python-Dev] peps: New PEP 490: Chain exceptions at C level

2015-03-26 Thread Serhiy Storchaka
On 26.03.15 10:08, victor.stinner wrote: https://hg.python.org/peps/rev/7daf3bfd9586 changeset: 5741:7daf3bfd9586 user:Victor Stinner date:Thu Mar 26 09:08:08 2015 +0100 summary: New PEP 490: Chain exceptions at C level +Python 3.5 introduces a new private ``_PyErr_ChainE