Re: [Python-Dev] pickle self-delimiting

2014-04-01 Thread Charles-François Natali
> No reason AFAIK. However, the fact that it is self-delimited is implicit > in the fact that "Bytes past the pickled object's representation are > ignored": https://docs.python.org/dev/library/pickle.html#pickle.load I find this sentence worrying: it could lead one to think that load() could read

Re: [Python-Dev] libpython added to ABI tracker

2014-04-01 Thread Benjamin Peterson
On Tue, Apr 1, 2014, at 13:59, Nick Coghlan wrote: > On 2 Apr 2014 00:54, "Benjamin Peterson" wrote: > > > > On Tue, Apr 1, 2014, at 4:45, Nick Coghlan wrote: > > > Georg, Larry, Benjamin - should checking these be added to PEP 101, so > > > we don't get the same thing happening for 3.5? > > > >

Re: [Python-Dev] libpython added to ABI tracker

2014-04-01 Thread Nick Coghlan
On 2 Apr 2014 00:54, "Benjamin Peterson" wrote: > > On Tue, Apr 1, 2014, at 4:45, Nick Coghlan wrote: > > Georg, Larry, Benjamin - should checking these be added to PEP 101, so > > we don't get the same thing happening for 3.5? > > I would like it if we could put this in the testsuite somehow. Pe

Re: [Python-Dev] pickle self-delimiting

2014-04-01 Thread Antoine Pitrou
On Tue, 1 Apr 2014 19:29:38 +0100 Charles-François Natali wrote: > Hi, > > Unless I'm mistaken, pickle's documentation doesn't mention that the pickle > wire-format is self-delimiting. Is there any reason why it's not documented? No reason AFAIK. However, the fact that it is self-delimited is im

Re: [Python-Dev] cpython (3.4): simplify check, since now there are only new-style classes

2014-04-01 Thread Antoine Pitrou
On Tue, 1 Apr 2014 13:28:53 -0500 Zachary Ware wrote: > > @@ -524,7 +521,7 @@ > > skip = set() > > for klass in default_classes: > > for check in handlers: > > -if isclass(check): > > +if instance(check, type): > > Should be isinstance, should it not? S

Re: [Python-Dev] [Python-checkins] cpython (3.4): simplify check, since now there are only new-style classes

2014-04-01 Thread Zachary Ware
On Tue, Apr 1, 2014 at 1:21 PM, benjamin.peterson wrote: > http://hg.python.org/cpython/rev/abb85902ce79 > changeset: 90090:abb85902ce79 > branch: 3.4 > parent: 90088:4a2dabac976d > user:Benjamin Peterson > date:Tue Apr 01 14:20:56 2014 -0400 > summary: > simplify ch

[Python-Dev] pickle self-delimiting

2014-04-01 Thread Charles-François Natali
Hi, Unless I'm mistaken, pickle's documentation doesn't mention that the pickle wire-format is self-delimiting. Is there any reason why it's not documented? The reason I'm asking is because I've seen some code out there doing its own ad-hoc length-prefix framing. Cheers, cf

Re: [Python-Dev] libpython added to ABI tracker

2014-04-01 Thread Andrey Ponomarenko
Nick Coghlan wrote: On 1 Apr 2014 01:38, "Victor Stinner" wrote: 2014-03-31 13:38 GMT+02:00 Andrey Ponomarenko : The public libpython API changes will be tracked here: http://upstream-tracker.org/versions/python_public_api.html For now I've excluded only symbols starting with an underscore.

Re: [Python-Dev] libpython added to ABI tracker

2014-04-01 Thread Benjamin Peterson
On Tue, Apr 1, 2014, at 4:45, Nick Coghlan wrote: > Georg, Larry, Benjamin - should checking these be added to PEP 101, so > we don't get the same thing happening for 3.5? I would like it if we could put this in the testsuite somehow. ___ Python-Dev mail

Re: [Python-Dev] libpython added to ABI tracker

2014-04-01 Thread Nick Coghlan
On 1 April 2014 21:23, Andrey Ponomarenko wrote: > > Nick Coghlan wrote: >> >> On 1 Apr 2014 01:38, "Victor Stinner" wrote: >>> >>> 2014-03-31 13:38 GMT+02:00 Andrey Ponomarenko : The public libpython API changes will be tracked here: http://upstream-tracker.org/versions/python_pub