Re: [Python-Dev] 2to3 porting HOWTO: setup.py question

2012-07-23 Thread anatoly techtonik
On Tue, Jul 24, 2012 at 1:27 AM, Éric Araujo wrote: > On 22/07/2012 15:57, R. David Murray wrote: >> >> I'm not familiar with distutils, really, so you could be right about >> what it is important to test. I was commenting based on the code >> snippet presented, which just deciding which "build"

Re: [Python-Dev] 2to3 porting HOWTO: setup.py question

2012-07-23 Thread Oscar Benjamin
On 23 July 2012 23:27, Éric Araujo wrote: > On 22/07/2012 15:57, R. David Murray wrote: > >> I'm not familiar with distutils, really, so you could be right about >> what it is important to test. I was commenting based on the code >> snippet presented, which just deciding which "build" object to

Re: [Python-Dev] 2to3 porting HOWTO: setup.py question

2012-07-23 Thread Éric Araujo
On 22/07/2012 15:57, R. David Murray wrote: I'm not familiar with distutils, really, so you could be right about what it is important to test. I was commenting based on the code snippet presented, which just deciding which "build" object to use. If build_py_2to3 can be imported by python2 and su

Re: [Python-Dev] 2to3 porting HOWTO: setup.py question

2012-07-23 Thread anatoly techtonik
On Mon, Jul 23, 2012 at 12:21 AM, Oscar Benjamin wrote: >> On Sun, 22 Jul 2012 20:22:50 +0100, Oscar Benjamin >> wrote: >> > On 22 July 2012 14:08, R. David Murray wrote: >> > >> > > On Sun, 22 Jul 2012 11:21:38 +0300, anatoly techtonik >> > > >> > > wrote: >> > > > http://docs.python.org/py3k/

Re: [Python-Dev] cpython (merge 3.2 -> default): MERGE: Better test for Issue #15402: Add a __sizeof__ method to struct.Struct

2012-07-23 Thread martin
Zitat von Serhiy Storchaka : On 23.07.12 22:46, Michael Foord wrote: I am now prepared a set of 14 __sizeof__ patches (should it be one issue or 14 individual issues in bugtracker?), and I feel a great desire not to write tests at all. Without tests how can you have any confidence the pat

Re: [Python-Dev] Doc/ACKS and Misc/ACKS

2012-07-23 Thread Ethan Furman
Brian Curtin wrote: On Mon, Jul 23, 2012 at 1:28 PM, Jesus Cea wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 23/07/12 19:30, Eli Bendersky wrote: That said, we could probably merge Doc/ACKS and Misc/ACKS (*). There doesn't seem to be any strong argument for separating doc contributi

Re: [Python-Dev] cpython (merge 3.2 -> default): MERGE: Better test for Issue #15402: Add a __sizeof__ method to struct.Struct

2012-07-23 Thread Serhiy Storchaka
On 23.07.12 22:46, Michael Foord wrote: I am now prepared a set of 14 __sizeof__ patches (should it be one issue or 14 individual issues in bugtracker?), and I feel a great desire not to write tests at all. Without tests how can you have any confidence the patches are correct (or will contin

[Python-Dev] Doc/ACKS and Misc/ACKS

2012-07-23 Thread Chris Jerdonek
> Date: Mon, 23 Jul 2012 19:17:32 +0200 > From: Antoine Pitrou > To: python-dev@python.org > Subject: [Python-Dev] Doc/ACKS and Misc/ACKS > >> > Doc/ACKS.txt is *only* for acknowledging documentation >> > contributions. Serhiy is already in Misc/ACKS. No need to add him >> > to Doc/ACKS.txt. >> >

Re: [Python-Dev] cpython (merge 3.2 -> default): MERGE: Better test for Issue #15402: Add a __sizeof__ method to struct.Struct

2012-07-23 Thread Michael Foord
On 23 Jul 2012, at 19:49, Serhiy Storchaka wrote: > On 23.07.12 19:38, Jesus Cea wrote: >> The problem is that if we do ">=", then an unpatched python >> interpreter could pass the test too. So we are not actually testing >> the feature. >> >> If the repeat counters are going to be optimized, th

Re: [Python-Dev] cpython (merge 3.2 -> default): MERGE: Better test for Issue #15402: Add a __sizeof__ method to struct.Struct

2012-07-23 Thread Serhiy Storchaka
On 23.07.12 21:19, Meador Inge wrote: The patch was out for review for several days ... Actually for several months (in issue14596). ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: ht

Re: [Python-Dev] cpython (merge 3.2 -> default): MERGE: Better test for Issue #15402: Add a __sizeof__ method to struct.Struct

2012-07-23 Thread Serhiy Storchaka
On 23.07.12 19:38, Jesus Cea wrote: The problem is that if we do ">=", then an unpatched python interpreter could pass the test too. So we are not actually testing the feature. If the repeat counters are going to be optimized, the obvious step would be to upgrade the test to do something like "B

Re: [Python-Dev] [Python-checkins] cpython (merge 3.2 -> default): MERGE: Better test for Issue #15402: Add a __sizeof__ method to struct.Struct

2012-07-23 Thread Jesus Cea
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 23/07/12 20:19, Meador Inge wrote: > self.assertGreaterEqual(sys.getsizeof(struct.Struct('123B')), [...] > and while they didn't fail without the patch I felt they were still > useful in documenting that there is nothing that guarantees > 'sizeof("1

Re: [Python-Dev] Doc/ACKS and Misc/ACKS

2012-07-23 Thread Brian Curtin
On Mon, Jul 23, 2012 at 1:28 PM, Jesus Cea wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 23/07/12 19:30, Eli Bendersky wrote: >>> That said, we could probably merge Doc/ACKS and Misc/ACKS (*). >>> There doesn't seem to be any strong argument for separating doc >>> contributions f

Re: [Python-Dev] Doc/ACKS and Misc/ACKS

2012-07-23 Thread Jesus Cea
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 23/07/12 19:30, Eli Bendersky wrote: >> That said, we could probably merge Doc/ACKS and Misc/ACKS (*). >> There doesn't seem to be any strong argument for separating doc >> contributions from other contributions. >> >> (*) I think perhaps Éric alre

Re: [Python-Dev] [Python-checkins] cpython (merge 3.2 -> default): MERGE: Better test for Issue #15402: Add a __sizeof__ method to struct.Struct

2012-07-23 Thread Meador Inge
On Mon, Jul 23, 2012 at 11:38 AM, Jesus Cea wrote: >> As for the tests, I intentionally kept them the way that Serhiy >> contributed them -- using >= instead of >. I kept them this way >> because we also discussed in issue14596 the prospect of optimizing >> the way repeat counts are handled. Th

Re: [Python-Dev] Doc/ACKS and Misc/ACKS

2012-07-23 Thread Meador Inge
On Mon, Jul 23, 2012 at 12:17 PM, Antoine Pitrou wrote: > On Mon, 23 Jul 2012 18:38:30 +0200 > Jesus Cea wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 23/07/12 18:27, Meador Inge wrote: >> > Doc/ACKS.txt is *only* for acknowledging documentation >> > contributions. Serhiy i

Re: [Python-Dev] Doc/ACKS and Misc/ACKS

2012-07-23 Thread Eli Bendersky
>> On 23/07/12 18:27, Meador Inge wrote: >> > Doc/ACKS.txt is *only* for acknowledging documentation >> > contributions. Serhiy is already in Misc/ACKS. No need to add him >> > to Doc/ACKS.txt. >> >> Oh, I missed that. Thanks for the head up. > > That said, we could probably merge Doc/ACKS and Mis

[Python-Dev] Doc/ACKS and Misc/ACKS

2012-07-23 Thread Antoine Pitrou
On Mon, 23 Jul 2012 18:38:30 +0200 Jesus Cea wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 23/07/12 18:27, Meador Inge wrote: > > Doc/ACKS.txt is *only* for acknowledging documentation > > contributions. Serhiy is already in Misc/ACKS. No need to add him > > to Doc/ACKS.txt. >

Re: [Python-Dev] [Python-checkins] cpython (merge 3.2 -> default): MERGE: Better test for Issue #15402: Add a __sizeof__ method to struct.Struct

2012-07-23 Thread Jesus Cea
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 23/07/12 18:27, Meador Inge wrote: > Doc/ACKS.txt is *only* for acknowledging documentation > contributions. Serhiy is already in Misc/ACKS. No need to add him > to Doc/ACKS.txt. Oh, I missed that. Thanks for the head up. > As for the tests, I in

Re: [Python-Dev] [Python-checkins] cpython (merge 3.2 -> default): MERGE: Better test for Issue #15402: Add a __sizeof__ method to struct.Struct

2012-07-23 Thread Meador Inge
On Mon, Jul 23, 2012 at 11:17 AM, jesus.cea wrote: > http://hg.python.org/cpython/rev/b9a3ed1b14b9 > changeset: 78260:b9a3ed1b14b9 > parent: 78257:03063e718f5f > parent: 78259:1911e192af0d > user:Jesus Cea > date:Mon Jul 23 18:16:18 2012 +0200 > summary: > MERGE: Be

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-23 Thread Brian Curtin
On Mon, Jul 23, 2012 at 11:24 AM, Andrew Svetlov wrote: > I thought my proposition is minor change, but if it's too late for 3.3 > — I'm ok. Very simply, the first beta is when feature freeze goes into effect. This is a really common policy that has been in effect for a long time in CPython and m

Re: [Python-Dev] venv scripts for fish and csh shells

2012-07-23 Thread Andrew Svetlov
I thought my proposition is minor change, but if it's too late for 3.3 — I'm ok. On Sun, Jul 22, 2012 at 8:54 PM, Antoine Pitrou wrote: > On Sun, 22 Jul 2012 20:39:15 +0300 > Andrew Svetlov wrote: >> Ok. >> Sorry for my mistake — there are really no commits for >> http://bugs.python.org/issue154

Re: [Python-Dev] [Python-checkins] cpython (merge 3.2 -> default): Merge #15232: correctly mangle From lines in MIME preamble and epilogue

2012-07-23 Thread Meador Inge
On Mon, Jul 23, 2012 at 12:34 AM, Meador Inge wrote: > On Sun, Jul 22, 2012 at 8:55 PM, r.david.murray > wrote: > >> http://hg.python.org/cpython/rev/80b81658455b >> changeset: 78246:80b81658455b >> parent: 78244:c43d73277756 >> parent: 78245:b97f65f2298d >> user:R David Murr

Re: [Python-Dev] Why no venv in existing directory?

2012-07-23 Thread Łukasz Langa
Wiadomość napisana przez Stefan H. Holek w dniu 23 lip 2012, o godz. 09:09: > Hi Carl, > > On 19.07.2012, at 18:39, Carl Meyer wrote: > >> Hi Stefan, >> >> On 07/19/2012 06:28 AM, Stefan H. Holek wrote: >>> While trying 3.3 beta I found that I cannot use my favorite >>> virtualenv pattern with

Re: [Python-Dev] Why no venv in existing directory?

2012-07-23 Thread Stefan H. Holek
Hi Carl, On 19.07.2012, at 18:39, Carl Meyer wrote: > Hi Stefan, > > On 07/19/2012 06:28 AM, Stefan H. Holek wrote: >> While trying 3.3 beta I found that I cannot use my favorite >> virtualenv pattern with pyvenv: > > I'd have no problem with lifting the restriction. > > I don't recall any cl