STINNER Victor added the comment:
Results on Linux (Debian Sid) with different Python versions:
* Python 2.4.6: 14112.8 ms
* Python 2.5.5: 14246.7 ms
* Python 2.6.4+: 14753.4 ms
* Python trunk (2.7a3+): 69.3 ms
It looks like re engine was optimized in trunk :-)
Note: I replaced stopwatch
STINNER Victor added the comment:
Ooops, my benchmark was wrong. It looks like the result depends sys.maxunicode:
$ python2.4 -c "import sys; print sys.maxunicode"
1114111
$ python2.5 -c "import sys; print sys.maxunicode"
1114111
$ python2.6 -c "import sys; prin
STINNER Victor added the comment:
Here is a fix for object.c (object_pyunicode_asstring-py3k.patch):
- PyObject_GenericGetAttr(): Replace PyErr_Format("... %.400s", ...,
_PyUnicode_AsString(name)) by PyErr_Format("... %U", ..., name), as done in
PyObject_GenericSetA
STINNER Victor added the comment:
Fix for _ssl module: replace _PyUnicode_AsString() by PyArg_ParseTuple() with
PyUnicode_FSConverter. This change fixes also ssl for file system encoding
different than utf8. I added a test on surrogates.
The test fails if surrogates can be encoded to the
STINNER Victor added the comment:
MaL> If you want a fail-safe stringified version of a Unicode object,
MaL> your only choice is to create a new API that does error checking,
MaL> properly clears the error and then returns a reference to a constant
MaL> string, e.g. ""
STINNER Victor added the comment:
PyRun_InteractiveLoop() doesn't specify the possible return value. It's maybe
because it's always zero and that the error are not handled :-)
http://docs.python.org/c-api/veryhigh.html#PyRun_InteractiveLoop
PyRun_InteractiveOneFlags() docume
STINNER Victor added the comment:
Patch for pythonrun.c:
- catch _PyUnicode_AsString() error in get_codeset(): very unlikely, codeset
is the result of nl_langinfo() and is ASCII only
- catch _PyUnicode_AsString(sys.stdin.encoding) error in
PyRun_InteractiveOneFlags()
- use
Changes by STINNER Victor :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue1693050>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by STINNER Victor :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue7774>
___
___
Python-bugs-list mailing list
Unsubscribe:
STINNER Victor added the comment:
Commit numbers: r78688 (trunk), r78698 (py3k), r78699 (2.6), r78700 (3.1).
2.6 branch is froze because 2.6.5RC1 was released and 2.6.5 final is planned
for next week. Ask barry if you should revert your commit or not r78699.
--
nosy: +barry
STINNER Victor added the comment:
+1 to setup a buildbot, but only after all bugs are fixed :-)
--
___
Python tracker
<http://bugs.python.org/issue7449>
___
___
STINNER Victor added the comment:
I'm applying fixes one by one in my local git-svn repository. I will commit
them (in one huge patch \o/) when I'm done, or maybe post a new version of the
patch (if I'm too scared of the patch).
--
___
STINNER Victor added the comment:
> I think the latest (v3) patch is in pretty good shape. (...)
> I'll break up the patch into multiple files as well.
> It will make it easier to deal with if I cause a regression.
I'm already doing that (apply the patch file by file).
STINNER Victor added the comment:
Ok, here is my patch "version 4", based on jerry's nothreads_3.patch. Changes
between version 3 and 4:
- test_support: threading_setup() returns (1,) instead of None; reap_threads()
simply returns the function instead of a dummy decorator
Changes by STINNER Victor :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue7300>
___
___
Python-bugs-list mailing list
Unsubscribe:
STINNER Victor added the comment:
I think initsite() should be atomic: if any kind of error occurs, Python should
print it and exit directly (exit code 1 to notice the error). If initsite()
fails, Python is not complelty initialized.
site is responsible to initialiaze a lot of things
STINNER Victor added the comment:
See also #3137.
--
___
Python tracker
<http://bugs.python.org/issue8063>
___
___
Python-bugs-list mailing list
Unsubscribe:
STINNER Victor added the comment:
Using "valgrind --log-file=/tmp/trace ./python" to slow down Python, I found
another bug in the interactive interpreter: if you press CTRL+c just after the
initialization of the site module the exception will be ignored.
When a signal is catched, i
Changes by STINNER Victor :
--
___
Python tracker
<http://bugs.python.org/issue8063>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/m
STINNER Victor added the comment:
> haypo, it seems you removed the initial message...
I know... My mouse clicked on [remove] button, it wasn't me! I don't know how
to restore it. The message: msg100432.
--
___
Python t
STINNER Victor added the comment:
I found the following issue in Roundup tracker to restore a deleted message:
http://psf.upfronthosting.co.za/roundup/meta/issue267
I tried to write the URL, but it doesn't work:
http://bugs.python.org/issue80...@action=edit&@a...@messages=100432
I t
STINNER Victor added the comment:
> Did someone notice that on Windows, subprocess imports threading,
> and use threads for the communicate() method?
No, I didn't ran the tests on Windows. I can expect that someone build Python
on Linux without threads, but is Python used in embed
STINNER Victor added the comment:
PyImport_Import() clears errors if a module has no globals, whereas
PyEval_GetGlobals() doesn't set any exception on failure. =>
import_no_global.patch removes this unnecessary PyErr_Clear().
--
___
Python
STINNER Victor added the comment:
Py_InitializeEx() calls PyErr_Clear() if PyCodec_Encoder() fails without
checking for the exception type.
Attached initiliaze_pycodec_error.patch checks for error type: if the error is
not an LookupError, display the error and exit (as done for initsite
STINNER Victor added the comment:
tok_stdin_decode() clears error without check for the type.
tokenizer_error.patch stops the tokenizer with an E_ERROR if the exception is
not an UnicodeDecodeError. Fix also err_input() to support E_ERROR: leave the
global exception (PyErr_*) unchanged
Changes by STINNER Victor :
Removed file: http://bugs.python.org/file16489/main_pending_calls.patch
___
Python tracker
<http://bugs.python.org/issue3137>
___
___
Pytho
STINNER Victor added the comment:
Remove main_pending_calls.patch hack: replaced by tokenizer_error.patch.
--
___
Python tracker
<http://bugs.python.org/issue3
Changes by STINNER Victor :
Added file: http://bugs.python.org/file16493/import_no_global.patch
___
Python tracker
<http://bugs.python.org/issue3137>
___
___
Python-bug
STINNER Victor added the comment:
> Remove main_pending_calls.patch hack: replaced by tokenizer_error.patch.
With extra tests, I realized that this patchs is still useful to process a
SIGINT emitted between Py_Initialize() and PyRun_AnyFileExFlags(). Without the
patch, if a SIGINT is emit
STINNER Victor added the comment:
SIGINT.patch is the sum of all patches, it should be easier to review it.
--
Added file: http://bugs.python.org/file16499/SIGINT.patch
___
Python tracker
<http://bugs.python.org/issue3
STINNER Victor added the comment:
My SIGINT.patch for #3137 moves the call to _PyGILState_Init() just before
initsite(), so it doesn't change too much Py_InitializeEx() and it's enough for
me :-)
--
___
Python tracker
<http://bu
New submission from STINNER Victor :
utf8 encoder doesn't work in backslashreplace error handler:
>>> "\uDC80".encode("utf8", "backslashreplace")
TypeError: error handler should have returned bytes
--
components: Unicode
messages: 100678
nos
STINNER Victor added the comment:
See also issue #8092.
--
___
Python tracker
<http://bugs.python.org/issue6697>
___
___
Python-bugs-list mailing list
Unsub
STINNER Victor added the comment:
See also issue #6697.
--
___
Python tracker
<http://bugs.python.org/issue8092>
___
___
Python-bugs-list mailing list
Unsub
STINNER Victor added the comment:
As requested by Guido, here is a new patch including the fix for the site
module: catch errors in execsitecustomize() and execusercustomize().
--
Added file: http://bugs.python.org/file16501/SIGINT-2.patch
Changes by STINNER Victor :
Removed file: http://bugs.python.org/file16488/initsite.patch
___
Python tracker
<http://bugs.python.org/issue3137>
___
___
Python-bugs-list m
Changes by STINNER Victor :
Removed file: http://bugs.python.org/file16491/initiliaze_pycodec_error.patch
___
Python tracker
<http://bugs.python.org/issue3137>
___
___
Changes by STINNER Victor :
Removed file: http://bugs.python.org/file16492/tokenizer_error.patch
___
Python tracker
<http://bugs.python.org/issue3137>
___
___
Python-bug
Changes by STINNER Victor :
Removed file: http://bugs.python.org/file16493/import_no_global.patch
___
Python tracker
<http://bugs.python.org/issue3137>
___
___
Python-bug
Changes by STINNER Victor :
Removed file: http://bugs.python.org/file16494/main_pending_calls.patch
___
Python tracker
<http://bugs.python.org/issue3137>
___
___
Pytho
Changes by STINNER Victor :
Removed file: http://bugs.python.org/file16499/SIGINT.patch
___
Python tracker
<http://bugs.python.org/issue3137>
___
___
Python-bugs-list m
STINNER Victor added the comment:
unicode_fromformat_U.patch: replace PyUnicode_FromFormat("..%s...", ...,
_PyUnicode_AsString(obj)) by PyUnicode_FromFormat("...%U...", ..., obj). It
replaces also "%.200s" by "%U", so the output is no more
STINNER Victor added the comment:
This issue is a regression introduced by r72208 to fix the issue #3672.
Attached patch fixes PyUnicode_EncodeUTF8() if
unicode_encode_call_errorhandler() returns an unicode string (eg.
backslackreplace error handler). I don't know unicodeobject.c code
STINNER Victor added the comment:
PyString_Format() uses a "goto unicode;" if a '%c' or '%s' argument is unicode.
The unicode label converts the partial formatted result (byte string) to
unicode, and use PyUnicode_Format() to finish to formatting.
I don'
STINNER Victor added the comment:
*Draft* patch fixing the issue: render_field() raises an error if the argument
is an unicode argument, string_format() catchs this error and converts self to
unicode and call unicode.format(*args, **kw).
Pseudo-code:
try:
# self.format() raises an
STINNER Victor added the comment:
My patch converts the format string to unicode using the default encoding. It's
inconsistent with str%args: str%args converts str to unicode using the ASCII
charset (if a least one argument is an unicode string), not the default
encoding.
>>>
STINNER Victor added the comment:
u'{0:c}'.format(256) formatter in implemented in Objects/stringlib/formatter.h
and this C template is instanciated in... Python/formatter_string.c (and not
Python/formatter_unicode.c). Extract of formatter_unicode.c comment:
/* don't def
STINNER Victor added the comment:
r77955 is a backport of r69304, commit made 12 months before the backport. It's
related to issue #4151.
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/i
STINNER Victor added the comment:
The patch replaces sysconfig.project_base by
sysconfig.get_config_var('srcdir'). You can maybe use sysconfig.project_base if
sysconfig.get_config_var('srcdir') is None?
--
___
P
STINNER Victor added the comment:
Commited to trunk: r78826 + r78827. I will later backport to py3k.
--
___
Python tracker
<http://bugs.python.org/issue3
STINNER Victor added the comment:
"Thanks to" my commit r78826 (fixing #3137), site errors are now fatal: Python
exits with an error instead of just printing "import site failed; ...". It's
the come back of #7774: test_executable_with_cwd of test_subprocess now alwa
STINNER Victor added the comment:
> I just looked at the code for PyFloat_AsDouble and it checks for NULL pointers
It's just a little help for developers: it will raise the ugly TypeError("bad
argument type for built-in operation") and returns -1.
It's never a good
STINNER Victor added the comment:
My change about site initialization error raised 2 old issues: #7774 and #7880.
flox commited a fix for #7880 and a workaround for #7774 (just enough to fix
test_subprocess).
--
___
Python tracker
<h
STINNER Victor added the comment:
This issue is not related to subprocess, subprocess is just used in examples to
show the bug. The problem is that Python defines an invalid sys.executable if
the process was created with a custom argv[0]. In Python trunk, the site module
now uses sysconfig
STINNER Victor added the comment:
Oooh, I shouldn't post messages at 3:05.
"If sys.executable *is invalid*, sysconfig fails, site import fails, and
finally Python *exits* (since my fix for #3137)."
"It looks like there is *no* trivial, portable and/or reliable solution *t
STINNER Victor added the comment:
Twisted uses the following code (on UNIX-like OS):
def launchWithName(name):
if name and name != sys.argv[0]:
exe = os.path.realpath(sys.executable)
log.msg('Changing process name to ' + name)
os.execv(exe, [name,
STINNER Victor added the comment:
ping! This issue is still open.
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue4376>
___
___
Python-bugs-list m
STINNER Victor added the comment:
getpath.patch: another patch written by flox. If argv[0] is set to a non
existent program name, sys.executable is set to an empty string instead of a
directory name.
Example of the bug with Python 2.5:
$ sh -c "exec -a xxx python -c 'import sys,
STINNER Victor added the comment:
r78835 (trunk) fixes getpath and includes also a fix for sysconfig which should
fix test_executable_with_cwd() of test_subprocess.
My fix on sysconfig is different than flox's patch: since I fixed getpath,
sys.executable cannot be a directory nam
STINNER Victor added the comment:
There is a 4th case about sys.executable: If argv[0] is an empty string, Python
search the absolute path of "python" (hardcoded program name). The result is
/usr/bin/python in my Linux box, whereas the real program name should be
/opt/pythontrunk/
Changes by STINNER Victor :
--
___
Python tracker
<http://bugs.python.org/issue7774>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/m
STINNER Victor added the comment:
Oh well, it's really hard to test the tests in my working copy because it
depends on a lot of factors: the current working directory, is Python installed
or not, the OS, etc. The test introduced in r78835 was incorrect (only the
test, the fix is co
STINNER Victor added the comment:
The problem comes from SSL_Shutdown() on a non blocking connection. See:
http://www.mail-archive.com/openssl-...@openssl.org/msg24097.html
--
___
Python tracker
<http://bugs.python.org/issue8
STINNER Victor added the comment:
The patch changing SSL_Shutdown() behaviour on non blocking socket was written
in 2006 by Darryl Miles and it will commited into 0.9.8m. The original patch:
http://marc.info/?l=openssl-dev&m=115153998821797&w=2
In our testcase, SSL_Shutdown() fa
STINNER Victor added the comment:
More informations:
http://www.openssl.org/docs/ssl/SSL_shutdown.html
http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=1891
Extract of the manual page:
If the underlying BIO is non-blocking, SSL_shutdown() will also return w
STINNER Victor added the comment:
There are different kind of bugs, but all of them are related to
SSL_Shutdown(). It depends on the socket timeout:
- blocking socket: nothing special (no change from previous OpenSSL version)
- timeout or non blocking socket: if SSL_shutdown() returns -1 and
STINNER Victor added the comment:
> r78835 (trunk) fixes getpath and includes also a fix for sysconfig which
> should fix test_executable_with_cwd() of test_subprocess.
Backported as r78868 to the py3k branch.
--
___
Python tracker
STINNER Victor added the comment:
> Commited to trunk: r78826
Backported to py3k as r78872. But py3k will require extra work: there are some
PyErr_Clear() somewhere, eating the errors.
--
___
Python tracker
<http://bugs.python.org/iss
New submission from STINNER Victor :
PyFile_WriteString() calls PyObject_Str() which calls PyErr_CheckSignals(). If
a signal was catched, the signal handler is called. If the signal handler
raises an error, PyObject_Str() and then PyFile_WriteString() return NULL.
mywrite() ignores all
STINNER Victor added the comment:
Bug related to this issue: #8124, PySys_WriteStdout() and PySys_WriteStderr()
ignore signal handlers errors.
--
___
Python tracker
<http://bugs.python.org/issue3
STINNER Victor added the comment:
This bug is related to #3137.
--
___
Python tracker
<http://bugs.python.org/issue8124>
___
___
Python-bugs-list mailin
STINNER Victor added the comment:
I commited unicode_fromformat_U.patch as r78875.
--
___
Python tracker
<http://bugs.python.org/issue6697>
___
___
Python-bug
STINNER Victor added the comment:
Oh, my ssl_rand_egd_unicode-py3k.patch is complelty broken! It writes a pointer
to an object into the "char* path" variable :-/
--
___
Python tracker
<http://bugs.python.
STINNER Victor added the comment:
object_pyunicode_asstring-py3k.patch commited as r78876.
--
___
Python tracker
<http://bugs.python.org/issue6697>
___
___
Pytho
STINNER Victor added the comment:
I posted on openssl-users mailing list. The author of patch (change
SSL_shutdown() behaviour for non blocking socket) replied!
http://marc.info/?l=openssl-users&m=126838806919896&w=2
--
___
Python tracke
STINNER Victor added the comment:
Commited: r78886 (trunk), r7 (py3k).
--
___
Python tracker
<http://bugs.python.org/issue7818>
___
___
Python-bugs-list m
Changes by STINNER Victor :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7818>
___
___
Python-bugs-list
New submission from STINNER Victor :
Python documentation has the prototype:
sqlite3.connect(database[, timeout, isolation_level, detect_types, factory])
http://docs.python.org/library/sqlite3.html#sqlite3.connect
Source code:
- sqlite.rst: .. function:: connect(database[, timeout
STINNER Victor added the comment:
> close() can fail
Not close, unwrap() (shutdown()) ;-)
> Again, why does this failure only show up in the FTP test?
Maybe because only the FTP test uses an SSL socket in non blocking mode.
--
___
Python t
STINNER Victor added the comment:
Python was displaying an error: did you saw the error? I don't know where
Django logs stderr.
Could you also run Python in verbose mode? Set PYTHONVERBOSE=2 environment
variable. It should write useful informations before the crash.
--
nosy: +
STINNER Victor added the comment:
Backported in r79197 (2.6).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
STINNER Victor added the comment:
> thread fix commited: r78610 (trunk)
> curses panel fix commited: r78635 (trunk)
Backport done in r79198 (2.6).
--
___
Python tracker
<http://bugs.python.org/
STINNER Victor added the comment:
> Commited: r78638 (trunk)
Backport done: r79199 (2.6).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
STINNER Victor added the comment:
> Fixed by r78641 (trunk)
Backport done: r79200 (2.6).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
STINNER Victor added the comment:
> Commited: r78646 (trunk)
Backport done: r79201 (2.6).
--
resolution: remind -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
STINNER Victor added the comment:
> r78835 (trunk) fixes getpath
Backport done: r79202 (2.6).
--
___
Python tracker
<http://bugs.python.org/issue7774>
___
_
STINNER Victor added the comment:
> Commited to trunk: r78826 + r78827
Partial backport to 2.6 as r79204: leave import site error handler unchanged
(print the error and continue). I don't want to change Python behaviour between
minor
Changes by STINNER Victor :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue8063>
___
___
Python-bugs-list
STINNER Victor added the comment:
> I commited unicode_fromformat_U.patch as r78875.
> object_pyunicode_asstring-py3k.patch commited as r78876.
Backported as r79240 and r79241 to 3.1.
--
___
Python tracker
<http://bugs.python.org/
STINNER Victor added the comment:
> Backported to py3k as r78872
And backported to 3.1 as r79247.
> But py3k will require extra work: there are some PyErr_Clear() somewhere,
> eating the errors.
Leave this issue open until #8124
STINNER Victor added the comment:
>> Backported to py3k as r78872
> And backported to 3.1 as r79247.
I reverted the change on initsite(): as for Python 2.6, I don't want to change
import site error handler between minor releases.
--
New submission from STINNER Victor :
sqlite.connect(":memory:").create_collation, "\uDC80", collation_cb) because
_PyUnicode_AsString() returns NULL and error, and the result is not checked.
Attached patch fixes the crash.
I didn't checked if the problem doe
Changes by STINNER Victor :
Removed file: http://bugs.python.org/file16616/sqlite_collation-py3k.patch
___
Python tracker
<http://bugs.python.org/issue8195>
___
___
Pytho
STINNER Victor added the comment:
(oops, my patch included tabulations!)
--
Added file: http://bugs.python.org/file16617/sqlite_collation-py3k.patch
___
Python tracker
<http://bugs.python.org/issue8
STINNER Victor added the comment:
The initial problem (test_subprocess failures) is solved thanks to different
fixes. I consider that we can close this issue. Use non portable tricks to get
the real program name if argv[0] is invalid doesn't sound like something
importat. If someone ch
New submission from STINNER Victor :
I wrote a patch to preallocate Python thread state before creating the thread
to avoid a fatal error: issue7544 (it's now closed). This patch is not enough
to avoid fatal errors in low memory condition.
Just after the creation of the t
Changes by STINNER Victor :
--
priority: -> low
title: Fatal error on thread creation in low memory condition (2) -> Fatal
error on thread creation in low memory condition: local storage
___
Python tracker
<http://bugs.python.org/
STINNER Victor added the comment:
My first sentence doesn't mean anything! I wanted to write:
sqlite.connect(":memory:").create_collation, "\uDC80", collation_cb) crashs
because _PyUnicode_AsString() returns NULL on error, and t
Changes by STINNER Victor :
--
nosy: -haypo
___
Python tracker
<http://bugs.python.org/issue4735>
___
___
Python-bugs-list mailing list
Unsubscribe:
STINNER Victor added the comment:
Fixed by r79271 (py3k), r79272 (3.1).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
4001 - 4100 of 35284 matches
Mail list logo
