[issue2862] cleanup of freelist management

2008-06-07 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2862> ___ _

[issue3029] free list management - list, dict, set

2008-06-07 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: everyone seems to be in agreement that this patch is a bad idea. closing. -- nosy: +gregory.p.smith resolution: -> rejected status: open -> closed ___ Python tracker <[EMAIL PR

[issue2862] cleanup of freelist management

2008-06-07 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I agree with this patch and will commit it later this weekend if I hear no objections. see the mailing list discussion. -- assignee: christian.heimes -> gregory.p.smith ___ Pytho

[issue2632] performance problem in socket._fileobject.read

2008-06-10 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- versions: -Python 2.6 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2632> ___ _

[issue2137] test_crasher in test_struct uses 8 GB memory on 64 bit systems

2008-06-11 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Test disabled on 64bit when using the supplied patch when forward porting to 2.6 in trunk revision 64114. -- assignee: -> gregory.p.smith keywords: +64bit, easy, patch nosy: +gregory.p.smith priority: -> high resol

[issue3082] test_multiprocessing broken

2008-06-11 Thread Gregory P. Smith
New submission from Gregory P. Smith <[EMAIL PROTECTED]>: Python 2.6a3+ (trunk:64150M, Jun 11 2008, 14:08:14) [GCC 4.2.3 (Ubuntu 4.2.3-2ubuntu7)] on linux2 Type "help", "copyright", "credits" or "license" for more information. % ./python Lib/t

[issue3082] test_multiprocessing broken

2008-06-11 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: ah yes that is indeed the same problem. marking this one as a dup. -- dependencies: +Thread local storage and PyGILState_* mucked up by os.fork() resolution: -> duplicate status: open

[issue1683] Thread local storage and PyGILState_* mucked up by os.fork()

2008-06-11 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: we need this in before 2.6 is released. -- assignee: -> gregory.p.smith nosy: +gregory.p.smith priority: high -> critical ___ Python tracker <[EMAIL PROTECTED]> <h

[issue3155] Python should expose a pthread_cond_timedwait API for threading

2008-06-20 Thread Gregory P. Smith
New submission from Gregory P. Smith <[EMAIL PROTECTED]>: Currently the threading module has loops in it such as threading.Condition.wait's loop that attempts to acquire a lock in non-blocking mode and if it fails, sleeps for a while and trys again. (with exponential backoff of slee

[issue3227] os.environ.clear has no effect on child processes

2008-06-28 Thread Joe P. Cool
New submission from Joe P. Cool <[EMAIL PROTECTED]>: If I call os.environ.clear in a python program child processes still see the cleared entries. But when I iterate over the keys like so names = os.environ.keys() for k in names: del os.environ[k] then the entries are also delet

[issue2862] cleanup of freelist management

2008-07-05 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: committed to 2.6 trunk in r64753. -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue2632] performance problem in socket._fileobject.read

2008-07-05 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: committed to release25-maint in r64754. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue2620] Multiple buffer overflows in unicode processing

2008-07-05 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10027/issue2620-gps01-patch.txt ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2620] Multiple buffer overflows in unicode processing

2008-07-05 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: here's an updated patch. It makes PyMem_NEW and PyMem_RESIZE macros always do explicit an overflow check before doing the multiplication. Uses of the the macros have been cleaned up in the couple places I noticed that would lea

[issue2113] Bad interaction between signal and subprocess

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Fixed as Amaury described in trunk r64756. still needs backporting to release25-maint. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2320] Race condition in subprocess using stdin

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: lowering the priority on this back to normal as there is a workaround: use close_fds=True. I agree that this is messy, I'm not sure if we can really fix it or even if we should. Running lsof shows the /bin/cat processes on OS X

[issue3304] invalid call to PyMem_Free() in fileio_init()

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith keywords: +easy nosy: +gregory.p.smith priority: -> normal ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3304] invalid call to PyMem_Free() in fileio_init()

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: thanks. fixed in trunk r64758. i'm assuming that'll be merged into py3k automagically. -- resolution: -> accepted versions: +Python 3.0 -Python 2.6 ___ Python tracke

[issue3277] socket's OOB data management is broken on OS X and FreeBSD

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith nosy: +gregory.p.smith priority: -> normal title: socket's OOB data management is broken on FreeBSD -> socket's OOB data management is b

[issue3278] socket's SO_OOBINLINE option does not work on OS X and FreeBSD

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith nosy: +gregory.p.smith priority: -> normal title: socket's SO_OOBINLINE option does not work on FreeBSD -> socket's SO_OOBINLINE option does not

[issue3278] socket's SO_OOBINLINE option does not work

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: This also happens on Linux: read -> x Exception in thread Thread-1: Traceback (most recent call last): File "/home/greg/sandbox/python/trunk/Lib/threading.py", line 523, in __bootstrap_inner self.run() File

[issue3278] socket's SO_OOBINLINE option does not work

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: p648 of Unix Network Programming third edition: "4. If the process has set the SO_OOBINLINE socket option and then tries to read the out-of-band data by specifying MSG_OOB, EINVAL is returned." so it does not sound like

[issue3278] socket's SO_OOBINLINE option does not work

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: further reading reveals that this is the expected behavior. p651 in 24.2: "select indicates an exception condition until the process reads -beyond- the out of band data." ... "the solution is to only select for a

[issue3278] socket's SO_OOBINLINE option does not work

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: A friend confirms that on NetBSD it matches the Linux behavior. "read -> x" is printed before the exception. also fwiw, my OS X version is 10.5.3. IMNSHO not a python bug. open it with FreeBSD and Apple. --

[issue3277] socket's OOB data management is broken on OS X and FreeBSD

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: not a python issue. thanks for opening one with FreeBSD. -- resolution: -> invalid status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3309] missing lock release in BZ2File_iternext()

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith keywords: +easy nosy: +gregory.p.smith priority: -> normal ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3309] missing lock release in BZ2File_iternext()

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Fixed in trunk r64767. Needs backporting to release25-maint. -- resolution: -> accepted type: -> behavior versions: +Python 2.5 -Python 2.6 ___ Python tracker <[EMAIL PR

[issue3307] invalid check of _bsddb creation failure

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> jcea nosy: +jcea priority: -> normal type: -> crash ___ Python tracker <[EMAIL PROTECTED]> <http://b

[issue988761] re.split emptyok flag (fix for #852532)

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: take a look at the patch being worked on in issue #3262. -- nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue3212] ssl module - should test for a wrong cert

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> janssen priority: -> normal ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3119] pickle.py is limited by python's call stack

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- superseder: -> eliminate recursion in pickling ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2480] eliminate recursion in pickling

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- dependencies: +pickle.py is limited by python's call stack ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue3183] sha modules & Modules/Setup.dist

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: seems harmless enough. done in trunk r64769. -- assignee: -> gregory.p.smith nosy: +gregory.p.smith priority: -> low resolution: -> fixed status: open -> closed ___ Pyth

[issue3210] subprocess.Popen does not release process handles if process cannot be started

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith components: +Library (Lib) -Extension Modules nosy: +gregory.p.smith priority: -> normal versions: +Python 2.6 ___ Python tracker <[EMAIL PR

[issue2277] MozillaCookieJar does not support Firefox3 cookie files

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: sounds like a good idea to add this. yay firefox 3. i'll review it. -- assignee: -> gregory.p.smith components: +Library (Lib) nosy: +gregory.p.smith priority: -> normal type: -> feature request v

[issue3001] RLock's are SLOW

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- components: +Interpreter Core, Library (Lib) nosy: +gregory.p.smith priority: -> normal ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3120] subprocess module truncates handles on AMD64

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith components: +Extension Modules nosy: +gregory.p.smith priority: -> high type: -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://b

[issue3094] By default, HTTPSConnection should send header "Host: somehost" instead of "Host: somehost:443"

2008-07-06 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: fixed in trunk r64771. (and indeed the previous behavior was buggy in the extreemly rare event that someone ran a https server on port 80 the :80 should have been supplied). -- assignee: -> gregory.p.smith keywords: +

[issue3046] Locking should be removed from the new buffer protocol

2008-07-06 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> teoliphant nosy: +gregory.p.smith priority: -> critical ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue1857] subprocess.Popen.poll/__del__ API breakage

2008-07-07 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith keywords: +patch nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue1606] Doc: subprocess wait() may lead to dead lock

2008-07-07 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: i'll come up with something for the documentation on this. -- assignee: -> gregory.p.smith nosy: +gregory.p.smith resolution: -> accepted type: -> behavior ___ Py

[issue1068268] subprocess is not EINTR-safe

2008-07-07 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: fyi - To fix issue #2113 I added handling of a select.error errno.EINTR being raised during the select.select call in r64756. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue874900] threading module can deadlock after fork

2008-07-12 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pyth

[issue874900] threading module can deadlock after fork

2008-07-12 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: The existing fork-and-thread4.patch doesn't actually reset _active_limbo_lock. Its missing a "global _active_limbo_lock" statement in the threading._after_fork() function. ___ P

[issue874900] threading module can deadlock after fork

2008-07-12 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: and a few more bugs. a new patch is attached. With this applied, pitrou's fork_threading.py bug demonstration script finally does the right thing. test_threading, including the new deadlock tests, and test_multiprocessin

[issue874900] threading module can deadlock after fork

2008-07-12 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10855/fork-and-thread.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue874900] threading module can deadlock after fork

2008-07-12 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10859/fork-and-thread2.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue874900] threading module can deadlock after fork

2008-07-12 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10869/fork-and-thread3.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue874900] threading module can deadlock after fork

2008-07-12 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10872/fork-and-thread4.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.

[issue874900] threading module can deadlock after fork

2008-07-12 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I still don't like the _after_fork() implementation. Its O(n) where n == number of threads the parent process had. Very wasteful when the fork() was done in the most common case of being followed by an exec and calling os._

[issue2303] isinstance is 4x as slow as in 2.5 because the common case raises

2008-07-13 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: % ./python.exe -mtimeit 'isinstance(3, int)' 100 loops, best of 3: 0.269 usec per loop % ../release25-maint/python.exe -mtimeit 'isinstance(3, int)'100 loops, best of 3: 0.335 usec per loop So I'd sa

[issue2534] Restore isinstance and issubclass speed in 2.6

2008-07-13 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: speedup of this patch confirmed. Also, it triggers the bugs mentioned that have their own issues open. Once #2542 is fixed this should be looked at again. Its a big performance regression in 2.6 over 2.5 if we don't get this

[issue3335] subprocess lib - opening same command fails

2008-07-13 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I am unable to reproduce this (using release24-maint on OS X 10.4). the script I used is attached. Does this script fail for you? If not, please upload something that fails. -- nosy: +gregory.p.smith Added file

[issue874900] threading module can deadlock after fork

2008-07-16 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I added a Misc/NEWS note for this in r65057. This is a good candidate for backporting to release25-maint. To answer Antoine Pitrou's question about using the old ident vs the new _get_ident(). I don't know if the for

[issue874900] threading module can deadlock after fork

2008-07-17 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Jesse: thanks for doing the py3k merge. Antoine: yeah it might be safer to use _get_ident() but since the len(_active) == 1 assert is not firing we're probably fine as is. A change to this that I was considering making to th

[issue2960] bsddb/test/test_replication.py bus error, segfault, assertion error, pass

2008-07-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: python 2.6b1+, bdb 4.7.25 on x86 ubuntu linux. % ../../../../python/trunk/python bsddb3/tests/test_replication.py -v test01_basic_replication (__main__.DBReplicationManager) ... zsh: segmentation fault ../../../../python/trunk/

[issue2960] bsddb/test/test_replication.py bus error, segfault, assertion error, pass

2008-07-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: (that last comment was using pybsddb svn r529) ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2960] bsddb/test/test_replication.py bus error, segfault, assertion error, pass

2008-07-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: hmm. nevermind. those last results clearly used the wrong bsddb library. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2960] bsddb/test/test_replication.py bus error, segfault, assertion error, pass

2008-07-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Okay, now i've run the correct test suite on the correct modules with pybsddb r530: The problems still happen. Sometimes it passes. Other times it raises an assertion error. test01_basic_replication DBReplicationManger e

[issue3120] subprocess module truncates handles on AMD64

2008-07-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: i believe this patch will fix it. but i don't have a windows build environment setup yet to even try it. Exposing pointers to data structures as a number to Python is very gross to begin with. It'd be safer to define a t

[issue2620] Multiple buffer overflows in unicode processing

2008-07-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: diff up for review on http://codereview.appspot.com/2599 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3120] subprocess module truncates handles on AMD64

2008-07-19 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file10951/windows-amd64-subprocess-handle-gps02.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3120] subprocess module truncates handles on AMD64

2008-07-19 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10950/windows-amd64-subprocess-handle-gps01.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3120] subprocess module truncates handles on AMD64

2008-07-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: fixed in trunk r65151 (in theory). I don't have amd64 to test with. Roger, would you please test an AMD64 build from that revision or later to confirm that it is fixed? Once confirmed, this should be backported to rele

[issue3120] subprocess module truncates handles on AMD64

2008-07-20 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- versions: -Python 2.6 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3120> ___ _

[issue1471] ioctl request argument broken on 64-bit OpenBSD or OS X

2008-07-20 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: i believe this is fixed by the two changes mentioned above, i was waiting for fbvortex to confirm the fix on his 64-bit OpenBSD system. these changes need backporting to release25-maint. -- status: pending -> open

[issue2960] bsddb/test/test_replication.py bus error, segfault, assertion error, pass

2008-07-21 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: using a python trunk optimized (non-debug) build and pybsddb r530: -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Berkeley DB 4.7.25: (May 15, 2008) bsddb.db.version(): (4, 7, 25) bsddb.db.__ver

[issue2620] Multiple buffer overflows in unicode processing

2008-07-21 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Commited to trunk. r65182. This still needs backporting to release25-maint. (and release24-maint if anyone is maintaining that) -- keywords: +patch versions: +Python 3.0 -Pyth

[issue1857] subprocess.Popen.poll/__del__ API breakage

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Fixed in trunk r65459. release25-maint r65460. -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3120] subprocess module truncates handles on AMD64

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: fixed in release25-maint r65461. already merged into py3k from trunk. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue1471] ioctl request argument broken on 64-bit OpenBSD or OS X

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: committed to release25-maint as r65466. if testing on 64bit openbsd or similar reveals that this is not fixed, please reopen the bug. -- status: open -> closed ___ Python tracke

[issue1606] Doc: subprocess wait() may lead to dead lock

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: See the documentation update in trunk r65469. It adds warnings about both common pipe related pitfalls discussed in this bug. -- resolution: accepted -> fixed status: open -> closed __

[issue3210] subprocess.Popen does not release process handles if process cannot be started

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I tried closing -all- of the handles listed here (the std ones used as input to _get_handles and the pipe read/write ones returned) on an OSError during CreateProcess but the problem still occurs for me using the test code in ms

[issue2113] Bad interaction between signal and subprocess

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: fixed in release25-maint r65475. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue2277] MozillaCookieJar does not support Firefox3 cookie files

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Thanks. I've looked over your code. The logic looks good, however I'd like to propose a better design and that this not be included in 2.6. Instead of putting this functionality in the MozCookieJar class, it shoul

[issue3487] sre "bytecode" verifier

2008-08-03 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: +1 I'd like to see this make it in. -- nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue2464] urllib2 can't handle http://www.wikispaces.com

2008-08-16 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: looks good to me. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2464> ___ __

[issue1397] mysteriously failing test_bsddb3 threading test in other threads

2008-08-16 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: agreed, that should be made to cause the test to fail. a failureException method that sets a flag that the main thread will detect and fail on when exiting should do the trick. side note: ...sadly that failure appears to be a test

[issue2464] urllib2 can't handle http://www.wikispaces.com

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: i was pondering if it should go in urlparse instead. if it did, i think it should be part of urlparse.urlunparse to ensure that there is always a trailing slash after the host:port regardless of what the inputs are. anyways, agreed

[issue874900] threading module can deadlock after fork

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: backported to release25-maint in r65789. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.p

[issue3309] missing lock release in BZ2File_iternext()

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: backported to release25-maint in r65790 -- status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue874900] threading module can deadlock after fork

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: specifically, test_3_join_in_forked_from_thread hangs in py3k and is currently disabled. -- assignee: gregory.p.smith -> ___ Python tracker <[EMAIL PROTECTED]> <http

[issue2464] urllib2 can't handle http://www.wikispaces.com

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: That test case looks good to me for 2.6 and 3.0. Also add a note to the documentation with a versionchanged 2.6 about urlunparse always ensuring there is a / between the netloc and the rest of the url. I would not back port th

[issue2013] Long object free list optimization

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: preventing this right now is that when i apply this to py3k today, it fails miserably in a debug build. first, my patch has an invalid assert(size > 0) in it in _PyLong_New as 0 size is used when the value is 0. get rid of

[issue2013] Long object free list optimization

2008-08-17 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: attached is an updated patch that also works in debug mode. to do this i had to exclude all zero length (value = 0) PyLongObjects from the free list. i'm still not sure why, they all have the same underlying allocation size.

[issue2013] Long object free list optimization

2008-08-17 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11144/py3k_longfreelist2_gps04.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue815646] thread unsafe file objects cause crash

2008-08-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: The fix can not be committed to Python 2.5 because it breaks compatibility by adding another field to the PyFileObject struct and adding two new C API functions. ___ Python tracker <[EMAIL

[issue2629] _Py_ForgetReference crash when called from _PyUnicode_New on MemoryError

2008-08-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Verified fixed. Python 2.6b2+ (trunk:65871, Aug 19 2008, 13:10:07) >>> msg = 'A'*2000111222 [12389 refs] >>> x = msg.decode('utf8') Traceback (most recent call last): File "", line

[issue3001] RLock's are SLOW

2008-08-20 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I doubt subclassability of RLock matters but who knows, people do code things. Regardless, using a C version wrapped in a simple python container class that calls the underlying C implementation's methods should be sufficient t

[issue3618] possible deadlock in IO library (Lib/io.py)

2008-08-20 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3618> ___ _

[issue3618] possible deadlock in IO library (Lib/io.py)

2008-08-20 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: see the python-3000 thread I just started asking for opinions on this. I'd personally say this bug is a good reason to go ahead with #3001 for 3.0. ___ Python tracker <[EMAIL PRO

[issue874900] threading module can deadlock after fork

2008-08-23 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: it passes on release25-maint for me on linux. i don't see it hanging in any of the 2.5 buildbots. looks like your r66003 change was a decent fix for windows judging by the buildbot. (fwiw, that test you patched in 66003 shou

[issue3678] Ignored LDFLAGS during linking libpython$(VERSION).so

2008-08-27 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith nosy: +gregory.p.smith priority: -> normal ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3710] Reference leak in thread._local

2008-08-27 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3710> ___ _

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-08-27 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- keywords: +patch nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3678] Ignored LDFLAGS during linking libpython$(VERSION).so

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I think this ldflags-ldlast patch (added) is whats really needed. -- keywords: +easy, needs review Added file: http://bugs.python.org/file11280/ldflags-ldlast-gps01.diff ___ Python t

[issue3710] Reference leak in thread._local

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: fyi - This bug and #1868 (http://bugs.python.org/issue1868) seem related. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: see also #3710 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1868> ___ ___ Python

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I like Amaury's patch, it gets rid of what seems like an existing gross hack of having localobject->dict exist at all. I believe it may also fix #3710 by getting rid of the unnecessary localobject->dict member. Could so

[issue3708] os.urandom(1.1): infinite loop

2008-08-27 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: i'll fix this and add a unit test. -- assignee: -> gregory.p.smith keywords: +easy nosy: +gregory.p.smith priority: -> low ___ Python tracker <[EMAIL PROTECTED]>

<    1   2   3   4   5   6   7   8   9   10   >