Changes by Gregory P. Smith :
--
nosy: +jcea -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue17477>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
that patch looks good for imaplib.
i'll follow up on the subprocess side of things to see if the default
behavior should be changed to better match what happened in 2.7 (or if not:
to make sure the change in behavior is sufficiently documented and not
r
Gregory P. Smith added the comment:
fyi, I un-cc'd myself as I don't maintain this module anymore; jcea does. :)
I agree with the patch. Support for anything older than 4.3 is completely
pointless in 2.7 and supporting 5.x is likely required for future OS distros
wanting t
Gregory P. Smith added the comment:
2.7, 3.2, 3.3 and 3.4 have all be updated to ctypes v3.0.13.
fwiw, I tried a build of 3.3 on Sparc Solaris 10 using snakebite (nitrogen) and
ctypes builds and links but two tests fail: ctypes.test.test_bitfields.C_Test
test_ints and test_shorts failed
Changes by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue17477>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I've updated libffi to v3.0.13 which contains the fixes for this in 2.7, 3.2,
3.3 and 3.4.
if someone wants to apply a surgical patch to fix this problem, the one
mentioned above is good as well as:
https://github.com/atgreen/libffi/c
New submission from Gregory P. Smith:
The subprocess module in Python 3 uses io.open(file_descriptor, mode, bufsize)
to create its Popen stdout, stderr and stdin file objects.
In Python 2, it used the old os.fdopen which created an old-style python 2 file
object that simply wraps libc's
Gregory P. Smith added the comment:
fyi - sem_open is unrelated, nothing in subprocess needs that.
--
___
Python tracker
<http://bugs.python.org/issue12
Gregory P. Smith added the comment:
Some way for me to reproduce this is needed.
--
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issu
Changes by Gregory P. Smith :
--
resolution: -> fixed
stage: needs patch -> commit review
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
fyi - subprocess uses /proc to get a list of open fd's in the child process
before exec when possible. search for FD_DIR in
http://hg.python.org/cpython/file/d674bbbed333/Modules/_posixsubprocess.c
--
___
P
Gregory P. Smith added the comment:
It looks like someone has already done the Python-ast cleanup and I don't
understand the point of the distutils test one or the libffi one (ffi has been
updated but it's trivial and would still apply).
--
nosy: +grego
Gregory P. Smith added the comment:
I'm not inclined to apply the patch to ffi unless someone can demonstrate that
it is an actual problem. given that nobody has applied it to *upstream* libffi
(since we just pulled in v3.0.13 earlier this week) I doubt it matters to
anyone.
everything
Gregory P. Smith added the comment:
The number of things we'll break by changing this errant behavior to be
_correct_ is way less than the number of things that are already broken due to
it.
If the bufsize=0 default is left in place the behavior differs between Windows
and POSIX plat
Gregory P. Smith added the comment:
(actually I'm not sure about the windows vs posix behavior difference, that may
not be true; I don't have a windows system handy to test that on)
--
___
Python tracker
<http://bugs.python.o
Gregory P. Smith added the comment:
great! fixing now. :)
--
___
Python tracker
<http://bugs.python.org/issue17488>
___
___
Python-bugs-list mailing list
Unsub
Changes by Gregory P. Smith :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
the pythonrun issue had already been fixed. the others were still there (valid
bugs, but were unlikely to be causing problems given the codepaths). fixed.
I didn't write a Misc/NEWS entry on the commit because I didn't know how to
usefully desc
Gregory P. Smith added the comment:
Here's is an os.scandir(path='.') implementation that iterates reading the
directory on the fly instead of pre-building a list.
os.listdir's implementation should ultimately be replaced by this as:
def listdir(path=None):
if path is
Gregory P. Smith added the comment:
you'll see my code already has TODOs in there for that. windows API
documentation suggests that windows returns even more (stat-like) info when
traversing a directory. returning a namedtuple with the relevant info from the
platform at hand would be
Gregory P. Smith added the comment:
Your objection is noted but it is wrong.
A Python program today cannot process arbitrarily large directories within a
fixed amount of ram today due to os.listdir. This makes it unsuitable for file
system cleanup tasks that we have run into on production
Gregory P. Smith added the comment:
phew, yay. because i didn't see anything obviously wrong with the #16962
commit.
also, regarding checking for EINTR on some of the close() calls. It isn't a
big deal. This _posixsubprocess.c code that contains those checks is always
execut
Changes by Gregory P. Smith :
--
nosy: +twouters
___
Python tracker
<http://bugs.python.org/issue11406>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Here's an updated patch that fixes the windows build based on twouters'
comments. It goes ahead and removes the old C implementation of listdir in
favor of the trivial Python wrapping of scandir.
--
Added file: http://bugs.python.org
Gregory P. Smith added the comment:
While i don't personally like things with iter in the name I won't object.
That way the scandir name would be left available for a future version of this
that yields namedtuples of directory entry details as Martin wa
Changes by Gregory P. Smith :
--
title: Python 2.7.4 Breaks ZipFile Extraction -> Python 2.7.4 breaks ZipFile
extraction of zip files with unicode member paths
versions: +Python 3.2, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.pyth
Gregory P. Smith added the comment:
> > Note that the patch uses type punning through a union
>
> What is the standard and portable way to cast an array of bytes to size_t?
I'd expect just casting the pointer type before dereferencing:
unsigned char *p;
...
hash = (
Changes by Gregory P. Smith :
--
priority: high -> release blocker
___
Python tracker
<http://bugs.python.org/issue17656>
___
___
Python-bugs-list mai
Changes by Gregory P. Smith :
--
nosy: +benjamin.peterson, larry
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Gregory P. Smith added the comment:
consensus here appears to be "bad idea... don't do this."
--
nosy: +gregory.p.smith
priority: high -> normal
resolution: -> wont fix
stage: -> committed/rejected
status: open -> closed
__
Gregory P. Smith added the comment:
okay, but i don't personally find any of these to be good ideas as "codecs"
given they don't have anything to do with translating between bytes<->unicode.
--
resolution: wont fix ->
stage: committed/reject
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue17826>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
it _looks_ like the libffi updates i put in 3.2, 3.3 and default (3.4) are
messed up with some changes missing in 3.2 and more missing in 3.3 and 3.4.
(i'm comparing vs upstream 3.0.13 <-> 2.7 <-> 3.2 <-> 3.3 <-> 3.4).
i blame
Gregory P. Smith added the comment:
I've got this and all of the fixes necessary for 3.3, default and 2.7 in my
local repositories.
odd thing in the 3.2 patch: it is entirely unclear to me if the issue 10309 fix
needs to be kept. i included it as it was missing from 3.2 after pre
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue17192>
___
___
Python-bugs-
Gregory P. Smith added the comment:
Actually I'm thinking this duck may only have a beak. Instead of a bunch of
fields of None I'd prefer just not having that attribute defined on the
object. I consider the os specific "stat-like" info from reading a
directory to be so
Gregory P. Smith added the comment:
The recommendation for anyone using regular expressions on hostile input is to
(a) don't do that. (b) use a better regexp without this possible behavior and
(c) use something like re2 (there's a Python binding at
https://github.com/axiak/pyre2)
Gregory P. Smith added the comment:
Indeed, doing this _without a regexp_ is preferred. :)
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue17
New submission from Gregory P. Smith:
In Python 2.7.3 through 2.7.5 the telnetlib select.poll based implementation
assumes that select.error has an errno attribute when handling errors. it does
not. select.error is not an EnvironmentError derived exception.
http://hg.python.org/cpython/file
Gregory P. Smith added the comment:
As this is only on the select.poll code path, a workaround for code that isn't
going to hit select.select file descriptor limits is to set their
telnetlib.Telnet instance _has_poll attribute to False before using it.
my_telnet = telnetlib.T
New submission from Gregory P. Smith:
1) Checkout a 3.4 tree. Mine was at revision d244e1770f1b.
2) ./configure
3) make -j14 profile-opt
4) ./python -m test.regrtest -v test_distutils
FAIL: test_sysconfig_module (distutils.tests.test_sysconfig.SysconfigTestCase
Gregory P. Smith added the comment:
Should _sysconfigdata.py contain these flags for reference, implying that it is
this test or distutils.sysconfig implementation which is really wrong?
--
___
Python tracker
<http://bugs.python.org/issue22
Changes by Gregory P. Smith :
--
title: make profile-opt fails to update _sysconfigdata.py during the rebuild ->
make profile-opt includes -fprofile* flags in _sysconfigdata CFLAGS
___
Python tracker
<http://bugs.python.org/issu
Gregory P. Smith added the comment:
attaching a proposed workaround in the unittest.
--
keywords: +patch
Added file:
http://bugs.python.org/file37231/issue22904-test-workaround-gps01.diff
___
Python tracker
<http://bugs.python.org/issue22
New submission from Gregory P. Smith:
When running a parallel make -j12 test, test_pydoc fails reasonably often with:
test test_pydoc failed -- Traceback (most recent call last):
File "/.../Lib/test/test_pydoc.py", line 556, in test_synopsis_sourceless
synopsis = pydo
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith ->
___
Python tracker
<http://bugs.python.org/issue22910>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
I suspect flakiness is due to parallel test execution. Is some other test
possibly executing at the same time removing __pycache__ directories or .pyc
files to recreate them (test_compileall?)? If the test were adjusted to point
to a .py file of its own
Gregory P. Smith added the comment:
fyi - tracking the new issue koobs reported in http://bugs.python.org/issue22910
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue20
New submission from Gregory P. Smith:
$ cat >test.py <
info = f.next()
File "/usr/lib/python2.7/tarfile.py", line 2319, in next
self.fileobj.seek(self.offset)
File "/usr/lib/python2.7/tarfile.py", line 555, in seek
raise StreamError("s
Gregory P. Smith added the comment:
removing it would also be fine, it's not like it gets used anymore. the fixes
were trivial. done.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http:
Gregory P. Smith added the comment:
thanks for the cleanup refactoring!
--
___
Python tracker
<http://bugs.python.org/issue23234>
___
___
Python-bugs-list mailin
Changes by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue3566>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I can apply this to subprocess32 but it is going to look much more like:
+#ifndef MS_WINDOWS /* WTF is anyone compiling on Windows? Shouldn't work! */
+# define HAVE_UNISTD_H 1
+#endif
+#ifdef HAVE_UNISTD_H
#include
+#endif
The real question is w
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue23223>
___
___
Python-bugs-list mailing list
Un
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith ->
___
Python tracker
<http://bugs.python.org/issue1060>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
This bug prevents zipfile's writestr() from writing large data (longer than
UINT_MAX) to a 64-bit zip file.
The zlib.crc32 function which, as written, cannot accept input with a size
larger than an unsigned int.
https://hg.python.org/cpython
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue23342>
___
___
Python-
Gregory P. Smith added the comment:
A 1) Opting not to capture by default is good. Let people explicitly request
that.
A 2) "check" seems like a reasonable parameter name for the "should i raise if
rc != 0" bool. I don't have any other good bikeshed name suggestio
Gregory P. Smith added the comment:
Ethan: check_output combines them when stdout=subprocess.STDOUT is passed (
https://docs.python.org/3.5/library/subprocess.html#subprocess.STDOUT).
Never pass stdout=PIPE or stderr= PIPE to call() or check*() methods as
that will lead to a deadlock when a pipe
Gregory P. Smith added the comment:
Likely a dupe of http://bugs.python.org/issue22904 which is why i set the
buildbot up. :)
I like your patch here better than my non-fixing poor hack in the other issue.
I hadn't noticed CFLAGS_NODIST b
Gregory P. Smith added the comment:
see also issue23390
--
superseder: -> make profile-opt: test_distutils failure
___
Python tracker
<http://bugs.python.org/issu
Changes by Gregory P. Smith :
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue22904>
___
___
Python-bugs-
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue23390>
___
___
Python-bugs-list mailing list
Un
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue23390>
___
___
Python-bugs-
Gregory P. Smith added the comment:
Also FWIW, I setup a buildbot earlier this year building in profile-opt mode.
--
___
Python tracker
<http://bugs.python.org/issue24
Gregory P. Smith added the comment:
The Makefile's default "make all" target is meant for developers and iterative
development.
make profile-opt is not.
If anything, this issue should document it somewhere if we even have docs on
how to make "release" builds of
New submission from Gregory P. Smith:
for bytes, \v (0x0b) is not considered a line break. for unicode, it is.
this traces back to the Objects/stringlib/ code where unicode defers to the
decision made by Objects/unicodeobject.c's ascii_linebreak table which contains
7 line breaks in
Gregory P. Smith added the comment:
hah, i should've searched the tracker first. looks like the other open issues
cover this.
--
resolution: -> duplicate
status: open -> closed
superseder: -> str.splitlines splitting on non-\r\n characters
versions: +Python 2.7, Pyth
Gregory P. Smith added the comment:
The obvious fix seems to be to not use splitlines but explicitly split on the
allowed characters for ASCII based protocols and formats that only want \r and
\n to be considered.
I don't think we can rightfully change the unicode splitlines beh
Gregory P. Smith added the comment:
If this isn't already mentioned in 2 to 3 porting notes it is worth
highlighting there. code which uses a str in python 2 and still uses a str in
python 3 is now splitting on many more characters.
That seems to be the source of bugs like issue
Gregory P. Smith added the comment:
i'm updating the title to be more accurate.
turning it on by default is likely not desirable as the makefile is primarily
used by developers who are iterating on changes.
but having it use a good workload (regrtest) and work with llvm and os x are
Gregory P. Smith added the comment:
My gut feeling is to say "don't do that" when it comes to passing subprocess
instances between processes (ie: pickling and unpickling them) and expecting
them to work as if nothing had changed... You already acknowledge that this is
a stran
Gregory P. Smith added the comment:
we'll need a test case .pyc where this happens.
--
___
Python tracker
<http://bugs.python.org/issue25083>
___
___
Pytho
Gregory P. Smith added the comment:
Inspecting the 2.7 code:
https://hg.python.org/cpython/file/2.7/Python/import.c#l761
following that down to
https://hg.python.org/cpython/file/2.7/Python/marshal.c#l1126
it looks like it does the right thing on EOF error (from either getc or from
fread
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue25106>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
attaching an updated patch.
fwiw, in my own quick tests i'm not seeing a performance difference on the
benchmark suite. but i am not trying to run it in such an isolated quiet
machine locked freq. environment.
it is still a good idea regardless. _
Gregory P. Smith added the comment:
Testing this on a host with a fixed frequency and mostx background tasks
disabled I cannot reproduce the speedups you list. I see no significant change
on most of them and a 6% slowdown on json_load and a 1-4% slowdown on regex_v8
(not sure if those are in
New submission from Gregory P. Smith:
https://docs.python.org/3/c-api/structures.html#c.PyMemberDef
T_STRING members are turned into str objects in Python. The documentation
needs updating to mention which codec the char * bytes are treated as.
Solving this issue involves code inspection and
Gregory P. Smith added the comment:
I applied the same _srcfile setting cleanup to 2.7 as we ran into this at work
with an embedded python stdlib. __file__ was set to something by the embedded
importer, but to something different than the path seen on the actual code
objects which appear to
Gregory P. Smith added the comment:
Definitely a bug. The path search should silently skip directories it can't
access.
On Tue, Oct 27, 2015, 7:05 AM R. David Murray
wrote:
>
> R. David Murray added the comment:
>
> So, two interesting questions: does this in fact match the
Gregory P. Smith added the comment:
Hisham, could you sign the Python contributor agreement?
https://www.python.org/psf/contrib/contrib-form/
thanks!
--
___
Python tracker
<http://bugs.python.org/issue23
Changes by Gregory P. Smith :
--
resolution: -> duplicate
status: open -> closed
superseder: -> subprocess.Popen.send_signal doesn't check whether the process
has terminated
___
Python tracker
<http://bugs.pyth
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6973>
___
___
Python-
Gregory P. Smith added the comment:
I chose to go with the "there should not be an error" approach similar to how
Python deals with multiple file closes. Both are technically programming
errors but the point of Python is make life easier.
Reasoning? I don't want someone to
Gregory P. Smith added the comment:
I'm unassigning as i won't be figuring out how to hackishly fix this again.
The best solution is a complete rewrite of zipimport.
this remains a known issue: if you use zipimport, do not allow the zip file to
change out from underneath your runni
Gregory P. Smith added the comment:
heh, you're right. it's a trivial obvious fix for the mistake in the existing
implementation. writing a test and committing.
the other option would be to get rid of the sanity check entirely or change it
not to use the odd "require a so
Gregory P. Smith added the comment:
I didn't bother adding the fix to 3.4, it isn't high value.
--
resolution: -> fixed
status: open -> closed
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.py
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue19217>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Reopen this if you find a reproducible way for this patch to prove useful.
--
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue22012>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
components: +Library (Lib)
___
Python tracker
<http://bugs.python.org/issue22012>
___
___
Python-bugs-list mailing list
Unsub
Changes by Gregory P. Smith :
--
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue22012>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I wouldn't _assume_ that there was a good design reason for that in
multiprocessing... it already mixed threads and fork() without realizing that
you cannot safely do that.
--
nosy: +gregory.p.smith
Gregory P. Smith added the comment:
_args_from_interpreter_flags really deserves its own unittest using a stubbed
out sys.flags. if someone wants to go ahead with the test provided in the
existing patch here or write one of those, feel free.
As is, i've committed a patch logically equiv
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20954>
___
___
Python-bugs-
Gregory P. Smith added the comment:
ironically this change would've been a lot simpler had it simply deleted
hash_randomization from the set of sys.flags considered by
_args_from_interpreter_flags().
-R is always enabled in Python 3.4. it cannot be disabled. it isn't even
docum
Gregory P. Smith added the comment:
This change breaks existing code that is relying on the behavior of the enum
API as shipped in 3.4 and 3.5. Please do NOT do this.
Worse, you've landed this change in a "stable" release of the enum34 "backport"
module (1.1.1) des
Gregory P. Smith added the comment:
lets collect some examples of where it causes problems (someone ran into the
problem at work which is why i hunted down this bugs.python.org issue) before
deciding.
If it stays in, it needs a mention in both Misc/NEWS and What's New as it will
require
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue25960>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
This appears due to Popen._waitpid_lock. It is not being released when the
signal fires and the while loop containing the with self._waitpid_lock repeats.
This also reproduces when using subprocess32
3201 - 3300 of 3457 matches
Mail list logo
