Gregory P. Smith added the comment:
New patch uploaded. Based on mfoord's 200903301411 version. Adds
documentation. Cleans up a few things and fixes names on a few things.
This patch has been put up for review in:
http://codereview.appspot.com/32080
--
Added file:
Gregory P. Smith added the comment:
fixed the unintentional extra edits in the docs in gps04.
--
Added file: http://bugs.python.org/file13510/unittest-new-asserts-gps04.diff.txt
___
Python tracker
<http://bugs.python.org/issue2
Changes by Gregory P. Smith :
Removed file:
http://bugs.python.org/file13480/unittest-new-asserts-gps02.diff.txt
___
Python tracker
<http://bugs.python.org/issue2
Changes by Gregory P. Smith :
Removed file: http://bugs.python.org/file13484/unittest-new-asserts.diff
___
Python tracker
<http://bugs.python.org/issue2578>
___
___
Pytho
Changes by Gregory P. Smith :
Removed file:
http://bugs.python.org/file13509/unittest-new-asserts-gps03.diff.txt
___
Python tracker
<http://bugs.python.org/issue2
Gregory P. Smith added the comment:
Reviewers: fuzzyman, GvR,
http://codereview.appspot.com/32080/diff/13/1006
File Doc/library/unittest.rst (right):
http://codereview.appspot.com/32080/diff/13/1006#newcode611
Line 611: assertTrue(expr[, msg])
On 2009/03/31 15:01:06, GvR wrote:
> M
Gregory P. Smith added the comment:
Comments applied. committed to trunk in r70837. Needs porting to
python 3.1.
Next changes TODO:
* rename the method def's and add deprecation warnings to fail* variants.
In room discussion at pycon 2009 sprints consensus on Equal vs Equals
names is
Gregory P. Smith added the comment:
def's of the methods changed to be the official assert* names in trunk
r70864. unittests added to confirm that all known method names continue
to work.
Guido - If we fix 2to3 to fixup unittests that use the fail* method
names to use the assert* names
Gregory P. Smith added the comment:
trunk r70878 has the code issue an actual PendingDeprecationWarning for
the fail* methods and documents them as deprecated. If anyone has a
better idea of a better way to state those deprecations in the docs,
feel free to jump in here.
I was unaware of the
Gregory P. Smith added the comment:
sounds good. This is done for 2.7.
I will make sure it gets merged into 3.1 properly before closing.
--
versions: -Python 2.7
___
Python tracker
<http://bugs.python.org/issue2
Gregory P. Smith added the comment:
good catch. the patch looks correct to me.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue5
Gregory P. Smith added the comment:
I'm used to doing this using a finally clause in the setUp() method (if
I do it at all, I'm not used to setUp failing).
I guess this would be a convenience to avoid the need for this pattern?
I'm not sure we really need a list of cleanup
Gregory P. Smith added the comment:
assertMultiLineEqual might be reasonable as a default assertEqual for
unicode. I wouldn't want to do it for bytes (py 2.x string).
--
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
fyi - Your docs in unittest-assertis.diff mention the wrong method name
(assertIsNotNone instead of assertIsNot). fix that and commit.
The unittest-sameelements.diff patch looks good.
--
___
Python tracker
Gregory P. Smith added the comment:
J. David Ibáñez - do you still happen to have that Document.odt laying
around?
--
___
Python tracker
<http://bugs.python.org/issue1
New submission from Gregory P. Smith :
Running test_httpservers on a 64-bit build of Python 2.7 trunk on OS X
10.5: (I added a print "nobody=", nobody)
test_authorization (__main__.CGIHTTPServerTestCase) ... nobody= 4294967294
Exception happe
Gregory P. Smith added the comment:
Fixed in r71299 trunk. Needs backporting to release26-maint and
release30-maint. (I'm waiting for buildbot results before I do that)
--
versions: -Python 2.7
___
Python tracker
<http://bugs.py
Gregory P. Smith added the comment:
fyi - Your patch does not work on windows as it uses os.path for uri
manipulation. that means it behaves differently with regards to / and \
based on platform.
I'm making a new one. I've written a unittest. should be
Changes by Gregory P. Smith :
Removed file: http://bugs.python.org/file9628/CGIHTTPServer_is_cgi_fix.diff
___
Python tracker
<http://bugs.python.org/issue2254>
___
___
Gregory P. Smith added the comment:
merged into release26-maint. release30-maint still needed.
--
versions: -Python 2.6
___
Python tracker
<http://bugs.python.org/issue5
Gregory P. Smith added the comment:
Fixed in trunk r71303.
This potentially changes the behavior of CGIHTTPServer (for the better)
so this is probably not appropriate to backport to a release branch
unless someone really considers the security of this to be severe.
If backported, the new
Gregory P. Smith added the comment:
Fixed via issue5705 which I filed not having seen this one.
--
assignee: -> gregory.p.smith
dependencies: +os.getpwent returns unsigned 32bit value, os.setuid refuses it
keywords: +64bit
nosy: +gregory.p.smith
resolution: -> fixed
status
New submission from Gregory P. Smith :
CGIHTTPServer._url_collapse_path_split should probably live in a more
general library and become a documented API. Perhaps in urlparse?
--
keywords: easy
messages: 85679
nosy: gregory.p.smith
priority: normal
severity: normal
status: open
title
Gregory P. Smith added the comment:
What is the status of these methods?
On the windows side, it appears that these are only available in Vista
and later so we'll need some conditional compliation magic there:
http://msdn.microsoft.com/en-us/library/bb408409(VS.85).aspx
fyi
Gregory P. Smith added the comment:
urlparse.urljoin and urlparse.urlsplit do not do what is required for
this function. urljoin does not collapse paths. urlsplit has nothing
to do with paths.
I agree r.david.murray that it is odd that it does two functions at once
(the collapse and the
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue2636>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
fyi - I can't compile issue2636-patch-1.diff when applied to trunk (2.7)
using gcc 4.0.3. many errors.
--
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
agreed, its not needed. closing. if someone wants it they're welcome
to supply a patch with tests.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue5872>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Gregory P. Smith :
When writing documentation for a module that is already well documented
in its docstrings, I really wish pydoc could output .rst directly.
It'd mean much less manual editing.
--
components: Demos and Tools
messages: 86866
nosy: gregory.p.
Gregory P. Smith added the comment:
oh. sphinx can already do this? nevermind then.
*goes off to look closer at sphinx*
--
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
Committed to trunk (2.7) in r72173. I'll merge it into py3k later this
afternoon.
--
priority: normal -> release blocker
versions: -Python 2.7
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
I merged ipaddr into py3k.
I can't lookup the revision number (r72186?) at the moment since
svn.python.org is having problems.
anyways, thanks pmoody & other ipaddr developers!
Now that the library is -in- (before the 3.1 beta cutoff :), non-API
Gregory P. Smith added the comment:
r72210 pep8-ified the test names.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue3959>
___
_
Gregory P. Smith added the comment:
thanks! committed in r72237 & py3k r72238.
--
resolution: -> accepted
status: open -> closed
___
Python tracker
<http://bugs.python.
Gregory P. Smith added the comment:
both the behavior change and PySys_SetArgvEx() with an additional
boolean parameter sounds good to me.
Some people may disagree about changing the default behavior. So long
as its documented in the whatsnew I personally think it is fine. But
would doing
Gregory P. Smith added the comment:
release30-maint r72245 (its already been merged into py3k).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
yes the reporter is correct.
the suggested chdir happens in the subprocess.
however, that only works on posix systems:
windows currently uses popen2/3. (see issue1535504 for another issue
with that). switching to subprocess and passing in cwd would fix
Gregory P. Smith added the comment:
fyi - non-posix / non-windows platforms could include alternate python
VMs that don't support fork, popen2 or subprocess.
--
assignee: gregory.p.smith ->
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
not reproducable in head as stated.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
Committed with a couple refactorings in trunk r72267. I also added a
test (basically checking for corruption that would occur if the locks
weren't working).
(I'll sort out any py3k vs trunk differences to make future change
mer
Gregory P. Smith added the comment:
gedit does it here:
http://git.gnome.org/cgit/gedit/tree/plugin-loaders/python/gedit-plugin-
loader-python.c#n542
I've emailed the file's author (Jesse) out of the blue to see if he knows
why PySys_SetArgv()
Gregory P. Smith added the comment:
re: gedit
"""I'm by no means an expert (I did not design the original python module
extension), we simply copied from vim at the beginning. That said, it
seems there are issues if you embed the python interpreter and do not
explic
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue5804>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Overall, this looks good. Some mostly minor comments in this review.
http://codereview.appspot.com/63060/diff/1/2
File Doc/library/zlib.rst (right):
http://codereview.appspot.com/63060/diff/1/2#newcode136
Line 136: When specified, it will cause the
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6001>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
"""I assume these changes were made to silence warnings from
-Wstrict-overflow, but I don't think that should be a goal:
I'd suggest only making changes where there's a genuine
possibility of overflow (even if it's
Gregory P. Smith added the comment:
reassigning to the volunteer to get this in :)
--
assignee: facundobatista -> orsenthil
___
Python tracker
<http://bugs.python.org/issue1
Gregory P. Smith added the comment:
to confirm, this is only a problem in 2.7 trunk right?
if so, i won't rush a fix.
but yes fallback code for legacy types or adding buffer api support to
array would work.
--
assignee: -> gregory
Gregory P. Smith added the comment:
I added a versionadded: 2.7 note to the docs in r72890.
This change is not suitable for back porting as it arguably adds a new
feature.
--
___
Python tracker
<http://bugs.python.org/issue1424
Gregory P. Smith added the comment:
On Mon, Jun 1, 2009 at 9:39 AM, Clay McClure wrote:
>
> Since Python 2.7 and 3.1 have not yet shipped, I hope it's not too late
> to continue this discussion. I have no vested interest in either ipaddr or
> netaddr, but I am interested
Gregory P. Smith added the comment:
Thanks!
Fixed in trunk r73135 and py3k r73136.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
> Consider applications that need to validate addresses (or networks,
> but not both) supplied as user input:
>
> address = ipaddr.IP(input)
>
> if isinstance(address, ipaddr.IPv4):
> if address.prefixlen != 32:
> raise
Gregory P. Smith added the comment:
This issue is closed.
Please take discussion up on a mailing list.
--
___
Python tracker
<http://bugs.python.org/issue3
New submission from Gregory P. Smith :
Do not use this bug for discussion of the topic. Use the python-dev
mailing list.
This bug is here to track its removal (or not) of the ipaddr library
pending the outcome of the mailing list discussion. Resolving this is a
release blocker either way
Gregory P. Smith added the comment:
fix for J. David's issue submitted to trunk r73565 and py3k r73566 just in
time for the 3.1 release.
release30-maint r73567
release26-maint r73568
--
status: open -> closed
versions: +Python 3.0, Py
Changes by Gregory P. Smith :
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/issue1202>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6380>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Your patch looks pretty good. I cleaned up a few things in it and added
a unittest (the existing test suite is run with both select and poll).
Committed to trunk in r73825.
I am leaving the issue open until this is ported and merged into py3k as
well as
Gregory P. Smith added the comment:
Merged to py3k in r73833.
--
___
Python tracker
<http://bugs.python.org/issue3392>
___
___
Python-bugs-list mailing list
Unsub
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith -> pitrou
___
Python tracker
<http://bugs.python.org/issue2281>
___
___
Python-bugs-list mai
Gregory P. Smith added the comment:
Thanks for all your work Nir! I personally think the BFS approach is the best
we've seen yet for this problem!
Having read the thread you linked to in full (ignoring the tagents
bikeshedding and mudslinging that went on there), it sounds like the ge
Gregory P. Smith added the comment:
I'm pretty sure Python setup.py does not build the non-openssl md5, sha1,
sha256 and sha512 extension modules at all when openssl is present. So falling
back on them is not likely to work unless anyone who wants this crazy force
fips mode thing t
Changes by Gregory P. Smith :
--
nosy: -gps
___
Python tracker
<http://bugs.python.org/issue9146>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
That sounds fine to me and I do like the usedforsecurity annotation on the API.
I'll gladly review any patches.
--
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
Accepting that the timeout is not perfect in the face of signals as a caveat is
fine (document the possibility) and can be improved later.
--
___
Python tracker
<http://bugs.python.org/issue8
Changes by P. Henrique Silva :
--
nosy: +phsilva
___
Python tracker
<http://bugs.python.org/issue7946>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
jjlee's issue3704.patch has been committed to py3k (3.2) in r82985. It could
still use backporting to 2.6, 2.7 and 3.1.
--
resolution: -> accepted
versions: -Python 3.2
___
Python tracke
Gregory P. Smith added the comment:
release27-maint r83145
release31-maint r83146
release26-maint r83147
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Changes by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue9216>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
+larry for (S2) regarding argument clinic's treatment of bool.
--
nosy: +gregory.p.smith, larry
___
Python tracker
<http://bugs.python.org/is
Gregory P. Smith added the comment:
attaching a proposed fix for (S5). os.chmod should have the same EINTR retry
treatment as everything else. That it does not appears to have been an
oversight.
--
keywords: +patch
Added file: http://bugs.python.org/file45781/os-chmod-EINTR
Gregory P. Smith added the comment:
So long as this code block that imports os is avoided, I believe that this can
be properly frozen:
+if not isinstance(path, str):
+import os
+path = os.fsdecode(path)
But it should be easy to avoid that code path when the
Changes by Gregory P. Smith :
--
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/issue29335>
___
___
Python-bugs-list mailin
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue29335>
___
___
Python-bugs-list mailing list
Un
Changes by Gregory P. Smith :
--
title: Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD ->
subprocess module does not check WIFSTOPPED on SIGCHLD
___
Python tracker
<http://bugs.python.org/issu
Gregory P. Smith added the comment:
The attached patch should fix it.
I want to incorporate a bug.py like regression test into test_subprocess.py.
--
keywords: +patch
stage: -> test needed
Added file: http://bugs.python.org/file46385/issue29335-gps01.d
Gregory P. Smith added the comment:
test added.
--
stage: test needed -> patch review
type: -> behavior
Added file: http://bugs.python.org/file46386/issue29335-gps02.diff
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
thanks Ned, I was awaiting interesting buildbot results. :)
fixed in 2.7 and 3.5 onwards. thanks for the report Zach.
not closing until I also apply the fix to the subprocess32 backport.
--
resolution: -> fixed
stage: patch review -> commit
New submission from Gregory P. Smith:
If you do a make -j12 test or make install before having run a separate 'make
all' the build _can_ fail trying to build pgen. (it seems to be parallel make
related, it won't always fail)
Even if you have run a separate 'make all'
Gregory P. Smith added the comment:
great, the issue you filed covers my second paragraph comment which really
should be its own issue. :)
--
___
Python tracker
<http://bugs.python.org/issue29
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue29243>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue29370>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue29375>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue24209>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue25667>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue27500>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue23448>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
keywords: +needs review
nosy: +gregory.p.smith
stage: -> patch review
versions: +Python 3.7 -Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Changes by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue11549>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Gregory P. Smith:
For reference, read https://github.com/google/oss-fuzz.
We should investigate creating fuzz targets for the Python re module (_sre.c)
at a minimum. There are probably other good targets as well such as _json.c
and _csv.c.
pickle and marshal are not
Gregory P. Smith added the comment:
there may be something in sysconfig.get_config_vars() we could use or, better,
we could add something specific to indicate both pgo and lto builds.
--
___
Python tracker
<http://bugs.python.org/issue26
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue29585>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue29592>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
FYI - hardcoding these addresses is now causing me problems as I try to get our
test suite passing on IPv6 only hosts. "localhost" is correct.
IMNSHO if for some reason a system cannot resolve "localhost" into a correct
address, it s
Gregory P. Smith added the comment:
https://bugs.python.org/issue29639 opened to track undoing this when
appropriate.
--
___
Python tracker
<http://bugs.python.org/issue18
New submission from Gregory P. Smith:
I am working on fixing our test suite to run on IPv6 only hosts (which are
becoming a reality). Many failures today occur because of hard coded 127.0.0.1
values.
This is wrong. We should refer to "localhost"
The "solution" to htt
Gregory P. Smith added the comment:
great! that makes me feel much less bad about fixing this in the way i desire.
:)
--
___
Python tracker
<http://bugs.python.org/issue29
Gregory P. Smith added the comment:
TL;DR - Just one more example of why nobody should *ever* use pickle under any
circumstances. It is useless for data that is not transient for consumption by
the same exact versions of all software that created it.
Patches against 2.7 are not useful here
New submission from Gregory P. Smith:
The readline module causes memory corruption (sometimes a crash) when the
sys.stdin file descriptor is out of bounds for its FD_SET() call within
readline.c's readline_until_enter_or_signal() function.
https://github.com/python/cpython/blob/master/Mo
3001 - 3100 of 3457 matches
Mail list logo
