Gregory P. Smith added the comment:
trunk r74463 now forces the HTTPResponse with buffering=True to close
afterwards using a HTTPResponse._must_close flag similar to what was
suggested in buffered_socket.diff in this issue.
--
___
Python tracker
Gregory P. Smith added the comment:
I am also unable to reproduce the reported problem using the
pastebin.ca/973578 code. The time to download 400mb from localhost
remains the same regardless of buffering=False (default) or True.
The problem still exists but it is better described in
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6665>
___
___
Python-
Gregory P. Smith added the comment:
+1 on the PyXXX_ClearFreeList patch and calling them from gc.collect()
as is done with the others.
I agree with Guido, don't add a tp_free_list slot as the common case
would be NULL.
Regarding gc clearing freelists: I agree with Antoine and M
Gregory P. Smith added the comment:
haha wow I just read the fnmatch code... trunk r2734 | guido | 1992-01-12
added fnmatch._cache for it to cache compiled regular expressions. That
has -long- since become unnecessary as the re module does that itself. ;)
I'll clean this up while f
Gregory P. Smith added the comment:
aww, i guess the _cache does cache the result of the glob -> regular
expression translation. it needs to stay for that.
--
___
Python tracker
<http://bugs.python.org/iss
Gregory P. Smith added the comment:
changing the '$' to \Z(?ms)' fixes the problem.
--
___
Python tracker
<http://bugs.python.org/issue6665>
___
___
Gregory P. Smith added the comment:
fixed in trunk r74475, py3k r74476
--
___
Python tracker
<http://bugs.python.org/issue6665>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
I'll backport this to 2.6 and 3.1 later (its too late for 3.1.1).
--
versions: -Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
That code was indeed a mess. I've incorporated most suggestions from
your cleaned up version (and fixed a bug in it) in trunk r74479.
Have you ever seen __get_builtin_constructor fail in practice? I can
imagine that packing up a stripped down p
Gregory P. Smith added the comment:
Yeah I'd take this to the list. Perhaps this is destined to be a public
API.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
btw, when using async io (poll, select, etc) I -think- your socket will
see a read event when the server closes the connection (sends you a FIN
or even a RST) at which point your sock.recv() when you've been told
data was ready will return 0 bytes indic
New submission from Gregory P. Smith :
The python logging module uses a lock to surround many operations, in
particular. This causes deadlocks in programs that use logging, fork
and threading simultaneously.
1) spawn one or more threads in your program
2) have at least one of those threads
Gregory P. Smith added the comment:
hmm apparently the bug i was fixing in r74463 is not actually a bug, the
httplib module does not support streaming requests in any way so even with
a new socket buffer being constructed per request, the buffer is
guaranteed to be empty at the end of
Gregory P. Smith added the comment:
reverted in r74522
--
___
Python tracker
<http://bugs.python.org/issue6724>
___
___
Python-bugs-list mailing list
Unsubscribe:
John P. Speno added the comment:
Hi. We encountered this issue on a Solaris 10 while building python 2.6.2.
There's a problem with reptrov's patch from 2009-01-04. The LDFLAGS in the
Makefile.pre.in patch need to be quoted also. Like so:
LDFLAGS='$(LDFLAGS)'
This allow
John P. Speno added the comment:
Furthermore, there's another bug in setup.py When extensions are built
and CPPFLAGS (or other arguments) has multiple arguments, the order of
the arguments are reversed. This is the wrong behavior. The specified
directories should be used in the given
Gregory P. Smith added the comment:
The decryption provided by the zipfile module is for the worthless
32-bit crc based "encryption" of zipfiles. I think promoting the use of
that is a bad idea.
zipfile can be used by people to get their data out of such files. We
should not enco
Gregory P. Smith added the comment:
I've started a project to patch this and similar messes up for Python
2.4 and later here:
http://code.google.com/p/python-atfork/
I'd like to take ideas or implementations from that when possible for
future use in the python standa
Gregory P. Smith added the comment:
The people who do not know how to get over that wall would be equally
stumped if presented with tokenized .pyc or .pyo files. No fake
encryption needed.
--
___
Python tracker
<http://bugs.python.org/issue6
Gregory P. Smith added the comment:
Already reverted in
r74522 | gregory.p.smith | 2009-08-18 22:33:48 -0700 (Tue, 18 Aug 2009)
for that reason.
--
___
Python tracker
<http://bugs.python.org/issue4
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6508>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
we should never pretend an old module doesn't exist. leave optparse as
optparse. argparse can come in under its own name.
we can mark getopt and optparse as deprecated at some point and remove
them in 10 years :)
+1 on inclusion btw. It looks like
Changes by Gregory P. Smith :
--
priority: -> low
___
Python tracker
<http://bugs.python.org/issue6800>
___
___
Python-bugs-list mailing list
Unsubscri
Gregory P. Smith added the comment:
There is no OS level API to kill threads. Python does not kill threads.
When you exec, your entire process should be replaced by the OS, threads
shouldn't matter they should simply disappear just as the rest of your
process state does.
This is
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue1590864>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +collinwinter, gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6713>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
On Mon, Sep 14, 2009 at 11:15 AM, Armin Ronacher wrote:
>
> Armin Ronacher added the comment:
>
>> @Armin: Doesn't that argument apply to *any* library proposed for
>> inclusion in the standard library? By which logic we should ne
Gregory P. Smith added the comment:
For reference, this is related to http://bugs.python.org/issue6721 but
deals with the C API side of things for an atfork mechanism to be used by
extension modules.
--
nosy: +gregory.p.smith
___
Python tracker
Gregory P. Smith added the comment:
issue 6923 has been opened to provide a C API for an atfork mechanism for
use by extension modules.
--
components: +Library (Lib)
___
Python tracker
<http://bugs.python.org/issue6
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
priority: -> normal
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
Documentation note added (copied from tarfile) in trunk r75149,
release26-maint r75150 (hopefully in time for 2.6.3 but thats up to
Barry).
--
___
Python tracker
<http://bugs.python.org/issue6
Gregory P. Smith added the comment:
Adding a warning to the documentation is not wrong, it is the only thing
that is possible for the 2.6.3 release. Its too late in the current
release process to change code.
--
___
Python tracker
<h
Gregory P. Smith added the comment:
yes this will be fixed in 2.7/3.2.
as for creative uses where someone might want the out of supplied path
overwriting behavior? those people are insane and should be made to jump
through extra hoops to get it
Changes by Gregory P. Smith :
--
versions: +Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue6972>
___
___
Python-bugs-list mailin
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
priority: -> high
___
Python tracker
<http://bugs.python.org/issue7079>
___
___
Python-bugs-
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue812369>
___
___
Python-
Gregory P. Smith added the comment:
> Antoine Pitrou added the comment:
>
> Rather than having a kind of global module registry, locks could keep
> track of what was the last PID, and reinitialize themselves if it changed.
> This is assuming getpid() is fast :-)
Locks can&#x
Gregory P. Smith added the comment:
no need for that. the problem is that they're held by a thread that
does not exist in the newly forked child process so they will never be
released in the new process.
example: if you fork while another thread is in the middle of logging
something and
Gregory P. Smith added the comment:
Seems simple enough, I don't see why not.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
This only appears to happen on Solaris. What version of Solaris are you
using? (i doubt that matters, i expect it happens on all versions)
I haven't look closely enough at the code yet, but reinitializing the
import lock in the child process should
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith -gps
___
Python tracker
<http://bugs.python.org/issue7208>
___
___
Python-
Gregory P. Smith added the comment:
Peter - can you apply the patch from svn r76000 and test that it works
properly on Solaris?
--
___
Python tracker
<http://bugs.python.org/issue7
Gregory P. Smith added the comment:
It might mean that other threads with access to the same file handle
could interfere and intercept part of the password entry if they wanted
to but thats not too concerning.
py3k/Modules/_io/bufferedio.c which is presumably used when input is
sys.stdin
Gregory P. Smith added the comment:
Documenting the parameters needed to avoid all AC_TRY_RUNs is a good first
step for any that are not obvious how to convert from AC_TRY_RUN into
something else.
--
___
Python tracker
<http://bugs.python.
Gregory P. Smith added the comment:
Removing a toxic person from the cc list. Mike, please go harm some other
all volunteer project.
--
nosy: -vapier
___
Python tracker
<http://bugs.python.org/issue1006
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
components: +Library (Lib)
nosy: +gregory.p.smith
priority: -> normal
title: getpass crashes when several returns are in stdin before getpass was
called -> getpass raises IOError when several returns are in std
Gregory P. Smith added the comment:
am unable to duplicate this behavior on Linux or OS X using python 2.6.
What platform did you see the problem on?
that said, can you apply the following patch to your getpass.py and see if
it helps at all?
http://svn.python.org/view/python/trunk/Lib
Gregory P. Smith added the comment:
ah i misread your example. the following works to reproduce it:
Python 2.6.2 (release26-maint, Apr 19 2009, 01:56:41)
[GCC 4.3.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
&
Gregory P. Smith added the comment:
and the r76000 patch does not fix it. investigating.
--
___
Python tracker
<http://bugs.python.org/issue7246>
___
___
Pytho
Gregory P. Smith added the comment:
change that. it looks like r76000 in trunk already fixes this. i was
using an old build when i tried earlier.
merged into release26-maint in r76015.
--
resolution: -> fixed
status: open -> closed
___
Gregory P. Smith added the comment:
merged into release26-maint in r76015. this patch also fixed issue7246.
py3k r76017
release31-maint r76019
--
resolution: -> fixed
status: open -> closed
versions: -Python 2.6, Python 2.7
___
Python t
Gregory P. Smith added the comment:
Fixed in release26-maint r76022. This will appear in Python 2.6.5.
I'm leaving release30-maint alone as it is already in 3.1.
sorry for not making it into 2.6.3/2.6.4 despite the code being ready. I
should've set this as a relea
Gregory P. Smith added the comment:
release26-maint r76023 to appear in Python 2.6.5.
release31-maint r76024 to appear in Python 3.1.2.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
Thanks for the patch!
applied in trunk r76028/r76029. py3k r76030/r76032
There are more of these, other bugs are open that should result in us
cleaning them up. see issue1006238 for example.
--
resolution: -> fixed
status: open ->
Gregory P. Smith added the comment:
these two have been merged and applied to trunk.
"""
i fixed the chflags specific check a long time ago (as i imagine others
have as well):
http://sources.gentoo.org/dev-lang/python/files/python-2.6-chflags-
cross.patch
same goes for the
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6873>
___
___
Python-
Changes by Gregory P. Smith :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue6873>
___
___
Python-bugs-list mailing list
Unsubscri
Gregory P. Smith added the comment:
How about defining this in threading.py:
def _enumerate():
"""Internal use only: enumerate() without the lock."""
return _active.values() + _limbo.values()
And calling it from _threading_local instead of accessi
Gregory P. Smith added the comment:
Reviewers: ,
http://codereview.appspot.com/150055/diff/1/4
File Modules/_threadmodule.c (right):
http://codereview.appspot.com/150055/diff/1/4#newcode221
Modules/_threadmodule.c:221: return PyBool_FromLong((long) r);
This explicit (long) cast is unnecessary
Gregory P. Smith added the comment:
Can you make the C implementation's repr() show something similar to the
Python implementation?
--
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
Attaching an updated patch that includes unittests.
I also changed the set functions to take input as long's instead of int's
as that is more likely to fit within a uid_t and forced the return values
on the get's to fit within a long and use
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
priority: -> normal
___
Python tracker
<http://bugs.python.org/
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue7406>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
indeed, those were missed. fixed in trunk r77007 and release26-maint
r77008.
--
___
Python tracker
<http://bugs.python.org/issue1747
Gregory P. Smith added the comment:
I applied the same fix that was applied to chown in trunk r77007 for
lchown and fchown. Could you test it on a platform where it previously
failed?
The existing code might still have issues if there are platforms where
uid_t and gid_t are unsigned but
Gregory P. Smith added the comment:
lemburg - see which issue #?
Anyways perhaps the right thing to do instead of trunk r65961 would have
been to change the s# to an s*.
Undoing it will be more painful now as several changes have gone in since
that require undoing and possibly redoing
Gregory P. Smith added the comment:
rpetrov - I couldn't really understand your message so I'm not sure if I'm
answering the right things: yes both the openssl and non-openssl modules
need to behave identically. the reason openssl is used when possible is
that its optimized
Gregory P. Smith added the comment:
yes its a real need and yes we should support this in the standard
library. no i have not had time to look at it since my comment a 14
months ago.
Thanks for the updated patch Eldon!
--
___
Python tracker
Gregory P. Smith added the comment:
trunk r77252 switches python 2.7 to use 's*' for argument parsing. unicodes
can be hashed (encoded to the system default encoding by s*) again.
This change has been blocked from being merged into py3k unless someone decides
we actually want
Gregory P. Smith added the comment:
In order to get a -3 PyErr_WarnPy3k warning for unicode being passed to hashlib
objects (a nice idea) I suggest creating an additonal 's*' like thing ('s3'
perhaps?) in Python/getargs.c for that purpose rather than modifying all of the
Gregory P. Smith added the comment:
I believe everything in here has been addressed. Please open new issues with
details for anything that doesn't quite right.
--
resolution: -> fixed
status: open -> closed
___
Python tra
Gregory P. Smith added the comment:
trunk r77263 and r77264 add this feature, including documentation and tests.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
I took the easy route and remove the test of the hostname all together. The
fact that the source port was used is sufficient indication that the bind call
was made.
--
___
Python tracker
<h
New submission from Alf P. Steinbach :
CPython 3.1.1 in Windows XP.
Traceback (most recent call last):
File "C:\Documents and Settings\Alf\sound\error.py", line 6, in
writer.setframerate( framerate )
NameError: name 'framerate' is not defined
Exception wave.Error:
Changes by Alf P. Steinbach :
Removed file: http://bugs.python.org/file15834/error.py
___
Python tracker
<http://bugs.python.org/issue7681>
___
___
Python-bugs-list mailin
Alf P. Steinbach added the comment:
Sorry, here's correct error message:
Traceback (most recent call last):
File "C:\Documents and Settings\Alf\sound\error.py", line 8, in
writer.writeframes( b"\0"*2*4 )
File "C:\Program Files\cpython\python31\lib\wave
Alf P. Steinbach added the comment:
No, sorry, the bugs in [wave.py] have nothing to do with a name IN A COMMENT in
the trivial code to exercise the bugs.
To reproduce the crash, just run the supplied code with Python 3.1.1 in Windows
XP.
The cause of the crash is, as I pointed out, use of
Gregory P. Smith added the comment:
You can't use a connect() call for the purpose of waiting for your
network to be up. This has nothing to do with Python. This is how all
network APIs work regardless of OS and language.
The "timeout" is due to the network stack being una
Gregory P. Smith added the comment:
> I would suggest to use 2^30 base only if sizeof(long)>=8 (64 bits
CPU).
Thats not the correct test. Test for an actual 64-bit build target.
sizeof(long) and sizeof(long long) are not usefully related to that in
any sort of cross platform manne
Gregory P. Smith added the comment:
Yes it is annoying to have to deal with the different OS specific error
numbers when handling socket.error, OSError, IOError or EnvironmentError
subclasses in general but that is life. Python does not attempt to
figure out what all possible behaviors and
Gregory P. Smith added the comment:
On 32-bit x86 (1.4Ghz Efficeon) using gcc 4.3.2-1ubuntu12 I see the
following perf with pidigits_noprint 2000:
py3k:
baseline longdigit14longdigit13+optimizations
3709 ms3664ms 4545ms
Those were from the best of five runs after a warmup
Gregory P. Smith added the comment:
hmm yes, ignore my 13+optimize result. apparently that used 15bit
digits despite --enable-big-digits on configure. attempting to fix that
now and rerun.
___
Python tracker
<http://bugs.python.org/issue4
Gregory P. Smith added the comment:
new results after fixing my longdigit13 build to use 30 bits instead of
15 (the configure script in longdigit13+optimizations didn't work right,
i had to manually add the #define to pyconfig.h)
py3k:
baseline longdigit14longdigit13+optimizations
Gregory P. Smith added the comment:
attaching an updated pidigits benchmark script that does a warmup run
before reporting the best result of 5.
Added file: http://bugs.python.org/file13132/pidigits_bestof.py
___
Python tracker
<http://bugs.python.
Gregory P. Smith added the comment:
Here are the results from 32-bit x86 on core2 duo gcc 4.0.1 using
pydigits_bestof.py 4000:
30-bit digits (14): 15719 ms
30-bit digits + optimizations (13+ops): 12490 ms
unpatched py3k: 13289 ms
(again, i had
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue936813>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
+1 to setting it up so that unit tests are always run against both and
keeping both.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue4
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue1518>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I'll take care of this. My goal is to do it before PyCon.
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
Could the PyObject_ClearWeakRefs(self); call in the middle of the lines
del_changes_class.patch adds also be used to cause python code to set
__del__ or __dict__ causing the wrong destructor or wrong dict to be
DECREFed?
(I'm trying to wrap my head a
Gregory P. Smith added the comment:
heh yuck that code was ancient. thanks for the update, i'll submit it.
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.or
Changes by Gregory P. Smith :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue5379>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue2281>
___
___
Python-
Gregory P. Smith added the comment:
Attaching a patch that adds Google's unittest.TestCase assertFooEqual()
extensions and automatically uses rich comparisons in assertEqual() with
nicely formatted failure messages for list, tuple, dict, set, frozenset.
The following are added by this
Gregory P. Smith added the comment:
Some statistics from our large code base as to which of the assert
methods get used relative to the others:
These percentages are relative to the count of assertEqual(s) uses being
100% and cover python code written by a crazy large number of engineers
Gregory P. Smith added the comment:
Oh for reference, i left these out but they may interest people for
completeness sake.
assert_ 15%
assertTrue 9%
assertFalse 5%
We don't currently have the auto type checking in assertEqual in our
internal codebase, direct use of the type spe
Gregory P. Smith added the comment:
benjamin.peterson mentioned this in his whats new in 3.1 lightning talk
at pycon today and completely by chance, I had made showing a couple
examples of ipaddr the topic of my own lightning talk ~30 minutes later. :)
Anyways I hope to commit this for 3.1 and
Gregory P. Smith added the comment:
Updated patch after sprinting on this with Michael Foord.
TODO:
* update assertRaisesWithRegexpMatch to be a context manager.
* documentation.
i'm working on the docs now.
--
Added file: http://bugs.python.org/file13480/unittest-new-asserts-
Changes by Gregory P. Smith :
Removed file:
http://bugs.python.org/file13447/unittest-new-asserts-gps01.diff.txt
___
Python tracker
<http://bugs.python.org/issue2
2901 - 3000 of 3457 matches
Mail list logo
