Gregory P. Smith added the comment:
zipimport.c makes no attempt to support zip files larger than 2GiB or zip64
files.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue19
Changes by Gregory P. Smith :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
fwiw, this patch made sense. using test_sub.py on my dual-core amd64 box with
an opt build is saw the times drop from ~0.90-0.97 to ~0.75-0.8. more speedup
than i was really anticipating for this use case. it probably depends upon
what the value of
Gregory P. Smith added the comment:
upstream simplejson (of which json is an earlier snapshot of) has an encoding
parameter on its dump and dumps method. Lets NOT break compatibility with that
API.
Our users use these modules interchangeably today, upgrading from stdlib json
to simplejson
Gregory P. Smith added the comment:
So why not put a dump_bytes into upstream simplejson first, then pull in a
modern simplejson?
There might be some default flag values pertaining to new features that need
changing for stdlib backwards compatible behavior but otherwise I expect it's a
Gregory P. Smith added the comment:
I saw a small regression over 4k when using a 64k buffer on one of my machines
(dual core amd64 linux). With 32k everything (amd64 linux, armv7l 32-bit
linux, 64-bit os x 10.6) showed a dramatic improvement on the microbenchmark.
approaching 50% less cpu
Gregory P. Smith added the comment:
comments added to the patch.
--
___
Python tracker
<http://bugs.python.org/issue19883>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
The upstream Debian issue contains a fix for the bug in eglibc. Python should
not attempt to work around this. Distros need to fix their libc if they shipped
a broken one.
--
components: +Extension Modules
resolution: -> not a bug
st
Gregory P. Smith added the comment:
Do you honestly have a situation where you need to share a computationally
significant amount of hashing state only to want to finish the computation
N different times with alternate computationally significant ending data
that multiprocessing would actually
Gregory P. Smith added the comment:
Please be constructive.
There is no way to implement generic pickling for hash objects that would work
across all implementations.
The underlying code implementing each function is free to store its internal
state however it wants and does not provide an
Changes by Gregory P. Smith :
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue12876>
___
___
Pyth
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6931>
___
___
Python-
Changes by Gregory P. Smith :
--
versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issue6931>
___
___
Python-bug
New submission from Gregory P. Smith:
The Py_SIZE() macro is not documented. It should be. It is very useful along
with PyList_New(positive_number) after using PyList_SET_ITEM() to fill in up to
the first positive_number elements of a list object in the most optimal manner
by avoiding
Gregory P. Smith added the comment:
(un-cc'ing myself as I can't deal with Windows)
--
components: +Tests, Windows -IO
___
Python tracker
<http://bugs.python.o
Changes by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue11361>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I don't currently have a need for this so, no.
--
___
Python tracker
<http://bugs.python.org/issue16178>
___
___
Pytho
Gregory P. Smith added the comment:
issue14252 appears to have been a fix for the windows side only.
On Posix the best that could be done here is to catch OSError within
Popen.terminate() and Popen.kill() and ignore the problem if there was an error.
We do not have a way to know if the child
Gregory P. Smith added the comment:
agreed, we could at least do that for the Popen methods.
--
___
Python tracker
<http://bugs.python.org/issue17131>
___
___
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue17131>
___
___
Pyth
Gregory P. Smith added the comment:
$SHELL is up to the user and not guaranteed to be anything remotely /bin/sh
compatible.
On Jul 31, 2014 4:14 PM, "Antoine Pitrou" wrote:
>
> Antoine Pitrou added the comment:
>
> Why not simply use $SHELL?
>
>
Gregory P. Smith added the comment:
use a frozenset for algorithms_guaranteed.
in the docs under more algor... may be available make the two variables
link to their docs. you might explicitly mention python 2.7.9 in that
paragraph.
you probably should use pystring_fromstring imstead of
Gregory P. Smith added the comment:
Keeping the delta small makes sense. I'd use frozenset in 3 as well but its
unimportant. LGTM.
--
___
Python tracker
<http://bugs.python.org/is
Gregory P. Smith added the comment:
modify it as you see fit, i hadn't noticed this issue; just the warnings.
--
___
Python tracker
<http://bugs.python.org/is
Gregory P. Smith added the comment:
thanks. btw an alternative type check to consider in these situations:
PyIndex_Check
https://docs.python.org/2/c-api/number.html#c.PyIndex_Check
but what you wrote works.
--
nosy: +gregory.p.smith
___
Python
Changes by Gregory P. Smith :
--
resolution: -> out of date
status: languishing -> closed
___
Python tracker
<http://bugs.python.org/issue2552>
___
___
Pyth
Gregory P. Smith added the comment:
Pick two suitable letters for the int128 and uint128 cases and create a patch
for an implementation with tests (targeting Python 3.5). The implementation
needs to compile and work even when the platform C compiler Python is compiled
with does not have a
Gregory P. Smith added the comment:
Review comments added. I don't really see why the fix should not be as trivial
as:
diff -r ca9bca7aecda Lib/telnetlib.py
--- a/Lib/telnetlib.py Tue Dec 10 16:06:46 2013 -0600
+++ b/Lib/telnetlib.py Tue Dec 10 18:08:37 2013 -0800
@@ -312,7 +
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue17200>
___
___
Python-bugs-list mailing list
Un
Changes by Gregory P. Smith :
--
resolution: -> out of date
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
anyways, i went with just the simple fix and no specific test for this issue as
the tests were painful and questionable reliability.
i appreciate the other refactoring suggestion within the code but for 2.7 and
3.3 bugfixes where no significant changes are
Gregory P. Smith added the comment:
one comment to address on the review, otherwise after addressing that I believe
this is ready to go in for 3.4.
--
nosy: +gregory.p.smith
priority: low -> normal
___
Python tracker
<http://bugs.pyth
Gregory P. Smith added the comment:
You didn't do anything wrong. You were running 3.3.3 which is the latest
release of 3.3. Portage is Gentoo's thing, you'd have to ask the gentoo python
portage ebuild maintainer and point them at the commit with the additional
patch to apply
Gregory P. Smith added the comment:
Unless it could replace the fork+exec code path in its entirety, which I do not
believe is possible, I see posix_spawn() as a distraction and additional
maintenance burden with no benefit.
http://pubs.opengroup.org/onlinepubs/759899/functions
Gregory P. Smith added the comment:
I would not bother pulling this out until the week before RC1 if the standard
has not yet been declared final.
Otherwise, -1 on keeping it under another name. The only hashes we bundle
should be standard ones as those are the only ones people will want to
Gregory P. Smith added the comment:
Given the likely delay in the standard Martin cites, I've change my mind:
agreed. Go ahead and remove it for 3.4.
We'll have an official sha3 in Python 3.5. Early adopters can live with PyPI.
--
Gregory P. Smith added the comment:
I'd rather see it bake in psutils for a while longer regardless of
implementation.
--
___
Python tracker
<http://bugs.python.org/is
Gregory P. Smith added the comment:
attaching a patch for 3.3.
up next, 3.4: So long as I get to it before the release candidates the approach
can likely be improved for 3.4 to actually hold the zip file we're importing
from open for the life of the process instead of doing all of these
Changes by Gregory P. Smith :
Removed file: http://bugs.python.org/file31869/issue19081-gps02.patch
___
Python tracker
<http://bugs.python.org/issue19081>
___
___
Pytho
Changes by Gregory P. Smith :
Removed file: http://bugs.python.org/file31860/issue19081-gps01.diff
___
Python tracker
<http://bugs.python.org/issue19081>
___
___
Pytho
Gregory P. Smith added the comment:
The Windows 7 buildbot is unhappy after that change and failing one of the new
tests:
ERROR: testZipFileChangesAfterFirstImport
(test.test_zipimport.ZipFileModifiedAfterImportTestCase)
Alter the zip file after caching its index and try an import
Gregory P. Smith added the comment:
updated 3.3 patch based off the changes made to the 2.7 one.
--
Added file: http://bugs.python.org/file9/issue19081-33-gps05.diff
___
Python tracker
<http://bugs.python.org/issue19
Changes by Gregory P. Smith :
Removed file: http://bugs.python.org/file33323/issue19081-33-gps04.diff
___
Python tracker
<http://bugs.python.org/issue19081>
___
___
Pytho
New submission from Gregory P. Smith:
Python 3.3.3+ (3.3:28337a8fb502+, Jan 7 2014, 01:32:44)
[GCC 4.6.3] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import unittest
>>> r
Gregory P. Smith added the comment:
somewhat related - https://code.google.com/p/unittest-ext/issues/detail?id=22
--
___
Python tracker
<http://bugs.python.org/issue20
Changes by Gregory P. Smith :
--
nosy: +michael.foord
___
Python tracker
<http://bugs.python.org/issue20165>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
Added file: http://bugs.python.org/file33356/issue19081-33-gps06.diff
___
Python tracker
<http://bugs.python.org/issue19081>
___
___
Pytho
Changes by Gregory P. Smith :
Removed file: http://bugs.python.org/file9/issue19081-33-gps05.diff
___
Python tracker
<http://bugs.python.org/issue19081>
___
___
Pytho
Gregory P. Smith added the comment:
I believe this is done. I'm opting not to go for a more complicated "cache the
open FILE* with the zip_directory_cache" approach for 3.4 due to complexity and
time.
long term: It'd be ideal if zipimport weren't a pile of C code s
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue19081>
___
___
Python-bugs-
Gregory P. Smith added the comment:
I'm not comfortable changing this for 2.7 or 3.3 in case some code is
unfortunately is depending on this behavior. But as it is it does seem like
the kind of thing that can hide problems (tests that are passing that are not
expected to).
Here'
Changes by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
2.7 subprocess is fundamentally flawed and cannot be fixed. Install
subprocess32 from PyPI. It's fixed in 3.2 and later.
--
nosy: +gregory.p.smith
resolution: -> wont fix
status: open -> closed
___
Pyt
Gregory P. Smith added the comment:
A pointer in the 2.7 subprocess docs to subprocess32 does seem like a good
idea, its what i tell everyone to do anyways. :)
If you've got a patch for this in 2.7 feel free to add it here and I can take a
look.
leaving this open as a reminder to
Gregory P. Smith added the comment:
The patch seems reasonable. i'd modify it slightly to include a check the
SYS_getdents64 is not already defined before doing the #define.
--
assignee: -> gregory.p.smith
___
Python tracke
Gregory P. Smith added the comment:
For those four libffi files in msg208964, do what you want with them. I
ignored executable bits entirely (didn't set or unset) when importing the code
as there is zero need to execute any of them.
IMNSHO, I think executable bits should _not_ be set on
Gregory P. Smith added the comment:
Not all cases of this were fixed by the existing patch. subimports still
trigger the bug via a different code path. attaching an updated unittest that
demonstrates that.
--
resolution: fixed ->
status: closed -> open
Added file:
Gregory P. Smith added the comment:
The call stack for that code path failing is:
#0 get_data (fp=0xf64920, archive=0xe77ecc
"/home/greg/sandbox/python/cpython/2.7/junk95142.zip",
toc_entry=('/home/greg/sandbox/python/cpython/2.7/junk95142.zip/ziptestpackage/ziptestmod
Gregory P. Smith added the comment:
The problem appears to be that every zipimporter instance keeps its own
reference to the zip files table of contents (self->files) instead of
continually using the module wide zip_directory_cache but the zip_stat_cache is
being maintained externally to t
Gregory P. Smith added the comment:
Here's a fix that I believe works with one TODO in there that needs
investigation due to a question about the current historical zipimport code.
--
Added file: http://bugs.python.org/file33614/issue19081-subimport-fix-gps02
Gregory P. Smith added the comment:
I refactored the unittests a bit and added another test for subimports when a
directory within the .zip file is in sys.path as well.
The quizzical "wtf" TODO I had in the code has been "answered" in that I am
unable to trigger a situati
Gregory P. Smith added the comment:
Updated to make that function (zipimporter_init) easier to follow by not
repurposing the path variable mid-function and allocate the local path buffer
rather than keeping it on the stack.
--
Added file: http://bugs.python.org/file33736/issue19081
Gregory P. Smith added the comment:
Fixed in the 2.7 branch. The existing patch in the 3.3 and 3.4 branches is
incomplete and does not actually fix the problem. Despite what the Misc/NEWS
entry claims. The patch I am attaching now (applies to 3.3, I will forward
port it to 3.4) fixes the
Gregory P. Smith added the comment:
Thanks Georg. I'll leave it until after the 3.3.4 release. For simplicity's
sake I'll leave it for 3.4.1 as well unless Larry says otherwise.
--
priority: release blocker -> deferred blocker
Gregory P. Smith added the comment:
documented with a deprecation. that's the best we can do for now. it can be
considered for removal in the 3.5 or 3.6 timeframe. i doubt many people used
it.
--
nosy: +gregory.p.smith
resolution: -> fixed
status: open -
Gregory P. Smith added the comment:
gah. i was tracking this down because I saw some strange errors that made me
suspect it might exist (in 2.7) when trying to use a zipped up standard library
but had not had time to confirm it. :(
I really should have rolled back the CLs causing it before
Changes by Gregory P. Smith :
--
title: Issue with zipimport in 3.3.4 -> Issue with zipimport in 3.3.4 and
3.4.0rc1
___
Python tracker
<http://bugs.python.org/issu
Changes by Gregory P. Smith :
Added file: http://bugs.python.org/file34103/issue20621-34-rollbacks-gps01.diff
___
Python tracker
<http://bugs.python.org/issue20
Gregory P. Smith added the comment:
if you look at the zipimport.c file log there was one additional tiny change to
fix a potential memory leak made after the change I suggested backing out:
http://hg.python.org/cpython/log/fb5f4cfc3230/Modules/zipimport.c
anyways, yes, backing up to the
Gregory P. Smith added the comment:
What do you mean by "everything"? How much did you back out? I *ONLY* wanted
the patches I posted in 20621 backed out as those were the source of the
problem.
The changes made on 2014-01-06 and 2014-01-07 were good even though they only
address
Gregory P. Smith added the comment:
Confirmed that Modules/zipimport.c in the 3.3 and default branches is identical
to the version from late last year. Both should be good for 3.3.5 and 3.4.0
releases.
--
___
Python tracker
<h
Gregory P. Smith added the comment:
At this point i'll be reapplying things since 8dbf8edb7128 to 2.7 and trying to
untangle where the problem came in. I confirmed with diff that you've backed
everything out to the pre-January state in all branches.
I've had part of th
Gregory P. Smith added the comment:
I believe this happens on all platforms.
--
___
Python tracker
<http://bugs.python.org/issue20621>
___
___
Python-bugs-list m
New submission from Gregory P. Smith:
Please cherry-pick 52ab9e1ff46a to roll back the zipimport brokenness.
This is the change that fixes issue20621 which is causing a rapid 3.3.5 brown
bag release.
--
assignee: larry
messages: 211391
nosy: gregory.p.smith, larry
priority: release
Gregory P. Smith added the comment:
Thanks for trying. :) I've got a complicated "test" case of zipping up the
stdlib into python27.zip and running the Python test suite against that
which also tends to trigger the bugs. Some tests failing with SystemError
and such.
It smell
Gregory P. Smith added the comment:
there's a separate issue open for you with the necessary rollback patch to
apply to your 3.4 release branch. http://bugs.python.org/issue20651
This particular issue is actually solved in default, 3.3 and 2.7 as benjamin
did the backouts/rollbacks o
Gregory P. Smith added the comment:
I don't see why this cannot wait until 3.4.1.
True, rounding away from zero is desirable in these cases but it seems like
this should be a non issue most of the time and any distro (ubuntu) that picks
up 3.4.0 can apply this fix to their own python pa
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue15819>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue19142>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
*Rereads latest patch*
I'm happy with this being backported as a bugfix to 3.1 and 2.6 so long
as the set_tunnel method is hidden. Call it _set_tunnel() in the
backport (and don't document its
Gregory P. Smith added the comment:
good catch. thanks!
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6567>
___
___
Python-bug
Changes by Gregory P. Smith :
--
assignee: -> ezio.melotti
___
Python tracker
<http://bugs.python.org/issue5511>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
Agreed, a standalone release combined with a public announcement about
its availability is a must if we want to get any sort of wide spread
testing.
It'd be great if we had a fully characterized set of tests for the
behavior of the existing engine... b
Changes by Gregory P. Smith :
--
assignee: loewis -> gregory.p.smith
nosy: +gregory.p.smith
priority: low -> normal
___
Python tracker
<http://bugs.python.org/
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
priority: -> normal
___
Python tracker
<http://bugs.python.org/
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue1006238>
___
___
Python-
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue1597850>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue5404>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
nice test case rhettg.
This is a correctness issue to prevent data loss on EINTR.
I've attached a patch that builds on rhettg's but allows the EINTR signal
to propagate upwards as desired by loweis and jorend for both read() and
readli
Gregory P. Smith added the comment:
realistically, file objects (Objects/fileobject.c) never raise EINTR as
they use the C library fread/fwrite/fclose underneath. Why should a
socket based file object every be allowed to raise EINTR rather than
handling it internally?
IMHO people should
Gregory P. Smith added the comment:
for each of these discrepancies that you're finding, please consider
submitting them as patches that add a unittest to the existing test
suite. otherwise their behavior guarantees will be lost regardless of if
the suite in this issue is adopted. t
Gregory P. Smith added the comment:
r73916 appears to fix this?
--
___
Python tracker
<http://bugs.python.org/issue3392>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
merged into release31-maint in r74425.
reopen the issue if this doesn't fix the problem.
--
status: open -> closed
versions: -Python 2.6
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
fixed in trunk r74426. socket.socket.sendall() and all
socket._fileobject methods (read/readline/write/flush) now properly
handle EINTR internally.
sendall will allow a python signal handler to raise an exception
aborting it in unknown state, otherwise it
Gregory P. Smith added the comment:
Note that http://bugs.python.org/issue4879 may have already fixed this
problem in trunk r68532.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue2
Gregory P. Smith added the comment:
Okay, I do not think this has been fixed yet. Anyone calling
getresponse() can indeed use buffering=True, it can mess things up if
the do not close the connection afterwards.
The addition of the sockbuf parameter to HTTPConnection as proposed in
Gregory P. Smith added the comment:
backported to release26-maint in r74456.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6
Gregory P. Smith added the comment:
I believe there will be a problem with the patch committed in r68532.
If getresponse(buffering=True) is called, extra data on the socket may
be consumed by the socket.makefile() buffer which will cause problems if
the connection is not closed immediately
Gregory P. Smith added the comment:
Anything that adds a new parameter can not be backported to 2.6 as that
counts as an API change / feature addition.
--
___
Python tracker
<http://bugs.python.org/issue2
Gregory P. Smith added the comment:
trunk r74463 now forces the HTTPResponse to close afterwards when
buffering=True to avoid the issue.
--
___
Python tracker
<http://bugs.python.org/issue4
2801 - 2900 of 3457 matches
Mail list logo
