Gregory P. Smith added the comment:
New changeset c1e46e94de38a92f98736af9a42d89c3975a9919 by Gregory P. Smith
(Alexey Izbyshev) in branch 'master':
bpo-32777: Fix _Py_set_inheritable async-safety in subprocess (GH-5560)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset 2bb0bfafb0beb819b7c60d9004382ce6867847c0 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-32777: Fix _Py_set_inheritable async-safety in subprocess (GH-5560)
(GH-5562)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset b90c68586e1f2c45c736dd38880f182be267e2ef by Gregory P. Smith
(Miss Islington (bot)) in branch '3.6':
bpo-32777: Fix _Py_set_inheritable async-safety in subprocess (GH-5560)
(GH-5563)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
components: +Extension Modules
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
Nathaniel's specific description of a problem is wrong. A Path with embedded
spaces is treated no different than one without by default.
Where things change, and what needs fixing, is when shell=True is passed. In
that case a PathLike object should n
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue32764>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
New changeset fc1ce810f1da593648b4d19e7d582a235ec1dd37 by Gregory P. Smith
(Brice Gros) in branch 'master':
bpo-6135: Fix subprocess.check_output doc to mention changes in 3.6 (GH-5564)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset 4e7a964aaf4374fa2f6b45cf5161fa6cd53aec19 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-6135: Fix subprocess.check_output doc to mention changes in 3.6 (GH-5564)
(GH-5572)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset 7f95c8c319c1ee593b130d0eb1d4947d9d7e008a by Gregory P. Smith
(Miss Islington (bot)) in branch '3.6':
bpo-6135: Fix subprocess.check_output doc to mention changes in 3.6 (GH-5564)
(GH-5573)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset e14c01037877768a3fe766e50d14993bd5d8a67e by Gregory P. Smith
(Pablo Galindo) in branch 'master':
bpo-32815: Improve docs on the subprocess API *text* parameter (GH-5622)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset ba4f218657efcba856d00eb320418355cce8309a by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-32815: Improve docs on the subprocess API *text* parameter (GH-5622)
(GH-5631)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 33dddac00ba8d9b72cf21b8698504077eb3c23ad by Gregory P. Smith
(Anselm Kruis) in branch 'master':
bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066)
https://github.com/python/cpython/commit/33dddac00ba8d9b72cf21b86985040
Gregory P. Smith added the comment:
New changeset 61bd4d2e6319a3c5c3b9ce5f807b44a45cc1d4a1 by Gregory P. Smith
(Anselm Kruis) in branch '2.7':
[2.7] bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) (GH-5825)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset 9c819a6a7d34594779fea3a25fd69ec5745e185e by Gregory P. Smith
(Anselm Kruis) in branch '3.6':
[3.6] bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) (GH-5826)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +Python 2.7, Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
I'm fine with undoing this for 3.7 in light of the many things we don't do
"right" all over the place with path like objects.
subprocess still presents as a mix of high and low level APIs so if we accept a
path like object in a subse
Gregory P. Smith added the comment:
Ned: when removing a feature added in beta1, should we remove the original NEWS
entry created for it? Or add a new NEWS entry that states that the previous
feature has been reverted?
--
___
Python tracker
Gregory P. Smith added the comment:
keeping the conversation in one place, the code review comment was: "I've
prefixed this with an underscore because it's not exposed when reading back.
ZipInfo has another "private" attribute, _raw_time"
compresslevel is docum
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue32973>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
versions: +Python 3.6, Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue32973>
___
___
Python-bugs-list m
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +5976
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33079>
___
___
Py
Gregory P. Smith added the comment:
I assumed simon meant "close_fds=False" when he wrote open_fds = True.
Regardless, supplying any pass_fds forces close_fds=True behavior.
File descriptors listed in pass_fds are explicitly set inheritable from within
the child process prior to ca
Gregory P. Smith added the comment:
I clarified the docs to mention that the inheritable flag is heeded when
close_fds=False in https://github.com/python/cpython/pull/6240/files
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Gregory P. Smith added the comment:
This bug stems from:
https://github.com/python/cpython/blob/master/Modules/_posixsubprocess.c#L454
When stdout=fd is passed, that results in c2pwrite=fd. The stdin/stdout/stderr
pipe fds are closed when > 2 without checking to see if they are listed
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +5977
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32270>
___
___
Py
Gregory P. Smith added the comment:
I believe the original issue is fixed, the original problem and the one Jack
followed up with no longer work in modern Python 3.
But there is discussion about possibly doing something better, if anyone is
interested in doing that I suggest opening a new
Change by Gregory P. Smith :
--
assignee: -> benjamin.peterson
___
Python tracker
<https://bugs.python.org/issue30416>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
New changeset 0e7144b064a19493a146af94175a087b3888c37b by Gregory P. Smith
(Alexey Izbyshev) in branch 'master':
bpo-32844: Fix a subprocess misredirection of a low fd (GH5689)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
pull_requests: +6046
___
Python tracker
<https://bugs.python.org/issue20104>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 79760ed256987cead08d668b95675afba6b3760f by Gregory P. Smith in
branch 'master':
bpo-20104: Add os.posix_spawn documentation. (#6334)
https://github.com/python/cpython/commit/79760ed256987cead08d668b95675a
Gregory P. Smith added the comment:
PR 6332 is overall a good cleanup. I pushed a couple changes to that PR and
left comments for some others. It should go in.
There are basic tests for os.posix_spawn in test_posix.py. More would be nice
as we don't currently have any for the error
Gregory P. Smith added the comment:
https://github.com/python/cpython/pull/6332 appears to address this.
--
___
Python tracker
<https://bugs.python.org/issue33
Gregory P. Smith added the comment:
A raw os.posix_spawn() API has been added to 3.7.
vfork() would likely all sorts of other problems. It is extremely complicated
and implementations have bugs. CERT says never to use it.
https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
New submission from Gregory P. Smith :
Build CPython (master in this case - though I originally noticed the problem
when building a 3.6 tree) as follows with clang installed:
build$ LD=clang-5.0 LDFLAGS=-fsanitize=undefined CC=clang-5.0 CXX=clang-5.0
CFLAGS=-fsanitize=undefined CXXFLAGS
Change by Gregory P. Smith :
--
nosy: +benjamin.peterson, fweimer
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
nosy: +twouters
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
related: https://ssl.icu-project.org/trac/ticket/13503
--
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Gregory P. Smith added the comment:
I think it is worth getting such a change in.
its arguable that the compiler should be able to see through the union for this
use case but I assume such a fix would only land in a recent clang version.
i'm attaching a variant on your patch that do
Gregory P. Smith added the comment:
notably, C99 variable length arrays syntax is not mentioned as allowed in
https://www.python.org/dev/peps/pep-0007/. If we want to use VLAs, that should
be clarified. But both our solutions should work with [1] instead of [] which
is allowed by the ubsan
Change by Gregory P. Smith :
--
pull_requests: +6233
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Python-
Change by Gregory P. Smith :
--
pull_requests: +6234
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue24318>
___
___
Python-
Gregory P. Smith added the comment:
FYI - The test suite minus some of the crazier tests (multiprocessing) that the
makefile uses today is the recommended workload and is effectively what linux
distros I've looked at use.
It is a myth that the specific application workload matters a
Gregory P. Smith added the comment:
By my reading on how strict aliasing works, I think just changing the
int64_t[1] or int32_t[1] in my PR to char[1] will work as char is always
assumed to alias?
the clang ubsan i was testing my PR against wasn't warning me about strict
ali
Gregory P. Smith added the comment:
I'm going to see what appveyor says with the VLA code on the PR. I've updated
it to use char[].
--
___
Python tracker
<https://bugs.python.o
Gregory P. Smith added the comment:
My PR is almost a revert of
https://github.com/python/cpython/commit/186122ead26f3ae4c2bc9f6715d2a29d339fdc5a
so I'm curious what your motivation behind that change to use the union was?
--
___
Python tr
Gregory P. Smith added the comment:
New changeset 397f1b28c4a12e3b3ed59a89599eabc457412649 by Gregory P. Smith in
branch 'master':
bpo-33312: Fix clang ubsan out of bounds warnings in dict. (GH-6537)
https://github.com/python/cpython/commit/397f1b28c4a12e3b3ed59a89599eab
Gregory P. Smith added the comment:
If you think this should be written differently, please propose it in a PR so
we can see what you are suggesting.
An unbounded member at the end of a struct is quite a common practice in C.
ex: PyBytesObject
Gregory P. Smith added the comment:
New changeset 392520bd78cd18639a27e5d2803c2e1c2bd593a8 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-33312: Fix clang ubsan out of bounds warnings in dict. (GH-6537) (GH-6543)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
ned: yes, it supposedly has. test_gdb. in a manner i cannot reproduce or
debug without error output that indicates anything about the problem.
test_gdb passes on my systems.
--
___
Python tracker
<ht
Gregory P. Smith added the comment:
I see one line in Tools/gdb/libpython.py that may be related. i'll try
changing that. the only way i have to _test_ it is to merge it into master.
--
___
Python tracker
<https://bugs.python.org/is
Change by Gregory P. Smith :
--
pull_requests: +6245
___
Python tracker
<https://bugs.python.org/issue33312>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 53f67d401df40486fd0fb8fbcf9da725cd37290c by Gregory P. Smith in
branch 'master':
bpo-33312: update Tools/gdb/libpython.py to match. (GH-6548)
https://github.com/python/cpython/commit/53f67d401df40486fd0fb8fbcf9da7
Gregory P. Smith added the comment:
New changeset 11659d00b9185c8f02ea6b642fa475a80e21f1a9 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-33312: update Tools/gdb/libpython.py to match. (GH-6549)
https://github.com/python/cpython/commit/11659d00b9185c8f02ea6b642fa475
New submission from Gregory P. Smith :
CPython needs to be regularly built and vetted for C undefined behavior.
CFLAGS=-fsanitize=undefined LDFLAGS=-fsanitize=undefined CC=clang LD=clang
./configure
is all it takes to start with.
if you do this today, test_ctypes will knock your socks off
Gregory P. Smith added the comment:
Sorry for the breakage. I'm glad the fix was that greppable and easy given I
had no idea where to start otherwise. :)
This is in for 3.7. The PR for 3.6 is pending, i want to let it out in the
next 3.7 builds for a while before i merge it into 3.6
Gregory P. Smith added the comment:
+1 in general to this work. Łukasz is effectively preaching to the choir by
looping me in here. :)
It is a big challenge to practically support Python in that we have no good
ability to parse and understand all language syntax versions via a single API
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue26834>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
Since this is a new API, the most important thing is to have decided how we
want it to look in 3.7, it is okay for it to be missing features so long as the
API doesn't prevent them from being added in the future.
ie: It is fine to ship it wi
Gregory P. Smith added the comment:
FWIW, I would _love_ to see this. But I don't wrangle Windows myself so I
can't usefully offer anything other than being happy to volunteer to run a
Clang on Windows buildbot VM once there is something to actually be run.
--
nosy: +grego
Gregory P. Smith added the comment:
Pablo, Victor, Ned and I synced up at the pycon2018 sprints. We're removing
posix_spawn from 3.7 (https://github.com/python/cpython/pull/6794) while the
API is worked on.
--
___
Python tracker
&
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue28287>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue33453>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
the PRs were merged, marking this as fixed.
--
nosy: +gregory.p.smith
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 8e633a4035bcff458c45fa095f4b8eab2f158466 by Gregory P. Smith
(Pablo Galindo) in branch '3.7':
bpo-20104: Remove posix_spawn from 3.7 (GH-6794)
https://github.com/python/cpython/commit/8e633a4035bcff458c45fa095f4b8e
Change by Gregory P. Smith :
--
priority: release blocker -> normal
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issue20104>
___
___
Py
Change by Gregory P. Smith :
--
components: +Library (Lib)
___
Python tracker
<https://bugs.python.org/issue20104>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
pull_requests: +6537
___
Python tracker
<https://bugs.python.org/issue24318>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +6548
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
If the behavior was consistent from 3.3 through 3.6, that is the behavior we
should keep going forward in 3.7+ without a deprecation period. (and this does
not seem worth deprecating, lets just keep the behavior the same as it was in
3.3-3.6)
That 2.7 is
Gregory P. Smith added the comment:
FYI - We run into this problem getting things using gettext for i18n within a
hermetic zipped up Python application at work. I'm not reopening it as I have
nothing new to propose right now, but figured I'd drop a note that it does seem
like a
Gregory P. Smith added the comment:
any thoughts on this Antoine?
--
nosy: +gregory.p.smith, pitrou
title: `wait` and `as_completed` depend on private api -> concurrent.futures
`wait` and `as_completed` depend on private api
___
Python trac
Gregory P. Smith added the comment:
Please try to reproduce this with Python 3.6.
On 2.7, I highly recommend you stop using the Python 2.7 subprocess module and
install the subprocess32 backport available on PyPI. It is *much* more reliable
Gregory P. Smith added the comment:
Using new syscalls for _posixsubprocess.c would be a feature so it would be
limited to 3.7+ if done at all.
My gut feeling is that the real bug is in *any* library code that uses
pthread_atfork() in a non thread safe manner. That code is fundamentally
Change by Gregory P. Smith :
--
components: +Extension Modules -Interpreter Core
type: behavior -> enhancement
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue31756>
___
___
Python-
Change by Gregory P. Smith :
--
pull_requests: +4042
___
Python tracker
<https://bugs.python.org/issue6721>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
logging is pretty easy to deal with so I created a PR.
bufferedio.c is a little more work as we either need to use the posixmodule.c
os.register_at_fork API or expose it as an internal C API to be able to call it
to add acquires and releases around the
Change by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue25083>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I'm un-cc'ing myself as I don't use Python 2 in an environment where we allow
it to write .pyc files at application runtime.
--
___
Python tracker
<https://bugs.pyt
Gregory P. Smith added the comment:
New changeset 7fed7bd8bb628f0f09c6011871a4ce68afb41b18 by Gregory P. Smith
(andyclegg) in branch 'master':
bpo-31756: subprocess.run should alias universal_newlines to text (#4049)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
I'd raise a ValueError in that case.
--
___
Python tracker
<https://bugs.python.org/issue31702>
___
___
Python-bugs-l
Gregory P. Smith added the comment:
I'd stick with ValueError in that case as well. if someone dislikes the
valueerrors because they _want_ to use an invalid one, they can file a bug
and we'll reconsider only if they have a meaningful use case.
On Wed, Oct 25, 2017 at 9:36 AM Serhiy
Gregory P. Smith added the comment:
If we do this, I think we should aim for the complete solution on the most
common posix platforms (Linux and MacOS) as C/C++ extensions are just as happy
to create threads these days. (but if you want to start with a simple python
threads only warning
Gregory P. Smith added the comment:
obviously didn't make it in 3.6 but this still seems desirable. I just saw
someone at work propose a trivial port of golang's sort.Search -
https://golang.org/pkg/sort/#Search - in Python which caused me to hunt for an
issue on bisect ke
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue25942>
___
___
Python-
Change by Gregory P. Smith :
--
versions: +Python 3.7 -Python 3.5
___
Python tracker
<https://bugs.python.org/issue25942>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
On Mon, Nov 6, 2017 at 3:11 PM Neil Schemenauer
wrote:
>
> Neil Schemenauer added the comment:
>
> Hi Victor,
>
> My first guess is that the build bot is not cleaning the fprofile
> information after updating the source tree. A few
Change by Gregory P. Smith :
--
resolution: -> works for me
stage: -> resolved
status: open -> closed
type: performance -> compile error
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
We're still seeing this (in 2.7.12, but the code at 2.7 head hasn't changed).
In this case the RLock being used within _acquireLock() still exists but is an
incomplete object by the time we use it.
--
resolution: fixed ->
status: c
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue21149>
___
___
Python-bugs-list mailing list
Un
Change by Gregory P. Smith :
--
pull_requests: +4321
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue21149>
___
___
Python-
Gregory P. Smith added the comment:
New changeset e84f6d3817ad3d18fdfbb5223b8078606166cea0 by Gregory P. Smith in
branch '2.7':
[2.7] bpo-21149: Workaround a GC finalization bug in logging. (#4368)
https://github.com/python/cpython/commit/e84f6d3817ad3d18fdfbb5223b8078
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
type: -> behavior
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
Given this is gcc exploding, I'm not sure there is anything we can do about it.
I _believe_ we're doing everything right.
--
___
Python tracker
<https://bugs.python.o
Change by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue13986>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith, twouters
___
Python tracker
<https://bugs.python.org/issue32248>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
New changeset 2d8f06382e7d5a759ca554110a699a397114824a by Gregory P. Smith
(izbyshev) in branch 'master':
bpo-32369: test_subprocess: Fix pass_fds check in test_close_fds() (#4920)
https://github.com/python/cpyt
2301 - 2400 of 3453 matches
Mail list logo
