New submission from Gregory P. Smith :
test_httplib uses self-signed.pythontest.net in it's test_networked_good_cert
test.
On modern Linux distros (current Debian testing sid), the certificate it
currently uses is rightfully rejected as being too weak:
ERROR: test_networked_good
Gregory P. Smith added the comment:
PR coming
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue35925>
___
___
Python-bugs-lis
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +13036
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +13037
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
EWDurbin says I can just open a PR with new certs in the repo and it'll go from
there. :)
--
assignee: EWDurbin -> gregory.p.smith
___
Python tracker
<https://bugs.python.org
Gregory P. Smith added the comment:
New changeset 2cc0223f43a1ffd59c887a73e2b0ce5202f3be90 by Gregory P. Smith in
branch 'master':
bpo-35925: Skip SSL tests that fail due to weak external certs. (GH-13124)
https://github.com/python/cpython/commit/2cc0223f43a1ffd59c887a73e2b0ce
Gordon P. Hemsley added the comment:
Hah, that's indeed where I've landed in my experimentation.
--
___
Python tracker
<https://bugs.python.o
Change by Gordon P. Hemsley :
--
pull_requests: +13059
___
Python tracker
<https://bugs.python.org/issue36684>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
The merged PR basically skips the specific failing unit test cases of the ssl
key strength check error is detected during these network tests. It should
probably be backported into 3.6 and 2.7 to ease maintenance and trust of the
buildbots on those
Gregory P. Smith added the comment:
New changeset 7e200e0763f5b71c199aaf98bd5588f291585619 by Gregory P. Smith
(Miro Hrončok) in branch '3.7':
bpo-30458: Disallow control chars in http URLs. (GH-12755) (GH-13154)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issue30458>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 64aa6d2000665efb1a2eccae176df9520bf5f5e6 by Gregory P. Smith in
branch 'master':
bpo-36533: Reinit logging.Handler locks on fork(). (GH-12704)
https://github.com/python/cpython/commit/64aa6d2000665efb1a2eccae176df9
Gregory P. Smith added the comment:
Thanks Julia!
--
nosy: +gregory.p.smith
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
assignee: Mariatta -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue27432>
___
___
Py
Gregory P. Smith added the comment:
safe_repr() as used internally by unittest wasn't intended to truncate by
default as part of its "safety". The "safe" part is that it catches Exception
and provides an alternate repr if the __repr__ raised.
unittest.util.safe_rep
Change by Gregory P. Smith :
--
title: Unittest truncating of error message not works -> Support unittest
assertion truncation of repr in error messages
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
versions: -Python 3.8
___
Python tracker
<https://bugs.python.org/issue36533>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +13086
___
Python tracker
<https://bugs.python.org/issue36533>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Gregory P. Smith :
Running make in the Doc directory does not install all necessary tooling on its
own. This is a hurdle to getting beginners up to speed on making documentation
changes (often their very first changes in the CPython project).
```
:~/oss/cpython
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue36838>
___
___
Python-bugs-list mailing list
Un
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +13089
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36838>
___
_
Gregory P. Smith added the comment:
The regression should be fixed. It'd be helpful if owners of applications that
were running into this could test their applications with this specific change.
--
resolution: -> fixed
stage: patch review -> commit review
status: ope
Gregory P. Smith added the comment:
New changeset 3b4b28efbde63502709bede7c5f9403ec6f37428 by Gregory P. Smith in
branch '3.7':
[3.7] bpo-36533: Reinit logging.Handler locks on fork(). (GH-12704) (GH-13170)
https://github.com/python/cpython/commit/3b4b28efbde63502709bede7c5f940
Gregory P. Smith added the comment:
I noted this at the mentored sprints this year when I suggested my mentee "cd
Doc ; make html" to show them how to build the docs, check that they build and
see what they look like.
Once upon a time we used to auto-fetch and install sphinx
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 3918ad6b45da31e05265de5a455102276717c659 by Gregory P. Smith in
branch 'master':
bpo-36838: Suggest 'make venv' when missing Doc/ tools. (GH-13173)
https://github.com/python/cpython/commit/3918ad6b45da31e05265
Gregory P. Smith added the comment:
Updated cert+key committed to pythontestdotnet. reassigning to EWDurbin to see
that they're deployed.
https://github.com/python/pythontestdotnet/commit/2d121419796dad6d4285bf5aefd464aff0f47a91
--
assignee: gregory.p.smith -> EWDurbin
re
Change by Gregory P. Smith :
--
pull_requests: +13104
stage: commit review -> patch review
___
Python tracker
<https://bugs.python.org/issue36816>
___
___
Py
Gregory P. Smith added the comment:
thats https://bugs.python.org/issue36816 (separate issue as our infrastructure
is fixed to have a modern certificate). PR pending automerge post-CI.
--
___
Python tracker
<https://bugs.python.org/issue35
Change by Gregory P. Smith :
--
pull_requests: +13108
___
Python tracker
<https://bugs.python.org/issue36816>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Gregory P. Smith :
We're having pain today due to the Lib/test/selfsigned_pythontestdotnet.pem
certificate update sychronization.
This wouldn't be painful if our tests relying on a specific certificate
matching something elsewhere on the network supporte
Change by Gregory P. Smith :
--
pull_requests: +13109
___
Python tracker
<https://bugs.python.org/issue36816>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +13110
___
Python tracker
<https://bugs.python.org/issue36816>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +13111
___
Python tracker
<https://bugs.python.org/issue36816>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 7b5dca8345f4a909367836a3a2c3c7ac6e4e2c0c by Gregory P. Smith in
branch '2.7':
[2.7] bpo-36816: Update the self-signed.pythontest.net cert (GH-13192)
(GH-13199)
https://github.com/python/cpython/commit/7b5dca8345f4a909367836a3a2c3c7
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue36601>
___
___
Python-bugs-list mailing list
Un
New submission from Gregory P. Smith :
Thing:
mock_thing.method sig=(a=None, b=0)
F
==
FAIL: test_has_calls_on_thing (__main__.MockCallTest)
--
Traceback
Gregory P. Smith added the comment:
PR is approved with automerge, just awaiting CI to give it the green light now.
--
___
Python tracker
<https://bugs.python.org/issue36
Gregory P. Smith added the comment:
If you use a debugger on this, you'll discover that what is happening inside of
mock's assert_has_calls is that it is catching and swallowing an exception
around the inspect.Signature instances bind() call complaining about 'b' being
a
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
type: -> enhancement
versions: +Python 3.8
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
In our 3.6 tree the test_ssl failure is now:
==
ERROR: test_protocol_sslv23 (test.test_ssl.ThreadedTests)
Connecting to an SSLv23 server with various client options
Gregory P. Smith added the comment:
(same on 2.7)
--
___
Python tracker
<https://bugs.python.org/issue35925>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +13163
stage: backport needed -> patch review
___
Python tracker
<https://bugs.python.org/issue35925>
___
___
Py
Change by Gregory P. Smith :
--
pull_requests: +13165
___
Python tracker
<https://bugs.python.org/issue35925>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset e2500610c62673f42371b54fb0e4de83e4b33146 by Gregory P. Smith
(Matthias Bussonnier) in branch 'master':
bpo-36895: remove time.clock() as per removal notice. (GH-13270)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
I saw the PR before the bug comment. merged. if we find a _good_ reason to
delay this removal a cycle during the 3.8 betas we can bring it back.
thanks for staying on top of the removal plan!
--
resolution: -> fixed
stage: patch rev
Gregory P. Smith added the comment:
fwiw - i agree that this can be removed. it has no reason to ever be called
directly. i double checked in our massive internal codebase at work and found
no calls other than python interpreters themselves.
--
nosy: +gregory.p.smith
New submission from Gregory P. Smith :
A Python pattern in code is to keep everything indented to look pretty while,
yet when the triple quoted multiline string in question needs to not have
leading whitespace, calling textwrap.dedent("""long multiline constant"&quo
Gregory P. Smith added the comment:
New changeset 7346a16ed584fd1e85359154820d286370b68648 by Gregory P. Smith in
branch '2.7':
[2.7] bpo-35925: Skip SSL tests that fail due to weak external certs or old TLS
(GH-13124) (GH-13253)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
3.6 (and 3.5 if larry wants) are the only remaining trees to apply this to,
assigning to the 3.6 RM.
--
assignee: gregory.p.smith -> ned.deily
versions: -Python 2.7
___
Python tracker
<https://bugs.pyth
Gregory P. Smith added the comment:
Oh good, I thought this had come up before. Your method idea that could be
optimized on literals makes a lot of sense, and is notably more readable than
yet another letter prefix.
--
___
Python tracker
<ht
Gregory P. Smith added the comment:
I'd say go for it. We can't guarantee we'll accept the feature yet, but I
think the .dedent() method with an optimization pass approach is worthwhile
making a proof of concept of regardless.
--
___
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +13233
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36760>
___
_
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
components: +Documentation -Library (Lib)
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset e883091abf7ca84a88e956fe5202e75c53bd4128 by Gregory P. Smith in
branch 'master':
bpo-36760: Clarify subprocess capture_output docs. (GH-13322)
https://github.com/python/cpython/commit/e883091abf7ca84a88e956fe5202e7
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
Thanks, it's actually good to see this being a feature accepted in other
languages.
--
priority: low -> normal
___
Python tracker
<https://bugs.python.org
Gregory P. Smith added the comment:
Catalin has been examining code... switching concurrent.futures.thread to use
SimpleQueue instead of Queue is probably a good idea as the queues in there get
used from weakref callbacks.
--
___
Python tracker
Gregory P. Smith added the comment:
https://bugs.python.org/issue32576 filed for that
--
___
Python tracker
<https://bugs.python.org/issue14976>
___
___
Pytho
New submission from Gregory P. Smith :
As a follow up to https://bugs.python.org/issue14976 which just introduced
queue.SimpleQueue:
concurrent.futures.thread currently uses a queue.Queue() from weakref callbacks
which could in theory lead to a deadlock when periodic gc triggers a cleanup
Gregory P. Smith added the comment:
there's a PR on the other issue i opened for this without noticing this one so
i'm marking this as the dup.
--
nosy: +gregory.p.smith
resolution: -> duplicate
stage: -> patch review
status: open -> closed
superseder: queue.Queue
Change by Gregory P. Smith :
--
title: concurrent.futures.thread potential deadlock due to Queue in weakref
callback -> concurrent.futures.thread deadlock due to Queue in weakref callback
___
Python tracker
<https://bugs.python.org/issu
Gordon P. Hemsley added the comment:
>> As discussed above, starting with msg309074, __deepcopy__() is being added
>> to the Python implementation because it already exists in the C
>> implementation.
>
> Python implementation shouldn't copy all im
Gregory P. Smith added the comment:
New changeset 6c6ddf97c402709713d668d0ed53836a7749ba99 by Gregory P. Smith
(Pablo Galindo) in branch 'master':
bpo-20104: Expose `posix_spawn` in the os module (GH-5109)
https://github.com/python/cpython/commit/6c6ddf97c402709713d668d0ed5383
Gregory P. Smith added the comment:
remaining work before closing this:
Doc/library/os.rst needs to describe os.posix_spawn
--
priority: low -> normal
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 0cd6bca65519109a8a7862d38ba1b8924e432a16 by Gregory P. Smith
(Pablo Galindo) in branch 'master':
bpo-20104: Fix leaks and errors in new os.posix_spawn (GH-5418)
https://github.com/python/cpython/commit/0cd6bca65519109a8a7862d38ba1b8
Gregory P. Smith added the comment:
New changeset f4d644f36ffb6cb11b34bfcf533c14cfaebf709a by Gregory P. Smith in
branch 'master':
bpo-25942: make subprocess more graceful on ^C (GH-5026)
https://github.com/python/cpython/commit/f4d644f36ffb6cb11b34bfcf533c14
Gregory P. Smith added the comment:
I went with my change to give the child process a small amount of time to
cleanup by default. Not perfect, but this should be more similar to the Python
<=3.2 behavior. Lets see if any issues crop up during the 3.7 betas.
--
resolution: ->
Gregory P. Smith added the comment:
New changeset ce237c7d58ba207575cdfb0195a58a6407fbf717 by Gregory P. Smith (Bo
Bayles) in branch 'master':
bpo-21417: Add compresslevel= to the zipfile module (GH-5385)
https://github.com/python/cpython/commit/ce237c7d58ba207575cdfb0195a58a
Gregory P. Smith added the comment:
New changeset 3d86e484de6334fe16cbab512744597bd0de4e80 by Gregory P. Smith
(Stéphane Wirtel) in branch 'master':
bpo-32681: Fix an uninitialized variable in the C implementation of os.dup2
(GH-5346)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
https://github.com/python/cpython/pull/5346 (merged) should fix that warning.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue32
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue32102>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
New changeset ce0f33d04528fcafc673a8707871f8430d8f7ce8 by Gregory P. Smith (Bo
Bayles) in branch 'master':
bpo-32102 Add "capture_output=True" to subprocess.run (GH-5149)
https://github.com/python/cpython/commit/ce0f33d04528fcafc673
Gregory P. Smith added the comment:
Thanks Bo. I agree with Nick, this is a readability win for a common annoying
to type otherwise case.
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Pytho
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +Python 3.7 -Python 3.5
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset dd42cb71f2cb02f3a32f016137b12a146bc0d0e2 by Gregory P. Smith
(Anders Lorentsen) in branch 'master':
bpo-31961: subprocess now accepts path-like args (GH-4329)
https://github.com/python/cpython/commit/dd42cb71f2cb02f3a32f016137b12a
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
versions: -Python 3.6, Python 3.8
___
Python tracker
<https://bugs.python.org/issue31961>
___
_
Gregory P. Smith added the comment:
Thanks for the PR! I accepted it as this makes sense as a feature.
pathlib all the things!
I think the code be polished up a bit to not rely on catching TypeError but
this gets the feature in before the 3.7 feature freeze (just). If further
changes
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue20104>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
likely. i don't have an android build, please reopen if there are still
android posix_spawn related build issues.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
Change by Gregory P. Smith :
--
assignee: serhiy.storchaka -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 066df4fd454d6ff9be66e80b2a65995b10af174f by Gregory P. Smith
(John Jolly) in branch 'master':
bpo-22908: Add seek and tell functionality to ZipExtFile (GH-4966)
https://github.com/python/cpython/commit/066df4fd454d6ff9be66e80b2a6599
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +Python 3.7 -Python 3.5
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
did this get discussed on distutils-sig? It's a trivial change (for the POSIX
only PR) and would be neat to go through one of the 3.7 beta cycles to see if
anything serious an unexpected is likely to come up for a
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith, twouters
___
Python tracker
<https://bugs.python.org/issue27987>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith, twouters
___
Python tracker
<https://bugs.python.org/issue31912>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
Interesting use case Josh. I don't know of a good way to deal with
non-extension-module Python API using .so files. I like your extension hack,
but what is the problem with having the version embedded in the .so
Gregory P. Smith added the comment:
I would not remove this. It is a new feature, leave it in for 3.7.
The style issues and missing error checks are easy to address. We're at
3.7beta1 stage, it is normal to have issues to be cleaned up in a beta re
New submission from Gregory P. Smith :
This has been true since Python 1.x. getpass.getuser() is documented as
"raising an exception" but doesn't specify what exception.
On Windows when the environment variables it looks at are not set, an
ImportError (!) escapes due to "
Change by Gregory P. Smith :
--
stage: resolved -> needs patch
___
Python tracker
<https://bugs.python.org/issue31356>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
The idea which this issue represents is not rejected. It is a good one, we
found a need for it during the dev sprint last September.
--
priority: release blocker -> normal
resolution: rejected ->
status: closed -> open
versions: +P
Gregory P. Smith added the comment:
Nick and Raymond: do you remember what our original motivating use cases were
for this idea during the sprint?
--
___
Python tracker
<https://bugs.python.org/issue31
Gregory P. Smith added the comment:
Don't revert something just because you found a bug, we can fix it. fwiw, the
PR passed appveyor's Windows run:
https://ci.appveyor.com/project/python/cpython/build/3.7build11551
So if there's a bug, we're missing some k
Gregory P. Smith added the comment:
got any pointers to those? I want to familiarize myself with existing
arguments for/against such a feature in subprocess to decide.
--
___
Python tracker
<https://bugs.python.org/issue31
Gregory P. Smith added the comment:
I agree with both of you at this point.
TODO: Revert the PR and backport that to the 3.7 branch (i'll take care of it)
--
resolution: fixed ->
stage: resolved -> needs patch
___
Python trac
Change by Gregory P. Smith :
--
nosy: +ned.deily
priority: normal -> release blocker
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue32777>
___
___
Python-
Gregory P. Smith added the comment:
out of curiosity, did you actually diagnose a process deadlocked due to this or
was it noted via code inspection?
this issue has been around since 3.4 and the file descriptor inheritance
changes from the looks of things
2201 - 2300 of 3453 matches
Mail list logo
