Change by Gregory P. Smith :
--
pull_requests: +15712
pull_request: https://github.com/python/cpython/pull/16091
___
Python tracker
<https://bugs.python.org/issue36
Gregory P. Smith added the comment:
as discussed, not pushing this back into 3.7 as we aren't hearing users call
this a problem.
--
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/is
Gregory P. Smith added the comment:
New changeset 995b5d38e7cc24cac3de8dfd516115f86b0bcf80 by Gregory P. Smith
(Christian Heimes) in branch 'master':
bpo-38153: Normalize hashlib algorithm names (GH-16083)
https://github.com/python/cpython/commit/995b5d38e7cc24cac3de8dfd516115
Change by Gregory P. Smith :
--
pull_requests: +15726
pull_request: https://github.com/python/cpython/pull/16108
___
Python tracker
<https://bugs.python.org/issue34
Change by Gregory P. Smith :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue34706>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue34706>
___
___
Python-
Gregory P. Smith added the comment:
New changeset 5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586 by Gregory P. Smith in
branch 'master':
bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108)
https://github.com/python/cpython/commit/5b9ff7a0dcb16d6f5c3cd4f1f52e0c
Gregory P. Smith added the comment:
While I don't like how that get_small_int macro is defined...
and I don't like that Py_UNREACHABLE() was usable as an expression in the
past...
it is probably best to just revert 3ab61473ba7f3dca32d779ec2766a4faa0657923.
The choice to use a macr
Gregory P. Smith added the comment:
What's needed here is a Decision. (release managers and steering councils make
those)
IMNSHO, this regression is intentional and does not feel like a bug.
The Python HTTP APIs were never designed with an explicit intent to allow
violations o
Gregory P. Smith added the comment:
All bug fixes are behavior changes. Any broken behavior can be relied upon by
someone.
So far the only ones who have popped up with this change as being a problem is
one project's test suite where the behavior was used by a test because it
Gregory P. Smith added the comment:
> I think this is a false dichotomy; in
> https://bugs.python.org/issue36274#msg351834 Jason proposed a few
> alternatives that allow for a secure and obvious default API while adding a
> new, explicitly unsafe API.
I'm not against tha
Gregory P. Smith added the comment:
i don't have context for what test was needed where anymore, but
https://github.com/python/cpython/pull/12704 removed the
_at_fork_acquire_release_weakset.
--
resolution: -> out of date
stage: -> resolved
status: ope
Gregory P. Smith added the comment:
New changeset 2180f6b058effbf49ec819f7cedbe76ddd4b700c by Gregory P. Smith
(Samuel Freilich) in branch 'master':
bpo-36871: Avoid duplicated 'Actual:' in assertion message (GH-16361)
https://github.com/p
Gregory P. Smith added the comment:
The test probably has a fragile regex. I don't spend time with gdb things much
myself.
--
___
Python tracker
<https://bugs.python.org/is
Change by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38239>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
pull_requests: +15954
pull_request: https://github.com/python/cpython/pull/16374
___
Python tracker
<https://bugs.python.org/issue36
Gregory P. Smith added the comment:
New changeset 4042e1afd252858de53e2b79d946a51a0182d1ba by Gregory P. Smith in
branch '3.7':
[3.7] bpo-36871: Handle spec errors in assert_has_calls (GH-16364) (GH-16374)
https://github.com/python/cpython/commit/4042e1afd252858de53e2b79d946a5
Gregory P. Smith added the comment:
i believe the issues surfaces in this are fixed at this point.
of note, my mock_call_test.py example now passes.
i'm not entirely sure that it _should_ pass though, but that depends on what we
want create_autospec of a class to do. should that autos
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38269>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
It appears that something in the buildbot configuration (typo?) has changed
which caused an entire new set of directories for the builder to be created:
@clang-ubsan:/var/lib/buildbot/clang-ubsan$ ls -al
total 68056
drwxr-xr-x 14 buildbot buildbot 4096
Gregory P. Smith added the comment:
https://github.com/python/buildmaster-config/pull/108 is to blame.
--
___
Python tracker
<https://bugs.python.org/issue38
Gregory P. Smith added the comment:
I'm not going to spend time manually deleting the unused build directories
until the typo in the new buildsuffix that caused the disk to fill up is fixed.
https://github.com/python/buildmaster-config/pull/111
I don't even understand why the b
Gregory P. Smith added the comment:
>From a yet another one of a plethora of reasons to hate buildbot point of
>view... A _log message_ saying "i'm not using this anymore, you can delete
>it" is infinitely worse than just going ahead and automatically deleting it.
Gregory P. Smith added the comment:
Let me know when pr 111 is deployed on the build master so I can log in and
cleanup the current typo names.
otherwise, things are probably running fine for the moment.
--
___
Python tracker
<ht
Change by Gregory P. Smith :
--
versions: +Python 3.9 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue37958>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
Regardless, since things have already shipped in stable releases, there is a
release that code _will_ encounter somewhere that does validate data but does
not support overruling that behavior. so i'm not sure if it actually matters
to have this in 3
Gregory P. Smith added the comment:
As a note on the general pattern, a user at work diagnosed a ^C problem in
their code when running on 2.7 to be due to Queue.get's
acquire()
try:
...
finally:
release()
Pattern, with the KeyboardInterrupt triggering after acquire() but before the
Gregory P. Smith added the comment:
New changeset c8165036f374cd2ee64d4314eeb2514f7acb5026 by Gregory P. Smith (T.
Wouters) in branch 'master':
bpo-38115: Deal with invalid bytecode offsets in lnotab (GH-16079)
https://github.com/python/cpython/commit/c8165036f374cd2ee64d4314eeb251
Change by Gregory P. Smith :
--
pull_requests: +16049
pull_request: https://github.com/python/cpython/pull/16464
___
Python tracker
<https://bugs.python.org/issue38
Gregory P. Smith added the comment:
New changeset c5a7e0ce194c0eafe82eb3e431881012398e7d46 by Gregory P. Smith
(Pascal Chambon) in branch 'master':
bpo-37408: Precise that Tarfile "format" argument only concerns writing.
(GH-14389)
https://github.com/p
Change by Gregory P. Smith :
--
assignee: -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org/i
Change by Gregory P. Smith :
--
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue37408>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 36c6fa968016a46a39c3cdbd0a17ea5490dfa343 by Gregory P. Smith in
branch '3.8':
bpo-38115: Deal with invalid bytecode offsets in lnotab (GH-16079) (GH-16464)
https://github.com/python/cpython/commit/36c6fa968016a46a39c3cdbd0a17ea
Gregory P. Smith added the comment:
thanks Thomas!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
versions: -Python 3.6, Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38216>
___
___
Pytho
Gregory P. Smith added the comment:
I'd imagine an equivalent of the 3.6 PR would work for 3.5.
Someone should look at how to do similar in 2.7 _if_ the project(s) that
complained about the problem rely on such behavior in their last 2.7 compatible
rel
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38326>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
preexec_fn is fundamentally unsupportable.
what code is using it, there should be a way not to rely on that.
--
___
Python tracker
<https://bugs.python.org/issue37
New submission from Gregory P. Smith :
Another use of the deprecated unsafe preexec_fn was to call os.umask in the
child prior to exec.
As seen in https://github.com/freeipa/freeipa/pull/3769 (see the code in there).
We should add an explicit feature for this to avoid people's desir
Gregory P. Smith added the comment:
We don't have to for all possible things, doing this just reduced friction for
existing uses. In this case, calling umask in our child ourselves would be
easy to support. (easier than the more important setuid/sid/gid/groups-ish
stuff that recently
Gregory P. Smith added the comment:
We should not provide such an "run arbitrary python code before execing the
ultimate child" feature in the standard library.
It is complicated, and assumes you have an ability to execute a new interpreter
with its own slow startup time as an in
New submission from Gregory P. Smith :
subprocess's preexec_fn feature needs to enter PendingDeprecationWarning state
in 3.9, to become a DeprecationWarning in 3.10, with a goal of removing it in
3.11.
Rationale: We now live in a world full of threads, it is entirely unsafe to
call
Gregory P. Smith added the comment:
preexec_fn has been mentally and advisability deprecated for years. :)
I'll mark it officially with pending deprecation in 3.9 destined to be removed
in 3.11. tracking that in its own rollup issue
https://bugs.python.org/issue38435
As far as posix_
Gregory P. Smith added the comment:
With task specific arguments. cwd, start_new_session, group, extra_groups,
user, etc..
We cannot provide a general do everything replacement and should not try.
It not possible.
--
___
Python tracker
<ht
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38417>
___
___
Python-bugs-list mailing list
Un
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +16306
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16726
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset f3751efb5c8b53b37efbbf75d9422c1d11c01646 by Gregory P. Smith in
branch 'master':
bpo-38417: Add umask support to subprocess (GH-16726)
https://github.com/python/cpython/commit/f3751efb5c8b53b37efbbf75d9422c
Gregory P. Smith added the comment:
Now to see if the more esoteric config buildbots find any platform issues to
address...
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracke
New submission from Gregory P. Smith :
test_subprocess is one of our long running tests, this slows down CI and
buildbots. There is room for improvement in its total execution time.
Use this issue as a rollup issue for any such work. we need to keep it
reliable, just focus on reducing
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +16315
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16736
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 67b93f80c764bca01c81c989d74a99df208bea4d by Gregory P. Smith in
branch 'master':
bpo-38456: Use /bin/true in test_subprocess (GH-16736)
https://github.com/python/cpython/commit/67b93f80c764bca01c81c989d74a99
Change by Gregory P. Smith :
--
pull_requests: +16316
pull_request: https://github.com/python/cpython/pull/16737
___
Python tracker
<https://bugs.python.org/issue38
Change by Gregory P. Smith :
--
type: -> behavior
___
Python tracker
<https://bugs.python.org/issue38473>
___
___
Python-bugs-list mailing list
Unsubscrib
Gregory P. Smith added the comment:
New changeset 4f0587f161786318cdfa22c42459676fa42aacb6 by Gregory P. Smith in
branch '3.8':
[3.8] bpo-38456: Use /bin/true in test_subprocess (GH-16737)
https://github.com/python/cpython/commit/4f0587f161786318cdfa22c4245967
Gregory P. Smith added the comment:
I assume the CI systems are shared and potentially noisy. It should be easier
to look at some logs from slower buildbots. but sadly test_subprocess has
fallen off the list of "10 slowest tests" that timing info is supplied for.
concurre
Change by Gregory P. Smith :
--
pull_requests: +16362
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/16805
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
Thanks for the feedback. Better late than never. :)
A default algorithm is a bad thing when it comes to authentication. Explicit
is better than implicit. A default regularly becomes obsolete as math and
cryptanalysis methods move forward and need to be
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue33604>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
BTW, if you want the type annotation that'd be used for this, 3.8 effectively
removes the Optional[] from the one listed in:
https://github.com/python/typeshed/blob/master/stdlib/2and3/hmac.py
Gregory P. Smith added the comment:
If I compile my own 3.7.5 and 3.8.0 both with --enable-optimizations, I am
unable to reproduce this.
greg@zoonaut:~/sandbox/python/cpython/lh$ ../b37/python permutations2x2
--max_depth 6 | egrep "^# Total_Time"
# Total_Time: 75.92
greg@zoonaut
Change by Gregory P. Smith :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset f33c57d5c780da1500619f548585792bb5b750ee by Gregory P. Smith in
branch 'master':
bpo-33604: Raise TypeError on missing hmac arg. (GH-16805)
https://github.com/python/cpython/commit/f33c57d5c780da1500619f54858579
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue34776>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Can you please open a separate issue for CVE-2019-18348? It is easier to track
that way.
(META: In general I think the CVE process is being abused and that these really
did not deserve that treatment. https://lwn.net/Articles/801157/ is good
reading
Gregory P. Smith added the comment:
can this be closed?
--
nosy: +gregory.p.smith
status: pending -> open
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue30618>
___
___
Python-
Gregory P. Smith added the comment:
Thanks Girts!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
Please revert. An absolute path changes semantics in many real world
situations (altering symlink traversals, etc). People expect the current
sys.argv[0] behavior which is "similar to C argv" and matches what was passed
on the interpreter co
Change by Gregory P. Smith :
--
versions: +Python 3.9 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue36541>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
versions: +Python 3.9 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue33348>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> lib2to3 doesn't parse f(*[] or [])
versions: +Python 3.8, Python 3.9 -Python 3.6
___
Python tracker
<htt
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue33348>
___
___
Python-
Change by Gregory P. Smith :
--
versions: +Python 2.7
___
Python tracker
<https://bugs.python.org/issue33348>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue36541>
___
___
Python-
Change by Gregory P. Smith :
--
title: Make lib2to3 grammar more closely match Python -> Make lib2to3 grammar
better match Python, support the := walrus
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
There isn't really much we can do without a reasonable repeatable way to
reproduce the problem.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/is
Gregory P. Smith added the comment:
I think sys.argv[0] is the important one as program logic often tends to use
that as an input.
I'm honestly unsure of if this will be as much of a problem for .co_filename or
sys.path[0].
--
___
Python tr
Gregory P. Smith added the comment:
(read that as: feel free to keep the behavior for co_filename and path[0] and
lets see what happens :)
--
___
Python tracker
<https://bugs.python.org/issue20
Gregory P. Smith added the comment:
I'm marking this fixed, technically it still exists in 2.7. it'll be up to
someone who cares about making a change to 2.7 to make a PR to go in there for
the final release. It has existed so long, I doubt it matters there.
--
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38576>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
stage: -> needs patch
___
Python tracker
<https://bugs.python.org/issue38576>
___
___
Python-bugs-list mailing list
Unsubscrib
New submission from Gregory P. Smith :
Creating an enum subclass (ie: defining an enum) is slow. This dramatically
impacts startup time of Python programs that import a bunch of potentially
needed constant definitions at startup before any proper code executes.
How slow? So slow that a
New submission from Gregory P. Smith :
We started down this path in https://bugs.python.org/issue31961 but had to
revert part of that before 3.7 as the implementation was incomplete making it
inconsistent across platforms. https://github.com/python/cpython/pull/4329.
Specifically accepting
New submission from Gregory P. Smith :
importlib is full of str.format calls, modernizing it to use f-strings is a
slight performance win and much more readable.
--
assignee: gregory.p.smith
messages: 356005
nosy: gregory.p.smith
priority: normal
severity: normal
status: open
title
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +16569
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17058
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
Another option not using a new letter: A triple-backtick token.
def foo():
value = ```this is a
long multi line string i don't want indented.
```
A discuss thread was started so I reconnected it with this issue. See
Gregory P. Smith added the comment:
.cleandoc is _probably_ more of what people want than .dedent? I hadn't
bothered to even try to pick between the two yet.
--
___
Python tracker
<https://bugs.python.org/is
Gregory P. Smith added the comment:
New changeset b4fc44bb2d209182390b4f9fdf074a46b0165a2f by Chris Griffith in
branch 'master':
bpo-43423 Fix IndexError in subprocess _communicate function (GH-24777)
https://github.com/python/cpython/commit/b4fc44bb2d209182390b4f9fdf074a
Gregory P. Smith added the comment:
The bug is fixed, Thanks Chris! There was a refactoring noted as being nice in
my comments on the primary main branch PR that would be nice to have. But
isn't critical. If you want to make a PR for that, just reuse this bpo-43423
issue number on t
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue43086>
___
___
Python-
Gregory P. Smith added the comment:
Compiling everything (your entire OS and libraries and CPython itself) with
compiler mitigations is recommended. I agree, there is nothing specific we
need to do within CPython itself.
--
nosy: +gregory.p.smith
resolution: -> not a bug
st
Gregory P. Smith added the comment:
amaajemyfren is correct (and thanks for the pointers to the original issue and
discussion). The warning remains out of caution.
--
nosy: +gregory.p.smith
resolution: -> not a bug
stage: -> resolved
status: open -&g
Gregory P. Smith added the comment:
yes, this was fixed.
--
nosy: +gregory.p.smith
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
CPython itself doesn't have guaranteed way to do this kind of thing. There is
no tracking of which types clear memory let alone which API calls may make
copies of data in places within their C that are not explicitly cleared
afterwards. We do not h
Gregory P. Smith added the comment:
Indeed, the `host` on that line there should just be ignored with the IP
address of the original data connection used in its place.
Your https://hackerone.com/reports/1040166 link provides plenty of information
and likes to prior art mitigations other ftp
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +23603
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/24838
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
I'm not interested in chasing down a CVE for this myself. If anyone wants to
jump through the hoops to obtain one, the text used for curl in the hackerone
link is likely a good guide.
My PR includes a way for people to opt-out of the secure behavior
Change by Gregory P. Smith :
--
title: ftplib use host from PASV response -> ftplib should not use the host
from the PASV response
___
Python tracker
<https://bugs.python.org/issu
1001 - 1100 of 3452 matches
Mail list logo
