[issue44733] Feature request: maxtasksperchild for ProcessPoolExecutor

2022-01-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: [bpo-46464](https://bugs.python.org/issue46464) describes a deadlock that the pre-requisite for this feature causes. Spawning new children directly via fork() is impossible once a thread in the parent process has been started and

[issue44733] Feature request: maxtasksperchild for ProcessPoolExecutor

2022-01-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: If we want this feature to stay in, it needs an implementation that does not rely on a multithreaded processing calling fork(). I'm going to have to revert the existing implementation for bpo-46464. -- stage: resolved -> needs patch status

[issue44733] Feature request: maxtasksperchild for ProcessPoolExecutor

2022-01-23 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith resolution: fixed -> ___ Python tracker <https://bugs.python.org/issue44733> ___ ___ Pyth

[issue46464] concurrent.futures.ProcessPoolExecutor can deadlock when tcmalloc is used

2022-01-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: https://bugs.python.org/issue44733 for 3.11 attempts to build upon the dynamic spawning ability and will need reverting unless a non-thread+fork implementation is provided. -- ___ Python tracker <ht

[issue46464] concurrent.futures.ProcessPoolExecutor can deadlock when tcmalloc is used

2022-01-24 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +29029 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/30847 ___ Python tracker <https://bugs.python.org/issu

[issue46503] assertion failure in Parser/string_parser.c

2022-01-24 Thread Gregory P. Smith
New submission from Gregory P. Smith : ``` >>> v = r"""f'\N '""" >>> import ast >>> ast.literal_eval(v) python: ../gpshead/Parser/string_parser.c:487: fstring_find_literal: Assertion `s == end || *s == '{' || *

[issue46503] assertion failure in Parser/string_parser.c

2022-01-24 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> pablogsal ___ Python tracker <https://bugs.python.org/issue46503> ___ ___ Python-bugs-list mailing list Un

[issue11322] encoding package's normalize_encoding() function is too slow

2022-01-24 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue11322> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46508] codec name acceptance became way too lenient in 3.9

2022-01-24 Thread Gregory P. Smith
New submission from Gregory P. Smith : in 3.8 this was not a valid codec name: "เ_เ_เ_iDnA" in 3.9 it gets treated as idna and triggers the punycode decoder when passed to bytes.decode(codec). Discovered by oss-fuzz. _Likely_ a consequence of https://bugs.python.org/issue

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2022-01-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: https://bugs.python.org/issue46508 filed to track fixing the acceptance and use of garbage codec values regression that this caused. -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2022-01-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: (note: this might not be the true cause of that issue; though it sounds potentially related - I haven't investigated far enough yet) -- ___ Python tracker <https://bugs.python.org/is

[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.

2022-01-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: note that Bodo's own followup issue about the breaking change for python-iconv was filed as https://bugs.python.org/issue44723 -- ___ Python tracker <https://bugs.python.org/is

[issue44723] Codec name normalization breaks custom codecs

2022-01-24 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue44723> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32958] socket module calls with long host names can fail with idna codec error

2022-01-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: ablack: the basic auth username:password@ part of the string is not part of a hostname. What code are you seeing that is trying to send that to a name resolver rather than stripping the obviously private info up through the @ sign? -- nosy

[issue46508] codec name acceptance became way too lenient in 3.9

2022-01-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: while figuring this issue out, it may also make sense to address https://bugs.python.org/issue44723 as well. -- ___ Python tracker <https://bugs.python.org/issue46

[issue46464] concurrent.futures.ProcessPoolExecutor can deadlock when tcmalloc is used

2022-01-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: It sounds like we need to introspect the mp_context= passed to ProcessPoolExecutor (and it's default when None) to raise an error when max_tasks_per_child is incompatible with it. -- ___ Python tracker &

[issue46464] concurrent.futures.ProcessPoolExecutor can deadlock when tcmalloc is used

2022-01-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: and similarly, the dynamic spawning could be kept when the mp_context is spawn (and possibly forkserver). -- ___ Python tracker <https://bugs.python.org/issue46

[issue44733] Feature request: maxtasksperchild for ProcessPoolExecutor

2022-01-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: from discussion on the other bug it looks like we should have a way to keep this; we just need to not allow it when the mp_context to be used is the 'fork' one. -- ___ Python tracker <https://bu

[issue44733] Feature request: maxtasksperchild for ProcessPoolExecutor

2022-01-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: As this is a new feature, it would also be reasonable to have specifying max_tasks_per_child without explicitly specifying a mp_context default to a safe mp_context. -- ___ Python tracker <ht

[issue45162] Remove old deprecated unittest features

2022-01-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: Per https://mail.python.org/archives/list/python-...@python.org/thread/GJTREADEXYAETECE5JDTPYWK4WMTKYGR/ we want to revert this change for 3.11 as it causes adoption pain for little benefit. To determine if we should proceed with this in 3.12 or future

[issue45173] Remove configparser deprecations

2022-01-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: Per https://mail.python.org/archives/list/python-...@python.org/thread/GJTREADEXYAETECE5JDTPYWK4WMTKYGR/ we want to revert https://github.com/python/cpython/commit/1fc41ae8709e20d741bd86c2345173688a5e84b0 for 3.11 to avoid causing pain. per that thread

[issue45162] Remove old deprecated unittest features

2022-01-26 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue45162> ___ ___ Python-bugs-list mailing list Un

[issue45162] Remove old deprecated unittest features

2022-01-26 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +29114 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/30935 ___ Python tracker <https://bugs.python.org/issu

[issue45162] Remove old deprecated unittest features

2022-01-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset b50322d20337ca468f2070eedb051a16ee1eba94 by Gregory P. Smith in branch 'main': bpo-45162: Revert "Remove many old deprecated unittest features" (GH-30935) https://github.com/python/cpython/commit/b50322d20337ca468f20

[issue45162] Remove old deprecated unittest features

2022-01-26 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: gregory.p.smith -> ___ Python tracker <https://bugs.python.org/issue45162> ___ ___ Python-bugs-list mailing list Un

[issue42982] Update suggested number of iterations for pbkdf2_hmac()

2022-01-27 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 897ce9018775bcd679fb49aa17258f8f6e818e23 by Illia Volochii in branch 'main': bpo-42982: Improve the text on suggested number of iterations of PBKDF2 (GH-24276) https://github.com/python/cpython/commit/897ce9018775bcd679fb49aa17258f

[issue42982] Update suggested number of iterations for pbkdf2_hmac()

2022-01-27 Thread Gregory P. Smith
Gregory P. Smith added the comment: I reworked the PR and went with less specific text and linking to the NIST 800 132 appendix as guidance on how people should determine what is right for them. there is no one right number. it is application specific. thanks for everyone's valuable

[issue46166] Get "self" args or non-null co_varnames from frame object with C-API

2022-01-27 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +3.11regression nosy: +gregory.p.smith priority: normal -> high ___ Python tracker <https://bugs.python.org/issu

[issue42982] Update suggested number of iterations for pbkdf2_hmac()

2022-01-27 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +29145 pull_request: https://github.com/python/cpython/pull/30966 ___ Python tracker <https://bugs.python.org/issue42

[issue46557] Logging captured warnings with a format string unnecessarily groups warnings together

2022-01-27 Thread Michael P. Nitowski
New submission from Michael P. Nitowski : Systems that aggregate logs like Sentry will group all captured warnings under the same event which makes it difficult to assess common warnings -- components: Library (Lib) messages: 411947 nosy: mnito priority: normal severity: normal status

[issue46557] Logging captured warnings with a format string unnecessarily groups warnings together

2022-01-27 Thread Michael P. Nitowski
Change by Michael P. Nitowski : -- keywords: +patch pull_requests: +29154 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30975 ___ Python tracker <https://bugs.python.org/issu

[issue46557] Logging captured warnings with a format string unnecessarily groups warnings together

2022-01-27 Thread Michael P. Nitowski
Michael P. Nitowski added the comment: Of course, here's an example script to reproduce: ``` import logging import warnings import sentry_sdk from sentry_sdk.integrations.logging import LoggingIntegration logging.captureWarnings(True) sentry_logging = LoggingIntegration(

[issue46548] macOS installers cannot be signed on Monterey

2022-01-27 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +ned.deily ___ Python tracker <https://bugs.python.org/issue46548> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40746] test_gdb failing on 32-bit armv7l when built with GCC -Og: Cannot access memory at address 0xfffffedc

2022-01-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: I manually tested this on 3.11 main and it appears to be working. -- resolution: -> works for me stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46576] test_peg_generator is extremely slow

2022-01-29 Thread Gregory P. Smith
New submission from Gregory P. Smith : test_peg_generator is an extremely slow test. This bug tracks any changes to reduce its runtime and test latency. -- components: Tests messages: 412104 nosy: gregory.p.smith priority: normal severity: normal status: open title

[issue46576] test_peg_generator is extremely slow

2022-01-29 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +29194 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31015 ___ Python tracker <https://bugs.python.org/issu

[issue46524] test_peg_generator takes 8 minutes on Windows

2022-01-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: re: slow tests in the first half of the list. the same total amount of time is going to be spent regardless. In our test suite on a modern fast 16 thread system, all but 10 tests are completed in parallel within the first 30 seconds. The remaining ~10

[issue46524] test_peg_generator takes 8 minutes on Windows

2022-01-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: If a decent parallelism CI systems are not available from github (they seem stuck at 2-3 threads per https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners), an alternative approach could be to shard across multiple

[issue46524] test_peg_generator takes 8 minutes on Windows

2022-01-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +29197 pull_request: https://github.com/python/cpython/pull/31015 ___ Python tracker <https://bugs.python.org/issue46

[issue45173] Remove configparser deprecations

2022-02-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset e8659b47dece5a272111c0af5e340c364a9f807b by Hugo van Kemenade in branch 'main': bpo-45173: Keep configparser deprecations until Python 3.12 (GH-30952) https://github.com/python/cpython/commit/e8659b47dece5a272111c0af5e340c

[issue46524] test_peg_generator takes 8 minutes on Windows

2022-02-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 164a017e13ee96bd1ea1ae79f5ac9e25fe83994e by Gregory P. Smith in branch 'main': bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (#31015) https://github.com/python/cpyt

[issue46576] test_peg_generator is extremely slow

2022-02-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 164a017e13ee96bd1ea1ae79f5ac9e25fe83994e by Gregory P. Smith in branch 'main': bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (#31015) https://github.com/python/cpyt

[issue46524] test_peg_generator takes 8 minutes on Windows

2022-02-02 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +29274 pull_request: https://github.com/python/cpython/pull/31089 ___ Python tracker <https://bugs.python.org/issue46

[issue46576] test_peg_generator is extremely slow

2022-02-02 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +29273 pull_request: https://github.com/python/cpython/pull/31089 ___ Python tracker <https://bugs.python.org/issue46

[issue46524] test_peg_generator takes 8 minutes on Windows

2022-02-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset f5ebec4d3e1199ec38b88920cfde8e460e5120dd by Gregory P. Smith in branch '3.10': [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089) https://github.com/python/cpyt

[issue46576] test_peg_generator is extremely slow

2022-02-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset f5ebec4d3e1199ec38b88920cfde8e460e5120dd by Gregory P. Smith in branch '3.10': [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089) https://github.com/python/cpyt

[issue45629] Tools/freeze needs tests in the test suite.

2022-02-02 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith nosy_count: 2.0 -> 3.0 pull_requests: +29280 pull_request: https://github.com/python/cpython/pull/31094 ___ Python tracker <https://bugs.python.org/issu

[issue45629] Tools/freeze needs tests in the test suite.

2022-02-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 8726067ace98a27557e9fdf1a8e1c509c37cfcfc by Gregory P. Smith in branch 'main': bpo-45629: Improve test.support.skip_if_buildbot (GH-31094) https://github.com/python/cpython/commit/8726067ace98a27557e9fdf1a8e1c5

[issue46576] test_peg_generator is extremely slow

2022-02-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: for my purposes those PRs make it reasonable, even though it remains one of our slowest tests. we can reopen/reuse this issue for any further test_peg_generator performance improvements as needed. -- assignee: -> gregory.p.smith resolut

[issue46524] test_peg_generator takes 8 minutes on Windows

2022-02-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: test_peg_generator is significantly less of the long tail on optimized builds now. CI extremely noisy performance wise (times vary by 2-3x without any differences anways) so I can't easily judge if this made a notable difference in windows CI la

[issue46524] test_peg_generator takes 8 minutes on Windows

2022-02-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks to Kumar for contributing Windows compiler flags side of this (the point of this issue). -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracke

[issue33178] Add support for BigEndianUnion and LittleEndianUnion in ctypes

2022-02-03 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith versions: +Python 3.11 -Python 2.7, Python 3.6 ___ Python tracker <https://bugs.python.org/issu

[issue46636] Bugs of 2to3 on built-in function or types(classes)

2022-02-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: lib2to3 is going away per https://bugs.python.org/issue40360 but it is behaving as intended above, it does not understand logic. it was only ever intended to maybe work on python 2-only code. not python 2-and-3 compatible code. -- nosy

[issue46639] Ceil division with math.ceildiv

2022-02-04 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +mark.dickinson ___ Python tracker <https://bugs.python.org/issue46639> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42353] Proposal: re.prefixmatch method (alias for re.match)

2022-02-04 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith versions: +Python 3.11 -Python 3.10 ___ Python tracker <https://bugs.python.org/issue42353> ___ _

[issue42353] Proposal: re.prefixmatch method (alias for re.match)

2022-02-04 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +29314 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/31137 ___ Python tracker <https://bugs.python.org/issu

[issue42353] Proposal: re.prefixmatch method (alias for re.match)

2022-02-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: What do other APIs in widely used languages do with regex terminology? We appear to be the only popular language who anchors to the start of a string with an API named "match". libpcre C: uses "match" to mean what we call "search

[issue46648] `test.test_urllib2.MiscTests.test_issue16464` flaky due to external connection

2022-02-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: The merged PRs disable the test without anything tracking fixing or re-re-enabling it. Reopening & retitling this issue. This specific test does not need to use an external server. That has nothing to do with what the purposes of the test is which is

[issue24904] Provide a way for potentially long runtime difflib algorithms to be aborted by the caller (and report progress?)

2022-02-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: The way I'd go about this is to support some form of periodic checkpoint in the algorithm where it checks in with code supplied by the difflib user. Traditionally that'd have been via callbacks, there might be an async style way to express that

[issue20342] Endianness not detected correctly due to AC_RUN_IFELSE macros

2022-02-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: any idea if this is still relevant? -- components: +Cross-Build nosy: +Alex.Willmer, gregory.p.smith ___ Python tracker <https://bugs.python.org/issue20

[issue46648] `test.test_urllib2.MiscTests.test_issue16464` flaky due to external connection

2022-02-07 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> sobolevn ___ Python tracker <https://bugs.python.org/issue46648> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue20342] Endianness not detected correctly due to AC_RUN_IFELSE macros

2022-02-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'll leave it open, nothing about this should be ppc64 vs ppc64el specific. Our cross compilation story has historically been not great. Building for a target of one endianness from a build host of other endianness... sounds like exactly one of

[issue46784] Duplicated symbols when linking embedded Python with libexpat

2022-02-17 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue46784> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46793] expose expat XML billion laughs attack mitigation APIs

2022-02-18 Thread Gregory P. Smith
New submission from Gregory P. Smith : Quoting from https://github.com/python/cpython/pull/31397#issuecomment-1044796561 """ XML_SetBillionLaughsAttackProtectionActivationThreshold XML_SetBillionLaughsAttackProtectionMaximumAmplification I still hope that someone can

[issue46784] Duplicated symbols when linking embedded Python with libexpat

2022-02-18 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +29557 pull_request: https://github.com/python/cpython/pull/31420 ___ Python tracker <https://bugs.python.org/issue46

[issue46200] Discourage logging f-strings due to security considerations

2022-02-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: A new system of logging APIs has been on several of our (core dev and otherwise) minds ever since f-strings were introduced. For this specific issue, agreed that documentation is key. The old logging APIs cannot change. And practically preventing

[issue46784] Duplicated symbols when linking embedded Python with libexpat

2022-02-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset e05e3d20d309603010f2c1194e612f894ad8a985 by Gregory P. Smith in branch '3.10': [3.10] bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) (GH-31420) https://github.com/python/cpyt

[issue46784] Duplicated symbols when linking embedded Python with libexpat

2022-02-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: PRs for 3.7 and 3.8 remain up to release blockers. -- components: +Build resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46784] Duplicated symbols when linking embedded Python with libexpat

2022-02-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: err "release managers" same thing right? ;) -- ___ Python tracker <https://bugs.python.org/issue46784> ___ ___

[issue45373] ./configure --enable-optimizations should enable LTO

2022-03-01 Thread Gregory P. Smith
Gregory P. Smith added the comment: FWIW I agree that we should try adding LTO to --enable-optimizations now. -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue45

[issue46896] add support for watching writes to selected dictionaries

2022-03-01 Thread Gregory P. Smith
Gregory P. Smith added the comment: At first quick glance, this makes sense and the API looks reasonable. Question: what happens on interpreter shutdown? Shutdown obviously finalized and clears out most all dicts. I guess the C callback simply gets called for each of these? That makes

[issue46896] add support for watching writes to selected dictionaries

2022-03-03 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +Mark.Shannon ___ Python tracker <https://bugs.python.org/issue46896> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46896] add support for watching writes to selected dictionaries

2022-03-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: Per interpreter seems best. If someone using this feature writes a buggy implementation of a callback that doesn't chain reliably, that is a bug in their code and all of the fallout from that is "just" a bug to be fixed in said code. Think

[issue38738] Fix formatting of True and False

2022-03-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 46a116c1c9f6b60a3d35ab9a419f8eee5de2542e by Géry Ogam in branch 'main': bpo-38738: Fix formatting of True and False in the threading documentation (GH-31678) https://github.com/python/cpython/commit/46a116c1c9f6b60a3d35ab9a419f8e

[issue1007] [py3k] Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more directly)

2007-08-23 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- title: Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more directly) -> [py3k] Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more direc

[issue1007] [py3k] Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more directly)

2007-08-23 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- assignee: -> greg __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1007> __ ___ Python-bugs-list mailing list Uns

[issue1771381] bsddb can't use unicode keys

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: The BerkeleyDB library operates on bytes only. Unicode doesn't make sense as a key without converting it to a particular encoding first. Use the unicode object's encode() method if you need to use it as a database key or create a wrapper object o

[issue1725856] bsddb.btopen . del of record doesn't update index

2007-08-23 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- assignee: -> greg _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1725856> _ ___ Python-bugs-list mailing li

[issue533281] bsddb module needs iterators

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: this was marked 'open' and 'fixed' at the same time. that should be an invalid state. it was indeed fixed eons ago. -- nosy: +greg status: open -> closed Tracker <[EMAIL PROTECTED

[issue1725856] bsddb.btopen . del of record doesn't update index

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: This code deletes the item that the internal database cursor created by the db.first() call is pointing at. Then when db.first() is called again it tries to reuse the same cursor. Now to decide if thats the expected behavior or a real problem and how to fix

[issue1725856] bsddb.btopen . del of record doesn't update index

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: My first description wasn't quite accurate. What was happening is that the __delitem__(i) call by del was closing the existing cursor and saving the key it was pointing to and the first() and last() methods were creating a new cursor and trying to restor

[issue1725856] bsddb.btopen . del of record doesn't update index

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: Committed to HEAD as r57378 Committed to release25-maint as r57379 Committed to py3k as r57380 -- resolution: -> fixed status: pending -> closed _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue533281] bsddb185 module needs iterators

2007-08-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: Oops. You're right. This was referring to the legacy bsddb185 module in Modules/bsddbmodule.c. In 2.6 that is never built by default. I'm marking it as wont fix. -- resolution: fixed -> wont fix title: bsddb module needs iterator

[issue1007] [py3k] Fix dumbdbm, which fixes test_shelve (for me); instrument other tests so we catch this sooner (and more directly)

2007-08-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: looks like someone already committed the one liner dumbdbm latin-1 fix. But the meat of this patch is the unit test improvements. I had to fix test_whichdb to exclude dumbdbm as that has no file for whichdb to test. committed to py3k as r57419

[issue1583946] SSL "issuer" and "server" names cannot be parsed

2007-08-25 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- nosy: -greg _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1583946> _ ___ Python-bugs-list mailing list Unsubs

[issue1706815] socket.error exceptions not subclass of StandardError

2007-08-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: Does the existing python SSL implementation allow it to be used over something other than a socket? If so then yes that makes sense, but otherwise its best to leave its inheritance from socket.error so that code that works when handed a regular socket can

[issue1035] bytes buffer API needs to support PyBUF_LOCKDATA

2007-08-27 Thread Gregory P. Smith
New submission from Gregory P. Smith: I've converted _bsddb.c to use the py3k buffer API for all data and keys it takes as input. All tests now fail with this error: BufferError: Cannot make this object read-only. This presumably results from this call: PyObject_GetBuffer(obj,

[issue1036] py3k _bsddb.c patch to use the new buffer API

2007-08-27 Thread Gregory P. Smith
New submission from Gregory P. Smith: This is my svn diff of a py3k Modules/_bsddb.c converted to use the buffer API. I'm submitting it here as so it doesn't get misplaced as it currently won't work until bytes objects support PyBUF_LOCKDATA (a separate bug)

[issue1035] bytes buffer API needs to support PyBUF_LOCKDATA

2007-08-27 Thread Gregory P. Smith
Changes by Gregory P. Smith: -- priority: normal -> __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1035> __ ___ Python-bugs-list mailing list Uns

[issue1038] [py3k] pdb does not work in python 3000

2007-08-27 Thread Gregory P. Smith
New submission from Gregory P. Smith: The Lib/pdb.py debugger fails in the py3k branch. Traceback (most recent call last): File "/usr/local/gps/python/py3k/Lib/pdb.py", line 1247, in main pdb._runscript(mainpyfile) File "/usr/local/gps/python/py3k/Lib/pdb.py", line

[issue1036] py3k _bsddb.c patch to use the new buffer API

2007-08-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: committed to py3k branch using SIMPLE instead of LOCKDATA: r57610 -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue1038] [py3k] pdb does not work in python 3000

2007-08-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: I was running it by typing "./python Lib/pdb.py Lib/test_foo.py" __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1038> __ _

[issue1035] bytes buffer API needs to support PyBUF_LOCKDATA

2007-08-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: I sent an initial patch to the mailing list. Its too late to be ready for 3.0a1; I'll fix it up next week. -- assignee: -> gregory.p.smith __ Tracker <[EMAIL PROTECTED]> <http://bugs.pyt

[issue1189216] zipfile module and 2G boundary

2007-08-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: i'll take care of this. -- assignee: -> gregory.p.smith nosy: +gregory.p.smith _ Tracker <[EMAIL PROTECTED]> <http://bugs.python

[issue1060] zipfile cannot handle files larger than 2GB (inside archive)

2007-08-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: i'll take care of it. any more info in the interim will be appreciated. -- assignee: -> gregory.p.smith nosy: +gregory.p.smith __ Tracker <[EMAIL PROTECTED]> <http://bugs.pyt

[issue1003] zipfile password fails validation

2007-08-29 Thread Gregory P. Smith
Gregory P. Smith added the comment: can you provide a test zip file demonstrating the problem? -- assignee: -> gregory.p.smith nosy: +gregory.p.smith type: crash -> behavior __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue1112] Test debug assertion in bsddb test_1413192.py

2007-09-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: that looks good to me. fixed in: 2.6 trunk r58023 release25-maint r58024 py3k r58025 -- resolution: -> fixed status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue1706815] socket.error exceptions not subclass of StandardError

2007-09-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: socket.error now inherits from IOError as of trunk r58067: Change socket.error to inherit from IOError rather than being a stand alone class. This addresses the primary concern in http://bugs.python.org/issue1706815 python-dev discussion here: http

[issue1035] bytes buffer API needs to support read locking and/or PyBUF_LOCKDATA

2007-09-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: Attaching the most recent patch (minor update from the second one i sent to the python-3000 mailing list to initialize ob_readonly_exports = 0 in the appropriate places). Current mailing list discussion is pointing out that the name LOCKDATA means something

[issue1035] bytes buffer API needs to support read locking and/or PyBUF_LOCKDATA

2007-10-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: This bug will be taken care of by PEP 3137 http://python.org/dev/peps/pep-3137/ being implemented. Anyways, no the _bsddb.c changes that I checked in do not cause a problem because I checked them in using PyBUF_SIMPLE. Until PEP 3137 is implemented the

<    1   2   3   4   5   6   7   8   9   10   >