Jason R. Coombs added the comment:
I was _unable_ to replicate the issue with a foo.py containing only `raise
ValueError`, even with `python -m pdb -m foo`.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Jason R. Coombs :
--
keywords: -3.10regression
___
Python tracker
<https://bugs.python.org/issue44461>
___
___
Python-bugs-list mailing list
Unsub
Jason R. Coombs added the comment:
A small patch to rinoh seems to work around the issue:
```
diff --git a/src/rinoh/resource.py b/src/rinoh/resource.py
index 57143f9d..586a4bb7 100644
--- a/src/rinoh/resource.py
+++ b/src/rinoh/resource.py
@@ -132,7 +132,9 @@ class DynamicEntryPoint
Jason R. Coombs added the comment:
I submitted https://github.com/brechtm/rinohtype/pull/270 to address the issue
in rinohtype. Please feel free to reopen and address the questions posed above
if appropriate.
--
resolution: -> wont fix
stage: -> resolved
status: open -&g
New submission from Jason R. Coombs :
importlib_metadata 4.5
(https://importlib-metadata.readthedocs.io/en/latest/history.html#v4-5-0)
removed the special exclusion for flake8 in the deprecation warning for
deprecated interfaces in entry_points. For the same motivations there, do the
same
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +25388
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26807
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
In https://github.com/python/importlib_metadata/issues/324, I painstakingly
created a library to perform robust performance monitoring of behaviors in the
library and specifically added tests that capture the performance of
entry_points against
Jason R. Coombs added the comment:
New changeset efe7d08d178a7c09bcca994f2068b019c8633d83 by Jason R. Coombs in
branch 'main':
bpo-44464: Remove special exclusion for flake8 in the deprecation warnings.
(#26807)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 17b916737bd05a11ec24341990c4d8dbfee8f94b by Jason R. Coombs in
branch '3.9':
[3.9] bpo-37741: make importlib.metadata docs discoverable through a module
directive. (GH-25415) (GH-26500)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset f4b31cdbc043449f3df7d291da67bcb3736be0db by Miss Islington (bot)
in branch '3.10':
bpo-44464: Remove special exclusion for flake8 in the deprecation warnings.
(GH-26807) (GH-26929)
https://github.com/python/cpyt
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
Thanks Irit. Reviewing now...
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue44461>
___
___
Py
Change by Jason R. Coombs :
--
pull_requests: +25553
pull_request: https://github.com/python/cpython/pull/26992
___
Python tracker
<https://bugs.python.org/issue44
New submission from Jason R. Coombs :
While investigating issue44461, I observed some complexities to the current
pdb.main implementation, some of which likely contributed to the bug being
present.
- variables are initialized to defaults
(https://github.com/python/cpython/blob
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +25561
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26992
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I was able to export the configuration using these instructions:
https://docs.microsoft.com/en-us/visualstudio/install/import-export-installation-configurations?view=vs-2019
That produced this config:
{
"version": "1.0&
Jason R. Coombs added the comment:
Thanks Barry for filing this. I was planning to do it but happy for you to beat
me to it.
I had one question I'd been meaning to ask - with this change, can the code
paths that were deprecated in 3.10 be removed in 3.11 (SelectableGroups and
cast to
Jason R. Coombs added the comment:
I was able to replicate the error using the script as posted:
```
draft $ cat > issue44638.py
import zipfile
class TestClass:
def __init__(self, path):
self.zip_file = zipfile.ZipFile(path)
def iter_dir(self):
return [each.name
Jason R. Coombs added the comment:
Here's a much simpler repro that avoids the class construction but triggers the
same error:
```
import zipfile
zip_file = zipfile.ZipFile('zipfile.zip')
names = [each.name for each in zipfile.Path(zip_file).iterdir()]
with zip_file.open(na
Jason R. Coombs added the comment:
Even simpler:
```
import zipfile
zip_file = zipfile.ZipFile('zipfile.zip')
names = [each.name for each in zipfile.Path(zip_file).iterdir()]
zip_file.open(names[0])
```
--
___
Python track
Jason R. Coombs added the comment:
This also reproduces the failure:
```
zip_file = zipfile.ZipFile('zipfile.zip')
path = zipfile.Path(zip_file)
name = zip_file.namelist()[0]
del path
zip_file.open(name)
```
Removing `del path` bypasses the issue. Something about the dest
Jason R. Coombs added the comment:
Even simpler:
```
zip_file = zipfile.ZipFile('zipfile.zip')
name = zip_file.namelist()[0]
zipfile.Path(zip_file)
zip_file.open(name)
```
--
___
Python tracker
<https://bugs.python.o
Jason R. Coombs added the comment:
Changing the repro to:
```
import zipfile
try:
import zipp
except ImportError:
import zipfile as zipp
zip_file = zipfile.ZipFile('zipfile.zip')
name = zip_file.namelist()[0]
zipp.Path(zip_file)
zip_file.open(name)
```
I'm able now
Change by Jason R. Coombs :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Using zipfile.Path with several files prematurely closes zip
___
Python tracker
<https://bugs.python
Jason R. Coombs added the comment:
> My python version is 3.8.9 and zipp is at 3.5.0 (but 3.4.1 behaves the same
> for me).
It's not enough to have `zipp` 3.5.0. You need to use `zipp.Path` over
`zipfile.Path`.
--
___
Python trac
Change by Jason R. Coombs :
--
pull_requests: +25724
pull_request: https://github.com/python/cpython/pull/27188
___
Python tracker
<https://bugs.python.org/issue44
Jason R. Coombs added the comment:
Additional problems I noticed while working on the refactor:
- There is a lot of overlap in behavior between the implementations of
_run_script and _run_module (initializing private variables, setting
mainpyfile, resetting the __main__ namespace).
- There
Change by Jason R. Coombs :
--
pull_requests: +25768
pull_request: https://github.com/python/cpython/pull/27227
___
Python tracker
<https://bugs.python.org/issue44
Change by Jason R. Coombs :
--
pull_requests: -25553
___
Python tracker
<https://bugs.python.org/issue44461>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
New changeset ee03bad25e83b00ba5fc2a0265b48c6286e6b3f7 by Jason R. Coombs in
branch 'main':
bpo-44461: Check early that a pdb target is valid for execution. (#27227)
https://github.com/python/cpython/commit/ee03bad25e83b00ba5fc2a0265b48c
Change by Jason R. Coombs :
--
pull_requests: +25932
pull_request: https://github.com/python/cpython/pull/27399
___
Python tracker
<https://bugs.python.org/issue44
Change by Jason R. Coombs :
--
pull_requests: +25933
pull_request: https://github.com/python/cpython/pull/27400
___
Python tracker
<https://bugs.python.org/issue44
Jason R. Coombs added the comment:
New changeset 49b5e20fa8c091f9158ccd26f9a12fc1e91cfc93 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-44461: Check early that a pdb target is valid for execution.
(GH-27227) (GH-27400)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
This issue is solved. Thanks Irit for taking the time to investigate the issue
and do the hard part of developing a test.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
_
New submission from Jason R. Coombs :
Importlib_resources 5.1 and 5.2 introduced the following changes (more details
at https://importlib-resources.readthedocs.io/en/latest/history.html#v5-2-1):
- Added ``simple`` module implementing adapters from a low-level resources
reader interface to a
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +25965
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
nosy: +jaraco
nosy_count: 8.0 -> 9.0
pull_requests: +25966
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
nosy: +FFY00
___
Python tracker
<https://bugs.python.org/issue44771>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
I've put together a patch based on python/importlib_resources@3b24bd6307, and
interestingly, the tests pass... which is a little concerning because in
https://github.com/python/importlib_resources/pull/221#discussion_r659214483, I
describe a compatib
Jason R. Coombs added the comment:
On further consideration, the concern I had may not be manifest in the
implementation. It may be the _adapters.wrap_spec provides all the
compatibility that's needed. I'll see if I can concoct an idiomatic case, but I
may find that there'
Change by Jason R. Coombs :
--
pull_requests: -25966
___
Python tracker
<https://bugs.python.org/issue40263>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Jason R. Coombs :
--
nosy: -jaraco
___
Python tracker
<https://bugs.python.org/issue40263>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
In [this
comment](https://github.com/python/importlib_resources/pull/221#discussion_r679124389),
I did more analysis and assuaged my own concerns about the implementation.
Everything seems to be working as intended, thanks to the strong work by FFY00
Jason R. Coombs added the comment:
New changeset aaa83cdfab6817446285e631232f64b394ac6791 by Jason R. Coombs in
branch 'main':
bpo-44771: Apply changes from importlib_resources 5.2.1 (GH-27436)
https://github.com/python/cpython/commit/aaa83cdfab6817446285e631232f64
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Jason R. Coombs :
In [this
comment](https://github.com/python/cpython/pull/27436#issuecomment-889815333),
I learned that it's possible to break the buildbots in a way that's not fixable
with a simple code change.
The recommendation there was to contact th
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +25996
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
In [this
comment](https://github.com/python/cpython/pull/27436#issuecomment-889815333),
I learned that it's possible to get repo clones into a bad state by:
- commit a text file to main (merge a PR)
- customize the newline handling for that fi
Change by Jason R. Coombs :
--
pull_requests: -25996
___
Python tracker
<https://bugs.python.org/issue44777>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Jason R. Coombs :
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue44777>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Jason R. Coombs :
--
pull_requests: +25997
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +25998
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Awesome. Thanks Łukasz.
--
___
Python tracker
<https://bugs.python.org/issue44777>
___
___
Python-bugs-list mailing list
Unsub
Change by Jason R. Coombs :
--
nosy: +jaraco
nosy_count: 6.0 -> 7.0
pull_requests: +26014
pull_request: https://github.com/python/cpython/pull/27436
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
pull_requests: +26015
pull_request: https://github.com/python/cpython/pull/27497
___
Python tracker
<https://bugs.python.org/issue44
Jason R. Coombs added the comment:
New changeset e63e6311aa258a5f3f49a7aed9fdde445fd384d6 by Jason R. Coombs in
branch 'main':
bpo-44771: Sync with importlib_resources 5.2.2, fixing refleak. (#27497)
https://github.com/python/cpython/commit/e63e6311aa258a5f3f49a7aed9fdde
Jason R. Coombs added the comment:
In addition to the two reported, there are two others:
- test_entry_points_dict_construction
- test_entry_points_by_index
that also fail. I've been able to replicate the issue in importlib_metadata, so
I'll fix it t
Jason R. Coombs added the comment:
All four of those tests had used `capture_warnings` in an attempt to capture
them, but it did not alter the warnings filter.
--
___
Python tracker
<https://bugs.python.org/issue44
Jason R. Coombs added the comment:
Patch at https://github.com/python/importlib_metadata/pull/333.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +26022
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27508
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset 21d5897982698a461215203ab51f56ad05648001 by Miss Islington (bot)
in branch '3.10':
bpo-44784: Apply changes from importlib_metadata 4.6.3 (GH-27508) (#27510)
https://github.com/python/cpython/commit/21d5897982698a461215203ab51f56
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
Thanks Filipe for the summary. I was unsure the status.
Even if we grant that Debian is too intrusive in its patching of distutils,
it's Python and distutils that are making the change here, so it's not
unreasonable for Python to maintain feat
Change by Jason R. Coombs :
--
versions: +Python 3.11 -Python 3.10
___
Python tracker
<https://bugs.python.org/issue43976>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
I'll probably fix the issue in importlib_metadata first
(https://github.com/python/importlib_metadata/issues/337).
--
___
Python tracker
<https://bugs.python.org/is
Jason R. Coombs added the comment:
There is an issue where that file originally got EOL conversions, so all
Windows buildbots were failing (issue44779).
I'd thought we'd worked around the issue by pushing out a PR that deleted the
file and ensuring it ran on the buildbo
Jason R. Coombs added the comment:
I'm going to attempt that technique again and see if it's sufficient to bypass
the symptom.
--
___
Python tracker
<https://bugs.python.o
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +26561
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28120
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I've submitted a PR that deletes the file and requested it be built by the
buildbots, but I also see that that bot hasn't built anything in 7 days
(https://buildbot.python.org/all/#/builders/405), so I'm not hopeful my request
for it to bu
Jason R. Coombs added the comment:
I'm not confident that I can get the message to the buildbot, so I sent a
message to [email protected] requesting to run the workaround on the
buildbot. The message was flagged for moderation. My hope is that eventually
goes through and
Jason R. Coombs added the comment:
Reported concern can be addressed in the new issue.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
The builder is now passing after the buildbot owner reset the checkout.
--
resolution: -> fixed
stage: -> resolved
status: pending -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
>> Subclass of set can now define
> Is there any use case for this?
Is your concern about a use-case for the general concept or for set
specifically?
I appreciate that Serhiy has taken the time to evaluate the specific concern I
raised and extra
Jason R. Coombs added the comment:
Oh, and I see now Serhiy has proposed a change that looks reasonable.
--
___
Python tracker
<https://bugs.python.org/issue43
Jason R. Coombs added the comment:
> In the short term, and possible for the long term, Debian can continue to
> patch the install routine...
The problem with this approach is Setuptools is attempting to adopt distutils
by exposing its own vendored copy of distutils as `distutils
Jason R. Coombs added the comment:
Here's what I propose:
1. In pypa/distutils, add support for honoring the proposed install schemes
(based on PR 25718). Merge with Setuptools.
2. Add whatever ugly hacks are needed to pypa/distutils to honor other
Debian-specific behaviors (revive
New submission from Jason R. Coombs :
In [pytest-dev/pytest#9174](https://github.com/pytest-dev/pytest/issues/9174),
it became clear that the DegenerateFiles object has a couple of interface
mismatches to Traversable:
- name is a property
- open accepts a 'mode' and arbitrary args
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +27156
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28844
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: behavior ->
___
Python tracker
<https://bugs.python
Jason R. Coombs added the comment:
Thanks Dave for closing. I would recommend in the future if you have packaging
questions to bring them to packaging problems repo as indicated at
https://packaging.python.org/support/#how-to-get-support.
Glad to hear that `as_file` promised to do what you
New submission from Jason R. Coombs :
[importlib_resources
5.3](https://importlib-resources.readthedocs.io/en/latest/history.html#v5-3-0),
deprecates the functions in _legacy. Let's introduce that deprecation in
CPython also.
In addition to merging the changes from importlib_resources,
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +27307
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29036
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
New changeset 4d03de3329ed8daa9c1107b1aedbb0fa280bddb6 by Filipe Laíns in
branch 'main':
bpo-45516: add protocol description to the Traversable documentation (#29039)
https://github.com/python/cpython/commit/4d03de3329ed8daa9c1107b1aedbb0
Jason R. Coombs added the comment:
New changeset c0295675305f6896e4ba7496441cc470d7edca89 by Filipe Laíns in
branch 'main':
bpo-45516: use documentation links in TraversableResources' description
(GH-29045)
https://github.com/python/cpython/commit/c0295675305f6896e4ba74964
Jason R. Coombs added the comment:
New changeset 8ce20bbdd6d2b1277a5e74154fcdcef2cb0fee49 by Filipe Laíns in
branch 'main':
bpo-45516: add protocol description to the TraversableResources documentation
(#29173)
https://github.com/python/cpython/commit/8ce20bbdd6d2b1277a5e74154fcdce
Jason R. Coombs added the comment:
I vaguely recall exploring this concept and finding that tarfiles don’t supply
the requisite interface because they’re not random access. I’m only 10%
confident in that recollection, so worth exploring
New submission from Jason R. Coombs :
Reported in https://github.com/python/importlib_metadata/issues/353,
importlib.metadata fails to find distributions in the path "". A fix was
applied to importlib_metadata 2.1.2 and 4.8.2. Let's apply that fix and
backport it to su
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue45765>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +27738
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29487
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset 6ec0dec7b7b50d4fee5b2b66cf38e4291bcdf44c by Jason R. Coombs in
branch 'main':
[bpo-45765] Fix distribution discovery on empty path. (#29487)
https://github.com/python/cpython/commit/6ec0dec7b7b50d4fee5b2b66cf38e4
Change by Jason R. Coombs :
--
pull_requests: +27762
pull_request: https://github.com/python/cpython/pull/29511
___
Python tracker
<https://bugs.python.org/issue45
Jason R. Coombs added the comment:
New changeset 3e0b830e859ca8792401bfd1402d659f56f99941 by Jason R. Coombs in
branch '3.9':
[3.9] [bpo-45765] Fix distribution discovery on empty path. (GH-29487).
(GH-29511)
https://github.com/python/cpython/commit/3e0b830e859ca8792401bfd1402d65
Jason R. Coombs added the comment:
New changeset ed55426acd58f030ccc0cf1297e66078f538797c by Miss Islington (bot)
in branch '3.10':
[bpo-45765] Fix distribution discovery on empty path. (GH-29487) (GH-29510)
https://github.com/python/cpython/commit/ed55426acd58f030ccc0cf1297e660
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset d5cd2effa69551c6bc7edfef8a414d545dea9117 by Jason R. Coombs in
branch 'main':
bpo-45514: Deprecate importlib resources legacy functions. (GH-29036)
https://github.com/python/cpython/commit/d5cd2effa69551c6bc7edfef8a414d
Jason R. Coombs added the comment:
See
https://discuss.python.org/t/deprecating-importlib-resources-legacy-api/11386
for some lively discussion on this deprecation.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
New submission from Jason R. Coombs :
Can you provide a description of what motivated you to change the behavior or
what benefits this change would have for you or others? Do you know why others
haven’t reported this need previously?
--
nosy: +jaraco
Jason R. Coombs added the comment:
This issue broke a date subclass in the calendra project
(https://github.com/jaraco/calendra/issues/11). I acknowledge this change was a
known breakage, but I mention it here and link the downstream issue for your
information.
--
nosy: +jaraco
Jason R. Coombs added the comment:
Same error on Python 2.7 and 3.7
--
versions: +Python 2.7, Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38
901 - 1000 of 1863 matches
Mail list logo
