Jason R. Coombs added the comment:
I addressed the [setuptools test suite
issue](https://github.com/pypa/setuptools/issues/2112) with [this
commit](https://github.com/pypa/setuptools/commit/f866311d60f54499c3637309e3429780d8c8f218).
What was a one-line elegant solution is now multiple lines
Jason R. Coombs added the comment:
> Platform differences can be papered over with functions.
I’m not suggesting that from within Python there should be another way to
detect a home directory. The expanduser functionality as written is just fine
for that, though I agree with Steve that us
Jason R. Coombs added the comment:
> I thought it might be useful for testing purposes if os.path (i.e. ntpath and
> posixpath) had a way to set the home directory that it uses in way that
> wouldn't affect other libraries and child processes.
I was thinking about this, and
New submission from Jason R. Coombs :
In https://github.com/jaraco/path/issues/186, the Path project discovered a
regression with Python 3.8. It seems that if one creates a symlink with an
absolute path. I used `shutil.copytree('temp', 'temp2', True)` and it p
Jason R. Coombs added the comment:
Thank you Eryk for the thorough and informative investigation. Seriously, wow.
> Do you want 3.8 to revert to using the print name, at least for symlinks?
> (ntpath._readlink_deep would need to be modified to support long target
> paths.) Or
Jason R. Coombs added the comment:
I strongly suspect bpo-37834 and GH-15231 is where the difference was
introduced.
--
___
Python tracker
<https://bugs.python.org/issue40
Jason R. Coombs added the comment:
> This is only an issue for broken symlinks, right? (More precisely, those that
> cannot be resolved, which may include very long paths on some machines.)
Unfortunately, no. In the original post above, you can see temp/bar points to
C:\Users\jarac
Jason R. Coombs added the comment:
Thanks William for the detailed problem description.
If the issue has been fixed on Python 3.9 but not on 3.8, then it was likely a
redesign that enabled the improved behavior, a redesign that won't be ported
back to Python 3.8 and earlier. In
Jason R. Coombs added the comment:
I'll take a look at the patch and convert it to a PR.
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org
Jason R. Coombs added the comment:
I've applied the patches and pushed them to
https://github.com/jaraco/cpython/tree/bugfix/bpo-38780.
```
cpython master $ http
https://bugs.python.org/file48933/0001-bpo-38780-Harden-socket-use-in-logging.handlers.patch
| git apply
cpython master
Change by Jason R. Coombs :
--
versions: +Python 3.10 -Python 2.7, Python 3.7
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list m
Change by Jason R. Coombs :
--
pull_requests: +22527
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23661
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Erlend, inspired by your patches, I created
https://github.com/python/cpython/pull/23661/commits/e9723003d49c722d57a69e5016b442d4d752fc6d,
which uses a NullSocket instance instead of None, allowing the
behavior-suppression to be encapsulated in a single
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue42382>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
I've ported the initial patch over to the backport and am exploring options in
https://github.com/python/importlib_metadata/pull/266.
--
___
Python tracker
<https://bugs.python.org/is
Jason R. Coombs added the comment:
In discussion, I realized that I don't yet understand what use-cases drive this
demand? What code is it that requires resolving a distribution from an entry
point?
--
___
Python tracker
<https://bugs.py
Jason R. Coombs added the comment:
This issue was implemented, just not as fully as I'd have hoped. Still lacking
is native support for .files on the built-in package providers and removing the
legacy APIs or at least configuring them to rely on the files API, but as far
as supplyin
Change by Jason R. Coombs :
--
pull_requests: +22614
pull_request: https://github.com/python/cpython/pull/23758
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
The PR for the related issue does address pickling. Do you expect pickles to
work across Python versions?
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +22672
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset dfdca85dfa64e72df385b3a486f85b773fc0f135 by Jason R. Coombs in
branch 'master':
bpo-42382: In importlib.metadata, `EntryPoint` objects now expose `dist`
(#23758)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
I started work on a test in
https://github.com/jaraco/cpython/tree/bugfix/bpo-38780-test, but (a) the test
was failing to exhibit the expected failures, and (b) I realized that the fix
isn't having the intended effect either, because for unix so
Change by Jason R. Coombs :
--
assignee: jaraco ->
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Jason R. Coombs :
--
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list mai
Jason R. Coombs added the comment:
New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but
processor) (#23010)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but
processor) (#23010)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but
processor) (#23010)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
> Regardless of whether PR 23611 is accepted, the test that it adds should be
> added to Python master to guard against regressions. I can submit that as a
> separate PR. Before I do that, do I need to create a new bpo ticket, or can I
> ju
Jason R. Coombs added the comment:
Can you tell me more about the use-case that exhibited this undesirable
behavior? That is, what loader is it that supports `open_binary` but not
`is_resource` and doesn't have a `__origin__`?
--
___
P
Jason R. Coombs added the comment:
In [this
commit](https://github.com/python/importlib_resources/commit/bd20d893f11f387d285c666bc99fd2d4a7c33ef8),
I've reconciled and merged the changes from importlib_resources 3.2-5.0,
mainly the namespace package support
(https://impo
Jason R. Coombs added the comment:
Thanks!
No rush, but ideally soon enough to be merged before the beta release of Python
3.10 (2021-05-03).
--
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
> Why do we keep setuptools?
I agree; would be good to remove it if possible.
There are many packages that fail to build without Setuptools being present or
--use-pep517 indicated. It would be nice if pip could make --use-pep517 the
default, update t
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issue42531>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Jason R. Coombs :
--
pull_requests: +23055
pull_request: https://github.com/python/cpython/pull/24232
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
pull_requests: +23057
pull_request: https://github.com/python/cpython/pull/24232
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
pull_requests: +23056
pull_request: https://github.com/python/cpython/pull/24232
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all
but processor) (GH-23010) (#24232)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all
but processor) (GH-23010) (#24232)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all
but processor) (GH-23010) (#24232)
https://github.com/python/cpyt
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
I've encountered this issue again with a different use-case.
I'm attempting to add a doctest to a routine that emits the paths of the files
it processes. I want to use ellipses to ignore the prefixes of the output
because they're not pertin
Jason R. Coombs added the comment:
The change to error handling for zipp.Path was added in
https://github.com/jaraco/zipp/issues/46 and released as
[3.1.0](https://zipp.readthedocs.io/en/latest/history.html#v3-1-0). Probably
that change was incorporated into CPython shortly thereafter with
Jason R. Coombs added the comment:
Today I encountered another situation where it would be convenient to allow an
ellipsis at the beginning of the syntax:
>>> pathlib.Path('abc')
...Path('abc')
Because pathlib.Path resolves to `PosixPath` and `WindowsPath` d
Jason R. Coombs added the comment:
As of June last year, Python 3.7 is in security fix only mode, so there's
nothing more to be done here.
--
nosy: +jaraco
resolution: -> fixed
stage: patch review -> resolved
status: pending -> closed
Jason R. Coombs added the comment:
For the first two errors, the issue seems to be that CPython includes tests for
the ResourceReader ABC and asserts that .contents() returns an empty list as
the default degenerate behavior
(https://github.com/python/cpython/blob
Jason R. Coombs added the comment:
> I would harmonize towards what the concrete implementations...
For FileReader and ZipReader, both rely on TraversableResources to implement
contents, which rely on `files().iterdir()`, which could raise
FileNotFoundError and definitely don't retu
Jason R. Coombs added the comment:
I've pushed [this
branch](https://github.com/python/cpython/tree/feature/42129-resources-namespace-packages),
which includes fixes for the above two identified issues. Still one issue
remains:
ERROR: test_package_has_no_reader_fal
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +23456
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24670
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I've stumbled into this issue and it's started occurring reliably on keyring in
Python 3.6 as found on Github CI
(https://github.com/jaraco/keyring/runs/1994652010?check_suite_focus=true).
It's not a highly-reproducible environment. I can&#x
Jason R. Coombs added the comment:
I started tracking it down in https://github.com/jaraco/keyring/issues/494 and
found I'd previously delved deep into a related issue
(https://github.com/jaraco/keyring/issues/281).
--
___
Python tracker
&
Jason R. Coombs added the comment:
All good. Thanks for the references. As with the prior issues, I'm going to
just suppress those failures.
--
___
Python tracker
<https://bugs.python.org/is
Jason R. Coombs added the comment:
Hey Steve. Thanks for the clarification. I'd forgotten the context,
specifically that any patches needed to be merged before the PEP was accepted,
and was working from a memory that we were willing to accept this change. Happy
to revert it, as that
Change by Jason R. Coombs :
--
pull_requests: +23524
pull_request: https://github.com/python/cpython/pull/24753
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
New changeset fbf75b9997e280b1220755d0a17dbed71240d42e by Jason R. Coombs in
branch 'master':
Revert "bpo-42405: fix C extensions build on Windows ARM64 (GH-23399)" (#24753)
https://github.com/python/cpython/commit/fbf75b9997e280b12207
Jason R. Coombs added the comment:
New changeset 67148254146948041a77d8a2989f41b88cdb2f99 by Jason R. Coombs in
branch 'master':
bpo-42129: Add support for resources in namespaces (GH-24670)
https://github.com/python/cpython/commit/67148254146948041a77d8a2989f41
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
For posterity, I'll share my motivation.
> Why is it a problem that people are using something which is documented as a
> tuple?
It's not a problem that they access it by tuple if it's documented.
The problem is that it's docume
New submission from Jason R. Coombs :
While troubleshooting a strange problem
(https://github.com/jaraco/keyring/issues/498) where a program worked on Python
3.7+ but failed on Python 3.6, I discovered a somewhat unintuitive behavior. On
Python 3.7+, keyword arguments to tuple subclasses are
Jason R. Coombs added the comment:
To be abundantly clear, the downstream issue was a coding error, but the coding
error was masked on Python 3.7+ when the subclass didn't reject the invalid
usage.
--
___
Python tracker
<https://bugs.py
Jason R. Coombs added the comment:
I see that changelog entry traces back to bpo-29695, but I don't believe it's
relevant to this issue.
--
___
Python tracker
<https://bugs.python.o
Jason R. Coombs added the comment:
I suspect bpo-20186 is implicated.
--
___
Python tracker
<https://bugs.python.org/issue43413>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
I suspect change in this issue led to issue43413.
--
nosy: +jaraco
___
Python tracker
<https://bugs.python.org/issue20
Jason R. Coombs added the comment:
In particular, [this
commit](https://github.com/python/cpython/commit/0b5615926a573c19c887a701a2f7047f4fd06de6).
--
___
Python tracker
<https://bugs.python.org/issue43
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue42382>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Jason R. Coombs :
importlib metadata has added a few important
[changes](https://importlib-metadata.readthedocs.io/en/latest/history.html#v3-7-0)
since the last sync in issue42382 (importlib_metadata 3.3):
- Performance enhancements to distribution discovery
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +23548
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24782
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
> Changing readlink to always return the correct path was deliberate.
Understood. However, this statement assumes the "correct path" is the most
precise path to resolve the target. If you instead define "correct path" as the
one that
Jason R. Coombs added the comment:
> Unless you're specifically testing single steps through symlink chains, you
> probably want to just use realpath anyway.
I do see now the references to `realpath` in the docs... and I think that
satisfies the need I described above. It doesn&#
Jason R. Coombs added the comment:
Perhaps related, I've encountered another apparent regression on Python 3.8 on
Windows when the current working directory is in a symlink to another volume
and one runs `setup.py develop` on a project using setuptools_scm
(https://github.com
Jason R. Coombs added the comment:
> I'll see if `realpath` satisfies the test suite needs for path pie.
I've tried replacing `readlink` with `realpath` and the tests still pass on
Unix-like OSs, and also passes on Python 3.8 on Windows, but now fails on older
Pythons on Windo
New submission from Jason R. Coombs :
I've encountered an apparent regression on Python 3.8 on Windows when the
current working directory is in a symlink to another volume and one runs
`setup.py develop` on a project using setuptools_scm
(https://github.com/pypa/setuptools_scm/issue
Jason R. Coombs added the comment:
> Perhaps related...
Now I'm thinking the issue is different, so I've created issue40732 to track
the realpath issue.
--
___
Python tracker
<https://bugs.pytho
Change by Jason R. Coombs :
--
nosy: +eryksun
___
Python tracker
<https://bugs.python.org/issue40732>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
It seems the underlying reason the behavior fails is the (intended) difference
resolving the empty path to a realpath when a symlink points to another volume.
The failing routine invokes realpath early
(https://github.com/pypa/setuptools_scm/blob
Jason R. Coombs added the comment:
It's because on Unix:
```
>>> os.path.relpath('/Users/jaraco/code/main/path/.flake8', '')
'.flake8'
```
But on Windows, relpath raises an error for the comparable call:
```
>>> os.path.relpath('\\
Jason R. Coombs added the comment:
To make matters more complicated, `git rev-parse --show-toplevel` also returns
the realpath:
```
# git rev-parse --show-toplevel
//vmware-host/Shared Folders/home/code/main/path
```
--
___
Python tracker
<ht
Jason R. Coombs added the comment:
Good news is it looks like the issue with setuptools_scm can be address in a
relatively straightforward manner
(https://github.com/pypa/setuptools_scm/issues/436#issuecomment-632899446).
I think that means the answers to the above questions are
Jason R. Coombs added the comment:
Thanks Steve. While I was able to avoid the original symptom by not using
readlink, I still think there's an issue here, both in the surprising behavior
observed by shutil.copyfile, but also by the essential behavior of readlink.
The more essential
Jason R. Coombs added the comment:
New changeset 5c1d745da5e1166a8724b619060165dcf3949e93 by Miss Islington (bot)
in branch '3.8':
bpo-39830: Add zipfile.Path to __all__ (GH-19115) (GH-19116)
https://github.com/python/cpython/commit/5c1d745da5e1166a8724b619060165
Jason R. Coombs added the comment:
What do you think about readlink returning something like:
class Link(str):
print_name = None # type: str | None
@property
def friendly_name(self) -> str:
return self.print_name or self
os.readlink would always return one of these Link obje
Change by Jason R. Coombs :
--
pull_requests: +19816
pull_request: https://github.com/python/cpython/pull/20576
___
Python tracker
<https://bugs.python.org/issue39
Change by Jason R. Coombs :
--
components: +macOS
nosy: +ned.deily, ronaldoussoren
___
Python tracker
<https://bugs.python.org/issue40840>
___
___
Python-bug
New submission from Jason R. Coombs :
Attempting to build Python on macOS following [the
instructions](https://devguide.python.org/setup/#macos-and-os-x) (for Homebrew).
xz is installed:
```
$ brew --prefix xz
Jason R. Coombs added the comment:
This issue doesn't happen on my mac that installs homebrew globally. Do the
build instructions assume Homebrew is installed system-wide?
--
___
Python tracker
<https://bugs.python.org/is
Jason R. Coombs added the comment:
In [this
commit](https://github.com/jaraco/jaraco.develop/commit/e3e5f66ca6693d8ec3abd31d99d491f6dfa1f67d),
I include "xz" in the routine. Should Python's developer docs include
something like that to ensur
Jason R. Coombs added the comment:
In [this latest
routine](https://github.com/jaraco/jaraco.develop/blob/6469c7a61e7349b93f191df38eed6cd020dd79be/jaraco/develop/macos-build-python.py),
on my macOS workstation with Homebrew installed locally, Python builds
successfully with just a few
Change by Jason R. Coombs :
--
pull_requests: +19875
pull_request: https://github.com/python/cpython/pull/20656
___
Python tracker
<https://bugs.python.org/issue39
Change by Jason R. Coombs :
--
pull_requests: +19878
pull_request: https://github.com/python/cpython/pull/20659
___
Python tracker
<https://bugs.python.org/issue39
Jason R. Coombs added the comment:
New changeset 161541ab45278df6603dd870113b10f13e4d9e16 by Jason R. Coombs in
branch 'master':
bpo-39791: Refresh importlib.metadata from importlib_metadata 1.6.1. (GH-20659)
https://github.com/python/cpython/commit/161541ab45278df6603dd870113b10
Jason R. Coombs added the comment:
New changeset a4fa9a95153a3800dea60b3029b2dcaf8a4f6acb by Miss Islington (bot)
in branch '3.9':
bpo-39791: Refresh importlib.metadata from importlib_metadata 1.6.1. (GH-20659)
(GH-20661)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
Thanks for the report Michael. I'm trying to figure out the best way to address
the issue. That test is shared with importlib_metadata, so needs to run without
CPython's test suite fixtures, such as the ones that generate non-ascii
filenames. I
Change by Jason R. Coombs :
--
pull_requests: +19894
pull_request: https://github.com/python/cpython/pull/20681
___
Python tracker
<https://bugs.python.org/issue39
Jason R. Coombs added the comment:
See GH-20681 for a proposed fix. I've scheduled the build bots to run the
patch. Will build bots prove the fix? If not, can you test the patch in the
same environment where it was discovered?
--
___
P
Jason R. Coombs added the comment:
New changeset 2efe18bf277dd0f38a1d248ae6bdd30947c26880 by Jason R. Coombs in
branch 'master':
bpo-39791: Support file systems that cannot support non-ascii filenames
(skipping tests in that case). (#20681)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 843c27765652e2322011fb3e5d88f4837de38c06 by Jason R. Coombs in
branch 'master':
bpo-39791 native hooks for importlib.resources.files (GH-20576)
https://github.com/python/cpython/commit/843c27765652e2322011fb3e5d88f4
1101 - 1200 of 1863 matches
Mail list logo
