Francisco Martín Brugué added the comment:
+1
while working on #issue14053 I missed the test for the scripts (in this case
some kind of mocking is needed).
--
___
Python tracker
<http://bugs.python.org/issue13
Francisco Martín Brugué added the comment:
Updated.
Interesting: I saw that repetition but due “[…] Ideally, it
should distinguish between this and other errors by checking the
subprocess's stderr, so that if a different error occurs, we can still
print out the error message. […]” I
Francisco Martín Brugué added the comment:
Ok! I haven't added NEWS as I thing is easier for the person that applies the
patch to simply write the line directly there instead of merging. Is that ok?
let me know if something has to be improved.
Thanks again for your mentoring
Francisco Martín Brugué added the comment:
> My only concern is communication: how do we tell people working on a tool
> that they should write a test in test_tools? I’m not sure they would read
> Tools/README; maybe a note at the top of the Python files would work; a note
> in
Francisco Martín Brugué added the comment:
I have some questions about this:
1) In Lib/test/string_tests.py it says:
“Common tests shared by test_str, test_unicode, test_userstring and
test_string”
but
a) I cannot find test_str
b) string is imported and only some constants
Francisco Martín Brugué added the comment:
Hi Éric,
some questions:
1)if test_tools is going to be the test for all the Tools (at least
until it grows to much), shoudn't be be module doc something like “””Tests for
scripts in Tools/**“””
2)is the SkipTest “reindent” specific?
C
Francisco Martín Brugué added the comment:
Sorry, my fault: I meant "Test for Tools" instead of """Tests for
reindent.py.""" (Im not talking about the skip message but the test
documentation or the first line 0,0...)
--
_
Francisco Martín Brugué added the comment:
Patch updated.
BTW, I didn't get any email due the review that Éric did (does one has to be
registered? I've done that now).
--
Added file: http://bugs.python.org/file24689/issue12659_434cd2fe
Francisco Martín Brugué added the comment:
> Patch looks good, thanks! BTW are you running a coverage tool to see > how
> far along we are?
Yes, always. The classes tested in that patch are at 100%.
The overall coverage is:
Name Stmts Miss Cover
Francisco Martín Brugué added the comment:
I've updated the patch with a test case for 'create_distribution' and one minor
rename.
I personally don't like too much the structure of 'LoggingCatcherTestCase' so
improvements are welcome.
Cheers,
franci
New submission from Francisco Martín Brugué :
I've added a test to Lib/packaging/tests/test_install.py to increase the line
test coverage of lib/packaging.install (and lib/packaging/pypi/wrapper
indirectly from 14% to 80%).
--
components: Tests
Changes by Francisco Martín Brugué :
--
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issue14183>
___
___
Python-bugs-list mailing list
Un
Francisco Martín Brugué added the comment:
Hi Éric,
> - # Test that the isntalled raises an exception if the project does not
> + # Test that the installed raises an exception if the project does not
> It took me many seconds to find the change :)
The editor told me :)
>
Francisco Martín Brugué added the comment:
Nadeem:
> - Don't use spaces around the '=' sign when used to indicate a
> keyword argument or a default parameter value.
ok, "code formating" is not working as expected (at least for lambdas...)
Éric :
> If you
Francisco Martín Brugué added the comment:
I've updated the patch. Let me know if something has to be changed.
--
Added file: http://bugs.python.org/file24727/issue14183_fbb9847b8f43.patch
___
Python tracker
<http://bugs.python.org/is
Francisco Martín Brugué added the comment:
> However, I have not actually applied and run test_string.py.
I've applied the issue13579_4720cc9e.patch to the changeset 0554183066b5
and applies without errors for me.
--
___
Python tracke
Francisco Martín Brugué added the comment:
Ok, I've updated the patch.
The NEWS entry could be:
Issue #13579: string.Formatter now understands the !a conversion specifier.
(not in the patch because AFAIN it makes the merge easier)
Let me know if that's in the line you want.
Francisco Martín Brugué added the comment:
What the status of this issue?:
the changeset http://hg.python.org/distutils2/rev/1e0ca4594a2a mentioned in
msg155480 seems to add tests (but it hasn't been add to the issue explicitly).
Can the issue be closed?
--
nosy: +fran
Francisco Martín Brugué added the comment:
On Debian:
* Command line 2.7.3
~/Prog/mypy$ python2.7 tem2.py
tem2.py
~/Prog/mypy$ python2.7 -m tem2
/home/ci/Prog/mypy/tem2.py
* IDLE 2.7.3
>>> print(__file__)
Traceback (most recent call last):
File "", line 1, in
Francisco Martín Brugué added the comment:
>From Idle editor window (F5):
>>>
Traceback (most recent call last):
File "/home/ci/Prog/mypy/tem2.py", line 1, in
print(__file__)
NameError: name '__file__' is not defined
>>>
--
_
Francisco Martín Brugué added the comment:
The patch is updated. Please let me know.
And as Éric noticed the NEWS entry could be:
Issue #13579: string.Formatter now understands the "a" conversion specifier.
Thanks!
--
Added file: http://bugs.python.org
Francisco Martín Brugué added the comment:
Just for the record:
Thanks to the old mq workflow in the devguide I've learned about them and I'm
now using it all the time to send and manage the patches.
The only thing is that one should first use the “qqueue” functionality (see “hg
h
Francisco Martín Brugué added the comment:
Just curiosity: how relate the magic numbers 10 and 2000 in
test_compiler_recursion_limit to recursion_depth and recursion_limit
Thanks!
--
nosy: +francismb
___
Python tracker
<http://bugs.python.
Francisco Martín Brugué added the comment:
Just info:
I still can reproduce that. (It's maybe just something wrong with my setup?)
--
Added file: http://bugs.python.org/file27183/testsResult.txt
___
Python tracker
<http://bugs.python.org/is
Francisco Martín Brugué added the comment:
The actual tip for me is:
ci@random:~/Prog/cpython/benchmarks/py2$ hg tip
changeset: 164:61768f86170c
tag: tip
user:Brett Cannon
date:Fri Aug 31 18:58:24 2012 -0400
summary: Allow for the specification of a base directory
Francisco Martín Brugué added the comment:
The box is a debian (wheezy):
ci@random:~/Prog/cpython/benchmarks/py2$ uname -a
Linux random 3.2.0-3-amd64 #1 SMP Mon Jul 23 02:45:17 UTC 2012 x86_64 GNU/Linux
The source repository dir:
ci@random:~/Prog/cpython/benchmarks/py2$ dir
lib LICENSE.txt
Francisco Martín Brugué added the comment:
> So the tests failed but the benchmarks finished without issue?
Yes. But the apparent diff is that I've used 2.6.8
If the benchmarks run without errors then I'm satisfied, else we figure
out what this fails ever
or we have a already tr
Francisco Martín Brugué added the comment:
I've to say that I also ran into that by following coverage numbers and as a
newbie is not so easy to see what Raymond told. IMHO that information could be
put as a comment.
Regards
francis
--
nosy: +fran
Francisco Martín Brugué added the comment:
A small question related to: "zipfile_276_filename_mismatch_v3.patch"
--- a/zipfile.pyWed Apr 30 11:44:38 2014
+++ b/zipfile.pyWed Apr 30 15:10:38 2014
@@ -970,10 +970,10 @@
if fheader[_FH_EXTRA_FI
Francisco Martín Brugué added the comment:
The formatter module was deprecated in Python 3.4 and is scheduled
for removal in Python 3.6. See [1] and [2].
---
[1] https://docs.python.org/3/library/formatter.html#module-formatter
[2] https://docs.python.org/3/whatsnew/3.4.html#deprecated
Francisco Martín Brugué added the comment:
Hi,
sorry if it's trivial but shouldn't we add a 'shifted_true' test
some were to make sure that this behavior change gets noticed next time?
def test_shifted_true(self):
self.assertEqual(True << 0, 1)
sel
Francisco Martín Brugué added the comment:
I Victor you were so fast, I started with one patch also in bool (at least the
place was right). The problem is that I was getting some extrage (for me at
least). As far I hat:
def test_shifted_true(self):
with self.assertRaises
Francisco Martín Brugué added the comment:
>
> What we want to test is that the return value is of type 'int', which is what
> Victor's test checks.
>
Thank you for the explanations!
for 2.7.6 type(2 << 62) is and type(2 << 61) is
(I suppose it's
Francisco Martín Brugué added the comment:
Actual tip:
changeset: 87276:2012e85638d9
date: Tue Nov 19 11:43:38 2013 -0800
It's a fresh clone, then:
make clean
./configure --with-pydebug
make -j4
./python -OO -m test -v test_email
== CPython 3.4.0a4+ (default:2012e85638d9, Nov 19 2013, 22:
Francisco Martín Brugué added the comment:
small correction:
a fresh clone, then:
./configure --with-pydebug
make -j4
./python -OO -m test -v test_email
--
___
Python tracker
<http://bugs.python.org/issue19
New submission from Francisco Martín Brugué:
I've just installed Cpython 2.7.6 32bit on Windows64, run the tests [1]
and some of them failed. Some of them seems related to audiodata not beeing
installed.
.\python.exe Lib\test\regrtest.py -v
== CPython 2.7.6 (default, Nov 10 2013, 19:
Changes by Francisco Martín Brugué :
Added file: http://bugs.python.org/file32942/failed_test_sunau.txt
___
Python tracker
<http://bugs.python.org/issue19866>
___
___
Changes by Francisco Martín Brugué :
Added file: http://bugs.python.org/file32943/failed_test_wave.txt
___
Python tracker
<http://bugs.python.org/issue19866>
___
___
Pytho
Francisco Martín Brugué added the comment:
On 12/03/2013 07:21 PM, Zachary Ware wrote:
>
> Zachary Ware added the comment:
>
> Francis, would you like to work on a patch for this? The change should go in
> Tools/msi/msi.py, if I
Francisco Martín Brugué added the comment:
> If performance is the reason for the feature: My impression is that
> the goal of the struct module is not necessarily top performance.
I'm not sure if it applies but on #19905 (message 205345 [1])
is said its a dependency for that iss
Francisco Martín Brugué added the comment:
Just feedback on windows7. I tried the tests inside IDLE and done 'Run Module'
(F5) (deleting the directories between tests):
test_A:
import os, shutil
os.makedirs('foo')
os.makedirs('bar/boo')
shutil.move('foo/&#x
Francisco Martín Brugué added the comment:
Hi,
just a question:
the status of this issue is pending but it seems to be already
resolved/duplicated. Means that this issue can be closed?
Thansk in advance!
--
nosy: +francismb
status: pending -> o
Francisco Martín Brugué added the comment:
First I've reviewed #msg205585 again (no patch applied). Notice that Traceback
was not accurate:
test_A:
>>> os.makedirs('foo')
>>> os.makedirs('bar/foo')
>>> shutil.move('foo/', &#x
Francisco Martín Brugué added the comment:
I've applied the patch manually to 2.7. Then I've done the tests again (notice
test_A traceback):
test_A:
>>> import os, shutil
>>> os.makedirs('foo')
>>> os.makedirs('bar/foo')
>>
Francisco Martín Brugué added the comment:
And finally the test runs:
1) The original. No new tests, no new patch.
== CPython 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (Intel)]
== Windows-7-6.1.7601-SP1 little-endian
== c:\users\brugue\appdata\local\temp\test_python_5444
Francisco Martín Brugué added the comment:
Hi Joar,
just a detail: is there a reason for the asymmetric check for timedelta
isinstance (and raising NotImplemented)? And BTW. isn't a double check for the
__sub__ case (or have I missed something)?
+def __add__(self, other):
+&
Changes by Francisco Martín Brugué :
--
nosy: +francismb
___
Python tracker
<http://bugs.python.org/issue15392>
___
___
Python-bugs-list mailing list
Unsubscribe:
Francisco Martín Brugué added the comment:
Hi Terry,
just take/put away some ... (they're not in a special order nor preference,
just some that could 'see' in the browser).
--
keywords: +patch
nosy: +francismb
Added file: http://bugs.python.org/file29553/i
Francisco Martín Brugué added the comment:
In 2.7.3 >>>
>>> u'{0:c}'.format(127)
u'\x7f'
>>> u'{0:c}'.format(128)
Traceback (most recent call last):
File "", line 1, in
u'{0:c}'.format(128)
UnicodeDecodeErr
Francisco Martín Brugué added the comment:
Adding a test that triggers the issue, let me know if is enough.
--
keywords: +patch
Added file: http://bugs.python.org/file29554/issue7267.patch
___
Python tracker
<http://bugs.python.org/issue7
New submission from Francisco Fernández Castaño:
>From the code example at
>https://docs.python.org/3/library/contextlib.html#contextlib.ContextDecorator
"logging.info('Entering: {}'.format(name))
NameError: name 'name' is not defined"
nam
Francisco Fernández Castaño added the comment:
Under Fernández it's ok.
--
___
Python tracker
<http://bugs.python.org/issue22603>
___
___
Python-bugs-list m
New submission from Francisco Arenas Afán de Rivera :
I found that the debugger doesn't follow the normal program order when
executing a foor loop with more than 3 instructions inside and one loop.
code example:
a = 0
b = 0
c = 0
for i in range(1):
a += 1
b += 1 # Set breakpoint
Changes by Luiz Francisco Artigas de Prá :
--
nosy: +Luiz Francisco Artigas de Prá
___
Python tracker
<http://bugs.python.org/issue19084>
___
___
Python-bug
101 - 154 of 154 matches
Mail list logo
