[issue13276] distutils bdist_wininst created installer does not run the postinstallation script on uninstalling

2011-10-27 Thread francisco
New submission from francisco : The bug can be reproduced by running the following command to create a Windows installer for the attached module: python setup.py bdist_wininst --install-script pis.py I include also the installer that I have created in the dist folder. The installer installs

[issue13276] bdist_wininst-created installer does not run the postinstallation script when uninstalling

2016-02-16 Thread francisco
francisco added the comment: I believe that this bug—which I reported in 2011—is not correctly tagged, what may explain why it has not been fixed yet. Despite the fact that the original issue report contains a script to reproduce the bug and that msg148674 contains a patch to fix the issue

[issue12412] non defined representation for pwd.struct_passwd

2011-06-25 Thread Francisco Garcia
New submission from Francisco Garcia : pwd.struct_passwd has different representations in cpython 2.7.2 and pypy 1.5 A unit test from cpython might enforce the same representation across interpreters: >>> print pwd.getpwuid(os.getuid()) Current cpython output: pwd.struct_passw

[issue44212] asyncio overrides signal handlers

2021-05-21 Thread Francisco Demartino
New submission from Francisco Demartino : Hello, It looks like when asyncio sets up a signal handler, it forgets about the previous one (if any). Here's a patch (was about to create a PR but the default text brought me to bugs.python.org) https://github.com/franciscod/cpython/c

[issue44212] asyncio overrides signal handlers

2021-05-21 Thread Francisco Demartino
Francisco Demartino added the comment: Looks like Roger Dahl also noted this on https://bugs.python.org/issue39765: > Second, set_signal_handler()[sic] silently and implicitly removes > corresponding handlers set with signal.signal(). [...] I think this should > be documente

[issue44212] asyncio overrides signal handlers

2021-05-21 Thread Francisco Demartino
Change by Francisco Demartino : -- keywords: +patch pull_requests: +24904 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26306 ___ Python tracker <https://bugs.python.org/issu

[issue46010] Cookie cutter templates to allow variable fields and data transfer proposal before system merge

2021-12-07 Thread Francisco Orozco
New submission from Francisco Orozco : Not featuring templates to allow variable fields and data record creation when converting projects to new platform projects for purpose to confirm, verify record creation, might be helpful, in addition of only viewing/editing project development and

[issue21879] str.format() gives poor diagnostic on placeholder mismatch

2019-02-28 Thread Francisco Couzo
Francisco Couzo added the comment: I'm preparing the PR myself -- ___ Python tracker <https://bugs.python.org/issue21879> ___ ___ Python-bugs-list m

[issue21879] str.format() gives poor diagnostic on placeholder mismatch

2019-04-03 Thread Francisco Couzo
Change by Francisco Couzo : -- pull_requests: +12602 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue21879> ___ ___ Python-

[issue21879] str.format() gives poor diagnostic on placeholder mismatch

2019-04-03 Thread Francisco Couzo
Francisco Couzo added the comment: I just made the pull request, I totally forgot I mentioned I was going to work on this, sorry! -- ___ Python tracker <https://bugs.python.org/issue21

[issue22102] Zipfile generates Zipfile error in zip with 0 total number of disk in Zip64 end of central directory locator

2018-03-05 Thread Francisco Facioni
Change by Francisco Facioni : -- keywords: +patch pull_requests: +5752 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue22102> ___ _

[issue14019] Unify tests for str.format and string.Formatter

2013-08-08 Thread Francisco Freire
Francisco Freire added the comment: I increased the coverage of formatter module to 40%. I added a new file "test_formatter.py" including some unit tests. -- keywords: +patch nosy: +francisco.freire Added file: http://bugs.python.org/file31202/my

[issue14019] Unify tests for str.format and string.Formatter

2013-08-24 Thread Francisco Freire
Francisco Freire added the comment: Thanks for the review. I corrected some issues in my code. Here is the new patch. -- Added file: http://bugs.python.org/file31453/mywork2.patch ___ Python tracker <http://bugs.python.org/issue14

[issue14924] re.finditer() oddity

2012-05-27 Thread Francisco Gracia
New submission from Francisco Gracia : I find baffling the following behaviour of *re.finditer()*: Python 3.2 (r32:88445, Feb 20 2011, 21:29:02) [MSC v.1500 32 bit (Intel)] on win32 Type "copyright", "credits" or "license()" for more informatio

[issue14924] re.finditer() oddity

2012-05-27 Thread Francisco Gracia
Francisco Gracia added the comment: Thank you both for your quick and clear explanations. However I regret that I keep considering the situation rather unsatisfactory. I can well understand that all objects are true and even that the convention that applies to some of them, like containers

[issue14929] IDLE crashes on *Edit / Find in files ...* command (Python 3.2, Windows XP)

2012-05-27 Thread Francisco Gracia
New submission from Francisco Gracia : There is little more that I can add to the title statement. 1. Start IDLE 2. Go to *Edit* menu option 3. Select *Find in files...* option 4. Put some word in the *Find* input box 5. Press *Search files* button When the command is issued the

[issue14937] IDLE's deficiency in the completion of file names (Python 32, Windows XP)

2012-05-28 Thread Francisco Gracia
New submission from Francisco Gracia : I find specially nice the completion feature for filenames of IDLE when they include long paths, something that is more mand more frequent with big disks and infinite amounts of files. But there is a small problem with it. If the name of any of the

[issue14937] IDLE's deficiency in the completion of file names (Python 32, Windows XP)

2012-05-28 Thread Francisco Gracia
Francisco Gracia added the comment: I would be delighted, but unfortunately I am a very poor programmer and do not have the slightest idea of how all this works. -- ___ Python tracker <http://bugs.python.org/issue14

[issue14937] IDLE's deficiency in the completion of file names (Python 32, Windows XP)

2012-06-02 Thread Francisco Gracia
Francisco Gracia added the comment: Is there any necessity at all for the IDLE to test the validity of the filenames? I mean: the file specification is provided by the underlying operating system, so by definition it has to be taken as valid. Testing for its validity is superfluous and, in

[issue14929] IDLE crashes on *Edit / Find in files ...* command

2012-06-03 Thread Francisco Gracia
Francisco Gracia added the comment: While your are at it, here is another suggestion: what the *Find in files ...* dialog needs most urgently in my opinion is a field for specifying clearly the directory from which the user wants to launch the search. Also in my modest opinion, having an

[issue14937] IDLE's deficiency in the completion of file names (Python 32, Windows XP)

2012-10-12 Thread Francisco Gracia
Francisco Gracia added the comment: In my machine with Windows XP and Python 3.3.0 both variants work, the only difference being that 'c:/ brings up the selection box authomatically and 'c:\ requieres that it be summoned with the tab key, as indicated. 2012/10/12 Terry J. Reedy &

[issue16226] IDLE crashes on *File / Path browser*

2012-10-14 Thread Francisco Gracia
New submission from Francisco Gracia: The menu option *File / Path browser* (as well in the *Shell* window as in the *Editor* one) shows a new window with a tree structure rooted at *sys.path*. The available leaf nodes show the *plus* sign that usually implies that they can be expanded by

[issue16229] Module *redemo.py* lacking in recent Python distributions

2012-10-14 Thread Francisco Gracia
New submission from Francisco Gracia: Since Python 3.2 the module *redemo.py* is lacking in the official Python distributions. The excellent and extremely useful *Regular expressions HOWTO* of 3.2.x and 3.3 keep however referring to it (although referring to the wrong path *Tools/demo

[issue16233] IDLE: conceptual problems with *Class browser*

2012-10-14 Thread Francisco Gracia
New submission from Francisco Gracia: The *File* option in the menu bar of both the Python shell and the program editor have an entry called *Class Browser*. If one selects it from the shell window, one gets always an error message with the title: "No filename" which says: "Thi

[issue16229] Module *redemo.py* lacking in recent Python distributions

2012-10-15 Thread Francisco Gracia
Francisco Gracia added the comment: You are right. I am referring to the Windows installer. I forgot to mention that I am using Windows XP. Thank you. 2012/10/14 Ned Deily > > Ned Deily added the comment: > > The demo scripts in the Tools directory were cleaned up earlier in Py

[issue21450] [Issue 13630] IDLE: Find(ed) text is not highlighted while dialog box is open

2014-05-07 Thread Francisco Gracia
New submission from Francisco Gracia: I was delighted with the behaviour of IDLE in version 3.4 until I noticed the problem of the matches with the non highlighted background in the modified (and in this sense improved) iterative text search operations. I was wondering how could this be possible

[issue13630] IDLE: Find(ed) text is not highlighted while dialog box is open

2014-05-08 Thread Francisco Gracia
Francisco Gracia added the comment: I had problems for installing your *SearchBar*, Tal, in Python 33 and 34 until it downed onto me that in its present form it is only Python 2 compliant. This is then its first weakness, that of course can be easily remedied by applying *2to3.py* to it, as I

[issue13630] IDLE: Find(ed) text is not highlighted while dialog box is open

2014-05-09 Thread Francisco Gracia
Francisco Gracia added the comment: The neat program *redemo.py* toggles between *Highlight first match* and *Highlight all matches*. -- ___ Python tracker <http://bugs.python.org/issue13

[issue14019] Unify tests for str.format and string.Formatter

2014-05-23 Thread Francisco Freire
Francisco Freire added the comment: Hi, I signed the contributor agreement. Thank you for your review comments. I did these tests about one year ago and right now I don't have much time to look at it again. I hope to do so in the next months. -- status: pending -&

[issue29630] REPL tab-completion triggers code execution

2017-02-23 Thread Francisco Demartino
New submission from Francisco Demartino: On the REPL, when autocompleting with the TAB key, getattr is called, potentially triggering code execution. This took me by surprise. Until you press RETURN, it should be pretty safe to go around autocompleting with certainty that you won't ru

[issue29630] REPL tab-completion triggers code execution

2017-02-23 Thread Francisco Demartino
Francisco Demartino added the comment: This branch (working on the PR) fixes it: https://github.com/franciscod/cpython/tree/bpo-29630 -- ___ Python tracker <http://bugs.python.org/issue29

[issue29630] REPL tab-completion triggers code execution

2017-02-23 Thread Francisco Demartino
Changes by Francisco Demartino : -- pull_requests: +213 status: pending -> open ___ Python tracker <http://bugs.python.org/issue29630> ___ ___ Python-bugs-lis

[issue29630] REPL tab-completion triggers code execution

2017-02-23 Thread Francisco Demartino
Francisco Demartino added the comment: I've updated that branch and made a pull request (https://github.com/python/cpython/pull/248) I think this is a good compromise: inspect.getattr_static can tell if it's a property, and in that case we don't call getattr on it to prevent

[issue29630] REPL tab-completion triggers code execution

2017-02-23 Thread Francisco Demartino
Francisco Demartino added the comment: > There is no way to safely inspect any Python object without triggering some > dunder functions like __getattr__, __getattribute__ or __dir__. But somehow inspect.getattr_static can do it? > Your change is not backwards compatible and m

[issue29630] REPL tab-completion triggers code execution

2017-02-23 Thread Francisco Demartino
Francisco Demartino added the comment: Serhiy, Chris, thank you for your additional comments. They surely helped me understand why my solution to this "problem?" isn't that good (also I slept on it a bit and maybe that helped). I still ponder for a way to get autoc

[issue27427] Math tests

2016-06-30 Thread Francisco Couzo
New submission from Francisco Couzo: I added some tests for the math module. -- components: Tests files: test_math.patch keywords: patch messages: 269632 nosy: franciscouzo priority: normal severity: normal status: open title: Math tests versions: Python 3.6 Added file: http

[issue26830] Refactor Tools/scripts/google.py

2016-04-22 Thread Francisco Couzo
Changes by Francisco Couzo : -- files: scripts_google.patch keywords: patch nosy: franciscouzo priority: normal severity: normal status: open title: Refactor Tools/scripts/google.py type: enhancement versions: Python 3.6 Added file: http://bugs.python.org/file42572/scripts_google.patch

[issue26830] Refactor Tools/scripts/google.py

2016-04-23 Thread Francisco Couzo
Francisco Couzo added the comment: I was also going to refactor the other demo scripts, but first I wanted to make sure there was at least some kind of interest in it. -- ___ Python tracker <http://bugs.python.org/issue26

[issue26830] Refactor Tools/scripts/google.py

2016-04-29 Thread Francisco Couzo
Francisco Couzo added the comment: Here's the patch with the modifications from the review. -- Added file: http://bugs.python.org/file42657/scripts_google_v2.patch ___ Python tracker <http://bugs.python.org/is

[issue21879] str.format() gives poor diagnostic on placeholder mismatch

2016-09-09 Thread Francisco Couzo
Changes by Francisco Couzo : -- keywords: +patch Added file: http://bugs.python.org/file44490/format.patch ___ Python tracker <http://bugs.python.org/issue21

[issue21879] str.format() gives poor diagnostic on placeholder mismatch

2016-09-09 Thread Francisco Couzo
Changes by Francisco Couzo : -- nosy: +franciscouzo ___ Python tracker <http://bugs.python.org/issue21879> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28139] Misleading Indentation

2016-09-13 Thread Francisco Couzo
New submission from Francisco Couzo: Fixed the warnings that appear when compiling 2.7 with -Wmisleading-indentation (Included in -Wall since GCC 6). Kinda related, though I don't think there would be too much interest in fixing it (all the tabs in Python's C source): $ find .

[issue26830] Refactor Tools/scripts/google.py

2016-09-14 Thread Francisco Couzo
Changes by Francisco Couzo : Added file: http://bugs.python.org/file44652/scripts_google_v4.patch ___ Python tracker <http://bugs.python.org/issue26830> ___ ___ Python-bug

[issue28145] Fix whitespace in C source code

2016-09-14 Thread Francisco Couzo
New submission from Francisco Couzo: I changed most of the tabs in the source code to spaces, and removed trailing whitespace. I also made some scripts that generate code use spaces and not generate trailing whitespace. (makesetup and makeunicodedata.py) I fixed a typo in Modules/makesetup

[issue27482] heap-buffer-overflow on address 0x6250000078ff

2016-09-15 Thread Francisco Couzo
Francisco Couzo added the comment: I can confirm this bug is also present in 3.7 -- nosy: +franciscouzo versions: +Python 3.7 ___ Python tracker <http://bugs.python.org/issue27

[issue28169] shift exponent overflow

2016-09-15 Thread Francisco Couzo
New submission from Francisco Couzo: Steps to reproduce: make distclean LDFLAGS="-lasan -lubsan" CFLAGS="-fsanitize=address -fsanitize=undefined" ./configure ASAN_OPTIONS="detect_leaks=0" make UBSAN_OPTIONS=print_stacktrace=1 ASAN_OPTIONS="allocator_may_ret

[issue28184] Trailing whitespace in C source code

2016-09-16 Thread Francisco Couzo
New submission from Francisco Couzo: As per Terry's recommendations (#28145), I'm going to open a new issue for each case. -- files: trailing_whitespace.patch keywords: patch messages: 276761 nosy: franciscouzo, josh.r, mark.dickinson, martin.panter, r.david.murray, t

[issue28185] Tabs in C source code

2016-09-16 Thread Francisco Couzo
New submission from Francisco Couzo: Files I didn't change: Python/dup2.c, Python/strdup.c (Since they are external dependencies) -- files: tabs_c.patch keywords: patch messages: 276762 nosy: franciscouzo, josh.r, mark.dickinson, martin.panter, r.david.murray, terry.reedy pri

[issue28185] Tabs in C source code

2016-09-16 Thread Francisco Couzo
Changes by Francisco Couzo : -- versions: +Python 3.7 Added file: http://bugs.python.org/file44703/tabs_h.patch ___ Python tracker <http://bugs.python.org/issue28

[issue28185] Tabs in C source code

2016-09-16 Thread Francisco Couzo
Changes by Francisco Couzo : Removed file: http://bugs.python.org/file44703/tabs_h.patch ___ Python tracker <http://bugs.python.org/issue28185> ___ ___ Python-bugs-list m

[issue28185] Tabs in C source code

2016-09-16 Thread Francisco Couzo
Changes by Francisco Couzo : Added file: http://bugs.python.org/file44704/tabs_h.patch ___ Python tracker <http://bugs.python.org/issue28185> ___ ___ Python-bugs-list m

[issue28184] Trailing whitespace in C source code

2016-09-16 Thread Francisco Couzo
Changes by Francisco Couzo : Added file: http://bugs.python.org/file44706/trailing_whitespace2.patch ___ Python tracker <http://bugs.python.org/issue28184> ___ ___ Pytho

[issue28186] Autogenerated tabs / trailing whitespace

2016-09-16 Thread Francisco Couzo
New submission from Francisco Couzo: Fix some auto generated whitespace issues (tabs and trailing whitespace) -- files: autogenerated_whitespace.patch keywords: patch messages: 276774 nosy: franciscouzo priority: normal severity: normal status: open title: Autogenerated tabs / trailing

[issue28186] Autogenerated tabs / trailing whitespace

2016-09-17 Thread Francisco Couzo
Changes by Francisco Couzo : Added file: http://bugs.python.org/file44709/autogenerated_whitespace2.patch ___ Python tracker <http://bugs.python.org/issue28186> ___ ___

[issue28145] Fix whitespace in C source code

2016-09-17 Thread Francisco Couzo
Francisco Couzo added the comment: I'm closing this issue since I've created new issues for each case, please refer to #28184, #28185, and #28186. -- status: open -> closed ___ Python tracker <http://bugs.pytho

[issue28186] Autogenerated tabs / trailing whitespace

2016-09-17 Thread Francisco Couzo
Changes by Francisco Couzo : Removed file: http://bugs.python.org/file44707/autogenerated_whitespace.patch ___ Python tracker <http://bugs.python.org/issue28186> ___ ___

[issue28475] Misleading error on random.sample when k < 0

2016-10-19 Thread Francisco Couzo
New submission from Francisco Couzo: Improved a bit the error message when k < 0, and also added a comment about it on the documentation and an additional test case. -- assignee: docs@python components: Documentation, Library (Lib), Tests files: random_sample.patch keywords: pa

[issue28476] Remove redundant definition of factorial on test_random

2016-10-19 Thread Francisco Couzo
Changes by Francisco Couzo : -- components: Tests files: test_random.patch keywords: patch nosy: franciscouzo priority: normal severity: normal status: open title: Remove redundant definition of factorial on test_random Added file: http://bugs.python.org/file45142/test_random.patch

[issue28475] Misleading error on random.sample when k < 0

2016-10-19 Thread Francisco Couzo
Changes by Francisco Couzo : Added file: http://bugs.python.org/file45144/random_sample2.patch ___ Python tracker <http://bugs.python.org/issue28475> ___ ___ Python-bug

[issue28540] math.degrees(sys.float_info.max) should throw an OverflowError exception

2016-10-26 Thread Francisco Couzo
New submission from Francisco Couzo: Most functions in the math library raise an OverflowError when the arguments are finite but the result is not. >>> math.exp(sys.float_info.max) Traceback (most recent call last): File "", line 1, in OverflowError: math range erro

[issue28593] Inconsistent itertools' predicate behaviour

2016-11-02 Thread Francisco Couzo
New submission from Francisco Couzo: As per Terry's recommendation https://mail.python.org/pipermail/python-dev/2016-November/146791.html Currently some functions in itertools (dropwhile and takewhile), don't accept None as a predicate, but filterfalse and groupby do. I'd

[issue28593] Inconsistent itertools' predicate behaviour

2016-11-04 Thread Francisco Couzo
Francisco Couzo added the comment: I think removing None as a valid predicate to filterfalse would make the API simpler, but I don't know if it's worth the API change, please do close the issue if you think it's not worth it. -- ___

[issue13117] Broken links in the “compiler” page, section “references” from the devguide.

2011-10-06 Thread Francisco Martín Brugué
New submission from Francisco Martín Brugué : Hi, In the page http://docs.python.org/devguide/compiler.html the links in the references [1] (http://www.foretec.com/python/workshops/1998-11/proceedings/papers/montanaro/montanaro.html) and in [Wang97] (http://www.cs.princeton.edu/%7Edanwang

[issue13117] Broken links in the “compiler” page, section “references” from the devguide.

2011-10-06 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: The reference for [1] could be changed to: http://www.python.org/workshops/1998-11/proceedings/papers/montanaro/montanaro.html -- ___ Python tracker <http://bugs.python.org/issue13

[issue13117] Broken links in the “compiler” page, section “references” from the devguide.

2011-10-06 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: The reference to [Wang97] could be changed to: http://www.cs.princeton.edu/research/techreps/TR-554-97 -- ___ Python tracker <http://bugs.python.org/issue13

[issue13117] Broken links in the “compiler” page, section “references” from the devguide.

2011-10-06 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: A patch with the links mentioned above. -- keywords: +patch Added file: http://bugs.python.org/file23329/issue13117.patch ___ Python tracker <http://bugs.python.org/issue13

[issue12659] Add tests for packaging.tests.support

2011-10-10 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: The patch is updated. Let me know if I've understood your review. Thanks ! -- Added file: http://bugs.python.org/file23370/issue12659_v3.patch ___ Python tracker <http://bugs.python.org/is

[issue12659] Add tests for packaging.tests.support

2011-10-22 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Hi Éric, Nice! and thanks for the info: I was just waiting to the check-in to compare and try further with the tests. Now I can just commit another patch by synching against the actual tip. Cheers, francis

[issue13193] test_packaging and test_distutils failures

2011-10-24 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Hi Eli, I cannot find the file/Distro: find / -name *'dist-info' 2> /dev/null /home/ci/cpython/Lib/packaging/tests/fake_dists/grammar-1.0a4.dist-info /home/ci/cpython/Lib/packaging/tests/fake_dists/towel_stuff-0.1.dist-info /home/c

[issue13193] test_packaging and test_distutils failures

2011-10-24 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: The changeset was: $ hg tip changeset: 73075:d4839fea4a5a [...] -- ___ Python tracker <http://bugs.python.org/issue13

[issue13193] test_packaging and test_distutils failures

2011-10-24 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: > >> Where should be the distro? > > You won't find it in the hg repository - it gets created by the test, and > then deleted afterwards. Thanks for the info > >> The changeset was: >> $ hg tip >> changes

[issue12659] Add tests for packaging.tests.support

2011-11-14 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Hi Éric, I've mutated test_support.py a bit and now passes in https://bitbucket.org/tarek/distutils2 changeset:6c3d67ed3adb. I've added runTest to Tester, used os.unlink also removed the test fake_dec test as in support.py from distutils2

[issue12185] Decimal documentation lists "first" and "second" arguments, should be "self" and "other"

2011-06-03 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Hi all, that is my first contribution. Please let me know if all it's OK. Thanks in advance ! -- keywords: +patch nosy: +francismb Added file: http://bugs.python.org/file8/issue_12185.patch ___ P

[issue12185] Decimal documentation lists "first" and "second" arguments, should be "self" and "other"

2011-06-04 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Hi Adam, I couldn’t see that from the threat context, I'm new to this and just wanted to learn the work flow and tools so I've just picked up an easy issue to start with. Anyway your patch seems mor

[issue10206] python program starting with unmatched quote spews spaces to stdout

2011-06-24 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: I've attached an alternative test case. I'm not sure if there is a more robust way to test: self.assert_('SyntaxError' in err.decode('ascii', 'ignore')) Due the use of 'SyntaxtError' directly as strin

[issue10206] python program starting with unmatched quote spews spaces to stdout

2011-06-24 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Just attaching the review patch -- Added file: http://bugs.python.org/file22443/issue10206v2.patch ___ Python tracker <http://bugs.python.org/issue10

[issue10206] python program starting with unmatched quote spews spaces to stdout

2011-06-24 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: On 06/24/2011 06:07 PM, R. David Murray wrote: > self.assertRegex(err.decode('ascii', 'ignore'), 'SyntaxError') I understand that's the standard way to check if a given failure happened in the command line o

[issue2259] Poor support other than 44.1khz, 16bit audio files?

2011-07-18 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Adding a test that opens the 24b48k.aif file, gets some information and does navigation on it. I'm aware that it doesn't triggers any extra failure against the actual tip (5a1bb8d4afd7) but it does if r72100 is undone (with some sma

[issue12659] Add tests for packaging.tests.support

2011-08-13 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: I've started with test for “fake_dec” and “TempdirManager”. Please let me know if that in the line you want. Thanks in advance Francis -- keywords: +patch nosy: +francismb Added file: http://bugs.python.org/file22895/issue12659_v1.

[issue12659] Add tests for packaging.tests.support

2011-09-03 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Hi Éric, sorry but I've not received that email. Could you simply paste/send me the link (I've not used Rietveld already and I can not to find that review). Thanks ! -- ___ Python trac

[issue12659] Add tests for packaging.tests.support

2011-09-07 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: I've updated the patch. From your review: the class 'Mixin' is still there as the idea was to imitate the use of 'TempdirManager' as is used in the rest of the tests and test what it's documentation says. Just let me know

[issue12659] Add tests for packaging.tests.support

2012-02-06 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: I've just updated “test_support.py” and tested against 'default' and 'distutils2' (after changing the imports). Just let me know what has to be changed ... BTW: in distutils2 I get (n

[issue13953] test_packaging: unused test?

2012-02-06 Thread Francisco Martín Brugué
Changes by Francisco Martín Brugué : -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue13953> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12659] Add tests for packaging.tests.support

2012-02-08 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: > If so, could you provide a patch this time? Done. The patch is against default. what about against distutils2? Do you need also a patch for it? -- Added file: http://bugs.python.org/file24458/issue12659_58bd6a58365d.pa

[issue13953] Get rid of doctests in packaging.tests.test_version

2012-02-08 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Hi here's a patch preview: it has to be re factored further but I stopped here as some tests failed: the out commented ones ... I've checked twice but I cannot see any diff, could you check that? Or, has maybe the behavior (due that bug) c

[issue13953] Get rid of doctests in packaging.tests.test_version

2012-02-09 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: I've done some cleanups -- Added file: http://bugs.python.org/file24471/issue13953_bf6f306ad5cf.patch ___ Python tracker <http://bugs.python.org/is

[issue13990] Benchmarks: 2to3 failures on the py3 side

2012-02-10 Thread Francisco Martín Brugué
New submission from Francisco Martín Brugué : Steps to reproduce: after following the usage instructions from make_perf3.sh go to the the py3 benchmarks directory and run the lib/2to3 tests (python3.2 test.py). The result are 3 failures and 17 errors. The equivalent procedure in the py2

[issue13953] Get rid of doctests in packaging.tests.test_version

2012-02-11 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Thank you for the review. Just some questions: Isn't that what the previous code (doctest code) did? I thought that the code should be ported as far backwards as possible and that's why I used the plain assertEqual (I don't know e

[issue12659] Add tests for packaging.tests.support

2012-02-11 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: On 02/11/2012 05:59 AM, Éric Araujo wrote: >> BTW: in distutils2 I get (not because of this change): > Actually I did fix that, but depending on your Python version the conditional > in the test may be wrong. What’s the Python version

[issue13953] Get rid of doctests in packaging.tests.test_version

2012-02-12 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Does a "doc test" test the output literally? (I've just always used unittest) Ok, thanks -- ___ Python tracker <http://bugs.pyt

[issue13579] string.Formatter doesn't understand the !a conversion specifier

2012-02-13 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Hi, here's a patch with the changes proposed by Terry Cheers, francis -- keywords: +patch nosy: +francismb Added file: http://bugs.python.org/file24512/issue13579_80a50b7ad88f.patch ___ Python tr

[issue14019] Unify tests for str.format and string.Formatter

2012-02-15 Thread Francisco Martín Brugué
Changes by Francisco Martín Brugué : -- nosy: +francismb ___ Python tracker <http://bugs.python.org/issue14019> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13579] string.Formatter doesn't understand the !a conversion specifier

2012-02-15 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: I have updated the patch with the documentation changes proposed and also added a news entry (does a new entry has to be added in some order?). Thank for the review in advance. -- Added file: http://bugs.python.org/file24526

[issue13579] string.Formatter doesn't understand the !a conversion specifier

2012-02-18 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Updated. The NEWS line is now at the top of the section. >As near as I can tell, the two change block beginning with >+In less formal terms, >[...] >are strictly re-wrapping and no text changes. Correct? Yes. Just a pydev question here

[issue13579] string.Formatter doesn't understand the !a conversion specifier

2012-02-18 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: > I suspect mq will confuse make patchcheck (since it looks for > differences between the working copy and the hg branch tip, and there > are no such differences for an applied mq patch). Does it makes sense to open a feature request

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-19 Thread Francisco Martín Brugué
New submission from Francisco Martín Brugué : The devguide (http://docs.python.org/devguide/patch.html) recommends the use of the mercurial “mq” feature to work with patches and that works IMHO very well. It also states that before sending the patch a sanity check should be done ('dev

[issue13579] string.Formatter doesn't understand the !a conversion specifier

2012-02-19 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Well, it's done: http://bugs.python.org/issue14053 -- ___ Python tracker <http://bugs.python.org/issue13579> ___ ___

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-19 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Here is a patch that works for me. Please check and review it. Thanks in advance! Francis -- keywords: +patch Added file: http://bugs.python.org/file24566/issue14053_336a614f35a3.patch ___ Python tracker

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-20 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Nice feedback ! One question : > >An alternative approach that solves all three of these problems is to >check whether we have any patches applied (using "hg qapplied"), and if >this is the case, then add "--r

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-20 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: The patch is updated. Notice about: [...]Ideally, it should distinguish between this and other errors by checking the subprocess's stderr, so that if a different error occurs, we can still print out the error message. […] that should be imp

  1   2   >