[issue12009] netrc module crashes if netrc file has comment lines

2011-06-10 Thread R. David Murray
R. David Murray added the comment: lexer.instream.readline(): no, we can't just call that without the seek, because reading the token that started with # may have caused the line to be consumed already. I've expanded the comment to explain this. cygwin: I'd add a comment if I

[issue11416] netrc module does not handle multiple entries for a single host

2011-06-10 Thread R. David Murray
R. David Murray added the comment: This should not be applied until after the patch for #12009 is applied, at which point the test will need to be adjusted. #12009 completely refactors the netrc test suite. I wonder if the 'hosts' attribute should be deprecated, but let&#x

[issue12314] regrtest checks (os.environ, sys.path, etc.) are hard to use

2011-06-10 Thread R. David Murray
R. David Murray added the comment: Improvements are welcome, the whole thing was a QnD hack that has been evolving over time...maybe there's some way to reuse unittest's assertEqual machinery? I also wonder if the whole environment-changed thing should be moved into unittest so it

[issue12314] regrtest checks (os.environ, sys.path, etc.) are hard to use

2011-06-10 Thread R. David Murray
Changes by R. David Murray : -- stage: -> needs patch type: -> feature request ___ Python tracker <http://bugs.python.org/issue12314> ___ ___ Python-bugs-

[issue12325] regex matches incorrectly on literal dot (99.9% confirmed)

2011-06-13 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue12063] tokenize module appears to treat unterminated single and double-quoted strings inconsistently

2011-06-13 Thread R. David Murray
R. David Murray added the comment: I agree with Petri, so I'm setting this to a doc issue. -- assignee: -> docs@python components: +Documentation nosy: +docs@python, r.david.murray stage: -> needs patch type: -> behavior ___ Python

[issue12174] Multiprocessing logging levels unclear

2011-06-13 Thread R. David Murray
R. David Murray added the comment: I think it would be good to mention the numeric levels in the text as well (in parenthesis, perhaps), unless the rest of the logging docs no longer refer to the numeric levels. -- nosy: +r.david.murray ___ Python

[issue11669] Clarify Lang Ref "Compound statements" footnote

2011-06-13 Thread R. David Murray
R. David Murray added the comment: Sometimes we use the patch keyword for doc issues where someone has suggested a specific new wording but not generated an actual patch. That seems to be the case here. -- nosy: +r.david.murray ___ Python tracker

[issue11669] Clarify Lang Ref "Compound statements" footnote

2011-06-13 Thread R. David Murray
Changes by R. David Murray : -- versions: -Python 3.1 ___ Python tracker <http://bugs.python.org/issue11669> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12327] in HTTPConnection the are len(body) and TypeError catch exception to detect if body is file like object, this hack do work with StringIO object

2011-06-13 Thread R. David Murray
R. David Murray added the comment: fileno and stat won't work on a StringIO object. So StringIO would need to be special cased to call getvalue. -- nosy: +orsenthil, r.david.murray ___ Python tracker <http://bugs.python.org/is

[issue8260] When I use codecs.open(...) and f.readline() follow up by f.read() return bad result

2011-06-13 Thread R. David Murray
R. David Murray added the comment: According to this ticket it hasn't been applied anywhere yet (a message will be posted here when it is). -- nosy: +r.david.murray versions: +Python 3.3 -Python 3.1 ___ Python tracker <http://bugs.py

[issue12327] in HTTPConnection the are len(body) and TypeError catch exception to detect if body is file like object, this hack do work with StringIO object

2011-06-13 Thread R. David Murray
R. David Murray added the comment: But if the len information is available, why not return it? -- ___ Python tracker <http://bugs.python.org/issue12327> ___ ___

[issue12327] in HTTPConnection the are len(body) and TypeError catch exception to detect if body is file like object, this hack do work with StringIO object

2011-06-13 Thread R. David Murray
Changes by R. David Murray : -- versions: +Python 3.2 -Python 2.6 ___ Python tracker <http://bugs.python.org/issue12327> ___ ___ Python-bugs-list mailin

[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases

2011-06-13 Thread R. David Murray
R. David Murray added the comment: Is it really necessary to copy this file? I haven't looked at the tests, but I'm wondering if they are using xxmodule.c only because it already existed. Could the test instead use a much simpler .c file that it creates on the fly? -

[issue12330] Named set methods on collections.Set and dict view objects

2011-06-13 Thread R. David Murray
R. David Murray added the comment: IIUC, collections.Set is, by definition, the full 'set' API. The fact that the set builtin implements some additional methods is a convenience. -- nosy: +r.david.murray, rhettinger ___ Python trac

[issue12330] Named set methods on collections.Set and dict view objects

2011-06-13 Thread R. David Murray
R. David Murray added the comment: collections.Set (in python 3.3, collections.abc.Set) is the *definition* of the minimal API. To construct a class that conforms to the minimal definition is certainly easier than constructing one that supports all of the methods that the set builtin does

[issue12327] in HTTPConnection the are len(body) and TypeError catch exception to detect if body is file like object, this hack do work with StringIO object

2011-06-15 Thread R. David Murray
R. David Murray added the comment: The code you are suggesting patching is trying its best to return a length. If that code needs to be fixed to not throw an error when confronted with a StringIO, then it should do its best to return a length. Your original message on the ticket did not

[issue11934] build with --prefix=/dev/null and zlib enabled in Modules/Setup failed

2011-06-15 Thread R. David Murray
R. David Murray added the comment: I normally build using --prefix, often with --prefix=/dev/null, and I can't recall any version not building zlib. Of course, I don't uncomment the zlib entry in Modules/Setup. As far as I can see the zlib entry is unique in Setup in using pre

[issue12314] regrtest checks (os.environ, sys.path, etc.) are hard to use

2011-06-15 Thread R. David Murray
R. David Murray added the comment: Sounds like a plan. -- ___ Python tracker <http://bugs.python.org/issue12314> ___ ___ Python-bugs-list mailing list Unsub

[issue1711800] SequenceMatcher bug with insert/delete block after "replace"

2011-06-15 Thread R. David Murray
R. David Murray added the comment: No need to apologize for the bump. The trick is catching the interest of someone who feels qualified to judge the patch. I've added a couple people to nosy who worked on difflib recently. If no one speaks up in the next few days, it might be time to

[issue12340] Access violation when using the C version of the io module

2011-06-15 Thread R. David Murray
Changes by R. David Murray : -- nosy: +pitrou ___ Python tracker <http://bugs.python.org/issue12340> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11102] configure doesn't find "major()" on HP-UX v11.31

2011-06-15 Thread R. David Murray
R. David Murray added the comment: Well, one way might be to set up and maintain an HP/UX buildbot :) Other than that, just keep bugging us periodically until someone gets around to doing it. -- nosy: +r.david.murray stage: -> commit review type: -> compile

[issue12342] characters with ord above 65535 fail to display in IDLE

2011-06-15 Thread R. David Murray
R. David Murray added the comment: Judging from the stack trace, it isn't str.format that's failing, it's tk failing to display it. -- nosy: +r.david.murray, terry.reedy title: characters with ord above 65535 fail conversion with str.format for '{:c}' in ID

[issue12346] Python 2.7.2 source code build (release) depends on mercurial

2011-06-16 Thread R. David Murray
R. David Murray added the comment: It used to be that the svn version info was pulled from embedded constants in Makefile.pre.in. I agree that depending on having mercurial (and, presumably, a repo!) at build time is wrong. These constants need to be pre-computed when a release tarball is

[issue12346] Python 2.7.2 source code build (release) depends on mercurial

2011-06-16 Thread R. David Murray
R. David Murray added the comment: Indeed, I just confirmed that building with a recent version of mercurial installed from the release 2.7.2 source tarball from python.org, the make results in: abort: repository . not found! abort: repository . not found! abort: repository . not found

[issue12313] make install misses test dirs for packaging and email modules

2011-06-16 Thread R. David Murray
R. David Murray added the comment: Fixing the missing dirs for email has been on my todo list for a while but obviously hasn't gotten done yet. I talked with Antoine about setting up a buildbot that tested an installed version, but I'm not sure when I'll get around to tryin

[issue12346] Python 2.7.2 source code build (release) depends on mercurial

2011-06-16 Thread R. David Murray
R. David Murray added the comment: Ah. For subversion there was a similar check, and the values were set to blank if the subversion binary was not found. For hg it looks like we need to add additional checks on whether or not there is a repo. (We can probably assume that if there is a

[issue9302] distutils API Reference: setup() and Extension parameters' description not correct.

2011-06-16 Thread R. David Murray
R. David Murray added the comment: I would not read [str] as implying a list of strings, FWIW. Nor would I assume a plural option meant a list if the text says "a string". But I'm just a bystander here and haven't even looked the docs y

[issue12350] Improve stat_result.st_blocks and st_blksize documentation

2011-06-16 Thread R. David Murray
R. David Murray added the comment: Looks good for linux. Do you have a posix reference that confirms this interpretation? -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue12

[issue12313] make install misses test dirs for packaging and email modules

2011-06-16 Thread R. David Murray
R. David Murray added the comment: Ah. I wouldn't have expected that. For my information, what was the error you got? -- ___ Python tracker <http://bugs.python.org/is

[issue12350] Improve stat_result.st_blocks and st_blksize documentation

2011-06-16 Thread R. David Murray
R. David Murray added the comment: Ah, bingo. That was what was tickling at my memory but I couldn't remember what the exact issue was I was recalling. I forget what I was doing where that mattered, but as I vaguely remember it there is no portable way to find out what blocksize st_b

[issue12350] Improve stat_result.st_blocks and st_blksize documentation

2011-06-16 Thread R. David Murray
R. David Murray added the comment: Ah, found it: Issue 10016. -- ___ Python tracker <http://bugs.python.org/issue12350> ___ ___ Python-bugs-list mailin

[issue12350] Improve stat_result.st_blocks and st_blksize documentation

2011-06-16 Thread R. David Murray
Changes by R. David Murray : -- versions: +Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issue12350> ___ ___ Python-bugs-list mailin

[issue9344] please add posix.getgrouplist()

2011-06-16 Thread R. David Murray
R. David Murray added the comment: Actually, when it is a feature request rather than a bug fix we usually use 'accepted'. It doesn't matter a whole lot, though. -- nosy: +r.david.murray ___ Python tracker <http://bugs.py

[issue8887] "pydoc str" works but not "pydoc str.translate"

2011-06-16 Thread R. David Murray
Changes by R. David Murray : -- title: “pydoc str” works but not “pydoc str.translate” -> "pydoc str" works but not "pydoc str.translate" ___ Python tracker <http:/

[issue12313] make install misses test dirs for packaging and email modules

2011-06-16 Thread R. David Murray
R. David Murray added the comment: OK, now I'm really confused. I tried to reproduce this by installing from my checkout into a work dir, and then running regrtest using that installed python, and discovered that test_email and its data directory got copied by the installation pr

[issue12320] test_packaging failures

2011-06-16 Thread R. David Murray
R. David Murray added the comment: Victor, that failure was already reported in issue 12333. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue12

[issue12346] Python 2.7.2 source code build (release) depends on mercurial

2011-06-17 Thread R. David Murray
R. David Murray added the comment: That needs to be ported to the other branches, then. Ezio, on a completely unrelated note, notice what happened to Ralf's reference. I think the regexes may need to be reordered. -- nosy: +ezio.me

[issue8716] test_tk/test_tkk_guionly fails on OS X if run from buildbot slave daemon -- crashes Python

2011-06-17 Thread R. David Murray
R. David Murray added the comment: Bump, this failure is still happening on the ppc tiger buildbot periodically. -- nosy: +ned.deily ___ Python tracker <http://bugs.python.org/issue8

[issue12313] make install misses test dirs for packaging and email modules

2011-06-17 Thread R. David Murray
R. David Murray added the comment: Well, regardless of whether or not I understand what's going on, clearly those directories in the makefile needed updating, so I did it. -- ___ Python tracker <http://bugs.python.org/is

[issue4470] smtplib SMTP_SSL not working.

2011-06-17 Thread R. David Murray
R. David Murray added the comment: Torsten, can you provide a clear, failing unittest for this? -- ___ Python tracker <http://bugs.python.org/issue4470> ___ ___

[issue12353] argparse cannot handle empty arguments

2011-06-17 Thread R. David Murray
R. David Murray added the comment: Thanks for the report and patch. I'm setting this to test needed since the final patch will need a unit test. The idiomatic way to do this kind of check is 'if not argstring or arg_string[0] not in self.fromfile_prefix_chars):' --

[issue4470] smtplib SMTP_SSL not working.

2011-06-17 Thread R. David Murray
R. David Murray added the comment: According to your traceback you should be seeing the error in the first line (the creation of the SMTP_SSL object). If I run that line at the python prompt of python2.7.1, I get your connection failure. If I run it using 2.7 tip (or 3.3 tip), the

[issue11767] Maildir iterator leaks file descriptors by default

2011-06-17 Thread R. David Murray
R. David Murray added the comment: The patch doesn't work on 2.7. The failures are related to #11700, although that would seem to indicate that something *is* trying to close the file. I have no idea what. -- dependencies: +mailbox.py proxy up

[issue11767] Maildir iterator leaks file descriptors by default

2011-06-17 Thread R. David Murray
R. David Murray added the comment: Well, if you want to you could investigate further, and try the patch from #11700 and see what is left to do here after it has been applied. I'll try to get 11700 in soon, though. -- ___ Python tracker

[issue12167] test_packaging reference leak

2011-06-17 Thread R. David Murray
R. David Murray added the comment: It means that objects were garbage collected. The refleak test runs the test multiple times, and ignores the first N runs to allow the object count to "settle". But sometimes it either doesn't settle, or later runs end up with objects

[issue12350] Improve stat_result.st_blocks and st_blksize documentation

2011-06-17 Thread R. David Murray
R. David Murray added the comment: I think that wording is as good as we can do for now. Providing a way to determine the size of st_blocks blocks should be a separate issue (a feature request). That enhancement can include an update to these docs, but since it is an enhancement it will

[issue12337] Need real TextIOWrapper for stdin/stdout

2011-06-17 Thread R. David Murray
R. David Murray added the comment: I'm not sure what the point of your example is, Terry. Is it not fixed in 3.2.1? -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/is

[issue11700] mailbox.py proxy close method cannot be called multiple times

2011-06-17 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed title: mailbox.py proxy updates -> mailbox.py proxy close method cannot be called multiple times type: -> behavior ___

[issue11767] Maildir iterator leaks file descriptors by default

2011-06-17 Thread R. David Murray
R. David Murray added the comment: Well, it turns out I was totally wrong about the 11700 dependency. I misread the errors that were produced by the test suite. Even after fixing 11700 they are still there: the tests are reading from the closed files. So something changed in the logic

[issue12359] tutorial: Module search path description is incorrect

2011-06-18 Thread R. David Murray
R. David Murray added the comment: The second paragraph goes on to cover your point, but I agree that it is not as clear as it should be. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue12

[issue11781] test/test_email directory does not get installed by 'make install'

2011-06-18 Thread R. David Murray
R. David Murray added the comment: I forgot that I had this issue open. I committed the makefile part of the patch in issue 12313. I currently have no way to test the windows part, but it seems a straightforward modification of the existing code, so I'm going to comm

[issue11781] test/test_email directory does not get installed by 'make install'

2011-06-18 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> compile error ___ Python tracker <http://bugs.python

[issue11584] email.decode_header fails if msg.__getitem__ returns Header object

2011-06-18 Thread R. David Murray
R. David Murray added the comment: OK, the invariant make_header(decode_header(x)) == x should once again work for anything returned by __getitem__. -- stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker

[issue11584] email.decode_header fails if msg.__getitem__ returns Header object

2011-06-18 Thread R. David Murray
R. David Murray added the comment: Heh, I misstated that invariant, it's only true when x is a Header. -- ___ Python tracker <http://bugs.python.org/is

[issue11873] test_regexp() of test_compileall fails occassionally

2011-06-18 Thread R. David Murray
Changes by R. David Murray : -- status: -> open ___ Python tracker <http://bugs.python.org/issue11873> ___ ___ Python-bugs-list mailing list Unsubscri

[issue12346] Python source code build (release) depends on mercurial

2011-06-18 Thread R. David Murray
Changes by R. David Murray : -- title: Python 2.7.2 source code build (release) depends on mercurial -> Python source code build (release) depends on mercurial ___ Python tracker <http://bugs.python.org/issu

[issue3216] Scarce msilib documentation

2011-06-18 Thread R. David Murray
Changes by R. David Murray : -- keywords: -easy, patch ___ Python tracker <http://bugs.python.org/issue3216> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12147] smtplib.send_message does not implement corectly rfc 2822

2011-06-18 Thread R. David Murray
R. David Murray added the comment: I think we can treat this as a bug. However... What if there is more than one set of Resent- headers? I think that it is not possible to guarantee we only look at the most recent set, since the RFC provides no way to identify a "set". Heuris

[issue12357] Python dist modifications for secure PyPI uploads

2011-06-18 Thread R. David Murray
R. David Murray added the comment: Furthermore, Éric is the one who is going to commit the patch, and therefore these tracker issues should be organized to provide him with maximum productivity. If he thinks this should be closed, then it should be closed. If you wish to continue to argue

[issue6771] Curses.wrapper: documentation/implementation error

2011-06-18 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.o

[issue12361] Memory Leak in File Logging

2011-06-18 Thread R. David Murray
Changes by R. David Murray : -- nosy: +vinay.sajip ___ Python tracker <http://bugs.python.org/issue12361> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12362] General Windows stdout redirection not working

2011-06-19 Thread R. David Murray
R. David Murray added the comment: The file association for .py is pythonw, which does exactly as you say, intentionally, so as to avoid problems with windows when running a GUI application. My understanding is that this caters to the most common use case on Windows: double clicking a .py

[issue12362] General Windows stdout redirection not working

2011-06-19 Thread R. David Murray
Changes by R. David Murray : -- dependencies: -Error in sys.excepthook on windows when redirecting output of the script superseder: -> Error in sys.excepthook on windows when redirecting output of the script ___ Python tracker &l

[issue10454] Clarify compileall command-line options

2011-06-19 Thread R. David Murray
R. David Murray added the comment: Looks fine except for your changes to the parenthesized defaults. Those should be '0' and 'False' for 2.7 and 3.x, respectively, since that's what they areally are. -- ___ Python tracker

[issue11795] Better core dev guidelines for committing submitted patches

2011-06-19 Thread R. David Murray
R. David Murray added the comment: Note that the older tradition was to *not* mention the contributor in NEWS (NEWS was just technical notes), but to mention them in the checkin message (and What's New, for things that make the What's New cut). However, since we can't edit c

[issue12362] General Windows stdout redirection not working

2011-06-19 Thread R. David Murray
R. David Murray added the comment: Ah, I should have known better than to rely on a memory instead of checking, since I don't use Windows much. My apologies. -- dependencies: +Error in sys.excepthook on windows when redirecting output of the script resolution: invalid -> d

[issue12346] Python source code build fails with old mercurial

2011-06-19 Thread R. David Murray
R. David Murray added the comment: Only if Ralf's patch is applied to all branches. Otherwise the make step reports "abort: repository . not found!", which most users will ignore but a few will report here. It looks from Ralf's quoted changeset like it was only app

[issue12255] A few changes to .*ignore

2011-06-19 Thread R. David Murray
R. David Murray added the comment: As I've said before, I would vote to not have .rej and .orig in .hgignore. You can always add them to your personal .hgignore, but I know of no way to tell mercurial "I *don't* want to ignore these files that are in the repo .hgignore".

[issue12255] A few changes to .*ignore

2011-06-19 Thread R. David Murray
R. David Murray added the comment: I have no idea what you mean by "for distrabution" in this context. The .hgignore in the checkout causes hg to ignore the files/patterns listed in it when any hg commands are run against that checkout. And no I can't remove it in my &quo

[issue6734] Imap lib implicit conversion from bytes to string

2011-06-19 Thread R. David Murray
R. David Murray added the comment: This was fixed in issue 4471 by Antoine when he added some tests that call login. He fixed it by changing _quote to work with strings. Per the discussion here I'm not sure this is the best fix, but until someone reports a bug with it it we may as wel

[issue12255] A few changes to .*ignore

2011-06-19 Thread R. David Murray
R. David Murray added the comment: Well, since there's no central server for hg, it can't track based on the server. Perhaps I confused you by saying that the .hgignore file was "in the repo". (It is "in the repo" in the sense that any tracked file is in th

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3

2011-06-19 Thread R. David Murray
Changes by R. David Murray : -- nosy: +pitrou ___ Python tracker <http://bugs.python.org/issue12291> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11873] test_regexp() of test_compileall fails occassionally

2011-06-20 Thread R. David Murray
R. David Murray added the comment: I reopened the issue because I don't know the answer to your question but suspect that it is an issue. So it needs to be checked. And the regex should be cleaned up regardless, for clarity's sake. --

[issue12374] Execution model should explain compile vs definition vs execution time

2011-06-20 Thread R. David Murray
R. David Murray added the comment: Isn't 'definition time' vs 'execution time' an artificial distinction? I'm surprised that the main module is compiled differently than a regular module. Is that an artifact of the CPython implementation or a part of the langu

[issue9998] ctypes find_library should search LD_LIBRARY_PATH on linux

2011-06-20 Thread R. David Murray
Changes by R. David Murray : -- nosy: +amaury.forgeotdarc, belopolsky -theller title: find_library should search LD_LIBRARY_PATH on linux -> ctypes find_library should search LD_LIBRARY_PATH on linux ___ Python tracker <http://bugs.pyth

[issue12147] smtplib.send_message does not implement corectly rfc 2822

2011-06-20 Thread R. David Murray
R. David Murray added the comment: Section 3.6.6 says: Resent fields are strictly informational. They MUST NOT be used in the normal processing of replies or other such automatic actions on messages. Further, since there is no specified order for the headers within a block, there

[issue12147] smtplib.send_message does not implement corectly rfc 2822

2011-06-20 Thread R. David Murray
R. David Murray added the comment: Note that that RFC language is clearly directed at automatic processing on *receipt*, not during sending. The RFC doesn't address automatic processing during sending, it leaves that the to the SMT

[issue12376] unittest.TextTestResult.__init__ breaks under complex __mro__

2011-06-20 Thread R. David Murray
Changes by R. David Murray : -- nosy: +michael.foord ___ Python tracker <http://bugs.python.org/issue12376> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

2011-06-20 Thread R. David Murray
R. David Murray added the comment: 2.6 is in security-fix-only mode. By inspection the 2.7 and 3.x code have the same issue (though the 3.x code is very different, there still appears to be a lack of error recovery logic. Joe, do you have any interest in writing a unit test for this? I

[issue12380] bytearray methods center, ljust, rjust don't accept a bytearray as the fill character

2011-06-21 Thread R. David Murray
R. David Murray added the comment: What's the use case? I'm inclined to reject this as not needed. -- nosy: +r.david.murray type: behavior -> feature request versions: +Python 3.3 -Python 2.7, Python 3.1 ___ Python tracker <http:/

[issue12381] bytearray methods count, find, index don't support None as in slice notation

2011-06-21 Thread R. David Murray
R. David Murray added the comment: As Raymond said in another issue, someone should fix this once and for all by factoring this check out into a reusable method and making sure it is used everywhere. -- keywords: +easy nosy: +r.david.murray versions: +Python 3.2, Python 3.3 -Python

[issue11869] Include information about the bug tracker Rietveld code review tool

2011-06-21 Thread R. David Murray
R. David Murray added the comment: Heh. You are assuming we know how it "should" be used :) It's pretty new yet, so I don't think we've figured that out. But at at least how it works should be mentioned in the devguide. ---

[issue12383] subprocess.Popen(..., env={}) fails to pass empty env.

2011-06-21 Thread R. David Murray
R. David Murray added the comment: The test appears to be failing on the buildbots: http://www.python.org/dev/buildbot/all/builders/x86%20Ubuntu%20Shared%203.2/builds/370 -- nosy: +r.david.murray status: closed -> open ___ Python tracker &l

[issue12380] bytearray methods center, ljust, rjust don't accept a bytearray as the fill character

2011-06-21 Thread R. David Murray
R. David Murray added the comment: A bytearray is for working with mutable data. We don't support using it in all places that the non-mutable data types can be used. You can code your example like this: barr.center(len(barr) * 4, bytes([barr[-1]])) I realize that isn't pa

[issue12385] the help for bytearray.maketrans describes bytes.maketrans

2011-06-21 Thread R. David Murray
R. David Murray added the comment: Hmm. I wonder why we have two copies of this method. Well, given that we do, the best fix for the docs would be to say "for use in the bytes or bytearray translate method" in both this docstring and the bytes.maketrans docstring. -

[issue12380] bytearray methods center, ljust, rjust don't accept a bytearray as the fill character

2011-06-21 Thread R. David Murray
R. David Murray added the comment: All right, let's get some other opinions from people who have actually worked with the bytearray and bytes code (and Terry because he cares about APIs). -- nosy: +haypo, ncoghlan, pitrou, rhettinger, terry.reedy status: closed -&

[issue12326] Linux 3: tests should avoid using sys.platform == 'linux2'

2011-06-22 Thread R. David Murray
R. David Murray added the comment: Indeed, the lib/plat- directories should continue to work just fine using linux3, correct? Or using linux, if we change sys.platform. (Note: just because we don't import them in the test suite doesn't mean that user code in the field isn't

[issue1874] email parser does not register a defect for invalid Content-Transfer-Encoding on multipart messages

2011-06-22 Thread R. David Murray
R. David Murray added the comment: Thanks for the patches. I didn't use them, but they were helpful references. This is in a grey area between a bug and a feature request. The fact is, though, that for the most part the email module currently doesn't make extra effort to detect d

[issue12389] typo in urllib: missing space after dot at sentence end

2011-06-22 Thread R. David Murray
R. David Murray added the comment: Thanks. -- nosy: +r.david.murray resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue12387] IDLE save keyboard shortcut problem

2011-06-22 Thread R. David Murray
Changes by R. David Murray : -- nosy: +kbk, terry.reedy ___ Python tracker <http://bugs.python.org/issue12387> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10354] tempfile.template is broken

2011-06-22 Thread R. David Murray
R. David Murray added the comment: I have removed the last mentions of template from the docs and docstrings, and added a comment that it is a private variable despite its name. I do not see a reason to break backward compatibility just to have a leading underscore in the name. If there is

[issue9921] os.path.join('x','') behavior

2011-06-22 Thread R. David Murray
R. David Murray added the comment: Here is a patch that I think describes the algorithm correctly, based on the comments in the module, with a clarifying parenthetical to cover the non-obvious consequence of that algorithm. -- versions: +Python 3.3 -Python 3.1 Added file: http

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

2011-06-22 Thread R. David Murray
R. David Murray added the comment: One question is whether this is a bug fix or a feature request. Other than that, I'd like to see the test classes collapsed into a single test class, considering that each one only has a single test in it. Probably ProxyAuthTests should be refactor

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

2011-06-23 Thread R. David Murray
R. David Murray added the comment: Oh, the bad error message is definitely a bug. The question is whether we can also add md5-sess support while fixing it. Sounds like Senthil thinks no, in which case this issue needs to be split into two parts

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

2011-06-23 Thread R. David Murray
R. David Murray added the comment: 3.3. IMO this is in the grey area between feature and bug fix. I think it is possible to argue that it can be treated as a bug fix, but I think we need opinions from other developers if we want to try to go that route. The reason I think it can be argued

[issue12353] argparse cannot handle empty arguments

2011-06-23 Thread R. David Murray
R. David Murray added the comment: Your unit test isn't consistent with the other unit tests in that set, which makes me suspicious that it isn't testing what we need to test. Also, there are unit tests for this case further up in the test file (TestEmptyAndSpaceContainingArgu

[issue10206] python program starting with unmatched quote spews spaces to stdout

2011-06-23 Thread R. David Murray
R. David Murray added the comment: Hmm. I don't know that it is really necessary to cater to the particular failure mode, I was more interested in seeing a unit test that checked the correct behavior: that a syntax error is raised (by capturing the output using the tools in script_h

[issue9921] os.path.join('x','') behavior

2011-06-23 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.o

[issue11909] Doctest sees directives in strings when it should only see them in comments

2011-06-23 Thread R. David Murray
R. David Murray added the comment: For the most part the patch looks good to me, too. My one concern is the encoding. tokenize detects the encoding...is it possible for the doctest fragment to be detected to be some encoding other than utf-8? -- nosy: +benjamin.peterson

<    18   19   20   21   22   23   24   25   26   27   >