Changes by Brett Cannon :
--
assignee: barry -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue18192>
___
___
Python-bugs-list mailing list
Un
Changes by Brett Cannon :
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue18194>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brett Cannon :
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue17907>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brett Cannon :
--
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brett Cannon :
--
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brett Cannon :
--
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
Everything that is going to be kept around has been moved. That just leaves:
1. Removing all uses of imp from the stdlib
2. Document as deprecated the last few things in imp which are simply being
removed (including adding a note in the docstrings)
3. Remove all
Brett Cannon added the comment:
And in case anyone is interested, it could be as many as 98 files to go
through. =)
--
___
Python tracker
<http://bugs.python.org/issue17
Brett Cannon added the comment:
Sorry, bad regex: it's more like 60 files.
--
___
Python tracker
<http://bugs.python.org/issue17177>
___
___
Python-bugs-l
Brett Cannon added the comment:
To have it on record, the command I am using to find uses of imp is::
ack "import imp(,|\n)|from imp import" -l
--
___
Python tracker
<http://bugs.python.o
Brett Cannon added the comment:
ack "import (\w+, *)*imp(,|\n)|from imp import" -l
--
___
Python tracker
<http://bugs.python.org/issue17177>
___
___
Brett Cannon added the comment:
Nope, no meta-issue. I literally just realized one evening that the handful of
exceptions that I filed bugs for could use an attribute for why the exception
was raised.
--
___
Python tracker
<http://bugs.python.
Brett Cannon added the comment:
At this point I have updated all the code that does not directly exposes imp
somehow or in Tools.
At this point the only thing I need to decide is whether I want to continue to
expose the lock stuff from imp or leave it private. After that the pending
Brett Cannon added the comment:
Obviously it can't be required that the index be provided as that would break
way too much code. There are already exceptions in the stdlib that have
optional attributes you can choose to (not) set.
As for relying upon it, it would be just like any other o
Brett Cannon added the comment:
Seems to be fairly consistent on Windows but more random on Linux. I have also
triggered it on my OS X machine randomly.
Can't tell if it's a timing issue or some other test doing something bad. I'm
worried solving it is going to require ta
Brett Cannon added the comment:
Found the test cases to cause this::
./python.exe -m test test_idle test_logging
Adding Roger and Terry to see if they happen to remember any of the IDLE tests
using logging or warnings in a way that could cause this.
P.S.: I thought we had a script somewhere
Brett Cannon added the comment:
Issue #18230 is another test_builtin failure related to tty tests.
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue13
New submission from Brett Cannon:
If you run test_builtin after test_getopt it will hang. If you run test_getopt
test_socket test_builtin it will fail in all tty-related tests for input().
Not sure if this is related to issue #17734 or #13886.
--
components: Library (Lib)
messages
Brett Cannon added the comment:
Issue #18230 is another test_builtin failure related to tty tests.
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue17
Changes by Brett Cannon :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue17177>
___
___
Python-bugs-list
Brett Cannon added the comment:
Fixed in http://hg.python.org/cpython/rev/ebec625b13f9
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brett Cannon :
--
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
I actually don't get the warnings when I run test_idle under regrtest. But what
I did was followed a hunch and added a check for warnings.showwarning() and
sure enough, it's been left modified by IDLE: PyShell replaces the function as
a side-effect
Changes by Brett Cannon :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brett Cannon :
--
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brett Cannon :
--
title: Implement importlib.util.decode_source_bytes() -> Implement
importlib.util.decode_source()
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
Another odd thing about this failure is that
http://hg.python.org/cpython/rev/59a11c81dd3c should have fixed it as it should
be setting warnings.showwarning() back to it's original value before the test
began executing. So I checked PyShell again and foun
Brett Cannon added the comment:
And Lib/idlelib/run.py also does the substitution. I'll file a separate bug for
all of this.
--
___
Python tracker
<http://bugs.python.org/is
New submission from Brett Cannon:
Both idlelib.run and idlelib.PyShell replace warning.formatwarning which is a
no-no. Only warning.showwarning is design to be replaced in any way. The proper
solution is to replace warnings.showwarning with code that calls whatever
formatting function you
Changes by Brett Cannon :
--
dependencies: +IDLE should not be replacing warnings.formatwarning
___
Python tracker
<http://bugs.python.org/issue18081>
___
___
Changes by Brett Cannon :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue17222>
___
___
Python-bugs-list
Brett Cannon added the comment:
Do you mean "sometimes there sometimes not" because old code won't set it (yet)
or because you don't think it will always be appropriate to set the attribute
and thus people won't set it when available?
--
_
Brett Cannon added the comment:
Going to temporarily re-open to remind me to add better deprecation docs for
imp.load_module() to point to specific loader in importlib.machinery.
Should also add example usage as well.
--
status: closed -> o
Brett Cannon added the comment:
No because it would mean new functionality in a bugfix release.
--
___
Python tracker
<http://bugs.python.org/issue18058>
___
___
Changes by Brett Cannon :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue17177>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
os.chmod is implemented in posixmodule.c and the argument parsing code can be
found at
http://hg.python.org/cpython/file/3acbb23c73bc/Modules/posixmodule.c#l2605 .
You will notice that the argument parsing is specified as "O&i|$O&p". Tha
Brett Cannon added the comment:
That's expected with that kind of argument. os.fchmod() and os.chmod() only
accept a path as a string or a file descriptor as an integer as specified in
the docs: http://docs.python.org/3/library/os.html#os.chmod
--
resolution: -> invalid
stat
Brett Cannon added the comment:
That is not a documentation bug (i.e. a problem with what is written at
docs.python.org), this is a feature request to try to improve the exception
message. That would require adding a new parameter format
(http://docs.python.org/3/c-api/arg.html?highlight
Brett Cannon added the comment:
Here is an initial stab at a zip file importer using importlib. Probably the
biggest shortcoming is that it doesn't support bytecode files, but that's
because I just have not bothered to add support yet (it's just one method to
implement). The
New submission from Brett Cannon:
class A: pass
class B(A): pass
sup = super(B, B())
isinstance(sup, A) # returns False
Why is that? Is there an explicit reason to prevent that isinstance check from
working? How about just for ABCs? Either way it's annoying that at least for
ABCs you
Brett Cannon added the comment:
One problem with the importers code is it doesn't properly clean up after the
module if the load failed and it wasn't a reload. Should store an attribute on
the module signaling whether it was a reload or not to know whether an
exception raised duri
Brett Cannon added the comment:
This is not the right place to ask for help with this. This is either a FreeBSD
or Mesa issue. Have you tried installing Python using FreeBSD-ports?
--
nosy: +brett.cannon
resolution: -> invalid
status: open ->
Brett Cannon added the comment:
I went ahead and added the needed method for bytecode loading; see the new
patch.
--
Added file: http://bugs.python.org/file30660/zip_importlib.diff
___
Python tracker
<http://bugs.python.org/issue17
Brett Cannon added the comment:
It would either be with freebsd-ports for having packaged Mesa incorrectly or
with Mesa for having something wrong with their build setup.
--
___
Python tracker
<http://bugs.python.org/issue18
Brett Cannon added the comment:
A two second granularity? Ugh. That will require a new (possibly private) API
to abstract that out in order to handle that case. What a pain. While I look
into that if people can look at the code and let me know if they see anything
wrong with it, hard to
Brett Cannon added the comment:
So I have a use case for this actually. =)
http://bugs.python.org/issue17621 is about trying to finally add a lazy mixin
to importlib so people stop asking for it. I have a version already written
externally at
https://code.google.com/p/importers/source/browse
Brett Cannon added the comment:
On Fri, Jun 21, 2013 at 10:02 AM, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> > http://bugs.python.org/issue17621 is about trying to finally add a
> > lazy mixin to importlib so people stop asking for it. I have a
> &
New submission from Brett Cannon:
Should specify the loader needs to be a callable which accepts two arguments:
module name and found file path.
--
assignee: brett.cannon
components: Documentation
messages: 191599
nosy: brett.cannon
priority: low
severity: normal
stage: needs patch
Brett Cannon added the comment:
On Fri, Jun 21, 2013 at 11:11 AM, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> > I'm attracted to the idea of making a loader lazy by simply doing
> > something
> > like ``class LazySourceFileLo
Brett Cannon added the comment:
I have no idea what CLOS does in this situation.
I'm fine with this never being changed, but I wanted to at least file the bug
to have the discussion in case it ever comes up again.
--
___
Python tracker
Brett Cannon added the comment:
While seing if it was worth making isinstance work with super(), I came up with
this at Antoine's suggestion of using a proxy instead of a mixin:
class LazyProxy(importlib.abc.Loader):
def __init__(self, loader):
self.loader = loader
def __call__
Changes by Brett Cannon :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
That solution looks right. Problem is that it would need to either go directly
into isinstance() or type would need to grow an __instancecheck__ to deal with
this case since you can't override isinstance from the instance end. That I'm
not sure peopl
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue15693>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I think the first step for this bug, now that I have two possible approaches,
is to write the unit tests. That way both approaches can equally be validated
based on their merits of complexity, etc. while verifying the work properly
Changes by Brett Cannon :
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue16803>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brett Cannon :
--
assignee: barry -> docs@python
keywords: +easy -3.3regression
nosy: +docs@python
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
So the approaches I have been using make a loader lazy, so what you have to
change in terms of sys.meta_path, sys.path_hooks, etc. would very from loader
to loader.
I have realized one tricky thing with all of this is that importlib itself
inspects modules
Changes by Brett Cannon :
Added file: http://bugs.python.org/file30670/test_lazy_loader.py
___
Python tracker
<http://bugs.python.org/issue17621>
___
___
Python-bug
Changes by Brett Cannon :
Added file: http://bugs.python.org/file30671/lazy_mixin.py
___
Python tracker
<http://bugs.python.org/issue17621>
___
___
Python-bugs-list mailin
Brett Cannon added the comment:
I have attached the test suite and two versions: one using a mixin and one
using a proxy. Neither solve the issue of import touching the module in any way
to check __loader__ and __package__. The mixin version is also failing one test
which could quite possibly
Brett Cannon added the comment:
Import manages the lock, not loaders.
--
___
Python tracker
<http://bugs.python.org/issue17621>
___
___
Python-bugs-list mailin
Brett Cannon added the comment:
It still falls under the purview of import to manage that lock. It's just the
design of the API from PEP 302. Otherwise it's just like any other reload.
--
___
Python tracker
<http://bugs.python.o
Brett Cannon added the comment:
I replied on python-checkins, I'll state here as well: the fix is still off
as warnings.formatwarning is still being replaced.
On Jun 24, 2013 6:20 PM, "STINNER Victor" wrote:
>
> STINNER Victor added the comment:
>
> This issue is
Changes by Brett Cannon :
--
assignee: -> brett.cannon
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue18302>
___
___
Python-bugs-
New submission from Brett Cannon:
>>> from re import bogus
Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundError: cannot import name bogus
Should have 'bogus' using the repr to match the other cases of
ModuleNotFoundError
--
assi
Changes by Brett Cannon :
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue17845>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
Obviously no worries for opening this up again; if something isn't clear better
to get it sorted out now rather than after 3.4 is out that door.
So I see two questions: why isn't ImportError being raised in the ``import
re.bogus`` case and why
Brett Cannon added the comment:
Paul's review did find one non-optimal thing the code is doing. I'll fix it the
next time there's a need to upload a new patch.
--
___
Python tracker
<http://bugs.pyt
Brett Cannon added the comment:
The impetus of ModuleNotFoundError is the need for something similar in
importlib thanks to ``from ... import``. When you do something like
__import__('os', fromlist=['path']), any ImportError must be silenced **if** it
relates only to the
Brett Cannon added the comment:
OK, I'll revert the changes related to ModuleNotFoundError.
As for adding a 'reason' attribute, I see two sticking points. One is how to
set the enum value. There is both the C code issue (specifically so ceval.c and
import.c can use the val
Brett Cannon added the comment:
In this instance where there are only a set number of options are expected to
be officially valid, yes I think enums are a good fit.
As for strings, the only way I would be okay with that is defining the strings
either as attributes on ImportError itself or off
Brett Cannon added the comment:
It's not a question of harder but more error-prone since a typo in the string
won't be directly noticed while mistyping an attribute name will be.
--
___
Python tracker
<http://bugs.python.o
New submission from Brett Cannon:
http://hg.python.org/cpython/file/8e838598eed1/Lib/importlib/_bootstrap.py#l455
: source_stats does not exist and instead should be source_path.
--
assignee: brett.cannon
components: IO
messages: 192237
nosy: brett.cannon
priority: normal
severity
Brett Cannon added the comment:
Any chance you want to write some tests for the function? =)
--
keywords: +easy
___
Python tracker
<http://bugs.python.org/issue18
Brett Cannon added the comment:
As ModuleNotFoundError is going to be reverted so should the changesets for
this issue.
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<http://bugs.python.org/i
Changes by Brett Cannon :
--
dependencies: +add ModuleNotFoundError
___
Python tracker
<http://bugs.python.org/issue18302>
___
___
Python-bugs-list mailin
Changes by Brett Cannon :
--
dependencies: -add ModuleNotFoundError
___
Python tracker
<http://bugs.python.org/issue18200>
___
___
Python-bugs-list mailin
Changes by Brett Cannon :
--
dependencies: +Update stdlib to use ModuleNotFoundError
___
Python tracker
<http://bugs.python.org/issue15767>
___
___
Python-bug
Changes by Brett Cannon :
--
assignee: brett.cannon
keywords: easy
nosy: brett.cannon
priority: low
severity: normal
stage: needs patch
status: open
___
Python tracker
<http://bugs.python.org/issue18
New submission from Brett Cannon:
No reason why it can't be generalized to accept a directory argument so that it
can be used by anyone to build a checkout of CPython whether it is in a box or
not.
Would also help maintain the code as me (and one else who cared to) could then
just alway
New submission from Brett Cannon:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/abbr
--
assignee: brett.cannon
keywords: easy
messages: 192311
nosy: brett.cannon
priority: low
severity: normal
status: open
title: Change use of acronym tag in devinabox index.html to abbr
Brett Cannon added the comment:
First, thanks to Yogesh for writing a patch!
Second, I still think the second line should be "The necessary bits to build
these optional modules were not found:". I purposefully like the vagueness of
it so we don't start going on about exte
Changes by Brett Cannon :
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue18302>
___
___
Python-bugs-
Changes by Brett Cannon :
--
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue18200>
___
___
Python-bugs-list
Changes by Brett Cannon :
--
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15767>
___
___
Python-bugs-list
Brett Cannon added the comment:
Because I removed ModuleNotFoundError; check the buildbot again and you will
notice it is 8 changesets behind, most of which are related to the removal of
ModuleNotFoundError.
--
resolution: -> out of date
status: open ->
New submission from Brett Cannon:
Having a private attribute has already caused one bug report. I want to try and
come up with something that doesn't leak outside of importlib.
--
assignee: brett.cannon
components: Library (Lib)
messages: 192322
nosy: brett.cannon
priority: n
Brett Cannon added the comment:
Discussion occurred on http://bugs.python.org/issue15767
--
___
Python tracker
<http://bugs.python.org/issue18200>
___
___
Pytho
Brett Cannon added the comment:
Wow, I really botched that function. And no one seems to really use it to
notice the errors (or at least the branches in the function where the errors
exist are never reached). =)
So the tests should go in test_importlib or test_import (I'm leaning towards
New submission from Brett Cannon:
Setuptools 0.8 uses a Python 2/3 compatible codebase so it should simplify the
instructions for running coverage.py.
--
assignee: brett.cannon
messages: 192343
nosy: brett.cannon
priority: normal
severity: normal
status: open
title: Look into using
New submission from Brett Cannon:
Right now there is a bunch of contorting with setuptools and coverage.py's
checkout to get things in reasonable places, etc. Might be easiest to create a
venv from the built checkout and then install both setuptools and the
coverage.py checkout into the
Changes by Brett Cannon :
--
superseder: -> col_offset is -1 and lineno is wrong for multiline string
expressions
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
Dražen: didn't do a deep review, but a cursory look suggests the patch is fine.
As for having to change a ton of files to start using the attribute, that's
part of the effect of changing something as basic as an exception. If you would
rather break
Brett Cannon added the comment:
When I wrote that code I was struggling to untangle the C code and it was
driving me up the wall because it was code unique to the C API and was just
ever so slightly different.
Anyway, the patch looks great! When I have time I will commit it to 3.3 and 3.4
Changes by Brett Cannon :
--
stage: test needed -> commit review
___
Python tracker
<http://bugs.python.org/issue18351>
___
___
Python-bugs-list mailing list
Un
Brett Cannon added the comment:
I'm closing to close this then if Ronald can't reproduce as I have changed
computers now and so my setup has shifted. Hopefully I was just a random case.
--
resolution: -> works for me
status: o
Brett Cannon added the comment:
Tomasz, can you sign the contributor agreement
(http://python.org/psf/contrib/contrib-form/) so we can commit your code?
--
___
Python tracker
<http://bugs.python.org/issue18
Brett Cannon added the comment:
Senko, could you sign the contributor agreement
(http://python.org/psf/contrib/contrib-form/) so we can use your patch?
--
___
Python tracker
<http://bugs.python.org/issue6
Changes by Brett Cannon :
--
assignee: brett.cannon
keywords: easy
nosy: brett.cannon
priority: low
severity: normal
status: open
title: Link to the contributor agreement from devinabox
___
Python tracker
<http://bugs.python.org/issue18
3001 - 3100 of 5934 matches
Mail list logo
