Brett Cannon added the comment:
To clarify, this is for pkgutil.
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue36453>
___
___
Pytho
Change by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<https://bugs.python.org/issue36453>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
title: get_importer only return the first valid path_hook(importer) ->
pkgutil.get_importer only return the first valid path_hook(importer)
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
Closing as a duplicate of issue36260.
--
nosy: +brett.cannon
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Cpython/Lib vulnerability found and request a patc
Brett Cannon added the comment:
You can also leave a comment in the other issue saying there's more details
in the closed duplicate.
On Thu, Mar 28, 2019 at 9:54 AM Karthikeyan Singaravelan <
rep...@bugs.python.org> wrote:
>
> Karthikeyan Singaravelan added the comment:
&g
Brett Cannon added the comment:
Thanks, everyone!
--
nosy: +brett.cannon
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
I'm already going through the "CLA not signed" issues and cleaning them up, so
there's no need for anyone to duplicate my work.
And this is not a steering council concern but a core-workflow concern.
--
resolution: -> not a
Change by Brett Cannon :
--
nosy: -brett.cannon
status: pending -> open
___
Python tracker
<https://bugs.python.org/issue36463>
___
___
Python-bugs-list mai
Brett Cannon added the comment:
Please provide code which consistently causes the crash, otherwise your use of
ctypes makes the very likely not Python's fault and nearly impossible to debug
without a working example.
--
nosy: +brett.cannon
status: open ->
Change by Brett Cannon :
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue31182>
___
___
Brett Cannon added the comment:
I'm going to agree w/ Serhiy and say thanks to Steve for the idea but for
maintainability purposes we should keep the CLI of both modules simple and only
for critical operations.
--
nosy: +brett.cannon
___
P
Brett Cannon added the comment:
RE: "And do you think polling for a new magic attribute is the right
approach?": my thinking behind that idea is that by standardizing the function
name it's easy to tell if there's a cache, but you can also do away with the
registrati
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue32413>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Did you mean importlib.reload() instead of sys.reload()?
And technically it would *if* you're okay with the other side-effects of
reloading, e.g. making sure no one has a reference to any objects from the
module's namespace which won't chang
Brett Cannon added the comment:
@Davin is there an issue for that and thus this issue can then be closed? Or
did you want to re-purpose this issue to track that? Either way I'm assigning
the issue to you to let you decide which way you want to go. :)
--
assignee: docs@p
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
Actually, it's even more subtle as the arguments are positional-only.
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/is
Brett Cannon added the comment:
So Terry is correct in so much as there is no parameter name. :) Both of the
functions in question are positional-only, so the name actually doesn't matter
beyond giving a way to reference the parameter in the documentation.
So thanks for the PR, Marco
Brett Cannon added the comment:
Could you explain a bit more, Victor, about why you want to avoid importing
hashlib and OpenSSL so much?
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue36
Brett Cannon added the comment:
It's more of a "can't be an instance method" than a strict "only classmethod".
Can I ask why you want it to be a strictmethod instead of a classmethod? I
personally don't want to change the docs as I think that encourages
Change by Brett Cannon :
--
components: +Library (Lib)
nosy: +davin, pitrou
___
Python tracker
<https://bugs.python.org/issue36586>
___
___
Python-bugs-list m
Brett Cannon added the comment:
Boy, having a postional-only parameter in that first position would have been
handy when we created this API (as Matthias pointed out). :)
The 'exec' keyword-only parameter is obviously the safest option here.
Making the first parameter positiona
Brett Cannon added the comment:
I realized another solution to this is to make the argument positional-only,
then the name simply doesn't matter. Probably unnecessary breakage, though.
--
versions: +Python 3.8
___
Python tracker
&
Brett Cannon added the comment:
RE: "does it mean we dont need this to work anymore as was earlier put in the
PEP?"
Correct, we aren't going to implement that part of the PEP ever.
--
___
Python tracker
<https://bugs.pyt
Brett Cannon added the comment:
Thanks for the idea, but this would break way too much code to warrant changing
it. Plus making this act differently just in the single-item case is too much
special-casing/surprise.
--
resolution: -> rejected
stage: -> resolved
status
Brett Cannon added the comment:
@mollison: would you like to open a PR w/ how you would expect it to be
formatted?
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue36
Brett Cannon added the comment:
New changeset a6de52c74d831e45ee0ff105196da8a58b9e43cd by Brett Cannon (josh)
in branch 'master':
bpo-32913: Added re.Match.groupdict example to regex HOWTO (GH-5821)
https://github.com/python/cpython/commit/a6de52c74d831e45ee0ff105196da8
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
If you look at that commit that Thomas made all it did was change where the
string was grabbed from, not what type of object was used. So it doesn't make
any sense as to why that would cause any specific change, so I think this may
be doctest
Brett Cannon added the comment:
I also don't think it's critical to make examples within a module's docs work
like a doctest. Plus I discourage importing objects directly off of modules
anyway and this would actually promote that.
--
nosy
Brett Cannon added the comment:
Basically _thread.RLock was added without an equivalent in _dummy_thread. Add
that and it will fix the issue. It probably wouldn't be too hard since you have
to implement it as if it's single-threaded and there's already a lock class in
_dummy
Brett Cannon added the comment:
I'm -1 on pulling `request` up to implicitly be part of the `urllib` namespace
without an import. `os.path` is the only exception that I know of in the stdlib
and that's historical (it predates packages existing in the language).
Otherwise the propo
Brett Cannon added the comment:
This is by design in the Windows installer. You can check a box to put
python3.6 on PATH if you want.
If you want the Python Launcher on UNIX, see
https://crates.io/crates/python-launcher.
--
nosy: +brett.cannon
resolution: -> not a bug
st
Brett Cannon added the comment:
There is probably validation code in len(), but the method itself can do
whatever it wants if you call it directly. So the documentation is accurate in
saying the method _should_ return >= 0 but that there's nothing strictly
enforcing that in Python
Brett Cannon added the comment:
This seems fine to me and I can't think of any negatives. Can anyone think of
why this might be a bad idea? (Messing with how sys.path is used is just so
fundamental I'm being paranoid. :)
--
nosy: +eric.snow
Change by Brett Cannon :
--
assignee: docs@python -> barry
___
Python tracker
<https://bugs.python.org/issue35181>
___
___
Python-bugs-list mailing list
Un
Brett Cannon added the comment:
Steve's right that we can't change the indexes on those functions for
pre-existing values, so appending to the end is the only real option in that
case. I still think they should both be deprecated due to how limiting their
APIs are.
Obviously
Brett Cannon added the comment:
If I remember correctly the un-deprecation was because 2/3 code could only use
getfullargspec() to get all relevant details. Since we're so close to being
done w/ Python 2 I think this might be the last change to make to them,
document their deprecation,
Brett Cannon added the comment:
New changeset 81c5a905951aaf46f292eb459c32649c0b74ef61 by Brett Cannon (Marco
Rougeth) in branch 'master':
bpo-36232: Improve error message on dbm.open() when the db doesn't exist
(GH-12060)
https://github.com/python
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue34616>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
New changeset 1a2252ed39bc1b71cdaa935d7726d82909af93ab by Brett Cannon (Zackery
Spytz) in branch 'master':
bpo-36594: Fix incorrect use of %p in format strings (GH-12769)
https://github.com/python/cpython/commit/1a2252ed39bc1b71cdaa935d7726d8
Brett Cannon added the comment:
I don't see anything wrong with the idea.
--
___
Python tracker
<https://bugs.python.org/issue22640>
___
___
Python-bugs-l
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
RE: "if a function continues to work correctly throughout the span of a Python
X version, why does it need to be removed?"
In this case the argument is whether inspect.getfullargspec() works correctly
in the face of positional-only parameters. Th
Brett Cannon added the comment:
Since I'm not bothered enough to check if this is still an issue I'm fine with
closing this.
--
resolution: -> out of date
stage: test needed -> resolved
status: open -> closed
___
Pyt
Brett Cannon added the comment:
Can this be closed, Nick?
--
___
Python tracker
<https://bugs.python.org/issue24048>
___
___
Python-bugs-list mailing list
Unsub
Brett Cannon added the comment:
Also note that inspect.getcallargs() has been deprecated since Python 3.5:
https://docs.python.org/3/library/inspect.html#inspect.getcallargs.
Since the function is deprecated I'm closing as "won't fix".
--
nosy: +brett.cannon
reso
Brett Cannon added the comment:
I don't think it's option C. As for whether A or B I don't know. Wouldn't hurt
to ask on python-dev if no one comes forward with a more authoritative answer.
--
___
Python tracker
<
Brett Cannon added the comment:
Actually find_module() should be deprecated and find_spec() should be defined
instead (and the same goes for load_module(); see bpo-9699). So I'm personally
fine w/ making this a doc problem w/ the plan to eventually deprecate the
m
Brett Cannon added the comment:
A disagreement has popped up over what the ideal solution is on the PR
currently connected to this issue. I'm having the folks involved switch it over
to here.
IMO I think py_compile can respect SOURCE_DATE_EPOCH and just blindly use it
for creating
Brett Cannon added the comment:
New changeset bca42186b69e2e615d29d0d4fdb493c9fe71c48b by Brett Cannon in
branch 'master':
bpo-32248: Introduce the concept of Loader.get_resource_reader() (GH-5108)
https://github.com/python/cpython/commit/bca42186b69e2e615d29d0d4fdb493
Brett Cannon added the comment:
As Eli's comments are coming off as negative to/at me, I feel like I have
to defend myself here. If you look at the commit there was actually two
places where the timestamp was checked; one did an equality comparison and
one did a >= comparison. It
Brett Cannon added the comment:
Bernhard's idea of SOURCE_DATE_EPOCH being an implicit envvar to forcibly
switch on hash-based .pyc files in py_compile is intriguing. I assume this
would force the check_source bit to be set? Or since SOURCE_DATE_EPOCH should
only be used in build scen
Brett Cannon added the comment:
To answer Steve's question, what you would want is a finder which recognized
the directory of the package so as to return a special loader just for that
package (basically __path__ is sent through the normal import mechanism and so
you would want somethi
Brett Cannon added the comment:
Nick makes this sound like it really should land in 3.5.5, so marking as a
release blocker for now.
--
nosy: +brett.cannon
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
I agree w/ David that this idea is premature. Plus I say it's easier to make it
so -O is more fine-grained so you can leave in asserts but get __debug__ set to
False.
--
nosy: +brett.cannon
___
Python tr
Brett Cannon added the comment:
Since Barry chose an option that wasn't listed, I'm planning on accepting
Bernhard's https://github.com/python/cpython/pull/5200 at some point next week
barring any new, unique objections.
--
___
Brett Cannon added the comment:
New changeset ccbe5818af20f8c12043f5c30c277a74714405e0 by Brett Cannon
(Bernhard M. Wiedemann) in branch 'master':
bpo-29708: Setting SOURCE_DATE_EPOCH forces hash-based .pyc files (GH-5200)
https://github.com/python/cpyt
Brett Cannon added the comment:
Just merged Bernhard's PR which forces hash-based .pyc files. Thanks to
everyone who constructively helped reach this point.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
Change by Brett Cannon :
--
pull_requests: +5153
___
Python tracker
<https://bugs.python.org/issue29708>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
New changeset cab0b2b053970982b760048acc3046363615a8dd by Brett Cannon in
branch 'master':
bpo-29708: Add What's New entries for SOURCE_DATE_EPOCH and py_compile (GH-5306)
https://github.com/python/cpython/commit/cab0b2b053970982b760048ac
Change by Brett Cannon :
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue29708>
___
___
Python-bugs-list
Brett Cannon added the comment:
I don't remember why that line was commented out to make the analyzer happy.
--
___
Python tracker
<https://bugs.python.org/is
Brett Cannon added the comment:
Notice that the returning of None only has to do with searching for the
*package*, not the *data file*. So I think the docs are still correct according
to your example, Paul.
--
___
Python tracker
<ht
Brett Cannon added the comment:
I don't think there is anyone specific who maintains it. Just whomever wants to
use it next and needs to fix it to make it work.
--
___
Python tracker
<https://bugs.python.org/is
Brett Cannon added the comment:
We should probably delete the line regardless so no one else gets thrown by
this (or at least leave a comment).
--
___
Python tracker
<https://bugs.python.org/issue32
Brett Cannon added the comment:
Thanks!
On Sun, Jan 28, 2018, 19:32 Xiang Zhang, wrote:
>
> Xiang Zhang added the comment:
>
> Done.
>
> --
> versions: -Python 3.6
>
> ___
> Python tracker
> &l
Brett Cannon added the comment:
No opinion from me on how critical this is.
--
___
Python tracker
<https://bugs.python.org/issue30697>
___
___
Python-bugs-list m
New submission from Brett Cannon :
Thanks to https://github.com/PowerShell/PowerShell, PowerShell Core is
cross-platform. That suggests that the Activate.ps1 file for venv should be
moved to the common/ directory instead of existing only in the nt/ directory.
--
components: Library
Brett Cannon added the comment:
Docs should still be correct.
--
___
Python tracker
<https://bugs.python.org/issue27428>
___
___
Python-bugs-list mailin
Change by Brett Cannon :
--
assignee: brett.cannon ->
stage: resolved ->
___
Python tracker
<https://bugs.python.org/issue29708>
___
___
Python-bugs-list
Change by Brett Cannon :
--
title: Classes -> Mislabeling of a dict comprehension as a generator expression
in the tutorial
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
The other option is to simply not worry about it and acknowledge you can
crash the compiler with a crazy-sized expression. Option 1 is too much work
and option 2 takes us from an AST to more of an s-expression format which
is a significant shift in design (now if
Brett Cannon added the comment:
On Sun, Feb 11, 2018, 16:26 Serhiy Storchaka,
wrote:
>
> Serhiy Storchaka added the comment:
>
> > The other option is to simply not worry about it and acknowledge you can
> > crash the compiler with a crazy-sized expression.
>
&g
Change by Brett Cannon :
--
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
I'm personally fine if the change gets reverted. I don't think the odd
behaviour is severe enough to justify breaking projects in a maintenance
release. Besides, they will learn soon enough about their code breaking in
Brett Cannon added the comment:
Oh, I haven't forgotten. :) This issue is the only one I have assigned to
myself and been looking forward to ripping it out for over 2 years (might not
get to it until the sprints at PyCon US, but I will definitely be ripping it
Brett Cannon added the comment:
I'm willing to give it another go. Do you want to open a PR to turn it back on
and see how the timing looks, Antoine?
--
status: pending -> open
___
Python tracker
<https://bugs.python.org
Brett Cannon added the comment:
Fixing the message makes sense. I assume this is happening in ceval.c or
import.c since
https://github.com/python/cpython/blob/42c35d9c0c8175332f50fbe034a001fe52f057b9/Lib/importlib/_bootstrap.py#L1021
has the appropriate message?
--
nosy: +barry
Brett Cannon added the comment:
Awesome, thanks for taking the time to verify all of that! And I agree with
your logic to not bother backporting.
--
___
Python tracker
<https://bugs.python.org/issue31
Brett Cannon added the comment:
This is only for `import *`, though, right? So I would argue you're already
tossing import perf out the window if you're willing to pollute your namespace
like that.
--
___
Python tracker
<https://bu
Change by Brett Cannon :
--
nosy: +twouters
___
Python tracker
<https://bugs.python.org/issue32959>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
FakePath? Otherwise SimplePath seems as good a name as any other one.
--
___
Python tracker
<https://bugs.python.org/issue32
Brett Cannon added the comment:
https://docs.python.org/2.7/tutorial/interpreter.html#source-code-encoding if
people are looking for the doc link.
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue32
Change by Brett Cannon :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue32980>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
title: Docs on unittest.TestCase.assertRaises() should be improved -> Docs on
unittest.TestCase.assertRaises() should clarify context manager details
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
If no one gets to this before the sprints at PyCon US I will take care of it,
but anyone can feel free to submit a pull request to fix this.
--
assignee: docs@python -> brett.cannon
keywords: +easy
___
Python trac
Change by Brett Cannon :
--
keywords: +patch
pull_requests: +5728
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Brett Cannon :
--
keywords: +patch
pull_requests: +5729
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32963>
___
___
Py
Brett Cannon added the comment:
The PR adds the documentation warnings. Serhiy, can you double-check that I
have the appropriate functions and the comment is acceptable?
--
___
Python tracker
<https://bugs.python.org/issue32
Brett Cannon added the comment:
New changeset 20003f9162631c47b79202316036d13d74484e4c by Brett Cannon in
branch '2.7':
bpo-32963: Fix the tutorial to state source has a default encoding of ASCII
(GH-5961)
https://github.com/python/cpython/commit/20003f9162631c47b79202316036d1
Brett Cannon added the comment:
Thanks for the bug report, Martijn!
--
keywords: -patch
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Brett Cannon :
--
keywords: +patch
pull_requests: +5730
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
No need to apologize! We all only have so much free time.
--
___
Python tracker
<https://bugs.python.org/issue32963>
___
___
Pytho
Brett Cannon added the comment:
You're probably right and it's worth propagating the warning a bit wider.
--
assignee: docs@python -> brett.cannon
___
Python tracker
<https://bugs.pytho
Change by Brett Cannon :
--
stage: patch review -> commit review
___
Python tracker
<https://bugs.python.org/issue25427>
___
___
Python-bugs-list mai
Change by Brett Cannon :
--
keywords: +security_issue
title: issue11662 Incomplete fix -> urllib and webbrowser.open() can open w/
file: protocol
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
'make regen-all' should do it (but so will just running 'make -s -j' like
any old build of CPython).
On Mon, Mar 5, 2018, 12:43 Jay Yin, wrote:
>
> Jay Yin added the comment:
>
> I'm unsure how to regenerate the
Brett Cannon added the comment:
New changeset 7a7f100eb352d08938ee0f5ba59c18f56dc4a7b5 by Brett Cannon in
branch 'master':
bpo-32758: Warn that ast.parse() and ast.literal_eval() can segfault the
interpreter (GH-5960)
https://github.com/python/cpyt
Brett Cannon added the comment:
New changeset b316c44b0105d11a80ff971636143735f3655bbf by Brett Cannon (Miss
Islington (bot)) in branch '3.6':
bpo-32758: Warn that ast.parse() and ast.literal_eval() can segfault the
interpreter (GH-5960) (GH-6042)
https://github.com/python/cpyt
2601 - 2700 of 5934 matches
Mail list logo