Brett Cannon added the comment:
With over 10 years of existence for that method, I can guarantee you someone
relies on it, and so we should do a reasonable job to avoid breaking them
without at least some warning first.
--
___
Python tracker
<h
Brett Cannon added the comment:
It won't work without the global namespace as pickle needs to be able to figure
out where the function lives (the function itself doesn't get pickled, just the
name of the function).
--
nosy: +brett.cannon
resolution: -> not a bug
stage:
Brett Cannon added the comment:
I agree with Serhiy that it might be time to create a seqtools module.
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue30
Brett Cannon added the comment:
New changeset a12df7b7d40dbf47825917c8fa03d2c09b5a382c by Brett Cannon (Jelle
Zijlstra) in branch 'master':
bpo-30218: support path-like objects in shutil.unpack_archive() (GH-1367)
https://github.com/python/cpyt
Brett Cannon added the comment:
Thanks for the patch (and patience), Jelle!
--
___
Python tracker
<http://bugs.python.org/issue30218>
___
___
Python-bugs-list m
Changes by Brett Cannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue30218>
___
Brett Cannon added the comment:
The key thing with the docs is that it doesn't say anywhere "takes a string
path" or a "path as a string" or something else that suggests path-like objects
don't work. If you want to clearly state that path-like objects are accepta
Changes by Brett Cannon :
--
assignee: -> haypo
___
Python tracker
<http://bugs.python.org/issue30273>
___
___
Python-bugs-list mailing list
Unsubscrib
Brett Cannon added the comment:
I've added your PR to my review queue, Serhiy, so I will get to it, I just
can't make any promises as to when (hopefully this week).
--
___
Python tracker
<http://bugs.python.o
Brett Cannon added the comment:
To be honest, I'm not excited by ./configure --enable-optimizations. I was
happy with an explicit "make profile-opt".
The configure flag was added because not everything can be enabled just in the
Makefile and so that people have a single flag to
Brett Cannon added the comment:
I'm not sure if this is going to be useful enough to force all contributors to
deal with. Justification for a change should be on bugs.python.org and that's
mentioned in the CONTRIBUTING.md guidelines. As for testing, the
Travis/AppVeyor failu
Changes by Brett Cannon :
--
pull_requests: +1648
___
Python tracker
<http://bugs.python.org/issue30327>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I agree with Victor since that's why I set up the Travis file that way. :)
Thanks to this issue, though, I have added a comment to .travis.yml to explain
why the version is what it is.
--
___
Python tracker
Changes by Brett Cannon :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue30327>
___
___
Brett Cannon added the comment:
OK, since Victor has verified my thinking wasn't totally off-target, I'm going
to close this.
Thanks for the idea and taking the time for the PR, Jensen. If you do want to
file issues or PRs against the devguide, the repo is at
https://github.
Brett Cannon added the comment:
Obviously Bob can re-open this if he disagrees with the general sentiment
against this idea, but since I doubt he will disagree I'm going to save him
some effort and close this issue.
Thanks to Andrew for taking the time to writing the PR and being pa
Brett Cannon added the comment:
You're correct that both are CPython implementation details and could be more
clearly marked as such.
(In case anyone is curious, the code to look up __import__() can be found at
https://github.com/python/cpython/blob/c7ac7280c321b3c1679fe5f657a6be0f86a
New submission from Brett Cannon:
The Travis file uses `make venv` which does `python3 -m pip install --upgrade
sphinx` which is pulling in Sphinx 1.6.1 which was released today (under Python
2.7 the pip call is direct instead of using `make venv`). The problem is that
Sphinx 1.6.1 adds some
Brett Cannon added the comment:
Technically it's probably best to do `python3 -m pip install sphinx~=1.5.6` so
bugfix releases are picked up.
--
___
Python tracker
<http://bugs.python.org/is
Brett Cannon added the comment:
New changeset fca224f117d25bdfec1bf7160b67438c4fcf6dee by Brett Cannon
(Mariatta) in branch 'master':
bpo-30380: Pin the version of Sphinx used to build the documentation (GH-1612)
https://github.com/python/cpython/commit/fca224f117d25bdfec1bf7160b6743
Changes by Brett Cannon :
--
pull_requests: +1706
___
Python tracker
<http://bugs.python.org/issue30380>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
pull_requests: +1707
___
Python tracker
<http://bugs.python.org/issue30380>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
pull_requests: +1708
___
Python tracker
<http://bugs.python.org/issue30380>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
New changeset 5e2016dce92d66e6e1fb25e6ce39031d8c7d5412 by Brett Cannon in
branch '3.6':
bpo-30380: Pin the version of Sphinx used to build the docs (GH-1612) (GH-1617)
https://github.com/python/cpython/commit/5e2016dce92d66e6e1fb25e6ce3903
Brett Cannon added the comment:
New changeset 083f13e34c0b9f9ed4ed64fed3989d4af97843b3 by Brett Cannon (Serhiy
Storchaka) in branch '3.5':
[3.5] bpo-30380: Fix Sphinx 1.6.1 warnings. (GH-1613) (GH-1615)
https://github.com/python/cpython/commit/083f13e34c0b9f9ed4ed64fed3989d
Brett Cannon added the comment:
New changeset 77606957e71ce477d2c5569718f0fc36f05c6f59 by Brett Cannon in
branch '3.5':
bpo-30380: Pin the version of Sphinx used to build the documentation (GH-1612)
(GH-1618)
https://github.com/python/cpython/commit/77606957e71ce477d2c5569718f0fc
Brett Cannon added the comment:
New changeset 97eb2a7d77011605e8fc49e754cd371ead4366bc by Brett Cannon in
branch '2.7':
[2.7] bpo-30380: Pin the version of Sphinx used to build the docs (GH-1612)
(GH-1619)
https://github.com/python/cpython/commit/97eb2a7d77011605e8fc49e754cd37
Brett Cannon added the comment:
All branches should be green again. Serhiy has a PR out to fix 2.7 for Sphinx
1.6.1, but it isn't passing yet so that branch is pinned to 1.5.6 until then.
I will leave this issue open for Serhiy to close once his 2.7 PR is m
Brett Cannon added the comment:
The problem with leaving os.fspath() out of os.path.normcase() is that suddenly
a single function that deals with paths won't work with path-like objects. So
that means support for path-like objects won't implicitly work in code that
assumes a path b
Changes by Brett Cannon :
--
pull_requests: +1833
___
Python tracker
<http://bugs.python.org/issue30380>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
All branches are now pinned to and working under Sphinx 1.6.1, so I'm closing
this as fixed!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Brett Cannon added the comment:
Can this be closed?
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue30273>
___
___
Python-bugs-list mailin
Brett Cannon added the comment:
So limited ABI modules can't be imported by a Py_DEBUG build. Stefano's patch
just skips over them. That seems reasonable, but one question I do have is
whether this would confuse users since they will simply get an ImportError
instead of some other
Brett Cannon added the comment:
The key thing to think about is do you think find_spec("parent.module") is
working with a single thing called "parent.module" or is it working with two
separate things of "parent" and "module" which happens to be contai
Brett Cannon added the comment:
Here is why Python does when importing a module that lacks __path__:
>>> import importlib
>>> del importlib.__path__
>>> import importlib.util
Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundE
Brett Cannon added the comment:
New changeset 94987826e89e8a89c20f081e18be33fc840e6203 by Brett Cannon (Garvit
Khatri) in branch 'master':
bpo-29851: Have importlib.reload() raise ImportError if the module's spec is
not found (GH-972)
https://github.com/python
Changes by Brett Cannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29851>
___
Brett Cannon added the comment:
I don't think os.normcase() calling os.fspath() needs to be a worry.
Pragmatically it's just getting a str/bytes from an object that knows how to
return a str/bytes for a path. IOW it's no different than
os.normcase(str(path)) and so embeddin
Brett Cannon added the comment:
The best place to propose this is on the python-ideas mailing list. My
suspicion, though, is people will say it's not worth the new syntax as you can
also undo your comprehensions as normal code and simply assign to a variable
name directly.
--
Brett Cannon added the comment:
I'm wondering if including the whole "tuple.index(%R)" part is still necessary?
The traceback will tell you what method you called, so wouldn't "%R not in
tuple" be enough?
--
components: +Interpre
Brett Cannon added the comment:
I've created https://github.com/python/peps/pull/267 to clarify things a bit
better in PEP 42, Dávid .
--
___
Python tracker
<http://bugs.python.org/is
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue13349>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
A potential compromise would be if ValueError gained a 'value' attribute. That
would allow for the exception message to be static but still provide the
information for introspection later if desired to figure out exactly what
object led to the ca
Changes by Brett Cannon :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue30477>
___
___
Brett Cannon added the comment:
I'm fine with not changing this, but I did want to say that I don't think
you're guaranteed to have access to the object that triggered the ValueError.
If the value that is searched for is in some extension module where it's
calculated u
Brett Cannon added the comment:
Is Cython not defining actual module objects or working around
types.ModuleType? I'm just trying to figure out how a Cython module is ending
up in a place where the attributes that are set by PyModule_NewObject() aren't
there
(https://github.com/pyth
Brett Cannon added the comment:
OK, so the warning is triggered if __package is None or __spec__ is None
(https://github.com/python/cpython/blob/ac5bbd43bc7b769c13ae0412cb28a3521f4d4ff1/Lib/importlib/_bootstrap.py#L1038).
That's defined in _calc___package__() which is only called if index
New submission from Brett Cannon:
If we guaranteed that the slowest tests in the test suite started early enough
in the test run to complete before the final test finished, we could shave off
several minutes worth of time in cases where the slowest tests are the hold-up.
So perhaps if we
Brett Cannon added the comment:
One way to control this would allow `-r` to take an optional `fast` argument to
do this selective shuffle of the slowest tests, i.e. `-r fast` would still
randomize but control for the slowest tests showing up in the first 75% of
tests
Brett Cannon added the comment:
I learned a few thing trying to make this work.
One is that the COVERAGE_PROCESS_START does need to point to an actual .ini
file (which includes an empty file).
Two,
https://bitbucket.org/ned/coveragepy/src/63dfe482a849e9cb0b82214242315a806a6a3d53/coverage
Changes by Brett Cannon :
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue11978>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Brett Cannon :
--
pull_requests: +1948
___
Python tracker
<http://bugs.python.org/issue11978>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I'm fine with adding a note to the Python 2 docs, but putting it in Python 3
seems to be going in the wrong direction as having sys.meta_path not be empty
is how Python will be going forward.
--
___
Python tr
Brett Cannon added the comment:
Yeah, there's actually a specific 'warning' directive which puts text in the
docs in a red box to make it a full-blown warning which is what I thought you
wanted, having it say "this is different than Python 2!". Having a sentence
th
Brett Cannon added the comment:
> Note that some error messages are "takes no keyword arguments", but others
> are "does not take keyword arguments" or "doesn't take keyword arguments".
> They should be unified. What wording is better?
I vote for &q
Brett Cannon added the comment:
New changeset ae8750bca8234a9af9382b9d7e457b57f810ad64 by Brett Cannon (Jamiel
Almeida) in branch 'master':
bpo-24899: Add comparison table for os.path -> pathlib (GH-1753)
https://github.com/python/cpython/commit/ae8750bca8234a9af9382b9d7e4
Changes by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
One thing to note is if we want to speed up things like the coverage run on
Travis we may want to make this optionally more deterministic rather than fully
random for the 10 selected files, otherwise coverage shifts and we can't rely
on any coverage metric
Brett Cannon added the comment:
Travis takes nearly 22 minutes to do a test run with the slowest test currently
at just under 8 minutes. That means on Travis the slowest test takes roughly
1/3 of the time. But with your machine taking literally 2 minutes, or 1/10 the
time as Travis, to do a
Brett Cannon added the comment:
The tests could either go into the respective type's tests or a new test module
like test_exception_messages could be added that's only to help keep messages
in sync with each other.
--
___
Python trac
Changes by Brett Cannon :
--
assignee: -> serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue30567>
___
___
Python-bugs-list mailing list
Un
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue36128>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Yes, the Mac installer should have installed everything, but software isn't
perfect. :) I would try installing again.
--
nosy: +brett.cannon, ned.deily, ronaldoussoren
___
Python tracker
<https://bugs.py
Change by Brett Cannon :
--
nosy: +davin, pitrou
___
Python tracker
<https://bugs.python.org/issue36153>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Anyone have an opinion about the __getitem__ proposal? I'm fine with it but I
wanted to make sure other import + namespace folks don't disagree.
--
___
Python tracker
<https://bugs.python.o
Change by Brett Cannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36043>
___
Brett Cannon added the comment:
It's 3.8 time now. :) Should we try and resolve this?
--
___
Python tracker
<https://bugs.python.org/issue32387>
___
___
Brett Cannon added the comment:
RE: " So basically you'd remove the whole feature just cause one package no
one installs abuses it. Doesn't make sense."
No, the point being made is *at least* one package that was found on PyPI
is abusing it, so it exists and we need to cons
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
I would be curious to hear what Pablo has to say with the new parser having
landed and if there's something we should be exposing from that code to replace
what's in 'parser' today? (Either w/o semantic
Brett Cannon added the comment:
It's sounding like it might be worth the effort then to make lib2to3's parser
not be a "hidden" thing in lib2to3, break it out as a new parser module (I have
no stance on name), and then deprecate the old parser module. I think this was
d
Change by Brett Cannon :
--
assignee: brett.cannon -> cheryl.sabella
___
Python tracker
<https://bugs.python.org/issue35661>
___
___
Python-bugs-list mai
Brett Cannon added the comment:
@Xavier different needs; AST and CST are at different stages of compilation.
--
___
Python tracker
<https://bugs.python.org/issue36
Brett Cannon added the comment:
And security issues should be reported according to
https://www.python.org/news/security/ .
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue36
Brett Cannon added the comment:
Limiting the version scope to 3.6 until someone reproduces on 3.7 and/or 3.8.
--
nosy: +brett.cannon
versions: -Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue36
Brett Cannon added the comment:
Yep, if it's the same problem then close this as a dupe and just poke the other
issue.
--
___
Python tracker
<https://bugs.python.org/is
Brett Cannon added the comment:
We could also have a new namespace package which is *just* for startup
injection so it wasn't such a hack to tie into the codecs startup code.
--
___
Python tracker
<https://bugs.python.org/is
Brett Cannon added the comment:
@eamanu tests are basically always necessary. :)
--
___
Python tracker
<https://bugs.python.org/issue36287>
___
___
Python-bug
Change by Brett Cannon :
--
nosy: +benjamin.peterson, brett.cannon, serhiy.storchaka, yselivanov
___
Python tracker
<https://bugs.python.org/issue36290>
___
___
Change by Brett Cannon :
--
assignee: terry.reedy -> brett.cannon
nosy: -terry.reedy
stage: needs patch ->
title: Lib/pyclbr.py fails when package spec cannot be determined ->
Lib/pyclbr.py crashes when the package spec cannot be determined by importlib
versions: -P
Brett Cannon added the comment:
I have a fix en-route.
--
___
Python tracker
<https://bugs.python.org/issue36298>
___
___
Python-bugs-list mailing list
Unsub
Change by Brett Cannon :
--
keywords: +patch
pull_requests: +12325
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36298>
___
___
Py
Brett Cannon added the comment:
Got a patch up if either of you would like to review.
--
___
Python tracker
<https://bugs.python.org/issue36298>
___
___
Pytho
Change by Brett Cannon :
--
stage: patch review -> commit review
___
Python tracker
<https://bugs.python.org/issue36298>
___
___
Python-bugs-list mai
Brett Cannon added the comment:
(And sorry about stealing this from you, Terry; I forgot to flip the assignment
while I was looking into this.)
--
___
Python tracker
<https://bugs.python.org/issue36
Change by Brett Cannon :
--
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
___
Python tracker
<https://bugs.python.org/issue36315>
___
___
Python-bug
Brett Cannon added the comment:
Unfortunately not because there is no warning being raised currently about the
deprecation (it's only documented as deprecated;
https://github.com/python/cpython/commit/44f602dd3b452bbacd3c85b1e5f9873c892b46e3).
A PR raising an appropriate deprecation f
Brett Cannon added the comment:
I agree that if it's a good example of using wsgiref then it should exist in
the wsgiref docs as an example. Then that would mean dropping the script and
updating the Makefile.
--
nosy: +brett.cannon
___
P
Brett Cannon added the comment:
So this is a test_multiprocessing issue? If it is then the title is misleading.
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue36
Change by Brett Cannon :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue36343>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Thanks!
--
nosy: +brett.cannon
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
I guess my confusion comes from the fact that test_venv in isolation is a
totally fine test suite, it just fails when test_multiprocessing runs it due to
something multiprocessing-related.
I've tried tweaking the title to reflect the fact that i
Brett Cannon added the comment:
Pulling in Eric and Nick as they have played w/ the C API more recently.
--
nosy: +eric.snow, ncoghlan
___
Python tracker
<https://bugs.python.org/issue36
Brett Cannon added the comment:
I agree with Eric.
Thanks for the idea, Ivan, but I'm closing this as an idea we won't be pursuing.
--
nosy: +brett.cannon
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Change by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<https://bugs.python.org/issue36085>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Thanks, mental!
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue36404>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
New changeset 360e1e4c519cfc139de707bcdd1e6c871eec79ee by Brett Cannon
(Stéphane Wirtel) in branch 'master':
bpo-36345: Add a new example in the documentation of wsgiref (#12511)
https://github.com/python/cpython/commit/360e1e4c519cfc139de707bcdd1e6c
Brett Cannon added the comment:
I actually still think we should remove serve.py as the person who had needed
to clean up that directory when we realized we had massive bitrot in /Tools. :)
I don't' think that just because Debian packages means we need to continue
supporting and m
Brett Cannon added the comment:
I've gone ahead and merged Pierre's fix (thanks!), but I'm not sure if
SharedMemoryManager should stay in the shared_memory docs or if it should move
over to multiprocessing.manager.
Davin, any input on that?
--
nosy
2501 - 2600 of 5934 matches
Mail list logo
