Brett Cannon added the comment:
The test_traceback changes should be easy to tweak to use a regex or
startwith() check so the tests pass again.
For the test_xml_etree failures I'm not sure how best to fix that other than
taking it out. Maybe if sys.gettrace() returns something then ski
Changes by Brett Cannon :
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue29691>
___
___
Python-bugs-list mailing list
Unsubscrib
Brett Cannon added the comment:
I don't think it's a duplicate because we had a passing coverage run when we
initially made the migration so something got tweaked to lead to the failures.
--
___
Python tracker
<http://bugs.python.o
Brett Cannon added the comment:
BTW, just because I assigned this to me doesn't mean others can't write a PR to
solve this. :) I will review any PR that fixes this issue, I'm just going to
make sure it gets solved no matter what if no one el
Brett Cannon added the comment:
So the reason we don't have the coverage run complain loudly is it takes at
least 40 minutes to complete, so having to wait for that could potentially be
annoying if you're e.g. trying to merge a cherry-pick and you just want to
verify you didn't
Changes by Brett Cannon :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29691>
___
___
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue29048>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
If the "ping" is for me, I spent my open source day last week reviewing the
dependency for this issue (and other stuff) so I plan to get to this PR this
Friday.
--
___
Python tracker
<http://bu
New submission from Brett Cannon:
E.g. https://ci.appveyor.com/project/python/cpython/build/3.7.0a0.142. This
looks to be the last consistent failure on AppVeyor.
--
components: Windows
messages: 289260
nosy: brett.cannon, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
Changes by Brett Cannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29749>
___
Changes by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<http://bugs.python.org/issue29769>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
title: PyLong_FromString fails on decimals with leading zero and base=0 ->
PyLong_FromString documentation wrong on numbers with leading zero and base=0
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
Since it sounds like everything on the Python side is fine I'm closing this.
--
nosy: +brett.cannon
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http:
Brett Cannon added the comment:
Please keep this issue closed until you hear back from the SWIG team. Just
because your code worked under Python 3.5 doesn't mean SWIG didn't accidentally
emit something that breaks under Python 3.6 because we started being more
stringent about
Changes by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<http://bugs.python.org/issue29258>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I'm still thinking about this but I'm still leaning towards deprecating
pathlib.absolute().
--
___
Python tracker
<http://bugs.python.o
Changes by Brett Cannon :
--
pull_requests: +500
___
Python tracker
<http://bugs.python.org/issue28810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
pull_requests: +502
___
Python tracker
<http://bugs.python.org/issue28810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I have merged all the PRs that Ivan had open. I'll leave the issue open since
Ivan said he had another PR he wanted to create.
--
___
Python tracker
<http://bugs.python.org/is
Brett Cannon added the comment:
I know it has it's uses (avoiding stat calls is one of them), but it is still
undocumented, untested, and has two comments in it saying it needs work.
Because of all that it might as well not exist since it doesn't meet our
standards of quality.
Changes by Brett Cannon :
--
title: Document Path.absolute -> Add support for Path.absolute
___
Python tracker
<http://bugs.python.org/issue29688>
___
___
Py
Changes by Brett Cannon :
--
title: Add support for Path.absolute -> Add support for Path.absolute()
___
Python tracker
<http://bugs.python.org/issu
Changes by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<http://bugs.python.org/issue26121>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
"What's the rationale for not calling self._flavour.pathmod.abspath() to
implement absolute()?" Beats me. :) It's just how Antoine wrote it and that's
all I know.
--
___
Python tracker
Changes by Brett Cannon :
--
assignee: brett.cannon ->
___
Python tracker
<http://bugs.python.org/issue29688>
___
___
Python-bugs-list mailing list
Unsubscrib
Brett Cannon added the comment:
That's because the frame-stripping trick is done through import.c which
importlib.import_module() doesn't pass through. So thanks for the report,
Ulrich, but it is working as expected and we won't be changing import_module()
to pass through the
Brett Cannon added the comment:
So new options sounds like a no-go, but what about the COMPACT attribute on the
json module as per https://github.com/python/cpython/pull/72?
--
___
Python tracker
<http://bugs.python.org/issue29
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue29805>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
components: +Library (Lib) -IO
___
Python tracker
<http://bugs.python.org/issue29805>
___
___
Python-bugs-list mailing list
Unsub
Brett Cannon added the comment:
Yep, I agree it isn't as nice as syntactic import, but that can happen when
you're not getting to use dedicated bytecode like syntactic import does.
If you can come up with a patch that adds hardly any more C code -- say about
10 or 20 lines?
Brett Cannon added the comment:
I agree with David that I don't see how adding a constant to the module is
really a complication of an API.
--
___
Python tracker
<http://bugs.python.org/is
Brett Cannon added the comment:
The type annotation is already in the AST so there's nothing to carry over from
typed_ast (we only care about the latest Python version while typed_ast tries
to be version-agnostic).
--
___
Python tracker
Brett Cannon added the comment:
Yes, the code won't be deleted until we're in a post-2.7 world.
--
___
Python tracker
<http://bugs.python.org/issue18716>
___
__
Brett Cannon added the comment:
I also support the idea of getting something like shutil.move() into pathlib.
--
___
Python tracker
<http://bugs.python.org/issue29
Brett Cannon added the comment:
I should also mention that rename()
(https://docs.python.org/3/library/pathlib.html#pathlib.Path.rename) and
replace() (https://docs.python.org/3/library/pathlib.html#pathlib.Path.replace)
already do exist, so it might be best to add a keyword-only flag to one
Changes by Brett Cannon :
--
assignee: -> terry.reedy
components: +IDLE
nosy: +terry.reedy
title: " don't work on Mac -> " don't work on Mac under IDLE
___
Python tracker
<http
Brett Cannon added the comment:
The BuiltinImporter's assumption is reasonable because there are no built-ins
that are packages. :) In pyexpat's case it's an extension module, not a
built-in.
As for the expat issue, a patch that backfills the missing info would probab
Changes by Brett Cannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29836>
___
Brett Cannon added the comment:
ExtensionFileLoader.is_package() is accurate because it's not typical for an
extension module to inject its own submodules like pyexpat is. Usually people
who use an extension module in a package use it just for a submodule and not
even as an __init__.
Brett Cannon added the comment:
Yep, kwargs should be dropped since it isn't used or documented:
https://docs.python.org/3/library/pathlib.html#pathlib.PurePath (probably just
a hold-over from when it did in some earlier version of the code).
--
components: +Library (Lib)
New submission from Brett Cannon:
https://github.com/python/cpython/blob/05f53735c8912f8df1077e897f052571e13c3496/Lib/importlib/__init__.py#L140
"reload() argument must be a module" (missing the "a").
--
assignee: brett.cannon
components: Library (Lib)
m
Brett Cannon added the comment:
First, I don't know what version you're testing against because 3.0.6.1 isn't
an actual release of Python and 3.6.1 isn't released yet (unless you know
something I don't know :) ).
Second, the issue is that you're trying to impo
New submission from Brett Cannon:
In issue #29540 there was a suggestion to add a `compact` argument to
json.dump() and json.dumps(). That was eventually rejected as adding complexity
to an API that's already messy.
But in GH-72 someone created a COMPACT constant to the json module which
Changes by Brett Cannon :
--
nosy: +benhoyt, r.david.murray
___
Python tracker
<http://bugs.python.org/issue29863>
___
___
Python-bugs-list mailing list
Unsub
Brett Cannon added the comment:
The output LGTM.
--
___
Python tracker
<http://bugs.python.org/issue27593>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
title: Fix grammar in importlib.reload() exception -> Fix grammar typo in
importlib.reload() exception
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
Shoot, that's too bad. I guess we should document it then so people are aware
that keyword arguments are ignored, else we will break subclasses. There's also
an unfortunate difference between PurePath and Path as PurePath doesn't h
Brett Cannon added the comment:
Then I vote for Serhiy's idea of simply raising an exception in the concrete
subclasses when a keyword argument is given.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Brett Cannon :
--
nosy: +giampaolo.rodola, haypo
___
Python tracker
<http://bugs.python.org/issue29883>
___
___
Python-bugs-list mailing list
Unsub
Brett Cannon added the comment:
Go for it, Mandeep!
--
___
Python tracker
<http://bugs.python.org/issue29862>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
New changeset 8f9e1bbf2dbdf46a0bf920279568a31460043376 by Brett Cannon (Ivan
Levkivskyi) in branch 'master':
bpo-28810: Document remaining bytecode changes in 3.6 (GH-651)
https://github.com/python/cpython/commit/8f9e1bbf2dbdf46a0bf920279568a3
Changes by Brett Cannon :
--
pull_requests: +713
___
Python tracker
<http://bugs.python.org/issue28810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
New changeset 74bfcc314b188e1e8c90e442270e36d6510755ee by Brett Cannon in
branch '3.6':
bpo-28810: Document remaining bytecode changes in 3.6 (GH-651) (GH-808)
https://github.com/python/cpython/commit/74bfcc314b188e1e8c90e442270e36
Brett Cannon added the comment:
Is there anything left to do for this Ivan?
--
___
Python tracker
<http://bugs.python.org/issue28810>
___
___
Python-bugs-list m
Brett Cannon added the comment:
New changeset cb5297a9e6b51c736ab8564b1a123577ba0dd2ad by Brett Cannon (Jim
Fasarakis-Hilliard) in branch 'master':
bpo-29836: Remove nturl2path from test_sundry and amend the module docstring
(GH-694)
https://github.com/python/cpyt
Brett Cannon added the comment:
New changeset 4807fa8386f825d0c71192c59f7e33b99a94bebe by Brett Cannon in
branch '3.6':
bpo-28810: Document changes to CALL_FUNCTION opcodes (GH-607)
https://github.com/python/cpython/commit/4807fa8386f825d0c71192c59f7e33
Brett Cannon added the comment:
New changeset 4b2a2a425a906c8e4eb8daee14ab1793e225f726 by Brett Cannon (Ivan
Levkivskyi) in branch 'master':
bpo-28810: Document changes to CALL_FUNCTION opcodes (GH-250)
https://github.com/python/cpython/commit/4b2a2a425a906c8e4eb8daee14ab17
Brett Cannon added the comment:
New changeset 68c5e4c592495f1e0f4f60acb3483beb6aa87be1 by Brett Cannon in
branch '3.6':
bpo-28810: Document BUILD_TUPLE_UNPACK_WITH_CALL bytecode (GH-605)
https://github.com/python/cpython/commit/68c5e4c592495f1e0f4f60acb3483b
Brett Cannon added the comment:
New changeset 7e52c3e7aefb4cdaa0662fc01ff68a5e976b77ca by Brett Cannon (Ivan
Levkivskyi) in branch 'master':
bpo-28810: Document BUILD_TUPLE_UNPACK_WITH_CALL bytecode added in 3.6 (GH-239)
https://github.com/python/cpyt
Brett Cannon added the comment:
New changeset 390a0969c1206a37c86961ebf7ef3050681ed8dd by Brett Cannon
(svelankar) in branch 'master':
bpo-29749: Update int() docstring (GH-565)
https://github.com/python/cpython/commit/390a0969c1206a37c86961ebf7ef30
Brett Cannon added the comment:
New changeset d908fd9ee1c307f7066023eb2031c0f509036cbc by Brett Cannon (Serhiy
Storchaka) in branch 'master':
bpo-29695: Fixed tests after removing keyword args support in some basic type
constructors. (GH-520)
https://github.com/python/cpyt
Brett Cannon added the comment:
New changeset 4d0630d9d5ff4919caa463a64887f32d671eaab8 by Brett Cannon in
branch '3.5':
bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (GH-441)
https://github.com/python/cpython/commit/4d0630d9d5ff4919caa463a64887f3
Brett Cannon added the comment:
New changeset 226af23e858e2914cf78dfa6fd441c7b90a4cc91 by Brett Cannon in
branch '3.6':
bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (GH-440)
https://github.com/python/cpython/commit/226af23e858e2914cf78dfa6fd441c
Brett Cannon added the comment:
New changeset 0705f66eb369aa6a6cdb699e24ff61e1ab2e0c56 by Brett Cannon (Ivan
Levkivskyi) in branch 'master':
bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (#238)
https://github.com/python/cpython/commit/0705f66eb369aa6a6cdb699e24ff61
Brett Cannon added the comment:
New changeset 9d07aceedabcdc9826489f8b9ba056283bb3 by Brett Cannon in
branch '3.6':
bpo-29455: Mention coverage.py in trace module documentation (GH-435)
https://github.com/python/cpython/commit/9d07aceedabcdc9826489f8b9bafff
Brett Cannon added the comment:
New changeset 5dfccb06dc513ae67fac5fee66356ad58a4de170 by Brett Cannon (Marco
Buttu) in branch 'master':
bpo-29455: Mention coverage.py in trace module documentation (#261)
https://github.com/python/cpython/commit/5dfccb06dc513ae67fac5fee66356a
Brett Cannon added the comment:
Benjamin did the update to 9.0.0.
We should probably update Tools/unicode/makeunicodedata.py to print out in the
end that the appropriate file needs to be added to pythontest.net **before**
merging an update to unicodedata
Brett Cannon added the comment:
New changeset d702c50049207d825c1d5925fbc7306514fa9a0a by Brett Cannon (Jim
Fasarakis-Hilliard) in branch 'master':
bpo-29912: Remove redundant tests in list_tests that are found in seq_tests
(GH-847)
https://github.com/python/cpyt
Changes by Brett Cannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29912>
___
Brett Cannon added the comment:
New changeset ec1f5df46ed37aa3e839d20298c4b361a9a74bc4 by Brett Cannon
(Vajrasky Kok) in branch 'master':
bpo-19791: Use functions from test support to check the symlink support.
(GH-822)
https://github.com/python/cpyt
Changes by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
I think we're getting bogged down in a larger scope than this issue is about.
All we should be discussing in this issue is whether adding an entry in the
glossary for "f-string" as it's already being used in the community is bad
(which I don
Brett Cannon added the comment:
New changeset a90e64b78d74b80a7cbcca2237280c724b99431b by Brett Cannon
(Sylvain) in branch 'master':
bpo-29932: Fix small error message typos in arraymodule.c (GH-888)
https://github.com/python/cpython/commit/a90e64b78d74b80a7cbcca2237280c
Changes by Brett Cannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29932>
___
Brett Cannon added the comment:
There's actually a footnote pointing out that %z is not supported by all libc
implementations: https://docs.python.org/3/library/time.html#id2. Probably
adding a note for %z in the strftime() table would be good.
--
nosy: +brett.c
Brett Cannon added the comment:
That's a good point, Serhiy, since that's what the exception is signaling. So
yes, the exception should be ModuleNotFounderror.
--
title: Have importlib.reload() raise ImportError when a spec can't be found ->
Have import
Changes by Brett Cannon :
--
nosy: +giampaolo.rodola, haypo
___
Python tracker
<http://bugs.python.org/issue29970>
___
___
Python-bugs-list mailing list
Unsub
Brett Cannon added the comment:
I consider it an enhancement, especially if someone was slopping with their
tests and explicitly checks the repr of ImportError.
--
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
There's also what changes might occur in the coverage results when we start
using fullcoverage: https://github.com/python/core-workflow/issues/18
--
___
Python tracker
<http://bugs.python.org/is
New submission from Brett Cannon:
I noticed that the documentation for the abc module
(https://docs.python.org/3/library/abc.html) has all example classes use
ABCMeta instead of ABC which is what most people probably want. To keep things
simple the docs should probably be updated to inherit
Changes by Brett Cannon :
--
title: test failures under Bash on Windows -> test failures under Bash on
Windows / WSL
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
Would it make sense to have a `make rebuild` or something which explicitly
ignores prebuilt files? That could then also serve as non-obvious documentation
on how to build those files in the first place.
--
nosy: +ncoghlan
Brett Cannon added the comment:
Yep, that's exactly what I was suggesting, Martin (and sorry if I missed you
saying that earlier; on vacation so trying to keep email/open source time to
minimum :) .
--
___
Python tracker
<http://bugs.py
Brett Cannon added the comment:
Under Creators Update with a clean Ubuntu 16.04 image and only installing clang
and make, I built with `CC=clang ./configure; make -s -j` and ran with
`./python -m test -j0 -x test_socket` (test_socket hung in a previous run; I
let it run for 10 minutes
Brett Cannon added the comment:
Running the tests with -uall didn't change the results.
--
___
Python tracker
<http://bugs.python.org/issue27869>
___
___
Brett Cannon added the comment:
When failures are bit more isolated they should probably be reported to
https://github.com/microsoft/bashonwindows .
--
___
Python tracker
<http://bugs.python.org/issue27
Changes by Brett Cannon :
--
versions: +Python 3.7 -Python 3.6
___
Python tracker
<http://bugs.python.org/issue27869>
___
___
Python-bugs-list mailing list
Unsub
New submission from Brett Cannon:
It looks like test_abc isn't really testing find_spec() very much compared to
find_module(). There might also be some tests still using find_module() that
should be updated to use find_spec() instead.
--
components: Tests
messages: 292552
Brett Cannon added the comment:
There's potentially some usefulness from other tools, but Raymond is right that
the main motivation is definitely gone long-term. Dropping this down to "low"
priority simply because others have asked for this kind of support before.
--
p
Brett Cannon added the comment:
Can you separate out the bug report from the feature request as two separate
issues? You can keep one here and rename the title if you want.
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.
Brett Cannon added the comment:
I think that covers it!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Brett Cannon:
If you look at the docs for shutil
(https://docs.python.org/3/library/shutil.html), you will notice all over it
says things like "path names given as strings". The question is whether that
statement is true in the face of path-like objects? If it is
Changes by Brett Cannon :
--
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue30235>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Without looking at the PR there are two ways to interpret my unfortunately
vague comment. One is to say that the objects returned by tempfile code should
support os.PathLike; that's what Serhiy is objecting to as those are objects
representing concrete t
Changes by Brett Cannon :
--
title: Add os.PathLike support to the tempfile module's 'dir' arguments ->
Add/check os.PathLike support for the tempfile module's 'dir' arguments
___
Python tracker
&
Brett Cannon added the comment:
Since the objects I thought of for this aren't purely representing paths I'm
going to close this to keep os.PathLike for things that are specifically
representing paths.
--
resolution: -> rejected
___
P
Brett Cannon added the comment:
The classes mentioned actually require that the path exist on the file system
so there's no extra restrictions. As for cost, it's pretty cheap as a call to
_os.fspath() is written in C and does an immediate type-check for str or bytes
for the c
New submission from Brett Cannon:
https://docs.python.org/3/library/importlib.html#importlib.machinery.ExtensionFileLoader
says "fullname, path" for __init__(), but
https://github.com/python/cpython/blob/647c3d381e67490e82cdbbe6c96e46d5e1628ce2/Lib/importlib/_bootstrap_external.py#
Brett Cannon added the comment:
How long has the method been there? And does it hurt anything for it to be
exposed? Removing it at this point may break code if it predates Python 3.7.
--
nosy: +brett.cannon
___
Python tracker
<h
Brett Cannon added the comment:
Another option is to rename 'name' to 'fullname', make 'name' keyword-only, and
then raise a DeprecationWarning if 'name' is used, eventually removing the
keyword-only argument.
--
_
2401 - 2500 of 5934 matches
Mail list logo
