[issue23399] venv should create relative symlinks where possible

2015-02-06 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue23399> ___ ___ Python-bugs-list

[issue12782] Multiple context expressions do not support parentheses for continuation across lines

2015-02-16 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Let's just Won't Fix this. Use a contextlib.ExitStack. -- ___ Python tracker <http://bugs.python.org/issue12782> ___ ___

[issue12782] Multiple context expressions do not support parentheses for continuation across lines

2015-02-16 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- resolution: -> wont fix status: open -> closed ___ Python tracker <http://bugs.python.org/issue12782> ___ ___ Python-bugs-

[issue24305] The new import system makes it impossible to correctly issue a deprecation warning for a module

2015-05-27 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue24305> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24309] string.Template should be using str.format and/or deprecated

2015-05-28 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: So yeah, we don't want to deprecate string.Template. It has a very specific use case that's used a lot, i.e. making strings dead simple to translate. %(foo)s was very problematic. {foo} is a little better, but looks too weird for most translat

[issue23968] rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET)

2015-05-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I don't know what problems I might have run into previously, but it's working now and seems fine to me. +1 -- nosy: +barry ___ Python tracker <http://bugs.python.o

[issue19699] Update zipimport for PEP 451

2015-06-02 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19699> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24168] Unittest discover fails with namespace package if the path contains the string same as the module name

2015-06-04 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue24168> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24168] Unittest discover fails with namespace package if the path contains the string same as the module name

2015-06-04 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: If you need a test case, try https://gitlab.com/warsaw/flufl.lock -- ___ Python tracker <http://bugs.python.org/issue24

[issue24351] string.Template documentation incorrectly references "identifiers"

2015-06-05 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Rather than change the code, which strives to keep the "Simple" in PEP 292's title, I'd rather just update the documentation to define what "identifier" means here. E.g. " * ``$identifier`` names a substitution pl

[issue24412] setUpClass equivalent for addCleanup

2015-06-08 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue24412> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24351] string.Template documentation incorrectly references "identifiers"

2015-06-09 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue24351> ___ ___ Python-bugs-list

[issue24454] Improve the usability of the match object named group API

2015-06-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue24454> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19995] %c, %o, %x, %X accept non-integer values instead of raising an exception

2015-06-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Found my first 3.5 breakage which I think is due to this. >>> from uuid import uuid4 >>> '%.32x' % uuid4() -- nosy: +barry ___ Python tracker <ht

[issue19995] %c, %o, %x, %X accept non-integer values instead of raising an exception

2015-06-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Fix: >>> '%.32x' % uuid4().int -- ___ Python tracker <http://bugs.python.org/issue19995> ___ ___ Pyth

[issue15014] smtplib: add support for arbitrary auth methods

2015-06-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I believe this change broke RFC 4954's AUTH command when the optional initial-response is expected. $4 "The AUTH Command" says: AUTH mechanism [initial-response] ... initial-response: An optional initial client response. If present,

[issue15014] smtplib: add support for arbitrary auth methods

2015-06-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Here's a rough thought for a fix. Some auth_*() methods require a challenge, but some don't, e.g. auth_plain(). Let's allow authobject() to be called with challenge=None. If they allow an initial-response, then they can just return the resp

[issue15014] smtplib: add support for arbitrary auth methods

2015-06-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Also, smtpd is not compatible with auth challenges because found_terminator() doesn't know that the response its getting isn't a command but instead a challenge response. So really we need another bug to track fixes to smtpd.py to handle challenge

[issue15014] smtplib: add support for arbitrary auth methods

2015-06-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jun 22, 2015, at 10:00 PM, R. David Murray wrote: >We change the authobj signature to challenge=None, then the first thing we do >in auth is 'initial_response = authobj()'. The return value can be the empty >string or a real initial val

[issue21935] Implement AUTH command in smtpd.

2015-06-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Martin says: "I cannot see any particular circumstances where unencrypted passwords for smtpd would be acceptable, given that there are perfectly established technologies. So I remain -1 on this patch." Here's a use case: a testing SMTP

[issue22032] Use __qualname__ together with __module__

2015-06-23 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: FWIW, this broke the zope.testing doctests: https://bugs.launchpad.net/zope.testing/+bug/1467644 I submitted a patch, which was reasonable given the normalization that zope.testing does for doctest output, but people should be aware that this can break

[issue22508] Remove __version__ string from email

2015-06-23 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: When I ported Mailman 3 to Python 3.5 I had to remove the check on email.__version__ :) -- ___ Python tracker <http://bugs.python.org/issue22

Re: [issue24534] disable executing code in .pth files

2015-06-30 Thread M.-A. Lemburg
On 01.07.2015 00:16, Min RK wrote: > >> Just because a feature can be misused doesn't make it a bad feature. > > That's fair. I'm just not aware of any uses of this feature that aren't > misuses, hence the patch. I don't remember the details of why t

[issue15014] smtplib: add support for arbitrary auth methods

2015-07-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I have a patch to support initial-response, which I'll be posting here after a bit of clean up and a full (local) test run, with documentation. I ended up adding a keyword argument `initial_response_ok=True` to .login() and .auth(). The reason for th

[issue15014] smtplib: add support for arbitrary auth methods

2015-07-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Attached patch includes test, documentation, and implementation. While this is technically a new feature, it fixes a regression in Python 3.5 w.r.t. 3.4. I'll email python-dev with a request for beta exemption. -- Added file: http://bugs.pytho

[issue15014] smtplib: add support for arbitrary auth methods

2015-07-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jul 07, 2015, at 05:59 PM, R. David Murray wrote: >I don't see any need to add the is_initial_auth_ok flag. Either the auth >method returns something that is not None (initial auth is OK), or it doesn't >(initial auth is not OK). I

[issue15014] smtplib: add support for arbitrary auth methods

2015-07-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Thanks! -- ___ Python tracker <http://bugs.python.org/issue15014> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15014] smtplib: add support for arbitrary auth methods

2015-07-09 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- assignee: -> barry status: open -> closed ___ Python tracker <http://bugs.python.org/issue15014> ___ ___ Python-bugs-list

Re: [issue24872] Add /NODEFAULTLIB:MSVCRT to _msvccompiler

2015-08-17 Thread M.-A. Lemburg
On 15.08.2015 22:41, Steve Dower wrote: > > Marc-Andre: there are a few concerns with including DLLs that aren't new with > any of the 3.5 changes. > > * depending on another CRT version is fine *if* it is available (users may > have to be told/helped to install the red

[issue24941] classproperty

2015-08-26 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue24941> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24965] Implement PEP 498: Literal String Formatting

2015-08-30 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue24965> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7175] Define a standard location and API for configuration files

2015-09-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm of mixed opinion. I personally don't like cluttering up my $HOME with a jillion dotfiles so I appreciate the organization XDG_CONFIG_HOME offers. But that also makes things less discoverable. Looking in XDG_CONFIG_HOME first with a fallbac

[issue7175] Define a standard location and API for configuration files

2015-09-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 01, 2015, at 07:15 PM, Glyph Lefkowitz wrote: >There are other advantages to following the XDG spec. If we follow it >correctly (and not, like Barry suggested, start adding random other >directories like ~/.python) I was really just suggestin

[issue25008] Deprecate smtpd

2015-09-05 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Removing smtpd would definitely be a hardship for me right now, probably for obvious reasons. I use it in testing frameworks, and even wrote a library called lazr.smtptest that is built around smtpd. In Mailman, we have an LMTP server built on smtpd that

[issue25014] Add contextlib.itercm()

2015-09-07 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue25014> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25002] Deprecate asyncore/asynchat

2015-09-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 04, 2015, at 08:55 PM, STINNER Victor wrote: >Maybe it can be fun to rewrite the module using asyncio, but I'm not >convinced that a SMTP server in the Python stdlib is super useful. As I mentioned in issue25008, removing smtpd would be a h

[issue25008] Deprecate smtpd

2015-09-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 07, 2015, at 02:26 PM, STINNER Victor wrote: >Can we modify the issue title to "Rewrite smtpd with asyncio"? Sure, although I'm currently thinking it's best to go third party until the API and imp

[issue24965] Implement PEP 498: Literal String Formatting

2015-09-09 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 09, 2015, at 11:57 PM, Eric V. Smith wrote: >There's one nit where I accept 'f' and 'F', but the PEP just says 'f'. I'm >not sure if we should accept the upper case version. I'd think not, but all >

[issue25061] Add native enum support for argparse

2015-09-10 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue25061> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25154] Drop the pyvenv script

2015-09-17 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue25154> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25154] Drop the pyvenv script

2015-09-17 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm sympathetic, given that in Debian/Ubuntu (and maybe other distros) where we have both Python 3.4 and 3.5, we have to install /usr/bin/pyvenv-3.4 and pyvenv-3.5, and then use symlinks to provide the default ve

[issue25154] Drop the pyvenv script

2015-09-17 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +doko ___ Python tracker <http://bugs.python.org/issue25154> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25159] Import time regression

2015-09-18 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue25159> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25154] Drop the pyvenv script

2015-09-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I have a patch which will at least improve the error message when `python3 -m venv` fails because python3-venv isn't installed on Debian/Ubuntu. I will work with Doko on this. -- ___ Python tracker

[issue22032] Use __qualname__ together with __module__

2015-09-24 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm not expecting a change either, I was also just documenting observed breakages. Given that I've ported a *ton* of code to 3.5 and only seen a handful of failures related to this issue, I agree that it's better just to provide information a

Re: [issue22798] time.mktime doesn't update time.tzname

2015-09-29 Thread M.-A. Lemburg
> varies among platforms. tzname is set when the module is being loaded and not updated afterwards (unless you call tzset()). I can't really see why you would expect a module global in Python to follow the semantics of a C global, unless this is explicitly documented. Note: The fact tha

[issue24755] asyncio.wrap_future undocumented

2015-09-30 Thread Andrej A Antonov
Changes by Andrej A Antonov : -- nosy: +polymorphm ___ Python tracker <http://bugs.python.org/issue24755> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25296] Simple End-of-life guide covering all unsupported versions

2015-10-02 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue25296> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25008] Deprecate smtpd (based on deprecated asyncore/asynchat): write a new smtp server with asyncio

2015-10-04 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm liking RDM's port of smtpd.py. I've done some clean ups, bug fixes, and added some debugging. See this branch over on gitlab: https://gitlab.com/python-smtpd-hackers/aiosmtpd/tree/issue25508 Try `python3 server.py` then run clien

[issue25328] ValueError in smtpd.py __init__() is not raised

2015-10-06 Thread Barry A. Warsaw
New submission from Barry A. Warsaw: In Python 3.5, SMTPChannel.__init__() ensures that enable_SMTPUTF8 and decode_data arguments are not both true. This even seems to be tested in test_smtpd.py. But it's clearly bogus because the exception is never raised! It just creates and throws

[issue25328] ValueError in smtpd.py __init__() is not raised

2015-10-08 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Oct 08, 2015, at 08:44 PM, Mauro S. M. Rodrigues wrote: >Python 3.5.0+ (3.5:1e99ba6b7c98, Oct 8 2015, 17:12:06) >[GCC 4.8.4] on linux >Type "help", "copyright", "credits" or "license" for more inf

[issue24978] Contributing to Python 2x and 3x Documentation. Translation to Russian.

2015-10-09 Thread Sebastian A. Brachi
Sebastian A. Brachi added the comment: > I wrote a proposal to the board a while ago I couldn't find that proposal, could you post a link to it? Thanks! -- nosy: +Sebastian A. Brachi ___ Python tracker <http://bugs.python.org

[issue21159] configparser.InterpolationMissingOptionError is not very intuitive

2015-10-12 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue21159> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21159] configparser.InterpolationMissingOptionError is not very intuitive

2015-10-12 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Reopening because we're starting to see regressions caused by the fix for this bug, e.g.: https://bugs.launchpad.net/configglue/+bug/1504288 -- keywords: +3.4regression, 3.5regression -patch status: closed -&

[issue21159] configparser.InterpolationMissingOptionError is not very intuitive

2015-10-13 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: The failure is in the configglue test suite, but apparently also kazan and qutebrowser are also affected by this change. In the Launchpad bug there's a link to a librarian build log result. The problem is that doing the .get() requires that subcl

[issue23857] Make default HTTPS certificate verification setting configurable

2015-10-14 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Re: platform_default - I'm not sure that's a good idea. It hides what's actually happening in some hard to discover place (the code). Probably EIBTI and just go with 'enable' and 'disable'. -- ___

[issue23857] Make default HTTPS certificate verification setting configurable

2015-10-14 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Oct 14, 2015, at 03:20 PM, Nick Coghlan wrote: >The rationale behind "platform_default" relates to what we put in the default >config file in the RPM. If enable/disable are the only options, then as soon >as the first version ships wi

[issue25008] Deprecate smtpd (based on deprecated asyncore/asynchat): write a new smtp server with asyncio

2015-10-16 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: This has come along pretty well. The project is managed here: https://gitlab.com/python-smtpd-hackers/aiosmtpd and documentation here: http://aiosmtpd.readthedocs.org/en/latest/ -- ___ Python tracker <h

[issue25515] Always use os.urandom for generating uuid4s

2015-10-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Oct 29, 2015, at 10:30 PM, Alex Gaynor wrote: >Right now uuid4 can be implemented one of 3 ways: If you're hacking on the uuid module, keep in mind issue22807 -- nosy: +barry ___ Python tracke

[issue25649] Come up with a good way to handle module aliasing

2015-11-17 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue25649> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25649] Come up with a good way to handle module aliasing

2015-11-17 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Another example is the six.moves module, though I haven't looked at its implementation approach. -- ___ Python tracker <http://bugs.python.org/is

[issue25698] test regressions introduced with the fix for #22995

2015-11-25 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue25698> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25698] test regressions introduced with the fix for #22995

2015-11-30 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: This seems entirely reproducible in a local Xenial sbuild using the source packages in https://launchpad.net/~doko/+archive/ubuntu/toolchain/+packages Interestingly, inspection of the built artifacts in the schroot after all is done yields: # find . -name

[issue25698] test regressions introduced with the fix for #22995

2015-11-30 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: First failure in test run afaict: == ERROR: test_recursive_dict_subclass_and_inst (test.test_cpickle.cStringIOCPicklerFastTests

[issue25698] test regressions introduced with the fix for #22995

2015-11-30 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: But if I just run test_cpickle.py, it succeeds! -- ___ Python tracker <http://bugs.python.org/issue25698> ___ ___ Python-bug

[issue25698] test regressions introduced with the fix for #22995

2015-11-30 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I set a breakpoint where the error occurs. I'm in test_cpickle.py dumps(). Doing cPickle.dumps(arg) in the bp, I get the error. arg is: (Pdb) arg {<__main__.H object at 0x7ff8e2a870d0>: None} (Pdb) type(arg) Look again at the AttributeE

[issue25601] test_cpickle failure on the ware-gentoo-x86 buildbot

2015-12-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm duping this one to issue25698 because while it came later, it has a lot more information. They are clearly the same bug. -- nosy: +barry superseder: -> The copy_reg module becomes unexpectedly empty in test

[issue25698] The copy_reg module becomes unexpectedly empty in test_cpickle

2015-12-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Well, one thing I noticed is that init_stuff() in cPickle.c can leak the copy_reg module object, if any of the subsequent PyObject_GetAttr*() calls fail. They return -1 without decref'ing copyreg. Probably not a horrible leak since it's probably

[issue25698] The copy_reg module becomes unexpectedly empty in test_cpickle

2015-12-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: At the problematic breakpoint mentioned in msg255630, copy_reg is nearly empty. (Pdb) sys.modules['copy_reg'] (Pdb) dir(sys.modules['copy_reg']) ['__builtins__', '__doc__', '__file__', '__name__', &

[issue25698] The copy_reg module becomes unexpectedly empty in test_cpickle

2015-12-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: This just gets weirder. I've narrowed it down to running this command: build-static/python Lib/test/regrtest.py test_doctest test_cpickle fails every time. What's even weirder is that I hacked regrtest to print some useful information before and

[issue25698] The copy_reg module becomes unexpectedly empty in test_cpickle

2015-12-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Dec 01, 2015, at 06:26 PM, Barry A. Warsaw wrote: >I'll note one other thing. Doko mentioned that in our build environment, >cPickle is built in, not an extension. Which may be relevant because in a from-hg-head build of Python 2.7, this prob

[issue25698] The copy_reg module becomes unexpectedly empty in test_cpickle

2015-12-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Dec 01, 2015, at 06:47 PM, Serhiy Storchaka wrote: >Thanks Barry. Running test_cpickle after test_doctest I now can reproduce the >problem in a from-hg-head build of Python 2.7. That's interesting because I can't! (Neither from the 2

[issue25698] The copy_reg module becomes unexpectedly empty in test_cpickle

2015-12-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I added cPickle to Modules/Setup.local and rebuilt from hg. cPickle's a built-in but I still can't reproduce the problem. -- ___ Python tracker <http://bugs.python.o

[issue25698] The copy_reg module becomes unexpectedly empty in test_cpickle

2015-12-05 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Dec 05, 2015, at 07:03 AM, Benjamin Peterson wrote: >The underlying issue is classic: PyDict_SetItem returns NULL if the stack is >too deep. This confuses import. Thanks for digging into this Benjamin. I'm not able to investigate further atm

[issue25833] pyvenv: venvs cannot be moved because activate scripts hard-code paths

2015-12-10 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue25833> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22995] Restrict default pickleability

2016-01-06 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm reopening this issue because we're starting to see a bunch of regressions in Debian and Ubuntu we think is caused by the changes here. We've definitely started seeing them with 3.5.1, where packages that use Cython built just fine in 3.5

[issue22995] Restrict default pickleability

2016-01-06 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jan 06, 2016, at 10:13 PM, Serhiy Storchaka wrote: >What return __reduce_ex__(4) for the NameAssignment instance in 3.5.0? I'm not sure yet (it takes some time to set up the right environment to test this), but I do know which TypeError is

[issue22995] Restrict default pickleability

2016-01-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Your explanation still doesn't entirely make sense to me yet because the crash is happening in what seems to be a Cython implementation class, not a generated class based on a .pyx in some other project using Cython. I tried to search the Cython Tra

[issue26036] Unnecessary arguments on smtpd.SMTPServer

2016-01-07 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue26036> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22995] Restrict default pickleability

2016-01-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: You asked what reductor(4) returns in Python 3.5.0: > /usr/lib/python3.5/copy.py(176)deepcopy() -> rv = reductor(4) (Pdb) reductor(4) (, (,), None, None, None) And this is completely reasonable: (Pdb) p rv (, (,), None, None, None) (Pdb) p rv[0]

[issue22995] Restrict default pickleability

2016-01-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I added some debugging to the if(required) clause. This is interesting: basicsize 16 slotnames 0 basicsize 16 tp_basicsize 80 basicsize 16 tp_basicsize comes in at 16 bytes. tp_dictoffset and tp_weaklistoffset must both be 0, and while slotnames is not

[issue22995] Restrict default pickleability

2016-01-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: So yeah, I guess Cython is doing something magical to boost the instance's type's basicsize, but I can't tell what from the Python prompt. It also clearly doesn't affect the un/picklability of the instance, so I think the entire check i

[issue22995] Restrict default pickleability

2016-01-11 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I've verified that backing out the typeobject.c change allows kivy and pysam to build. s3ql still fails but for other reasons, though its build does get past the cython failure. This clinches it for me. I am going to remove the typeobject.c clause

[issue22995] Restrict default pickleability

2016-01-11 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jan 11, 2016, at 05:50 PM, Serhiy Storchaka wrote: > >Therefore my guess was true. There is a bug in Cython. It creates classes >that can't be correctly unpickled or copied. I don't think that's necessarily true. Clearly the cla

[issue22995] Restrict default pickleability

2016-01-11 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jan 11, 2016, at 07:20 PM, Serhiy Storchaka wrote: >I think we have to left this restriction in 3.6 (and Cython should fix its >bug by providing either __getnewargs__/ __getnewargs_ex__, __getstate__ or >__reduce__/__reduce_ex__). But in 2.7 a

[issue22995] Restrict default pickleability

2016-01-11 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: BTW Serhiy, can you please file a bug with upstream Cython? I think you're the right person to do it since you added this restriction. With reverting this in 2.7 and 3.5 it's not urgent, but we don't want to have to reopen this w

[issue22995] Restrict default pickleability

2016-01-12 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Thanks Stefan and Serhiy! I think this issue is now resolved. -- status: open -> closed ___ Python tracker <http://bugs.python.org/issu

[issue26060] Class __dict__ iteration order changing due to type instance key-sharing

2016-01-12 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Is this a bug though? No guarantees of dict order exists, regardless of whether the dict changes or not, right? Even if the implementation used to, or in some circumstances still does, appear to preserve iteration order, you shouldn't count

[issue26036] Unnecessary arguments on smtpd.SMTPServer

2016-01-12 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Tangentially, I'm kind of hoping we can get this into 3.6 as an asyncio replacement for smtpd: https://gitlab.com/python-smtpd-hackers/aiosmtpd -- ___ Python tracker <http://bugs.python.org/is

Re: [issue21955] ceval.c: implement fast path for integers with a single digit

2016-02-03 Thread M.-A. Lemburg
On 03.02.2016 18:05, STINNER Victor wrote: > >> python -m timeit "sum([x * x * 1 for x in range(100)])" > > If you only want to benchmark x*y, x+y and list-comprehension, you > should use a tuple for the iterator. ... and precalculate that in the setup: python -m

Re: [issue21955] ceval.c: implement fast path for integers with a single digit

2016-02-05 Thread M.-A. Lemburg
On 05.02.2016 16:14, STINNER Victor wrote: > > Please don't. I would like to have time to benchmark all these patches (there > are now 9 patches attached to the issue :-)) and I would like to hear > Serhiy's feedback on your latest patches. Regardless of the performance, the fastint5.patch look

[issue25698] The copy_reg module becomes unexpectedly empty in test_cpickle

2016-02-10 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Thanks for digging deeply and fixing this! -- ___ Python tracker <http://bugs.python.org/issue25698> ___ ___ Python-bugs-list m

[issue26408] pep-8 requires a few corrections

2016-02-22 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue26408> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26408] pep-8 requires a few corrections

2016-02-22 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- assignee: docs@python -> barry ___ Python tracker <http://bugs.python.org/issue26408> ___ ___ Python-bugs-list mailing list Un

[issue26408] pep-8 requires a few corrections

2016-02-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Thanks! I like some of the changes, and may tweak a few others. Thanks for the contribution. -- ___ Python tracker <http://bugs.python.org/issue26

[issue26408] pep-8 requires a few corrections

2016-02-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Feb 22, 2016, at 02:20 PM, Georg Brandl wrote: >Georg Brandl added the comment: > >-Consistency within one module or function is most important. >+Consistency within one module or function is the most important. > >You left out "th

[issue26176] EmailMessage example doesn't work

2016-02-24 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue26176> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26426] email examples: incorrect use of email.headerregistry.Address

2016-02-24 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue26426> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26521] add `extend_enum` to Enum

2016-03-09 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I was thrown off a bit by the description below. it's not that the OP wants to generate an Enum lazily (the functional API lets them do that), it's that the OP wants to *extend* an Enum lazily. Seems like a pretty obscure use case to me. I&

[issue26632] __all__ decorator

2016-03-23 Thread Barry A. Warsaw
New submission from Barry A. Warsaw: This is probably terrible, but given how difficult it is to keep __all__'s up to date, maybe something like this can be useful. I literally whipped this up in about 5 minutes, so sit back and watch the bikeshedding! import sys def public(thing):

<    19   20   21   22   23   24   25   26   >