Zachary Ware added the comment:
I've come across something in the implementation here that I'd like some
clarification on. What is the purpose of overriding __dir__ in Enum and
EnumMeta? It doesn't change any behavior that I'm aware of, just makes things
look a littl
Zachary Ware added the comment:
Here's a new version of the patch, which is a major rewrite. Among the changes:
- Switch from using 'goto' to execute the right subroutine to 'call' and end
every subroutine with 'exit /B' (thank you Richard for making me
Zachary Ware added the comment:
Here's a simple patch to clear up the first paragraph of PCbuild/readme.txt,
applicable to 3.3 and default.
--
keywords: +patch
nosy: +zach.ware
Added file: http://bugs.python.org/file30352/issue17326.diff
___
P
Zachary Ware added the comment:
Terry, I just tested your 2.7 patch, and it does work, but the workaround that
(I think) we have both been using on 3.x to find the Tcl/Tk .dlls (copying them
into PCbuild) doesn't work on 2.7 for some reason. However, if you add
..\tcltk\bin to PATH,
Zachary Ware added the comment:
Dave, your patch is a significant improvement on the accuracy of the current
doc, but the whole paragraph seems somewhat haphazard and confusing to me.
Here's my own attempt to clean it up, though I'm not certain just how much
improve
Changes by Zachary Ware :
--
title: os.path.join behavior on Windows (ntpath.join) is unexpected and not
well documented -> os.path.join behavior on Windows (ntpath.join) is not well
documented
___
Python tracker
<http://bugs.python.org/issu
Zachary Ware added the comment:
Committed, with better line wrapping.
Thank you Dave Sawyer for the initial patch, and RDM for the review.
--
___
Python tracker
<http://bugs.python.org/issue15
Zachary Ware added the comment:
To kick this along a bit, do the following testcases seem like the right
behavior to others, based on Mark Hammond's roadmap in msg51983? If there's
some agreement, I'll work on getting a modernized patch put together.
# currently (3.4)
assertTr
Zachary Ware added the comment:
Fixed, with a few changes based on the .hgignore file. Thanks for the patch,
Robert.
--
assignee: -> zach.ware
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> enhancement
versio
Zachary Ware added the comment:
Daniel: It's taken two years, but I've reviewed your patch :). There are a few
things that need to be addressed, but the basic change looks pretty good. If
you're still interested in seeing this fixed, I look forward to reviewing an
updated p
Zachary Ware added the comment:
I think I'd rather see a blacklist than a whitelist; it should be much shorter
and can be passed to regrtest with the "-x" option within build_pgo.bat.
Since we officially discourage PGO with VS 2008 and 2010 (due to compiler bugs)
anyway, mark
Zachary Ware added the comment:
eryksun: You commented on my review comment; does Claudiu's latest patch look
good to you?
--
nosy: +eryksun
___
Python tracker
<http://bugs.python.org/is
Changes by Zachary Ware :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue22613>
___
___
Python-bugs-list mailing list
Unsubscrib
New submission from Zachary Ware:
>From docs@:
"""
Hello,
First, I want to thank you for the useful and clear documentation of Python.
Beeing a fanatic reader of it, sometimes I encounter some mistake (or it seems
to me it is such). If this could bring some help, yo
Zachary Ware added the comment:
After the last round of changes, the buildbots appear to be mostly happy. If
anybody else wants to backport the changes, I'd be happy to review and commit,
but I'll leave the backporting itself to whoever wants to do it. In the
meantime, closing
Zachary Ware added the comment:
It grafted very easily, so it turns out to be "yes" :)
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.o
Changes by Zachary Ware :
--
assignee: -> zach.ware
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python
Zachary Ware added the comment:
Superseded by #22644 (and done, anyway).
--
assignee: -> zach.ware
resolution: -> fixed
stage: -> resolved
status: open -> closed
superseder: -> Update Windows installers to OpenSSL 1.0.1j
typ
Zachary Ware added the comment:
Done, as long as the buildbots stay happy with it.
--
assignee: -> zach.ware
components: +Installation, Windows
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> security
___
Zachary Ware added the comment:
Sure; here's a patch. I suspect we may want to try giving Sphinx some
different options to clean up the output a bit, but I'm not experienced enough
with Sphinx to have any specific suggestions.
--
Added file: http://bugs.python.org
Changes by Zachary Ware :
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue22677>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
I finally made it back to this and committed a tweaked version of your patch.
Thanks for the report and patch!
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python track
Zachary Ware added the comment:
I'm ambivalent on per-version externals dirs by now; I've since found it much
easier to maintain hg-shared repos per branch. I'll go ahead with this shortly
on all three branches, unless there are objections to it on 2.7 and 3.4.
--
ve
Zachary Ware added the comment:
Basically, after:
hg clone h.p.o/cpython default
hg share default 3.4
hg share default 2.7
hg -R 3.4 update 3.4
hg -R 2.7 update 2.7
the 2.7, 3.4, and default directories are separate working copies created from
the same history, each at a different revision
Zachary Ware added the comment:
There's no change from the status quo on that front: the only change
is that the $(externalsDir) VS variable becomes "..\externals" instead
of "..\..". Is there an open issue for vers
Zachary Ware added the comment:
I'd say so.
--
stage: -> resolved
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issue22177>
___
__
Zachary Ware added the comment:
This is fairly wild speculation on my part, but I think Python is likely at the
bottom of the suspect list for whose bug this is, after (in order):
1) your own code
2) matplotlib
3) Tcl/Tk
I would suggest trying to come up with the shortest reproducer you can
Changes by Zachary Ware :
Added file: http://bugs.python.org/file37060/issue17896-2.7.diff
___
Python tracker
<http://bugs.python.org/issue17896>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file30113/move_externals.diff
___
Python tracker
<http://bugs.python.org/issue17896>
___
___
Python-bug
Zachary Ware added the comment:
I don't think we're on the same page here, Terry, so here's some patches and a
wall of text to hopefully make me clearer.
In particular, I don't understand what you mean by "merge multiple tcltk
directories in isolated build directo
Changes by Zachary Ware :
Added file: http://bugs.python.org/file37059/issue17896-3.4.diff
___
Python tracker
<http://bugs.python.org/issue17896>
___
___
Python-bug
Zachary Ware added the comment:
Thanks, Ezio!
--
assignee: -> zach.ware
___
Python tracker
<http://bugs.python.org/issue22173>
___
___
Python-bugs-list mai
Zachary Ware added the comment:
Ok, I've imported nasm-2.11.06 to:
http://svn.python.org/projects/external/nasm-2.11.06
I'll work on a patch for default and see what (if anything) will need to change
in the openssl checkout.
--
Zachary Ware added the comment:
Fairly simple patch for default.
--
keywords: +patch
Added file: http://bugs.python.org/file37089/issue17717-default.diff
___
Python tracker
<http://bugs.python.org/issue17
Zachary Ware added the comment:
It doesn't look like "import locale" can fail ("import _locale" can, but
locale.py has emulation that would work with this patch).
LGTM.
--
stage: patch review -> commit review
versions: -Python 3.6
__
Zachary Ware added the comment:
The patches for 2.7 and 3.4 were more trivial than for default, and I was
pretty confident in the patch for default, so I went ahead and committed. I
did switch around which end of PATH our copy of NASM was added to, to make it
easier for someone to override
Changes by Zachary Ware :
--
components: +Build
nosy: +tim.golden
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue17717>
___
___
Python-
Zachary Ware added the comment:
Thanks for tracking it down, Ned!
--
___
Python tracker
<http://bugs.python.org/issue18604>
___
___
Python-bugs-list mailin
Zachary Ware added the comment:
Thanks for the test, Terry. Committed.
--
assignee: -> zach.ware
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Zachary Ware added the comment:
Good point, David. Jeremy, Trent, you're the only other Windows buildbot
operators as far as I know; feel free to clean up the old externals locations
as you like.
Also, sorry to make it a bit hairier to operate, but I think this is a big
enough improv
Zachary Ware added the comment:
Aaron, what version of Python are you using on what version of Windows? Also,
32 or 64 bit on both?
I can't reproduce this with any Python 3.3.6 or newer on 64-bit Windows 8.1.
--
___
Python tracker
Zachary Ware added the comment:
I haven't built 3.3.0 again yet to try to reproduce with it, but there
have been enough bug and security fixes in the more recent 3.3
releases that I'd strongly advise updating on general principle and
seeing if this issue goes away. If not to 3.4.2, a
Zachary Ware added the comment:
I have had a chance to build 3.3.0 and I was able to reproduce the bug with it,
so it is in fact fixed in later versions.
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Pytho
Zachary Ware added the comment:
Sorry, I haven't had a chance to get back to this one.
--
___
Python tracker
<http://bugs.python.org/issue19949>
___
___
Pytho
Zachary Ware added the comment:
Mark, did you test your latest patch?
--
___
Python tracker
<http://bugs.python.org/issue19980>
___
___
Python-bugs-list mailin
Zachary Ware added the comment:
Steve, I was actually just minutes away from committing the same fix in the
opposite direction when I got the notification of your commit. Nick will
correct me if I'm wrong but I think PyOS_CheckStack was supposed to stay in
pythonrun.c, especially since
Zachary Ware added the comment:
In that case, it would be good to make sure it still applies and passes the
tests. Last time I tried it didn't, and I was called away before I could
leave a note to that effect (for which I am sorry). However, I don't have
a strong enough opinion on
Zachary Ware added the comment:
Another round of review posted on Rietveld. I'll try to get the VS2015 preview
downloaded today and give some more feedback after using it.
Just one inconsequential note on python3.diff: the 'lib' command in
python3dll.vcxproj could use a
Zachary Ware added the comment:
After a debug build with VS2015, my biggest concern is this:
..\PC\bdist_wininst\install.rc(19): fatal error RC1015: cannot open include
file 'afxres.h'. [P:\ath\to\cpython\PCbuild\bdist_wininst.vcxproj]
There's also a slew of new warnings, m
Zachary Ware added the comment:
This is still causing a somewhat serious warning on Windows, see [1] for
example. The condition warned about affects every platform.
It took me some time to make sense of that function, but I think I finally
understand what's going on. I think St
Zachary Ware added the comment:
Definitely not 2.7, since it's still on VS2008 and would require so many
changes for this to matter that it's just not an issue; I'm not sure on 3.4.
Is cabinet.lib available (and have everything we need) for MSVC10 and SDK 7.1
(which are the im
Changes by Zachary Ware :
--
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue22938>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Zachary Ware :
--
components: -Windows
___
Python tracker
<http://bugs.python.org/issue22938>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
Note that pickling of the pure Python version of methodcaller works as expected:
Python 3.4.2 (default, Nov 20 2014, 12:40:10)
[GCC 4.8.3] on linux
Type "help", "copyright", "credits" or "license" for more information.
&
Zachary Ware added the comment:
Try the following in Command Prompt:
cd /D C:\Users\kyle\Downloads && python -c "import io;print io.__file__"
The result should be "C:\Python27\lib\io.pyc". If it's not, rename the file
that you do get back.
--
nosy:
Zachary Ware added the comment:
No problem, glad it was an easy one :)
--
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue22967>
___
___
Py
Zachary Ware added the comment:
I'd prefer to just reimplement itemgetter and attrgetter to make them picklable
rather than adding pickling methods to them; see attached patch.
I also posted a few comments, but I just went ahead and addressed them myself
in this patch. I'm not qu
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file37319/issue22955.diff
___
Python tracker
<http://bugs.python.org/issue22955>
___
___
Python-bugs-list m
Changes by Zachary Ware :
Added file: http://bugs.python.org/file37320/issue22955.diff
___
Python tracker
<http://bugs.python.org/issue22955>
___
___
Python-bugs-list m
Zachary Ware added the comment:
Sorry Steve, I haven't been on Windows since my last review to give it
another try. And, of course, somewhere in the 5 seconds between shutting
down from Gentoo and turning back on for Windows last night, my laptop
decided that POSTing was just too much e
Zachary Ware added the comment:
Sorry, but there's nothing we can do about it; that will be a Tk issue. I'd
suggest discussing it with the Tcl/Tk developers, see http://wiki.tcl.tk/1020
--
nosy: +zach.ware
resolution: -> third party
stage: -> resolved
status
Zachary Ware added the comment:
Serhiy: functools.partial is a somewhat less than ideal comparison. The
pure-Python version is not picklable, the Python and C versions return
different things (the Python version is a function returning a function, the C
version is a regular class and returns
Zachary Ware added the comment:
Serhiy Storchaka added the comment:
> Reimplementations of the pure-Python itemgetter and attrgetter to
> automatically pickleable Python classes have a disadvantage. It makes
> the pickling incompatible between Python and C versions. This means
> tha
Zachary Ware added the comment:
I don't know near enough to comment on this one. If you feel confident in it,
I'd say go ahead.
--
___
Python tracker
<http://bugs.python.o
Zachary Ware added the comment:
Not sure why I was added here, but...
I agree with David, we need to see the python-dev discussion to its finish
before we make any more changes to any of our private copies of libffi. I hope
to get some experimental results from Windows written up and posted
Zachary Ware added the comment:
To clarify a bit, there's very little re-compiling, but everything that
references the pythoncore project (every extension) is re-linked. There's no
way around that short of not including the hg revision (which I won't accept
:), but the re-linki
Zachary Ware added the comment:
Hmmm, what are sections 3 and 4? Are you building from the VS GUI or
Command Prompt?
>From Command Prompt in a clean checkout, running PCbuild\build.bat -d -e
(debug build) should take several minutes. The same again should be quick,
and then just "
Zachary Ware added the comment:
On testing, you are correct, Mark. Sorry for the premature close.
How does this patch look to you, Steve?
--
assignee: -> zach.ware
keywords: +patch
resolution: not a bug ->
stage: resolved ->
status: closed -> open
type: -> beha
Zachary Ware added the comment:
Our original explanation accounts for the 31 projects "rebuilding".
I'll get the patch committed later tonight (hopefully).
--
___
Python tracker
<http://bugs.pyt
Zachary Ware added the comment:
STINNER Victor added the comment:
> Note: The binary (in debug mode) moved from PCbuild\python_d.exe to
> PCbuild\win32\python_d.exe
There ought to be a 'python.bat' in the root of the source tree that
will always point to the last-built pytho
Zachary Ware added the comment:
_posixsubprocess should not be compiled on Windows, as it will not work and
has the potential to completely screw up subprocess on Windows. This
appears to be a bug in subprocess32's setup.py, and thus does not apply to
Python itself at all. I agree with V
Changes by Zachary Ware :
--
nosy: +steve.dower
___
Python tracker
<http://bugs.python.org/issue23246>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
The .EXE is very strange, but the fix was simple enough. Thanks for the report.
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue23
New submission from Zachary Ware:
The Argument Clinic conversion of the binascii module left hexlify and
unhexlify with bad docstrings:
hexlify(...)
b2a_hex($module, data, /)
--
Hexadecimal representation of binary data.
The return value is
Zachary Ware added the comment:
Thanks for the (very quick!) review, Serhiy.
--
assignee: -> zach.ware
___
Python tracker
<http://bugs.python.org/issu
New submission from Zachary Ware:
Larry, in #22120 msg224817, you said:
"Since IIUC there's no code in 3.4 that uses an unsigned integer return
converter, I'm not backporting the fix."
Modules/binascii.c does have one use of an unsigned integer return, resulting
in the on
Zachary Ware added the comment:
I got the 1.0.1l sources prepared and committed to svn.python.org 12 days ago,
but got pulled away from it before I had a chance to build and test it. Steve,
Tim, if one of you has a chance to test it out before I do, please don't
hesitate.
Note tha
Changes by Zachary Ware :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue23355>
___
___
Zachary Ware added the comment:
I'm not seeing any problem with any section 4.1. If you can provide a direct
link to the problem and a description of it, please reopen the issue.
--
nosy: +zach.ware
resolution: -> not a bug
stage: -> resolved
status: ope
Zachary Ware added the comment:
Rather than add a variable to sys that will be empty 99% of the time, I think
I'd rather stick a '__command__' constant in the __main__ module namespace when
running with '-c' (think of '__file__'). You could then get at it el
Zachary Ware added the comment:
The patch is way out of date, pgen.vcxproj needs to be updated to match the
rest of our projects.
If nobody else takes this over (and it is low priority for a reason!), I'll get
back to it eventually.
--
nosy: +steve.
Zachary Ware added the comment:
> I don't even know what pgen is or why I'd want to build it...
pgen is the parser generator, taking Grammar/Grammar as input and generating
Include/graminit.h and Python/graminit.c. Only useful when you're changing
Python's grammar, but
Zachary Ware added the comment:
What does the diff to importlib.h look like? Does it look like a real change
to importlib or is it something innocuous like a change in whitespace or the
path separator in the heading?
--
components: +Build, Windows
nosy: +tim.golden, zach.ware
Zachary Ware added the comment:
Ah ha. Do you have the hg eol extension enabled? If not, you
probably should; it makes for far fewer headaches on Windows, and
should make this issue go away.
We should probably try to mitigate the problem anyway; Steve, how hard
would it be to change the
Zachary Ware added the comment:
The other option would be to change _freeze_importlib to force it to
use \n instead of \r\n; I'm not sure which change would be harder to
do.
Paul: fair enough; I've just found that keeping eol enabled reduces
headaches due to line endings to almost not
Zachary Ware added the comment:
Thanks, Steve!
--
assignee: -> steve.dower
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue23461>
___
__
Zachary Ware added the comment:
This one could use a NEWS entry, and possibly what's new as well.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Zachary Ware :
--
components: -2to3 (2.x to 3.x conversion tool)
___
Python tracker
<http://bugs.python.org/issue24289>
___
___
Python-bugs-list mailin
Zachary Ware added the comment:
If this wasn't outdated two and a half years ago, it is now :)
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyt
Zachary Ware added the comment:
We need to bump the Py_LIMITED_API definition in PCbuild/xxlimited.vcxproj
as well.
--
___
Python tracker
<http://bugs.python.org/issue24
Zachary Ware added the comment:
See discussion on #24244, I think this is an issue with your checkout rather
than the code.
--
nosy: +zach.ware
status: open -> pending
___
Python tracker
<http://bugs.python.org/issu
Changes by Zachary Ware :
--
assignee: -> steve.dower
components: +Build, Installation, Windows -Library (Lib)
nosy: +steve.dower, tim.golden, zach.ware
___
Python tracker
<http://bugs.python.org/issu
Changes by Zachary Ware :
--
assignee: -> steve.dower
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Zachary Ware added the comment:
Am I missing something here?
Python 3.6.0a0 (default:c2c3b79ba992, Jun 4 2015, 10:24:23)
>>> from configparser import ConfigParser
>>> cp = ConfigParser()
>>> cp.read_string("""\
... [remember]
... eth2.6 = True
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue24352>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
Ahhh, bitten by a typo? :)
--
components: -Extension Modules
resolution: -> not a bug
stage: -> resolved
status: open -> closed
type: enhancement -> behavior
versions: +Python 3.3, Python 3.4 -Python 3.6
__
Zachary Ware added the comment:
Python 3.1 is so old at this point that you're pretty much on your own. If you
for some reason have to use 3.1, you can go fishing on python-list for
assistance in getting it working.
--
resolution: -> out of date
stage: -> resolved
s
Zachary Ware added the comment:
If I'm not mistaken, if you're building an extension with some flavor of MinGW,
you've got the tools to build the lib yourself, right? It strikes me as being
much more reliable to provide hints towards how to do it yourself than to
provi
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue24175>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
The docs also say "New in version 3.4.4" :)
--
nosy: +zach.ware
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs
2101 - 2200 of 2740 matches
Mail list logo
