Zachary Ware added the comment:
I believe we're also waiting on input from Barry about whether to apply the
patch to 2.6.
--
___
Python tracker
<http://bugs.python.org/is
Zachary Ware added the comment:
> Does the 2.x patch apply cleanly to 2.6?
It should, if I remember correctly, though I haven't checked since
uploading it. I believe there were actually very few or no changes to the
file the patch is for between 2.6
Zachary Ware added the comment:
Here's a new version of the patch, with the fixes that Ned pointed out.
I also tried to address concerns about lost information; menu divisions have
been added to Doc/library/idle.rst, along with the blurb about running without
a subprocess being depre
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file28725/issue16893.diff
___
Python tracker
<http://bugs.python.org/issue16893>
___
___
Python-bugs-list m
Zachary Ware added the comment:
Your patch is certainly much simpler and more effective than mine; consider
mine withdrawn. I didn't take the simple step of figuring out exactly where
the problem was happening and was just trying to fix the issue without changing
anything in the actual
Zachary Ware added the comment:
Thanks for the review, Ezio. I've made some changes and here's the new patch.
--
Added file: http://bugs.python.org/file29237/issue16935.v3.diff
___
Python tracker
<http://bugs.python.o
Zachary Ware added the comment:
2528e4aea338 seems to have broken building on Windows:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/1517
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue17
New submission from Zachary Ware:
Here's the fix for test discovery of test_future* (particularly test_future3).
Without the patch, running 'python -m unittest discover Lib/test/
"test_future*"' results in an error in test_future3.py, due to test_future.py's
Fu
Zachary Ware added the comment:
Correction: ...all instances of support.unload *in test_future.py* with
support.CleanImport...
--
___
Python tracker
<http://bugs.python.org/issue17
Changes by Zachary Ware :
--
components: Tests
files: test_hash_discovery.diff
keywords: patch
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for test_hash.py
type: behavior
versions: Python 3.3, Python 3.4
Added file
New submission from Zachary Ware:
Version 1 converts test_main() into load_tests(). Version 2 removes the now
unnecessary import of run_unittest from support; thank you to Ezio for
reminding me to look at imports in these patches.
--
Added file: http://bugs.python.org/file29272
Zachary Ware added the comment:
Version 2 removes an unnecessary import in test_dbm_gnu.py
--
Added file: http://bugs.python.org/file29273/test_dbm-s_discovery.v2.diff
___
Python tracker
<http://bugs.python.org/issue17
New submission from Zachary Ware:
Here's a patch for test_imaplib.py that converts test_main into load_tests.
--
components: Tests
files: test_imaplib_discovery.diff
keywords: patch
messages: 183294
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
s
New submission from Zachary Ware:
Just subclassing issues in this one.
--
components: Tests
files: test_index_discovery.diff
keywords: patch
messages: 183299
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue10967>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue8273>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
I got to looking over my patch here again, and thought of another possible fix.
I'm not sure which is uglier, though :)
The problem is that most of the test cases are created using a custom subclass
of unittest.TestCase which takes extra constructor argu
Changes by Zachary Ware :
Added file: http://bugs.python.org/file29308/test_robotparser_discovery.v3.diff
___
Python tracker
<http://bugs.python.org/issue17066>
___
___
Zachary Ware added the comment:
Here's a pair of patches for 3.x and 2.7. The 3.x patch is actually targeted
at default; it has a couple extra instances of ``SkipTest`` that are converted
to :exc:`SkipTest` in the patch.
--
keywords: +patch
versions: +Python 3.3
Added file:
Changes by Zachary Ware :
Added file: http://bugs.python.org/file29319/issue17329-2.7.diff
___
Python tracker
<http://bugs.python.org/issue17329>
___
___
Python-bug
Zachary Ware added the comment:
In the patches, the description of SkipTest is copied directly from the
docstring in Lib/unittest/case.py with a bit of markup added. It mentions
TestResult.skip(), which doesn't exist. I wonder if that was meant to be
TestCase.skipTest()?
--
Zachary Ware added the comment:
Fair points. I had originally put it in the section you suggested, but then
decided that it better fit in a new section of its own under "Classes and
functions" as that section "describes in depth the API of unittest." But then,
it also
New submission from Zachary Ware:
I have found Doc/make.bat to be very useful, but I have hit a few of its
limitations now and then. Thus, I have made extensive modifications to bring
it much closer to the way Doc/Makefile works. Among the things changed in the
attached patch:
- Use pushd
Zachary Ware added the comment:
> Doc/make.bat assumes that this issue has already been resolved:
> if "%PYTHON%" EQU "" set PYTHON=..\pcbuild\python
> Even with '_d' appended, as it should be, that does not work for 3.x.
> I think that line should
Zachary Ware added the comment:
In issue17386, I have offered a patch to Doc/make.bat which makes using
make.bat on Windows very, very nearly the same as using make on UNIX. With
such a patch applied, it would be trivial to rewrite section 7.6.1 with
instructions that apply equally well to
Zachary Ware added the comment:
Sure can. This one should do it, at least for anyone with 3.3 installed.
--
Added file: http://bugs.python.org/file29358/win_doc_make_minipatch.diff
___
Python tracker
<http://bugs.python.org/issue17
Zachary Ware added the comment:
Here's an updated version in the form of a patch.
Features include:
- Ensure things are done in the right directory with pushd/popd
- Allow setting environment variables (for the life of the script) with:
make test "PYTHON=..\PCbuild\python.exe&q
Zachary Ware added the comment:
> Richard Oudkerk added the comment:
>
> +1
Thank you :)
> To use Tools/builbot/*.bat doesn't the current directory have to be the main
> directory of the repository? Then I see no point in the "-C" argument: just
> set th
Zachary Ware added the comment:
>Terry J. Reedy added the comment:
>
>One must run external.bat if one is to subsequently build from the vs
>gui with *most* of the external dependencies. I think the command to
>run it should be 'external', not 'ready'.
Zachary Ware added the comment:
I agree that, long-term, test_robotparser should probably be rewritten with
less magic. Short-term, though, I think it would be good to get a temporary
fix for discovery in place since this is the only test file that completely
blows up discovery before it
Zachary Ware added the comment:
Applying the minipatch makes the big patch fail to apply, so here's an update.
Also changed in this version of the patch:
- README.txt is updated. Not all the changes directly relate to this patch,
but there were some needed updates in there anyway
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file29417/win_doc_make.v2.diff
___
Python tracker
<http://bugs.python.org/issue17386>
___
___
Python-bug
Changes by Zachary Ware :
Added file: http://bugs.python.org/file29418/win_doc_make.v2.diff
___
Python tracker
<http://bugs.python.org/issue17386>
___
___
Python-bug
Zachary Ware added the comment:
I was recently bitten by this issue. I've reviewed Terry's patch on Rietveld,
and have tested it myself some. It seems to get the job done without getting
in the way.
--
nosy: +zach.ware
___
Python trac
Zachary Ware added the comment:
It does, in fact. Here's a patch.
--
Added file: http://bugs.python.org/file29419/issue10652.v2.diff
___
Python tracker
<http://bugs.python.org/is
New submission from Zachary Ware:
This patch converts test_main() to load_tests(*args) due to test_main doing a
lot of namespace manipulation on all the test classes. There are a lot of
subclassing issues that discovery doesn't like, hence throwing away the second
argument pass
New submission from Zachary Ware:
With support.suppress_crash_popup(), we can stop skipping
test_sys.SysModuleTest.test_recursionlimit_fatalerror on Windows.
--
components: Tests
files: test_sys_unskip.diff
keywords: patch
messages: 184765
nosy: ezio.melotti, zach.ware
priority: normal
Zachary Ware added the comment:
I was rather off about kill_python, wasn't I?
Anyway, I've finally gotten another version put together that I'd like to get
comments on. Major differences between this patch and the previous one, in no
particular order:
- Add a 'conf
Zachary Ware added the comment:
Defaulting to opening a browser window sounds great to me. In those cases
where there is no network access, though, I think we should keep a fallback
help.txt, and I think the Sphinx text rendering is about the simplest and
easiest fallback we can get. Shall
Zachary Ware added the comment:
Any comments? Christian, I'd especially like to hear from you since it looks
like you were the original author of Doc/make.bat (issue1472).
--
___
Python tracker
<http://bugs.python.org/is
Zachary Ware added the comment:
> You seem to end your subroutines (or whatever they are called) using "goto
> end" rather than "exit /b". Since popd follows the "end" label, does this
> mean that you get a popd after calling each subroutine?
Ye
New submission from Zachary Ware:
Here's a patch for test_tarfile.py discovery.
There are a couple of inheritance issues resolved; CommonReadTest (and its
children, MiscReadTest and StreamReadTest) are changed simply to avoid running
the tests in CommonReadTest on their own--they pass
New submission from Zachary Ware:
Just inheritance issues in this one. The patch removes _BaseYearTest as its
only use was as a unittest.TestCase subclass to inherit from, which caused the
discovery issues.
--
components: Tests
files: test_time_discovery.diff
keywords: patch
messages
New submission from Zachary Ware:
Inheritance issues again. This one has some magic in test_main to create the C
and Python tests programmatically which I felt was best left alone, so the
patch simply converts test_main into a load_tests which ignores its arguments.
--
components
New submission from Zachary Ware:
test_sqlite.py simply imports and runs tests from sqlite3.test, the patch
converts test_main to load_tests to do the same.
--
components: Tests
files: test_sqlite_discovery.diff
keywords: patch
messages: 186528
nosy: brett.cannon, ezio.melotti
Zachary Ware added the comment:
Ping.
Version 4 still applies cleanly, and with issue16935 fixed, it works properly.
The fix for test_socket is looking like it could use the ReapedSuite from this
patch, so would anyone mind looking at this one again and committing if it's
qualified?
T
Changes by Zachary Ware :
Added file: http://bugs.python.org/file29779/test_tarfile_discovery.v2.diff
___
Python tracker
<http://bugs.python.org/issue17689>
___
___
Pytho
New submission from Zachary Ware:
(Copied the nosy list from issue17484)
The new test module fails on Windows due to the lack of termios and pwd
modules. Here's a patch that fixes things. I suspect the skip condition on
UnixGetpassTest could be changed to check 'termios' rath
Zachary Ware added the comment:
The new tests fail on Windows, see for example
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/1763/steps/test/logs/stdio
It can be fixed on Windows by moving the `s.bind(('127.0.0.1', 0))` line above
the `self.assertIn(&#x
Zachary Ware added the comment:
Buildbots look happy (with test_getpass, anyway) and my machine is happy too.
Thanks for the commit :)
--
___
Python tracker
<http://bugs.python.org/issue17
Zachary Ware added the comment:
Here's a new patch to address Ezio's review comments, including more updates to
Doc/README.txt, the addition of an 'htmlview' target to make.bat, and
documentation of the 'htmlview' target in the Makefile usage message
Zachary Ware added the comment:
> Zachary, I suppose Modules/_operator.c is a rename of Modules/operator.c.
> Could you generate your patch using "hg diff --git" so that history isn't
> lost here?
Of course; I thought I already had, but apparently I messed that up a bi
Zachary Ware added the comment:
Here's another new version of the patch, addressing Ezio's review comments and
a few things I found after giving operator.py a closer look myself.
Things changed in operator.py in this version:
- all ``__func__ = func`` assignments are moved to the
Changes by Zachary Ware :
--
nosy: -Arfrever, brett.cannon, eric.araujo, ezio.melotti, jcea, meador.inge,
pitrou, serhiy.storchaka, zach.ware
___
Python tracker
<http://bugs.python.org/issue16
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file28327/operator.py
___
Python tracker
<http://bugs.python.org/issue16694>
___
___
Python-bugs-list mailin
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file28328/py_operator.diff
___
Python tracker
<http://bugs.python.org/issue16694>
___
___
Python-bugs-list m
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file28374/py_operator.v3.diff
___
Python tracker
<http://bugs.python.org/issue16694>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file28388/py_operator.v5.diff
___
Python tracker
<http://bugs.python.org/issue16694>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file28383/py_operator.v4.diff
___
Python tracker
<http://bugs.python.org/issue16694>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file28522/py_operator.v7.diff
___
Python tracker
<http://bugs.python.org/issue16694>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file28524/py_operator.v8.diff
___
Python tracker
<http://bugs.python.org/issue16694>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file28532/py_operator.v9.diff
___
Python tracker
<http://bugs.python.org/issue16694>
___
___
Python-bug
Changes by Zachary Ware :
--
nosy: +Arfrever, brett.cannon, eric.araujo, ezio.melotti, jcea, meador.inge,
pitrou, serhiy.storchaka, zach.ware
___
Python tracker
<http://bugs.python.org/issue16
Zachary Ware added the comment:
A change that I mentioned in a Rietveld comment on v10, but not in my last
message: __all__ in operator.py no longer includes all of the __func__s, as
currently doing "from operator import *" does not import all of the
Zachary Ware added the comment:
That is indeed simpler than what I wrote, and it does work as expected. But,
is it preferable to do it this way, or with Ezio's suggested method
(``skip_unless_gzip = unittest.skipUnless(gzip, "gzip not available")``, and
for bz2 and lzma)? I
New submission from Zachary Ware:
In Doc/library/socket.rst, :func:`socket` links to #module-socket, not
#socket.socket. The attached patch changes all occurances of :func:`socket` to
:func:`~socket.socket`, except the first one which keeps the explicit module
name (no
Changes by Zachary Ware :
Added file: http://bugs.python.org/file29872/socket_func_link_2.7.diff
___
Python tracker
<http://bugs.python.org/issue17740>
___
___
Python-bug
Zachary Ware added the comment:
So it does. Would you like a new pair of patches? It is just a
search-and-replace from ":func:`socket`" to ":func:`.socket`".
--
___
Python tracker
<http://bug
Zachary Ware added the comment:
I caught a small oversight. This new patch changes the example in README.txt
to ``make html "PYTHON2=C:\Python27\python.exe"`` (PYTHON->PYTHON2). Also, I
added a bit of backward compatibility to make.bat; %PYTHON2% will default to
%PYTHON%
Zachary Ware added the comment:
>> should I just add a requires_gzip to test.support and use those three
>> in test_tarfile?
> I think that's reasonable for now -- we can always refactor it later
> and replace them with a skip_unless_module()
Here's a patch :)
Zachary Ware added the comment:
Thank you for the review, Raymond.
Since Serhiy agrees that the _operator __func__s are unnecessary, here's a v13
that removes them. Again, I'm not a native C speaker, so these new changes in
_operator.c deserve a bit of extra scrutiny. Everything
Zachary Ware added the comment:
I just happened across this issue, which I think has been superseded by issues
#16748 and #16968.
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue14
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue17037>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue7559>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Zachary Ware:
Just subclassing and test_main in this one.
--
components: Tests
files: test_iterlen_discovery.diff
keywords: patch
messages: 187116
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for
New submission from Zachary Ware:
This one actually had Failures rather than Errors; those failures arose from
enUS_locale being None because it was being changed in test_main. This patch
attempts to fix things by adapting get_enUS_locale() to return a tuple of a
suitable setting for
Zachary Ware added the comment:
The test_socket patch is incomplete with the way I've been converting test
modules, but it is a good starting point. Should this issue be renamed to be
specifically for test_socket?
The necessity of reaping threads at the end of the test poses a bit
New submission from Zachary Ware:
I think this one only didn't work with discovery by accident: the only change
necessary to make discovery pass was to make _TestPoll match all other _Test*
classes by inheriting from BaseTestCase instead of unittest.TestCase. The
remainder of the change
New submission from Zachary Ware:
This patch converts test_osx_env.py to use a skip decorator instead of just not
running the test at all.
--
components: Tests
files: test_osx_env_discovery.diff
keywords: patch
messages: 187189
nosy: brett.cannon, ezio.melotti, zach.ware
priority
New submission from Zachary Ware:
This one had subclassing issues, and SystemRandom_TestBasicOps was being
skipped by exclusion from the list of tests passed to support.run_unittest, so
it's been converted to a skip decorator.
--
components: Tests
files: test_random_discovery
New submission from Zachary Ware:
Just subclassing and test_main in this one.
--
components: Tests
files: test_set_discovery.diff
keywords: patch
messages: 187259
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for
Zachary Ware added the comment:
Hmmm, it looks a couple of things have gone wrong. First, I didn't try the
patch on 3.3, whose test_multiprocessing is significantly different than
default's. This appears to be due largely to dd5e98ddcd39, but there have been
other changes to on
Zachary Ware added the comment:
Could you elaborate on what you mean to be done? All I've ever had to do was
run the nasm installer and add the install location to PATH.
--
___
Python tracker
<http://bugs.python.org/is
Zachary Ware added the comment:
I agree it would be nice, but I'm not sure how easy or practical it would be to
implement, particularly making sure that NASM is on the PATH. And besides, at
some point, we have to draw the line between what we can reasonably do for a
user and what w
Zachary Ware added the comment:
After finally finding a way to check the status of the pushd stack, I found a
bug in my patch whereby an extra directory is left on the pushd stack at the
end of each run. As such, the version 5 patch changes from using 'goto end' to
using 'exit
New submission from Zachary Ware:
(Copying the nosy list from issue9607)
test_keyword has a couple of failures on Windows, all due to newline
issues--see for example
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/1845/steps/test/logs/stdio
Zachary Ware added the comment:
Your patch works for me. And for what it's worth, I agree about not
backporting; keywords are frozen and never going to change in 2.7 or 3.3 anyway.
I did find one other small bug in test_keyword; running the test via "-m
test.te
New submission from Zachary Ware:
Ezio, you brought up the fact that the 2.7 Windows buildbots were skipping the
Tkinter tests in Terry's core-mentorship thread about tkinter on Windows last
month, and I've finally learned what is causing that failure. It appears that
when 689a81
Zachary Ware added the comment:
The patch works fine on Win 7 for me. I left a couple comments on Rietveld,
neither of which is of great importance.
--
___
Python tracker
<http://bugs.python.org/issue7
Zachary Ware added the comment:
I left a couple of Rietveld comments. Other than those nitpicks it looks good
to me, and I could be convinced otherwise on the nitpicks :)
Also, thanks for catching the extra commas after the "After"s in operator.rst;
I had meant to include those i
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue17846>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Zachary Ware:
PCbuild\readme.txt has a comment from Trent Nelson dated 2-April-2008
suggesting moving the external library location for Windows from "\..\" to "\external\" to make switching between
versions easier. I've gotten rather annoyed with h
Zachary Ware added the comment:
Here's the relevant bit of the output from that buildbot after Terry's change:
==
FAIL: testLoadWithUNC (test.test_t
Zachary Ware added the comment:
Would anyone mind committing this? It was approved by Raymond almost a year
ago now, and is still accurate.
The patch still applies cleanly to 3.3 and default, though with some fuzz.
--
versions: -Python 3.2
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file30154/issue17883.diff
___
Python tracker
<http://bugs.python.org/issue17883>
___
___
Python-bugs-list m
Zachary Ware added the comment:
Here's a better patch after learning a bit better how subprocess.Popen works...
--
Added file: http://bugs.python.org/file30156/issue17883.diff
___
Python tracker
<http://bugs.python.org/is
Zachary Ware added the comment:
I'm not sure where to go with this from here, without knowing more about what's
going wrong. Just to make sure there wasn't anything wrong with the Tcl/Tk
build or some manner of issue with things not being properly cleaned up or
something, I
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue17947>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
Thanks for your response, Martin.
Martin v. Löwis wrote:
> Zach: Temporarily committing changes to test specific buildbot issues
> is fine
I suppose it would also be beneficial to get some output from the other bots
which are *not* failing, to have someth
2001 - 2100 of 2740 matches
Mail list logo
