Zachary Ware added the comment:
Ok, so my changes to CONVERT_TO_DOUBLE don't fly with gcc, so that's out. In
the two cases where convert_to_double wants a PyObject *, we could declare
"PyObject *objself = (PyObject *)self;", but that's not particularly appealin
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue20510>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
Good catch! See my review comments.
Also, if you haven't already, could you please sign a contributor's agreement?
See http://www.python.org/psf/contrib/.
--
stage: -> patch review
versions: +Python 2.
Zachary Ware added the comment:
Vajrasky: Note that you can reply to individual review comments within
Rietveld; this way context is kept and replies are easier :). The same people
get the message either way.
Anyhow, for float point 1: you can use I believe you can use (unaryfunc) for
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33746/clinic_typeobject_v2.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Pytho
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33744/clinic_resource_v2.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33644/clinic_marshal_v2.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Zachary Ware added the comment:
Clearing nosy for file cleaning, will restore:
larry,nadeem.vawda,serhiy.storchaka,vajrasky,zach.ware
--
nosy: -larry, nadeem.vawda, serhiy.storchaka, vajrasky
___
Python tracker
<http://bugs.python.org/issue20
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33678/clinic_marshal_v3.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33767/clinic_listobject_v3.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Pytho
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33479/clinic_marshal.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33643/clinic_floatobject.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Zachary Ware :
--
nosy: +larry, nadeem.vawda, serhiy.storchaka, vajrasky
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33769/clinic_marshal_v4.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33778/issue20185_conglomerate.diff
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Pytho
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33773/clinic_floatobject_v2.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Pytho
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33887/issue20185_conglomerate_v2.diff
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33612/clinic_listobject.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33641/clinic_listobject_v2.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Pytho
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33475/clinic_resource.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file33562/clinic_typeobject.patch
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bug
Changes by Zachary Ware :
--
Removed message: http://bugs.python.org/msg210340
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bugs-list m
Zachary Ware added the comment:
Ok, current status of this issue as I see it:
Objects/typeobject.c:part of conglomerate patch, LGTM
Objects/longobject.c:awaiting revision based on review
Objects/listobject.c:part of conglomerate patch, LGTM
Objects/floatobject.c: part of
Zachary Ware added the comment:
Hi Rihards,
This is not a bug, this is an example of the limitations of binary floating
point arithmetic. See http://docs.python.org/3/tutorial/floatingpoint.html for
more information. For explanation by demonstration, have a look at this:
Python 3.3.2
Zachary Ware added the comment:
Done.
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue20451>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue20429>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
New patch still gives an assertion failure at line 153 of typeobject.c when
trying to get __text_signature__ from anything that should have one (on
Windows, at least).
Python 3.4.0b3+ (default, Feb 7 2014, 11:43:04) [MSC v.1600 32 bit (Intel)] on
win32
Type
New submission from Zachary Ware:
Builtins with a valid signature embedded in the docstring, but with no other
docstring content are not picked up by the __text_signature__ getter because
the docstring ends with ")\n--" rather than ")\n--\n\n". The att
Zachary Ware added the comment:
Forgot to mention, there are no current examples of this checked in.
winreg.HKEYType has a couple of methods with no docstring (__enter__ and
__exit__), and _winapi has several docstring-less functions, though
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue20609>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
Oops...
Can you try out this patch and see if it will work for you? It looks like it
should work, but I'm not set up to build 64-bit at all yet, much less on 32-bit.
Tim, would you mind also taking a look since you tested #19788 for me and we're
in
Zachary Ware added the comment:
Forgot to attach the patch...
--
keywords: +patch
Added file: http://bugs.python.org/file34062/issue20609.diff
___
Python tracker
<http://bugs.python.org/issue20
Zachary Ware added the comment:
> Yes, thanks, that patch fixes it so it builds successfully. Tried w/
> Python 3.4rc1 on Windows 7 w/ VS2010.
Ok, good.
> Of course maybe it should really be building kill_python.exe for the
> matching architecture and running that, but I'm n
Changes by Zachary Ware :
--
stage: -> needs patch
type: -> enhancement
versions: -Python 3.1, Python 3.2, Python 3.5
___
Python tracker
<http://bugs.python.org/i
Zachary Ware added the comment:
The plan is to eventually have enough time to pick through the file and make
sure everything is actually up to date :).
>From just a quick glance, here's a couple of the things that still need to be
>done:
- all of the external links should be
Zachary Ware added the comment:
The newer patch looks good to me, I'll get it committed as soon as I can test
it. Thanks!
--
assignee: -> zach.ware
___
Python tracker
<http://bugs.python.org
Zachary Ware added the comment:
Fixed, thanks for the report and patch!
And btw, you are right to avoid "while we're in there" changes in general, but
modernizing the test suite gets a little bit of leniency in that regard. It
wouldn't have been appropriate to venture out
Zachary Ware added the comment:
Fixed, thanks for the report!
--
assignee: -> zach.ware
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
New submission from Zachary Ware:
I broke cross-building 64-bit binaries on 32-bit Windows in issue #19788,
69d13cdc4eeb fixes it.
--
assignee: larry
components: Build, Windows
messages: 211529
nosy: larry, zach.ware
priority: release blocker
severity: normal
stage: commit review
Zachary Ware added the comment:
I considered doing a test like that, but figured it was pretty well covered by
the assert_python_ok no-arg test. On the other hand, it looks like we document
that the default value of SystemExit().code is None, so it should be tested.
I'll add it in.
T
Zachary Ware added the comment:
I noticed this earlier today as well, but didn't have a chance to report. I
also happened to have a week-old doc page still loaded in the next tab over
(which didn't have the problem), and noticed that it was marked as being built
by Sphinx 1.
Changes by Zachary Ware :
--
nosy: +David.Felix
___
Python tracker
<http://bugs.python.org/issue20693>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
Hi David,
Thanks for the report, but this has already been reported in issue20693. I've
added you to the nosy list on that issue.
--
assignee: docs@python ->
nosy: +zach.ware
resolution: -> duplicate
stage: -> committed/rejecte
Zachary Ware added the comment:
Ok, I had missed that the warnings in your two separate cases were in fact
different. I still don't understand why VC++ sees the two cases so differently
(throwing different warnings), but it at least explains the different results
in your two cases.
I
Zachary Ware added the comment:
Fixed, thanks for the report and patch!
--
assignee: -> zach.ware
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
New submission from Zachary Ware:
PC/pyconfig.h does "#define hypot _hypot", but VS 2010 and above already define
a hypot function (implemented by _hypot), which results in a warning if you
have warning 4211 enabled (which warning level 4 does) or a recursive
definition which re
Zachary Ware added the comment:
Hi Tom,
Your issue is very strange; I use VS 2010 Express on a regular basis and have
never had the error shown in your log. The "solution folder" thing is no big
deal; it's annoying that it reminds you about it every time you open the
sol
Changes by Zachary Ware :
--
Removed message: http://bugs.python.org/msg212199
___
Python tracker
<http://bugs.python.org/issue20771>
___
___
Python-bugs-list m
Changes by Zachary Ware :
--
nosy: -Alfonso.Andalon.Jr.
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
title: Download Talkray... -> spam
___
Python tracker
<http://bugs.python
Zachary Ware added the comment:
> Can anyone please test the patch on Windows?
It seems to work; memory usage is much lower with the patch than without using
an 8 MB file. I don't notice any behavioral change with the patch; if there's
anything specific to look for on that fro
Zachary Ware added the comment:
The new test passes on Windows with the whole patch applied, but fails without
the changes to fileinput.py. Is this change meant to fix behavior, or just the
memory usage issue?
Just for completeness, here's the failure output (with unpatched fileinp
Zachary Ware added the comment:
Output attached.
--
Added file: http://bugs.python.org/file34231/20501.output
___
Python tracker
<http://bugs.python.org/issue20
Zachary Ware added the comment:
Thanks for the report!
--
assignee: docs@python -> zach.ware
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issu
Zachary Ware added the comment:
New patch passes on Windows. Without the patch to fileinput.py, the new
hook_encoded tests pass and the new test_readline test fails (as expected).
--
___
Python tracker
<http://bugs.python.org/issue20
Zachary Ware added the comment:
Agreed with Vajrasky, the 2.7 commit wasn't as clean as it could be (sorry I
didn't get an actual review done before you committed, I posted my last test
results in a bit of a hurry). The commented out line should either be removed,
or used inst
Zachary Ware added the comment:
Windows 8 (or at least 8.1) doesn't seem to be too far off from the directions
on that site. If you're proficient enough to change an environment variable in
Windows 7, chances are good you can figure it out on Windows 8(.1). If you're
not, c
Zachary Ware added the comment:
What's the status here? Appears to be fixed?
--
___
Python tracker
<http://bugs.python.org/issue19085>
___
___
Python-bugs-l
Zachary Ware added the comment:
This was added by #20456 (a couple weeks ago).
--
components: +Demos and Tools
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
superseder: -> Argument Clinic rollup patch, 2014/01/31
type: -> enhancement
versio
Zachary Ware added the comment:
Since I can't reproduce, I'm going to go ahead and close the issue. If you can
reproduce it after following the steps I laid out in my previous message,
please re-open this issue.
--
components: +Windows
resolution: -> invalid
stage:
Zachary Ware added the comment:
Terry J. Reedy added the comment:
> However, rather than require a tearDowmnodule for every module that imports
> tkinter, lets fix the root problem.
I agree that that would be the ideal solution.
> I thought of having the environment change warning
Zachary Ware added the comment:
For the UTF-7 comment, I'd go with something like "locale encoding is probably
not UTF-7" or "UTF-7 is a convenient, seldom used encoding", or something to
that effect.
About writeTmp vs. context manager: as you wish. It would
Zachary Ware added the comment:
Here's a patch that seems to work; with it applied, I can run
`PCbuild\python_d.exe -m test -uall -rF test_tcl test_tk test_ttk_textonly
test_ttk_guionly test_idle` through at least 115 rounds of testing with no
warnings or errors aside from a locale wa
Zachary Ware added the comment:
Sorry, the bug tracker is not the place to look for help like this. Please
redirect your question to python-list[1], where several very knowledgeable
people listen in and are ready to render assistance for any manner of problems
using Python.
[1] https
Zachary Ware added the comment:
For 2.7 and 3.3, the error message just needs to be fixed (s/3.0/3.x/); it
lives in the sphinx-build.py script somewhere in Doc/. For default, though,
since we now rely on an installed version of Sphinx rather than a checked out
version, the whole version
Zachary Ware added the comment:
Doc/README.txt will also probably need an update, at least on default.
--
___
Python tracker
<http://bugs.python.org/issue20
Zachary Ware added the comment:
You can rewrite about as much you want. The biggest restriction on that is
trying to keep existing links intact, which means either avoiding renaming or
removing sections, or being sure to keep a reference to the old name.
I have reservations about suggesting
Zachary Ware added the comment:
It may warrant a mention that doctest now checks method_descriptors' (C
methods) __doc__ for doctests.
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/is
Zachary Ware added the comment:
I started looking at this again recently, and discovered that building from
within Visual Studio doesn't work with the proposed patches.
So, here's a different approach that adds 'Makefile' projects for each of Tcl,
Tk, and Tix instead of us
Zachary Ware added the comment:
Martin: I'll wait until after 3.4 is branched to commit to default, and make
sure I have some time to pick up the pieces when I do :). The buildbots should
be fine, though; external-common.bat is patched to pull in the tix sources as
Zachary Ware added the comment:
You already have a short, simple, one-line solution, and have had suggestions
for shortening it yourself if you absolutely need to do so. If you can provide
proof that this is an extremely common use case (and considering how short the
solution already is, it
Changes by Zachary Ware :
--
nosy: +Michael.Felt
stage: -> patch review
versions: -Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Zachary Ware added the comment:
Indeed, thank you Marco for continuing this work!
The patches that I committed [1] were mostly done by Jelle Zijlstra. There
were not many tests that had dict ordering issues; but it looks like we used
sorted() rather than list() in a few places. I think
Zachary Ware added the comment:
This is a duplicate of #28901.
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Embedded Release interactive mode documentation
___
Python tracker
<http://
Zachary Ware added the comment:
Each of those items is added to builtins by site.py, which I believe is not
imported by default by the embeddable distribution. I didn't immediately find
that fact mentioned in the docs, though.
Also note that the embeddable distribution isn't really
Changes by Zachary Ware :
--
nosy: +lukasz.langa
___
Python tracker
<http://bugs.python.org/issue28909>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Zachary Ware :
--
assignee: Jelle Zijlstra ->
stage: -> patch review
versions: +Python 3.7
___
Python tracker
<http://bugs.python.org/i
Zachary Ware added the comment:
Steve, does the latest patch look good to you?
--
___
Python tracker
<http://bugs.python.org/issue26876>
___
___
Python-bugs-list m
Zachary Ware added the comment:
__qualname__ has become a thing since this issue was opened, it may make
implementation of this feature significantly easier.
--
nosy: +zach.ware
versions: +Python 3.7 -Python 3.5
___
Python tracker
<h
Zachary Ware added the comment:
This appears to have been a transient failure; all builders are passing a
forced build. I'm no expert on nntplib, but I'm not sure there's much we can
do here beyond replacing the outside connection with a mock server. That
pretty much defeats
Zachary Ware added the comment:
This is causing all buildbots to fail again; I'd be in favor of temporarily
skipping the affected tests with a message that points back to here until we
have a permanent solution.
--
keywords: +buildbot
priority: normal -&
Zachary Ware added the comment:
The `/` operator in Python 2 does integer division. `math.ceil(10/3)` in
Python 2 is equivalent to `math.ceil(3)`.
--
nosy: +zach.ware
resolution: -> not a bug
stage: -> resolved
status: open -> closed
_
New submission from Zachary Ware:
Discussion in #29034 inspired me to run a refleak check on Windows, with the
following results from a 32-bit build of the current 3.6 branch:
C:\cpython\3.6>PCbuild\build.bat -e -d
C:\cpython\3.6>python -m test -uall -R 3:3:refleak_log.txt --timeou
Changes by Zachary Ware :
--
assignee: -> steve.dower
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
___
Python tracker
<http://bugs.python.org/issu
Zachary Ware added the comment:
Unfortunately, this is unlikely to be fixed. Python 3.4 is in security-fix
only mode, so this will only be fixed in 3.4 if it can be shown to be a
security issue. Even so, a binary installer will not be produced for the next
3.4 release, so you'd ha
Changes by Zachary Ware :
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29128>
___
___
Changes by Zachary Ware :
--
components: -asyncio
nosy: -Mama Mama
title: AT&T tech email support number <1 855 338 0710 Spam
versions: -Python 3.6
___
Python tracker
<http://bugs.python.org/
Zachary Ware added the comment:
VS 2010 is not a supported compiler version for 3.6 (or 3.5) and VS 2012 is not
a supported compiler for any version of Python. Extension modules built by
those versions for use with Python 3.6 as supplied by python.org will only work
in very particular
Zachary Ware added the comment:
LGTM.
--
assignee: -> vinay.sajip
nosy: +vinay.sajip, zach.ware
stage: -> commit review
___
Python tracker
<http://bugs.python.org/i
Zachary Ware added the comment:
Triple-quoted strings are strings, not multi-line comments, though people do
abuse them for that purpose sometimes. Changing this behavior would be a huge
change for next to no benefit, so I'm closing the issue.
If you insist on using a triple-quoted stri
Zachary Ware added the comment:
Building _ctypes with the bundled copy of libffi is deprecated since Python
3.6, and is not possible in 3.7. If you need the ctypes module, please install
libffi separately and make sure the Python build process can find it. If you
build libffi yourself, please
Zachary Ware added the comment:
Raymond Hettinger wrote:
> Similarly, make sure that clarity and cut-and-pastability don't get lost by
> adding ... PS2 prompts that uglify the examples.
Note that Sphinx adds a ">>>" button to the upper right of the example
that,
Zachary Ware added the comment:
LGTM.
--
assignee: docs@python -> Mariatta
nosy: +Mariatta, zach.ware
stage: needs patch -> commit review
___
Python tracker
<http://bugs.python.org/i
Zachary Ware added the comment:
That line is correct, the point is that deep copy will duplicate even the
things that you may *want* to be shared.
See also #27416. I'm not sure what we can do to further clarify that line, but
it is certainly easy to misread.
--
nosy: +zach
Zachary Ware added the comment:
Python 3.2 is out of support, so unfortunately there's nothing we can do to
help here. I would recommend using Python 3.6 as it is the latest version, but
if you absolutely need 3.2 for some reason your best bet is probably to build
it yourself. It
Zachary Ware added the comment:
I've disabled the Touch step on the buildbots until this is fixed.
--
keywords: +buildbot
nosy: +zach.ware
priority: normal -> critical
versions: +Python 2.7, Python 3.7
___
Python tracker
<http://bugs
Zachary Ware added the comment:
Fixed in PR13.
--
nosy: +zach.ware
pull_requests: +32
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Zachary Ware added the comment:
This has been done in PR2. Thank you for the patch anyway, Louis, and I'm
sorry we didn't wind up using it!
--
nosy: +haypo, zach.ware
pull_requests: +33
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Pyt
Changes by Zachary Ware :
--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
priority: normal -> critical
versions: +Python 2.7, Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/issu
Zachary Ware added the comment:
We really need to be able to function regardless of the core.autocrlf setting.
See #27425 for more about the EOL issues.
--
dependencies: +Tests fail because of git's newline preferences on Windows
___
Python tr
1801 - 1900 of 2740 matches
Mail list logo
