[issue14097] Improve the "introduction" page of the tutorial

2014-07-01 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the reviews, Ezio and Andy. Committed with most of your points addressed, though I did leave out the link to `long` since I could not come up with a good wording for adding it, and `long` is easily findable from `int`. Also, the link for 'co

[issue18604] Consolidate gui available checks in test.support

2014-07-01 Thread Zachary Ware
Changes by Zachary Ware : -- assignee: zach.ware -> ned.deily resolution: fixed -> ___ Python tracker <http://bugs.python.org/issue18604> ___ ___ Pyth

[issue18258] Fix test discovery for test_codecmaps*.py

2014-07-01 Thread Zachary Ware
Zachary Ware added the comment: Not forgotten, just hadn't gotten to on the list yet. -- assignee: -> zach.ware resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.5 -Python 3.3 ___ Pyth

[issue16968] Fix test discovery for test_concurrent_futures.py

2014-07-02 Thread Zachary Ware
Zachary Ware added the comment: Since then, Senthil Kumaran converted test_urllib2_localnet (and another urllib test or two) to unittest.main, using this: """ threads_key = None def setUpModule(): # Store the threading_setup in a key and ensure that it is cleaned up #

[issue14097] Improve the "introduction" page of the tutorial

2014-07-02 Thread Zachary Ware
Zachary Ware added the comment: You're both welcome :) -- ___ Python tracker <http://bugs.python.org/issue14097> ___ ___ Python-bugs-list mailing list

[issue21907] Update Windows build batch scripts

2014-07-02 Thread Zachary Ware
New submission from Zachary Ware: I am aware of a few open issues with the build scripts provided for Windows (both the Tools/buildbot scripts and the .bat files provided in PCbuild), such as #9973 and #9822, and there are some other issues that bother me but that I haven't opened issue

[issue21907] Update Windows build batch scripts

2014-07-02 Thread Zachary Ware
Zachary Ware added the comment: Here's the devguide patch. -- Added file: http://bugs.python.org/file35832/devguide_update.diff ___ Python tracker <http://bugs.python.org/is

[issue21912] Deferred logging may use outdated references

2014-07-03 Thread Zachary Ware
Changes by Zachary Ware : -- nosy: +vinay.sajip ___ Python tracker <http://bugs.python.org/issue21912> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21151] winreg.SetValueEx causes crash if value = None

2014-07-03 Thread Zachary Ware
Zachary Ware added the comment: Thanks to Dave for the report, eryksun for the suggestion, and John for the patch! I'm not sure why the test case doesn't fail on a regular test run on Python 3; it looks like BYTE *data starts out as NULL when Python is not in interactive mode, whic

[issue9116] test_capi.test_no_FatalError_infinite_loop crash on Windows

2014-07-03 Thread Zachary Ware
Zachary Ware added the comment: With the popup-supression context manager from #11732 in use and the buildbots using the regrtest '-n' option, I think we're at the point of being "fixed enough" and vote to close this issue. I'll leave the final decision to someon

[issue21906] Tools\Scripts\md5sum.py doesn't work in Python 3.x

2014-07-03 Thread Zachary Ware
Zachary Ware added the comment: Hmmm, I was just reloading the page to post a patch I'd worked up, and lo and behold there's already one here! Here's mine anyway; you can use any parts of it that you like, Berker. There are a couple of not-quite-related changes in test_tool

[issue21906] Tools\Scripts\md5sum.py doesn't work in Python 3.x

2014-07-03 Thread Zachary Ware
Zachary Ware added the comment: Hmmm, I was just reloading the page to post a patch I'd worked up, and lo and behold there's already one here! Here's mine anyway; you can use any parts of it that you like, Berker. There are a couple of not-quite-related changes in test_tool

[issue21906] Tools\Scripts\md5sum.py doesn't work in Python 3.x

2014-07-03 Thread Zachary Ware
Changes by Zachary Ware : -- Removed message: http://bugs.python.org/msg17 ___ Python tracker <http://bugs.python.org/issue21906> ___ ___ Python-bugs-list m

[issue17652] Add skip_on_windows decorator to test.support

2014-07-05 Thread Zachary Ware
Zachary Ware added the comment: The patch looks fine, but I don't see a big gain from it; call me +0. It might be interesting to see a patch that converts current "@skipIf(sys.platform == 'win32' or os.name == 'nt')" instances to "@skip_on_windows&

[issue21907] Update Windows build batch scripts

2014-07-07 Thread Zachary Ware
Zachary Ware added the comment: With a vote and a half in favor, I'll go ahead with this probably later today. There is one change needed to the `clean` script; the `hg purge` call should ignore Lib/test/data to avoid downloading the codecmaps test files every time. I may backport t

[issue21518] Expose RegUnloadKey in winreg

2014-07-07 Thread Zachary Ware
Zachary Ware added the comment: I'd like to see the windows_helper.py part of the patch split into its own issue, and someone more qualified than I to review it (though I'll learn what I can and give it a shot if nobody else can). The new issue should also try to use the new wind

[issue21781] make _ssl module 64-bit clean

2014-07-07 Thread Zachary Ware
Zachary Ware added the comment: This appears to have broken 64-bit Windows: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/4745 -- nosy: +zach.ware resolution: fixed -> status: closed -> open ___ Python tracker

[issue9973] Sometimes buildbot fails to cleanup working copy

2014-07-07 Thread Zachary Ware
Zachary Ware added the comment: This should be fixed by #21907 for 3.5, at least; other versions can either have #21907 backported (in whole or in part), or continue to live with it (like they have for the past 4 years). -- assignee: -> zach.ware resolution: -> fixed

[issue9822] windows batch files are dependent on cmd current directory

2014-07-07 Thread Zachary Ware
Zachary Ware added the comment: Fixed by #21907. -- assignee: -> zach.ware resolution: -> fixed stage: -> resolved status: open -> closed superseder: -> Update Windows build batch scripts versions: +Python 3.5 -Python 3.4 ___

[issue17846] Building Python on Windows - Supplementary info

2014-07-07 Thread Zachary Ware
Zachary Ware added the comment: Issue #21907 changed how things are done somewhat, and has made PCbuild/build.bat the new obvious place to go for building Python from the command line; the devguide has been updated to reflect that (although I may have missed a place to update). What else

[issue10583] Encoding issue with chm help in 2.7.1

2014-07-07 Thread Zachary Ware
Zachary Ware added the comment: I do in 2.7.8, though. This appears to have been a Sphinx issue (likely caused by HTML Help's lack of Unicode support), introduced sometime between Sphinx versions 0.6.5 and 0.6.7, and fixed sometime between versions 1.1.3 and 1.2.2. --

[issue21781] make _ssl module 64-bit clean

2014-07-07 Thread Zachary Ware
Zachary Ware added the comment: Looks good now, thanks for the quick fix, Victor! -- resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.4 ___ Python tracker <http://bugs.python

[issue21907] Update Windows build batch scripts

2014-07-08 Thread Zachary Ware
Zachary Ware added the comment: The XP buildbot seems to have choked on this change, I suspect because of the 'clean' script exiting with a non-zero error code. I'm not certain why it can't recover, though. David, can you tell what's going on with it

[issue21918] Convert test_tools to directory

2014-07-08 Thread Zachary Ware
Zachary Ware added the comment: How about this? -- keywords: +patch Added file: http://bugs.python.org/file35905/test_tools.diff ___ Python tracker <http://bugs.python.org/issue21

[issue21918] Convert test_tools to directory

2014-07-08 Thread Zachary Ware
Zachary Ware added the comment: Here's the same patch in --git format, which should make the actual changes clearer (though probably not in Rietveld). -- Added file: http://bugs.python.org/file35906/test_tools.diff--git ___ Python tracker

[issue20513] Python 2.7. Script interruption on logoff from 0 session under Win2003 and earlier

2014-07-08 Thread Zachary Ware
Zachary Ware added the comment: Windows Server 2003, XP, and 2000 are all officially supported by Python 2.7, as they were all current (for certain values of "current") at the time Python 2.7 was released. That said, it's not completely clear to me what the bug is but it strik

[issue21947] `Dis` module doesn't know how to disassemble generators

2014-07-09 Thread Zachary Ware
Changes by Zachary Ware : -- nosy: +ncoghlan ___ Python tracker <http://bugs.python.org/issue21947> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21907] Update Windows build batch scripts

2014-07-09 Thread Zachary Ware
Zachary Ware added the comment: Thanks for getting the XP bot running again, it looks like it's now having issues with how the tests are now run (some issue with how sys.stdin is set up in a subprocess); I'm not sure if that should be fixed by reverting back to not using run_te

[issue21942] pydoc source not displayed in browser on Windows

2014-07-10 Thread Zachary Ware
Zachary Ware added the comment: Fixed, thanks for the report! I took an alternate approach to fixing the problem; nturl2path was only used at all because pydoc used to produce actual "file://" links rather than rendering the page itself, and there's no reason to use nturl2pat

[issue21959] msi product code for 2.7.8150 not in Tools/msi/uuids.py

2014-07-11 Thread Zachary Ware
Changes by Zachary Ware : -- nosy: +steve.dower ___ Python tracker <http://bugs.python.org/issue21959> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21953] pythonrun.c does not check std streams the same as fileio.c

2014-07-11 Thread Zachary Ware
Changes by Zachary Ware : -- stage: -> resolved ___ Python tracker <http://bugs.python.org/issue21953> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue21958] Allow python 2.7 to compile with Visual Studio 2013

2014-07-11 Thread Zachary Ware
Zachary Ware added the comment: Agreed. -- ___ Python tracker <http://bugs.python.org/issue21958> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4453] MSI installer shows error message if "Compile .py files to bytecode" option is selected

2014-07-11 Thread Zachary Ware
Changes by Zachary Ware : Removed file: http://bugs.python.org/file18370/unnamed ___ Python tracker <http://bugs.python.org/issue4453> ___ ___ Python-bugs-list mailin

[issue16895] Batch file to mimic 'make' on Windows

2014-07-14 Thread Zachary Ware
Zachary Ware added the comment: Still relevant, but the current patch is overkill (Brian was right, it's just way more batch than is healthy to check in). Things are changing rapidly, though; I'll close it as "postponed" for now, with the expectation o

[issue21918] Convert test_tools to directory

2014-07-15 Thread Zachary Ware
Zachary Ware added the comment: Here's a new version of the patch in response to review comments. Patch is in --git format, which means no Rietveld link for this one. Changes from the first patch: - Remove Tools/parser/test_unparse.py entirely (moved to Lib/test/test_tools/) - R

[issue9390] Error in sys.excepthook on windows when redirecting output of the script

2014-07-16 Thread Zachary Ware
Zachary Ware added the comment: This appears to me to be a well-documented Windows bug with a clear, documented fix, and I am not able to reproduce it so I'm not sure if it's even still relevant. Closing the issue. -- resolution: -> third party stage: -> resol

[issue21918] Convert test_tools to directory

2014-07-16 Thread Zachary Ware
Zachary Ware added the comment: Committed, thanks for the reviews! I had modeled load_tests after test_json's load_tests. The idiom used in test_email causes a warning from regrtest about sys.path being modified, so I modified the idiom slightly and used that. I have declined to bac

[issue17480] pyvenv should be installed someplace more obvious on Windows

2014-07-16 Thread Zachary Ware
Zachary Ware added the comment: I think a pyvenv.exe would be overkill, but I think it would be reasonable to install the pyvenv script to \Scripts rather than \Tools\Scripts, possibly as both 'pyvenv.py' and 'pyvenv-X.Y.py'. Personally, I still prefer 'py -3 -m ve

[issue15968] Incorporate Tcl/Tk/Tix into the Windows build process

2014-07-16 Thread Zachary Ware
Zachary Ware added the comment: Terry: the difference you saw between using regrtest and using unittest.main from the interactive prompt was because of regrtest.saved_test_environment: tkinter._fix sets environment variables at the beginning of one test which are cleared at the end by

[issue21059] idle_test.test_warning failure

2014-07-16 Thread Zachary Ware
Zachary Ware added the comment: I believe I eventually figured out the reason for the failure, it had to do with the fact that the Tcl/Tk DLLs were copied into PCbuild to avoid adding ..\tcltk[64]\bin to PATH and the persistent issue that tkinter._fix changes environment variables to make

[issue21918] Convert test_tools to directory

2014-07-16 Thread Zachary Ware
Zachary Ware added the comment: Sure, I'll work on that some time this week. -- ___ Python tracker <http://bugs.python.org/issue21918> ___ ___ Python-bugs-l

[issue21044] tarfile does not handle file .name being an int

2014-07-17 Thread Zachary Ware
Zachary Ware added the comment: This change appears to have broken 2.7 on Windows: http://buildbot.python.org/all/builders/x86%20Windows7%202.7/builds/2707/steps/test/logs/stdio -- nosy: +zach.ware resolution: fixed -> stage: resolved -> commit review status: closed -

[issue21907] Update Windows build batch scripts

2014-07-17 Thread Zachary Ware
Zachary Ware added the comment: As you can probably tell, I wasn't on a machine where I could test build_pgo.bat before I committed changes to it (oops). It looks like your patch is reversed, would you mind fixing it? I can tell you it will need to change, though; build.bat needs t

[issue22002] Make full use of test discovery in test subpackages

2014-07-17 Thread Zachary Ware
New submission from Zachary Ware: Here's a patch against 3.4 implementing Serhiy's suggestion in msg223277 and taking it a step further, actually using test discovery in all of the test.test_* subpackages. To reduce duplication, the patch adds a 'load_package_tests' funct

[issue22004] io documentation refers to newline as newlines

2014-07-18 Thread Zachary Ware
Zachary Ware added the comment: Fixed! Thanks for the report. -- nosy: +zach.ware versions: -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issue22

[issue18392] Doc: PyObject_Malloc() is not documented

2014-07-18 Thread Zachary Ware
Changes by Zachary Ware : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> PyObject_Malloc is not documented ___ Python tracker <http://bugs.python

[issue17896] Move Windows external libs from \..\ to \externals

2014-07-19 Thread Zachary Ware
Zachary Ware added the comment: After the most recent changes to the buildbot scripts, it would be every time without a patch to the clean script, but at the time I only meant a single time (which really isn't a big deal). The patch is well out of date, I can update it if we can come

[issue22019] ntpath.join() error with Chinese character Path

2014-07-20 Thread Zachary Ware
Zachary Ware added the comment: What type are your arguments, str, unicode, or a mix? I can reproduce your issue using a unicode and a str containing a non-ASCII character, while any other combination "works": >>> import os >>> os.path.join('t

[issue16748] Make CPython test package discoverable

2014-07-21 Thread Zachary Ware
Changes by Zachary Ware : -- dependencies: +Make full use of test discovery in test subpackages versions: +Python 3.5 -Python 3.3 ___ Python tracker <http://bugs.python.org/issue16

[issue22002] Make full use of test discovery in test subpackages

2014-07-21 Thread Zachary Ware
Zachary Ware added the comment: Thank you, Brett and David. @Mark: This issue is a continuation of the #16748 effort (#16748 is a meta-issue for this kind of thing) and unrelated to #10572 (though this will add a feature to test.support that can be useful for the scattered test packages

[issue22002] Make full use of test discovery in test subpackages

2014-07-21 Thread Zachary Ware
Zachary Ware added the comment: Victor, could you give me a yay or nay on the test_asyncio change? -- nosy: +haypo ___ Python tracker <http://bugs.python.org/issue22

[issue22022] test_pathlib: shutil.rmtree() sporadic failures on Windows

2014-07-21 Thread Zachary Ware
Zachary Ware added the comment: This looks like a duplicate of #19811, which was closed as a duplicate of #19629. -- nosy: +zach.ware resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> support.rmtree fails on symlinks u

[issue20064] PyObject_Malloc is not documented

2014-07-21 Thread Zachary Ware
Zachary Ware added the comment: It appears that PyObject_Realloc and PyObject_Free are also not documented; they should be along with PyObject_Malloc. I also left a couple of comments on Rietveld. -- nosy: +zach.ware stage: needs patch -> patch review versions: +Python 3.5 -Python

[issue22024] Add to shutil the ability to wait until files are definitely deleted

2014-07-21 Thread Zachary Ware
New submission from Zachary Ware: As suggested by Martin in msg170717, shutil should grow some way to block until a given file/directory is actually deleted, due to Windows' scheme of not actually deleting a file until all handles to it are closed. This could take the form of a '

[issue12855] linebreak sequences should be better documented

2014-07-21 Thread Zachary Ware
Changes by Zachary Ware : -- stage: -> patch review versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issu

[issue22025] webbrowser.get(command_line) does not support Windows-style path separators

2014-07-22 Thread Zachary Ware
Changes by Zachary Ware : -- nosy: +georg.brandl stage: -> patch review versions: -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issu

[issue22026] 2.7.8 ttk Button text display problem

2014-07-22 Thread Zachary Ware
Zachary Ware added the comment: I believe this is a change in Tk itself, I can get your 2.7.6 result with Python 2.7.8+ compiled against Tcl/Tk 8.5.2, and your 2.7.8 result with Python 2.7.6 compiled against Tcl/Tk 8.5.15. I would guess that Tk is trying to avoid getting glyph in your

[issue21665] 2.7.7 ttk widgets not themed

2014-07-22 Thread Zachary Ware
Zachary Ware added the comment: 2.7.8 seems fine and there haven't been any reports about Tkinter not working on Win2k yet, so I'll go ahead and change the 2.7 buildbot scripts and close the issue. -- assignee: -> zach.ware ___ P

[issue14484] missing return in win32_kill?

2014-07-22 Thread Zachary Ware
Zachary Ware added the comment: It looks like we have a bit of a mess here. 2.7 has a return there (and thus doesn't fall back to TerminateProcess if GenerateConsoleCtrlEvent fails), added 40 commits after the initial implementation in b1c00c7d3c85, but 3.x was never changed so 2.7 an

[issue22026] 2.7.8 ttk Button text display problem

2014-07-22 Thread Zachary Ware
Changes by Zachary Ware : -- stage: -> resolved ___ Python tracker <http://bugs.python.org/issue22026> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue22002] Make full use of test discovery in test subpackages

2014-07-23 Thread Zachary Ware
Zachary Ware added the comment: Committed with a couple of changes from the posted patch: commented on the multiple dirname() calls as Serhiy suggested, removed the 'with DirsOnSysPath():' line since it turns out to be unnecessary when supplying top_level_dir to loader.discover(),

[issue21500] Make use of the "load_tests" protocol in test_importlib packages

2014-07-23 Thread Zachary Ware
Zachary Ware added the comment: This has been covered by #22002. -- nosy: +zach.ware resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> Make full use of test discovery in test subpackages __

[issue21813] Enhance doc of os.stat_result

2014-07-24 Thread Zachary Ware
Zachary Ware added the comment: The only comments you didn't address you were right not to (sorry for the noise about path_fd, I completely missed that it was just a link reference); what you committed looks fine to me. Thanks for your work on this, it looks like a big improvement

[issue20055] On Windows NT 6 with administrator account, there are two failing tests on test_shutil.py

2014-07-24 Thread Zachary Ware
Changes by Zachary Ware : -- Removed message: http://bugs.python.org/msg223821 ___ Python tracker <http://bugs.python.org/issue20055> ___ ___ Python-bugs-list m

[issue22055] Incomplete sentence in asyncio BaseEventLoop doc

2014-07-24 Thread Zachary Ware
Zachary Ware added the comment: Misposted to #20055: New changeset 84f26a437893 by Victor Stinner in branch '3.4': Issue #20055: Fix BaseEventLoop.stop() docstring, incomplete sentence. http://hg.python.org/cpython/rev/84f26a437893 New changeset f657b64c67ab by Victor Stinner

[issue14534] Add method to mark unittest.TestCases as "do not run".

2014-07-24 Thread Zachary Ware
Zachary Ware added the comment: Victor: Sorry for the delay in getting back to this. I'm attaching your full patch again; the diff you posted is a diff against your first patch, while what we need to be able to review it properly is a diff against the tip of the 'default' bran

[issue21623] build ssl failed use vs2010 express

2014-07-24 Thread Zachary Ware
Zachary Ware added the comment: Mo Jia: are you still having issues with this? -- resolution: -> works for me status: open -> pending ___ Python tracker <http://bugs.python.org/i

[issue19980] Improve help('non-topic') response

2014-07-24 Thread Zachary Ware
Zachary Ware added the comment: Mark, would you like to update your patch to address my review comments? -- ___ Python tracker <http://bugs.python.org/issue19

[issue8110] subprocess.py doesn't correctly detect Windows machines

2014-07-24 Thread Zachary Ware
Zachary Ware added the comment: How about this? Should apply equally to 3.4 and default, 2.7 is different but can use the same concept (with s/_winapi/_subprocess/ among other changes). -- nosy: +zach.ware stage: test needed -> patch review versions: +Python 3.4, Python 3.5 -Pyt

[issue22059] incorrect type conversion from str to bytes in asynchat module in asynchat.py

2014-07-24 Thread Zachary Ware
Zachary Ware added the comment: Hoxily: It's best to spell out the bug you have found, preferably with an error/exception message and a way to reproduce it. My best guess at the problem you're reporting (after looking at that line about 4 times) is that "bytes(str, self.encod

[issue22060] Clean up ctypes.test, use unittest test discovery

2014-07-24 Thread Zachary Ware
New submission from Zachary Ware: Attached is a patch that aims to clean up the ctypes tests a bit, namely by removing the custom resource management (which conflicts with regrtest), the custom test discovery (which is better left to unittest), and the custom test running (which is better

[issue21314] Document '/' in signatures

2014-07-24 Thread Zachary Ware
Zachary Ware added the comment: Apologies for the delay in answering, Emily. And, unfortunately, I don't have a good answer. If you would like to write a patch, I would suggest just sticking the documentation wherever you think is best and make sure there is a link to it from the Sy

[issue18436] Add mapping of symbol to function to operator module

2014-07-25 Thread Zachary Ware
Zachary Ware added the comment: With no one (including me) clamoring for this, I'm going to go ahead and reject it. If someone in the future does really want this, I'd be happy to review a new patch. -- resolution: -> rejected stage: -> resolved status: open -&

[issue22072] Fix typos in SSL's documentation

2014-07-25 Thread Zachary Ware
Zachary Ware added the comment: Thanks, Alex! -- nosy: +zach.ware versions: +Python 3.4 ___ Python tracker <http://bugs.python.org/issue22072> ___ ___ Python-bug

[issue21958] Allow python 2.7 to compile with Visual Studio 2013

2014-07-25 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the patch, I've committed it. For future reference, the devguide should answer any questions you may have about how to contribute to Python, or you can ask on any of the various mailing lists (where you'll either get an answer or be po

[issue20170] Derby #1: Convert 137 sites to Argument Clinic in Modules/posixmodule.c

2014-07-28 Thread Zachary Ware
Zachary Ware added the comment: MSVC is not happy, here's some build output: "P:\ath\to\cpython\PCbuild\pcbuild.sln" (Build target) (1) -> "P:\ath\to\cpython\PCbuild\python.vcxproj" (default target) (2) -> "P:\ath\to\cpython\PCbuild\pythoncore.vcxproj"

[issue20586] Argument Clinic: functions with valid sig but no docstring have no __text_signature__

2014-07-28 Thread Zachary Ware
Changes by Zachary Ware : -- versions: +Python 3.5 Added file: http://bugs.python.org/file36143/issue20586.diff ___ Python tracker <http://bugs.python.org/issue20

[issue20586] Argument Clinic: functions with valid sig but no docstring have no __text_signature__

2014-07-28 Thread Zachary Ware
Changes by Zachary Ware : Removed file: http://bugs.python.org/file34025/clinic_sig_no_docstring.diff ___ Python tracker <http://bugs.python.org/issue20586> ___ ___ Pytho

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2014-07-28 Thread Zachary Ware
Zachary Ware added the comment: Certainly, Martin. I'm in the process of getting it updated and self-reviewing again. This patch will require #20586 and possibly another new Clinic feature (allowing output to multiple destinations; I have a change for that feature on my issue20172 sa

[issue22096] Argument Clinic: add ability to specify an existing impl function

2014-07-28 Thread Zachary Ware
Changes by Zachary Ware : -- components: Demos and Tools nosy: larry, zach.ware priority: normal severity: normal status: open title: Argument Clinic: add ability to specify an existing impl function type: enhancement versions: Python 3.4, Python 3.5

[issue22096] Argument Clinic: add ability to specify an existing impl function

2014-07-28 Thread Zachary Ware
New submission from Zachary Ware: It would be nice to be able to specify an existing function as the _impl function, for cases like winreg.OpenKey and OpenKeyEx which are the same function by different names, or _winapi.GetCurrentProcess, whose impl function is "return GetCurrentPr

[issue22104] test_asyncio unstable in refleak mode

2014-07-29 Thread Zachary Ware
Zachary Ware added the comment: I think I'm to blame for exposing this in 4f9f7e0fe1fd. I have a theory on why that exposed it; I think regrtest is holding an extra reference to the TestSuite in runtest_inner since it is using a different branch now that test_asyncio doesn't have a

[issue22104] test_asyncio unstable in refleak mode

2014-07-30 Thread Zachary Ware
Zachary Ware added the comment: I checked on my theory, and removing the extra reference to 'tests' from the runtest_inner scope fixes it for me: $ python -m test -R 3:3: test_asyncio Running Debug|Win32 interpreter... [1/1] test_asyncio beginning 6 repetitions 123456 .. 1 test O

[issue20170] Derby #1: Convert 137 sites to Argument Clinic in Modules/posixmodule.c

2014-07-30 Thread Zachary Ware
Zachary Ware added the comment: Close, but no cigar :). Posted Rietveld comments to address the last two compile issues (one of which also appears to be a major bug, but only a warning at compile time). Also, Victor has added os.get_blocking() and os.set_blocking(), which prevent your patch

[issue16383] Python 3.3 Permission Error with User Library on Windows

2014-07-30 Thread Zachary Ware
Zachary Ware added the comment: Jim, is there any way you could cut down your example to something small and self-contained? It may be that the process of doing that leads to a problem in your code. As it is, I cannot reproduce your error, or pick out what might be causing it. From a brief

[issue10572] Move test sub-packages to Lib/test

2014-07-30 Thread Zachary Ware
Zachary Ware added the comment: I'm in favor of a move, especially for ctypes, sqlite3, unittest, and tkinter, and don't really see a reason not to move distutils and lib2to3. The IDLE tests make a certain amount of sense to stay in the idlelib folder, just because IDLE is a sp

[issue22108] python c api wchar_t*/char* passing contradiction

2014-07-31 Thread Zachary Ware
Zachary Ware added the comment: See also issue20466 (which has a patch for this, but I cannot speak for its effectiveness). I'd be in favor of closing that issue and this one as duplicates of #18395, and noting in #18395 that the embedding example must be updated before that issue is c

[issue20170] Derby #1: Convert 137 sites to Argument Clinic in Modules/posixmodule.c

2014-07-31 Thread Zachary Ware
Zachary Ware added the comment: The patch applies and compiles cleanly, and I finally tracked down what was causing the errors I reported yesterday: os_utime_impl was changed to use Py_RETURN_NONE instead of just setting return_value = Py_None, so Windows skipped the exit routine and left an

[issue20466] Example in Doc/extending/embedding.rst fails to compile cleanly

2014-08-01 Thread Zachary Ware
Zachary Ware added the comment: Thanks for your efforts, Saimadhav. The issue has been fixed in another way, though. -- resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> Make _Py_char2wchar() and _Py_wchar2c

[issue22108] python c api wchar_t*/char* passing contradiction

2014-08-01 Thread Zachary Ware
Changes by Zachary Ware : -- stage: -> resolved versions: -Python 3.3 ___ Python tracker <http://bugs.python.org/issue22108> ___ ___ Python-bugs-list mai

[issue22096] Argument Clinic: add ability to specify an existing impl function

2014-08-01 Thread Zachary Ware
Zachary Ware added the comment: Fair enough. -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue20170] Derby #1: Convert 137 sites to Argument Clinic in Modules/posixmodule.c

2014-08-01 Thread Zachary Ware
Zachary Ware added the comment: Another nit to pick: long lines in docstrings. There are several lines about 75-78 characters long in several different docstrings, which look absolutely terrible when you try "import os;help(os)" on an 80-character-wide terminal due to an 8 charac

[issue22124] Rotating items of list to left

2014-08-02 Thread Zachary Ware
Zachary Ware added the comment: This is not a bug. The assignment "a = nums" doesn't create a copy of "nums", it just assigns the name "a" to the same object that "nums" refers to. Since lists are mutable, changes made to "a" are vis

[issue20170] Derby #1: Convert 137 sites to Argument Clinic in Modules/posixmodule.c

2014-08-04 Thread Zachary Ware
Zachary Ware added the comment: Yep, Windows is happy with the latest patch. Since this is such an enormous patch, I'm assuming it's only going into 3.5 and have changed the version field accordingly. -- versions: +Python 3.5 -Python 3.4

[issue22125] Cure signedness warnings introduced by #22003

2014-08-04 Thread Zachary Ware
Zachary Ware added the comment: Either patch makes MSVC happy; Meador's gets points from me for simplicity. -- ___ Python tracker <http://bugs.python.org/is

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2014-08-04 Thread Zachary Ware
Zachary Ware added the comment: Here's an updated patch. It includes the patch from #20586 for proper signature/docstring output in _winapi. -- versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file36256/issue20172.v7

[issue20323] Argument Clinic: docstring_prototype output causes build failure on Windows

2014-08-04 Thread Zachary Ware
Zachary Ware added the comment: You're right, of course; I don't know how I got a non-screwball result in prior testing. Here's an updated patch. I have not come up with any better alternative. -- stage: -> patch review Added file: http://bugs.python.org/file36259/

[issue22136] Fix _tkinter compiler warnings on MSVC

2014-08-04 Thread Zachary Ware
New submission from Zachary Ware: Dropping support of Tk 8.3 caused a few compiler warnings on Windows: ..\Modules\_tkinter.c(587): warning C4090: '=' : different 'const' qualifiers ..\Modules\_tkinter.c(588): warning C4090: '=' : different 'const'

[issue8232] webbrowser.open incomplete on Windows

2014-08-04 Thread Zachary Ware
Changes by Zachary Ware : -- stage: needs patch -> patch review versions: +Python 3.5 -Python 3.1 ___ Python tracker <http://bugs.python.org/issue8232> ___ _

[issue20056] Got deprecation warning when running test_shutil.py on Windows NT 6

2014-08-05 Thread Zachary Ware
Zachary Ware added the comment: Perhaps you could change the test to catch the warning and confirm its presence on Windows? -- ___ Python tracker <http://bugs.python.org/issue20

<    11   12   13   14   15   16   17   18   19   20   >