Zachary Ware added the comment:
I wonder, is there any really good reason to keep a separate
Lib/idlelib/help.txt, or can Doc/library/idle.rst be used for its purpose (with
or without a small amount of processing to, for instance, remove comments and
extra backslashes)? Both have most of the
Zachary Ware added the comment:
Right you are, Todd; I'll get another issue opened for that soon.
--
___
Python tracker
<http://bugs.python.org/issue5066>
___
___
Zachary Ware added the comment:
I've come up with a semi-comprehensive list of the tests that cause ugly
failures with test discovery. Tests were run on 3.4 debug, on Windows 7 32bit
without several of the 'external' projects built, using the command
``PCbuild\python_d.
New submission from Zachary Ware:
Here's a patch to fix test_array.py
--
components: Tests
files: test_array.diff
keywords: patch
messages: 179291
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for test_array.py
Zachary Ware added the comment:
I'd like to see Éric, Ezio, and my comments on v3 in Rietveld addressed, but
after that I'm good with it :)
--
___
Python tracker
<http://bugs.python.
New submission from Zachary Ware:
Lib/idlelib/help.txt and Doc/library/idle.rst contain almost exactly the same
information, only formatted a bit differently. This issue is to suggest the
merger of the two files, by way of creating help.txt from idle.rst as a part of
the build or install
Zachary Ware added the comment:
Issue 16893 has been filed to deal with the idea of merging the files.
--
___
Python tracker
<http://bugs.python.org/issue5
New submission from Zachary Ware:
I find myself frustrated with some of the hoops I have to jump through and
extra things I have to remember when I want to play around with Python on
Windows. To make things a little easier, I've created a 'make.bat' file that
can sit in
New submission from Zachary Ware:
Here's the fix for test_asyncore.py.
--
components: Tests
files: test_asyncore_fix.diff
keywords: patch
messages: 179373
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discover
New submission from Zachary Ware:
Here's the fix for test_bisect.py.
This one has an extra change, that of replacing the manual method of obtaining
c_bisect and py_bisect with two calls to support.import_fresh_module.
This one also has an extra wrench thrown in the gears by including
Changes by Zachary Ware :
--
components: Tests
files: test_bufio_fix.diff
keywords: patch
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for test_bufio.py
type: behavior
versions: Python 3.3, Python 3.4
Added file
Zachary Ware added the comment:
> A general comment about these patches: I think it would be better to
remove test_main() (and related unnecessary code) with unittest.main().
One of the advantage of doing it now is that you can simply test discovery
by doing ./python Lib/test/test_foo
Zachary Ware added the comment:
Version 4 looks good to me!
--
___
Python tracker
<http://bugs.python.org/issue5066>
___
___
Python-bugs-list mailing list
Unsub
Zachary Ware added the comment:
Version 4 replaces test_main() with unittest.main()
--
Added file: http://bugs.python.org/file28650/issue16852.v4.diff
___
Python tracker
<http://bugs.python.org/issue16
Zachary Ware added the comment:
Here's version 2 of the patch, which converts the doctests to a standard
testcase and removes test_main().
--
Added file: http://bugs.python.org/file28651/test_bisect_fix.v2.diff
___
Python tracker
Zachary Ware added the comment:
Patch v2, in which test_main() goes away.
--
Added file: http://bugs.python.org/file28652/test_asyncore_fix.v2.diff
___
Python tracker
<http://bugs.python.org/issue16
Zachary Ware added the comment:
Version 2 removes test_main() and associated ``tests`` list.
--
Added file: http://bugs.python.org/file28654/test_array.v2.diff
___
Python tracker
<http://bugs.python.org/issue16
New submission from Zachary Ware:
Version 2 replaces test_main() with unittest.main().
--
Added file: http://bugs.python.org/file28655/test_bufio_fix.v2.diff
___
Python tracker
<http://bugs.python.org/issue16
New submission from Zachary Ware:
Patch looks good to me. Thank you, Berker!
--
___
Python tracker
<http://bugs.python.org/issue16905>
___
___
Python-bugs-list m
New submission from Zachary Ware:
This patch fixes discovery for test_bytes.py. That fix changes
string_tests.py, which breaks test_unicode.py and test_userstring.py, so those
two files have been changed as well. All three test files also use
unittest.main() now instead of test_main
Changes by Zachary Ware :
--
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue16910>
___
___
Python-bugs-list mailing list
Unsubscri
New submission from Zachary Ware:
Here's the fix for test_codecs.py, I believe. I had a few headaches trying to
get this patch created without changing some of the characters or adding a BOM
to the file, and at one point the test was failing for no apparent reason.
This version of the
New submission from Zachary Ware:
Here's a fix for test_crypt.py, inspired by Ezio's mention of using setUpModule
in issue 16905.
I can't test this on a platform that actually has _crypt at the moment, but I
should be able to later today if nobody else has before then. Some
Changes by Zachary Ware :
--
components: Tests
files: test_configparser_discovery.diff
keywords: patch
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for test_configparser.py
type: behavior
versions: Python 3.3
Zachary Ware added the comment:
I was just about to test it at home and couldn't find it in my list of open
issues.
Thanks, Ezio :)
--
___
Python tracker
<http://bugs.python.org/is
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue16935>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
I agree that raising SkipTest (or subclasses thereof, such as ResourceDenied)
at module level should be supported. That would mean no changes would be
needed in most of the should-be-skipped-but-fail-instead tests listed in issue
16748 to make test discovery
Zachary Ware added the comment:
Georg:
> Note that Sphinx' "make text" output already should be suitable. We
> already update the pydoc topics with that on every release, so we could
> just as well do the same for the IDLE doc. No need for another
> separate sc
Zachary Ware added the comment:
Chris:
> There are lots of modules to change here. I wonder if some or most of
> this couldn't be automated.
Possibly, but I don't mind going through individually if Ezio (or others) don't
mind committing individually. From what I'
Zachary Ware added the comment:
> I don't think we have to worry about it getting out of date quickly.
Fair point :)
> Automatically generating the IDLE help at run time from a documentation
> source file is not posssible anyway, since the doc sources are not
> availa
Zachary Ware added the comment:
For the conversion from test_main() to unittest.main(), I could certainly see
automation helping a lot; most cases are very simple. But really, that issue
is somewhat tangential to this one and in my last message I was thinking from
the perspective of just the
New submission from Zachary Ware:
Here's an incomplete patch to test_concurrent_futures.py that does not convert
from test_main() to unittest.main(); the decorator on test_main has me unsure
how to make the conversion. I've attempted moving various parts of the
decorator'
Zachary Ware added the comment:
That looks quite good, except for the fact that discovery (of the form `python
-m unittest discover Lib/test/ 'test_*.py'`) won't hit reap_threads or
reap_children. It does cover `python -m test.test_concurrent_futures` and
standard regrtest, t
Zachary Ware added the comment:
Ok then, I'll update the patch. Thanks, Brett!
--
___
Python tracker
<http://bugs.python.org/issue16968>
___
___
Python-bugs-l
Zachary Ware added the comment:
Hmmm, actually, I was wrong; Brett's suggestion doesn't cover running as part
of regrtest. It looks like Chris is right and some kind of load_tests magic
will have to happen. I'm looking into it now.
--
___
Zachary Ware added the comment:
Sorry, I wasn't as clear as I meant to be in my last message, I was suddenly
rushed and didn't realize I'd left out what I meant to say, which was:
Now that Andrew has committed Todd's fix to issue 5066, idle.rst and help.txt
are very well
Zachary Ware added the comment:
I'm at a loss on this one. I tried a few different methods of wrapping the
tests in load_tests(), I tried doing support.threading_setup() in setUpModule
and support.threading_cleanup() in tearDownModule, tried the same in each test
class (following the ex
Zachary Ware added the comment:
Thank you, Chris. I'm rather ashamed of how long I've spent beating my head on
this issue and missed the spare tests reference in runtest_inner.
Simply removing the "tests" name entirely clears things up, if this isn't too
ugly:
diff
Zachary Ware added the comment:
Here's a patch that I believe nicely handles the raising of unittest.SkipTest
at module level while doing test discovery. It adds a _make_skipped_test
function to unittest.loader, and an ``except case.SkipTest`` clause to
TestLoader._find_tests. For ou
New submission from Zachary Ware:
Here's a fix for test_robotparser.py. With this patch, the command 'python -m
unittest discover Lib/test/ "test_*.py"' can actually be run--before the patch,
test_robotparser's unique TestCase subclass causes un
Zachary Ware added the comment:
Right you are, Chris. v4 has a comment added to regrtest.runtest_inner
pointing back to this issue.
Also in v4, ReapedSuite has been moved to test.support. At least one other
test module (test_pydoc) uses the same idiom as test_concurrent_futures, and so
Zachary Ware added the comment:
Since the older Windows project files were removed, v10 removes the patches to
them.
Everything else still applies cleanly.
Also, in the spirit of what Brett said in 16651 about not re-implementing
blindly, I did just look up what Jython, IronPython, and PyPy
Zachary Ware added the comment:
I failed to mention; v4 also removes setUpModule() which was present in the
first 3 patches. With 16935 fixed, setUpModule would be unnecessary.
--
___
Python tracker
<http://bugs.python.org/issue16
Changes by Zachary Ware :
--
components: Tests
files: test_ctypes_discovery.diff
keywords: patch
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for test_ctypes.py
type: behavior
versions: Python 3.3, Python 3.4
Added
New submission from Zachary Ware:
This patch fixes discovery for test_dbm.py and removes test_main() from
test_dbm, test_dbm_dumb, test_dbm_gnu, and test_dbm_ndbm.
It also removes unnecessary __init__ methods from DumbDBMTestCase and
WhichDBTestCase, which only called unittest.TestCase
Changes by Zachary Ware :
--
components: Tests
files: test_file_discovery.diff
keywords: patch
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for test_file.py
type: behavior
versions: Python 3.3, Python 3.4
Added file
Zachary Ware added the comment:
Sure can. With a little luck, I'll have the patch ready later today; with less
luck it'll be sometime later this week.
--
___
Python tracker
<http://bugs.python.o
Zachary Ware added the comment:
I think this patch should cover the test and Doc changes necessary. Of course,
let me know if it doesn't :)
--
Added file: http://bugs.python.org/file29039/issue16935.v2.diff
___
Python tracker
Zachary Ware added the comment:
Having thought about this more, I think I agree that this is the wrong approach
to the issue and that a more general ability to add command line options to
unittest would be better. Closing this issue.
--
resolution: -> rejected
status: open ->
Zachary Ware added the comment:
Perhaps it would be best to either combine SuppressCoreFiles and
suppress_crash_popup, or provide a new construct that does so since both are
used in almost every place one is used. Also, test_daemon_threads_fatal_error
in test_threading should be using
Zachary Ware added the comment:
Issue17326 can now be closed as a duplicate of this issue.
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue19
Zachary Ware added the comment:
Here's a patch that combines Valerie's patch with a merged suppress_crash_popup
and SuppressCoreFiles called SuppressCrashReport.
Tests ok on Windows; I haven't been able to test on Unix yet.
--
Added file: http://bugs.python.org/file3
Zachary Ware added the comment:
I had missed this issue before; issue16968 tracks the same thing.
There are a couple of issues that the committed patch doesn't address. Namely,
the file still uses test_main, and there is no thread or process reaping when
running the file via disc
New submission from Zachary Ware:
Full title: Update PCbuild/readme.txt to be more accurate, more descriptive,
more complete, less repetitive, more audience-aware, and all around, hopefully,
better.
What started as a simple patch to fix the supported Windows versions list, the
legacy build
Zachary Ware added the comment:
Here's the patched file for easier review.
--
Added file: http://bugs.python.org/file32149/patched_pcbuild_readme.txt
___
Python tracker
<http://bugs.python.org/is
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue19229>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
Oops, forgot to provide the [1] link...
[1] https://mail.python.org/pipermail/python-dev/2013-October/129477.html
--
___
Python tracker
<http://bugs.python.org/issue19
Zachary Ware added the comment:
Even after reading through #15061, I still wonder why _compare_digest is in
_operator at all. It makes even less sense to me to put a Python
implementation in operator; shouldn't the Python implementation be in the
module that actually uses it?
Branching
Zachary Ware added the comment:
Thanks, Tim! There are a couple minor things I'd like to get into a new patch
before it's committed (there are a couple tabs that should be spaces, and I'd
like to add a very short note to the Sub-Projects header about sub-projects
being contai
Zachary Ware added the comment:
Here's the new patch, a few tabs converted, a few trailing spaces removed, and
one sentence added to the Sub-projects section description.
--
Added file: http://bugs.python.org/file32336/pcbuild_readme.v2
Zachary Ware added the comment:
This patch will only apply to tip. There would need to be some changes to
backport to 3.3 and I haven't actually looked at 2.7, but I expect it would
require extensive changes that probably wouldn't be worth it. There are a few
factual errors in 3.
New submission from Zachary Ware:
As discussed in issue19273, here are a pair of patches that correct factual
errors in PCbuild/readme.txt in both 2.7 and 3.3.
The 3.3 patch makes the following changes:
- Remove Win2k mentions, it is not supported (Tcl nmake command also adjusted)
- MSVCRT9
Changes by Zachary Ware :
Added file: http://bugs.python.org/file32357/pcbuild_readme-2.7.diff-w
___
Python tracker
<http://bugs.python.org/issue19391>
___
___
Python-bug
Changes by Zachary Ware :
Added file: http://bugs.python.org/file32355/pcbuild_readme-3.3.diff-w
___
Python tracker
<http://bugs.python.org/issue19391>
___
___
Python-bug
Zachary Ware added the comment:
The 2.7 patch makes the following changes:
- python30.dll -> python27.dll
- remove "(see below)" from _bsddb and _sqlite3 which have nothing to see below
- bz2.vcproj isn't as magical as it made out to be, and it can clean itself
- nasmw ->
New submission from Zachary Ware:
Here's a patch that builds _testembed on Windows and adjusts test_capi to not
skip EmbeddingTests on Windows. The .vcxproj is based on _freeze_importlib,
with "when to build" settings lifted from _testimportmultiple.
The pat
Changes by Zachary Ware :
Added file: http://bugs.python.org/file32416/test_capi_cleanup-3.3.diff
___
Python tracker
<http://bugs.python.org/issue19440>
___
___
Python-bug
New submission from Zachary Ware:
Here's a patch to clean up test_capi a little bit; it removes a __future__
import, converts from test_main to unittest.main, and makes use of subtests to
run each _testcapi function.
I'll post a separate patch for 3.3; there's just enough dif
Zachary Ware added the comment:
Adding to Vajrasky's report, the same commit also adds 3 warnings when building
on Windows:
..\Objects\unicodeobject.c(10588): warning C4018: '>' : signed/unsigned
mismatch [P:\Projects\OSS\Python\cpython\PCbuild\pythoncore.vcxproj]
..\Objec
New submission from Zachary Ware:
Here's a patch to remove the compiler warning raised during the "clean" step on
the Windows buildbots. The warning is about the fact that ssl.vcxproj doesn't
have an NMakeCleanCommandLine command; the patch adds such a command that
simply
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file30080/2.7_rt.bat_tcltk_fix.diff
___
Python tracker
<http://bugs.python.org/issue17883>
___
___
Pytho
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file30156/issue17883.diff
___
Python tracker
<http://bugs.python.org/issue17883>
___
___
Python-bugs-list m
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file30196/issue17883-tmp-test.diff
___
Python tracker
<http://bugs.python.org/issue17883>
___
___
Python-bug
Zachary Ware added the comment:
Buildbots are still hanging on test_ttk_guionly and failing test_tcl and both
patches still apply cleanly.
Is there anything I can do to help move this forward again?
--
___
Python tracker
<http://bugs.python.
Zachary Ware added the comment:
That appears to be the case:
"""
P:\Projects\OSS\Python\cpython\ $ chcp
Active code page: 437
P:\Projects\OSS\Python\cpython\ $ PCbuild\python_d.exe
Python 3.4.0a4+ (default:995173ed248a+, Nov 1 2013, 09:12:43) [MSC v.1600 32
bit (Intel)] on w
Zachary Ware added the comment:
If there are no objections, I'd like to commit both of these in the next day or
two (which is nice to be able to say :)).
--
nosy: +brian.curtin
stage: committed/rejected -> patch review
___
Python tracke
Zachary Ware added the comment:
If there are no objections, I'd like to commit this one soon.
--
nosy: +brian.curtin
stage: -> patch review
___
Python tracker
<http://bugs.python.org
Changes by Zachary Ware :
--
assignee: -> zach.ware
___
Python tracker
<http://bugs.python.org/issue19440>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Zachary Ware :
--
assignee: docs@python -> zach.ware
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue19391>
___
___
Pyth
Zachary Ware added the comment:
These diffs are produced by `hg diff --git`. If I'm not mistaken, the reason
there is no review link is because these patches are not against default
branch. Here's one without the `--git` option though, just to see if I'm wrong
:). If I am, I
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file32356/pcbuild_readme-2.7.diff
___
Python tracker
<http://bugs.python.org/issue19391>
___
___
Python-bug
Zachary Ware added the comment:
How wrong I was...
--
Added file: http://bugs.python.org/file32469/pcbuild_readme-2.7.diff
___
Python tracker
<http://bugs.python.org/issue19
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file32354/pcbuild_readme-3.3.diff
___
Python tracker
<http://bugs.python.org/issue19391>
___
___
Python-bug
Changes by Zachary Ware :
Added file: http://bugs.python.org/file32470/pcbuild_readme-3.3.diff
___
Python tracker
<http://bugs.python.org/issue19391>
___
___
Python-bug
Changes by Zachary Ware :
Removed file: http://bugs.python.org/file32468/pcbuild_readme-2.7.diff-w-no-git
___
Python tracker
<http://bugs.python.org/issue19391>
___
___
Zachary Ware added the comment:
This patch's changes to test_capi seem to work for Windows and keeps at least
Gentoo and FreeBSD 10 happy.
--
stage: -> patch review
Added file: http://bugs.python.org/file32471/issue19439.v2.diff
___
Python
Zachary Ware added the comment:
Well, this is embarrassing. I'm so used to there not being much difference
between 3.3 and 3.4; I didn't even think about subTest being new, and obviously
I didn't test it as I should have.
Here's a new patch for 3.3 (tested this time!) t
Zachary Ware added the comment:
Thanks for the lesson, Vajrasky and David, and thank you for the review Brian.
The final commit did have a couple changes not in the posted patch, just fixes
of the same two obvious typos in both branches (avalible -> available, lniked
->
Zachary Ware added the comment:
I'll leave this open until the buildbots prove happy.
I did make a couple extra changes to the patch to TclTest.testLoadWithUNC to
make a couple of skip conditions actually report a skip instead of just
returning, and to remove a superfluous '
Zachary Ware added the comment:
Vajrasky Kok wrote:
> When building Python in Windows in release mode (not debug mode), I had
> to download the Tcl/Tk binary build from ActiveState
It is a bit of a hassle, but you can build your own Release mode Tcl/Tk; there
are instructions in the
Zachary Ware added the comment:
The buildbots appear to be happy, no more hanging and no more testLoadWithUNC
failure. There is a failure in test_tcl on one bot, but it is not related to
this issue.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status
Zachary Ware added the comment:
Having another chance to look at this one, my previous message was incorrect;
Terry's patch does not fix the issue for an installed Python 2.7. The only
change it needs to work, though, is to replace 'Tkinter' with 'FixTk' in the
Zachary Ware added the comment:
An alternative that works and also removes repeated "Warning -- os.environ was
modified by test_*" is to import FixTk at the top of test_support, allowing the
environment to be set up and to persist throughout all of the tests. I'm not
sure
New submission from Zachary Ware:
After the recent commits to 3.2, I noticed that the only non-red 3.2 buildbots
are the Windows bots; all other 3.2 bots are failing on `make touch`, which
doesn't exist in 3.2.
The simplest fix seems to me to be to add a fake 'touch' target t
Zachary Ware added the comment:
Looks like the last commit broke 8.5.15 on Windows; in particular, on line 25
of widget_tests.py, int_round doesn't exist. Replacing 'int_round' with
'round' allows most tests to pass, but I sti
Zachary Ware added the comment:
Working from ce08158e3f6c with 8.5.15 on Windows, I get the same failures with
a different AssertionError:
==
FAIL: test_insertwidth (tkinter.test.test_tkinter.test_widgets.EntryTest
Zachary Ware added the comment:
FTR, both 8.5.11 and 8.6.1 pass all tests on Windows from ce08158e3f6c (with
unrelated modifications required to build and use 8.6.1).
--
___
Python tracker
<http://bugs.python.org/issue19
Changes by Zachary Ware :
--
nosy: +zach.ware
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue15411>
___
___
Python-bugs-list mai
Changes by Zachary Ware :
--
nosy: +zach.ware
stage: needs patch -> patch review
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/iss
New submission from Zachary Ware:
There is only one remaining compiler warning on 32-bit Windows, see [1]
(buildbot doubles warning counts on the Windows bots).
The warning is coming from Modules/_sha3/keccak/KeccakF-1600-opt32.c#l497,
which uses extractLanes as defined on line 213.
The
1301 - 1400 of 2740 matches
Mail list logo
