Zachary Ware added the comment:
>Serhiy Storchaka added the comment:
>
>Oh, sorry, I missed issue17689.
That's alright, this is a legitimately different issue that just happens to
encompass the purpose of the other. As long as your patch hits all the points
mine meant to, I&
Zachary Ware added the comment:
Looking at this one again, I missed removing the run_unittest import. Here's a
new patch.
--
Added file: http://bugs.python.org/file30631/test_locale_discovery.v2.diff
___
Python tracker
<http://bugs.py
Zachary Ware added the comment:
Jeremy, can you give me the output of a test run with issue17883-tmp-test.diff
applied? (Or just what a `python -m test -v test_ttk_guionly` gives with
..\tcltk\bin on the PATH)
--
___
Python tracker
<h
New submission from Zachary Ware:
The test package is almost to the point where I can run `PCbuild\python_d.exe
-m unittest discover Lib/test/ "test_*.py"` and get a useful result, the only
thing that still blows up is multibytecodec_support.py. I had not previously
noticed this p
Changes by Zachary Ware :
--
type: enhancement -> behavior
___
Python tracker
<http://bugs.python.org/issue18258>
___
___
Python-bugs-list mailing list
Un
Zachary Ware added the comment:
So many things have been fixed since I last made a list of failing modules that
it seemed like time to make a new one. First, failing modules that already
have open issues with patches:
- test_codecmaps* (issue18258)
- test_concurrent_futures (issue16968
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue16662>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Zachary Ware:
This one is another inheritance issue. The patch removes unittest.TestCase as
a base for LargeFileTest and converts test_main into setUpModule, load_tests,
and tearDownModule. This seems like the way to go due to the fact that the
order of test execution
Zachary Ware added the comment:
Being Python 3, it should actually be "builtins" rather than "__builtins__".
Also, imp.rst and importlib.rst have the same issue in the description of
reload().
--
nosy: +zach.ware
___
P
Changes by Zachary Ware :
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue18272>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Zachary Ware:
Technically, test discovery already works for test_json.py / json_tests, but
not the way really expected (each test file is discovered individually), and
not as simply as it could. The attached patch does the following:
- remove test_json.py
- rename
Zachary Ware added the comment:
Ok, I've managed to cobble together a buildbot setup to test the hang myself
and have come up with a couple possible solutions.
The first is to change the buildbot service on the slaves to allow desktop
interaction. This way, the tests can actually run
Zachary Ware added the comment:
> Jeremy Kloth added the comment:
>
> Although the solution for test_ttk_guionly of disabling the gui resource is a
> good quick fix, I'm curious as to why there isn't the same issue (test hangs)
> when run using 3.3 on the same machi
Zachary Ware added the comment:
It seems all it took to backport was a copy and paste. Here's the patch.
--
Added file:
http://bugs.python.org/file30703/issue17883-add_is_gui_available.diff
___
Python tracker
<http://bugs.python.org/is
Zachary Ware added the comment:
I had a chance to look at this today and took a stab at writing a patch
(attached). Since moving all of the test functions into a TestCase subclass
necessarily means indenting everything another level, the patch is a huge ugly
mix of - and + lines that don&#
Changes by Zachary Ware :
Added file: http://bugs.python.org/file30729/issue16000.v1-cmp.diff
___
Python tracker
<http://bugs.python.org/issue16000>
___
___
Python-bug
Zachary Ware added the comment:
Here's a stab at fixing that issue. It works, but I don't know that it's the
best solution.
This patch converts test_seek into setUp, and attempts to make sure the test
file is in the same state at the beginning of each test, with a new
tearDow
Zachary Ware added the comment:
Here's a new patch addressing Serhiy's Rietveld comment. This patch also
includes the addition of 'flush=True' to the verbose print in
BaseLocalizedTest.setUp to make output look a little nicer.
--
Added file: http://bugs.
Zachary Ware added the comment:
After testing on Windows, here's version 3. This version changes tearDownClass
to truncate the file rather than unlink it, and adds a check to make sure the
file is properly truncated to 0 length. Unlinking the file makes the test take
an extra 40 secon
Zachary Ware added the comment:
How about this patch?
I agree that "types of arguments/parameters" has great potential for confusion,
so the glossary has been changed to "kinds of argument/parameter" (dropping the
pluralization as well; it is unnecessary). I think just t
Zachary Ware added the comment:
I have recently learned why this issue had seemed transient to me previously:
the hg eol extension apparently causes hg to create all files that are not
explicitly set to LF or BIN using CRLF on Windows. Thus, this is what happens:
"""
P:\Pyt
Changes by Zachary Ware :
Added file: http://bugs.python.org/file30785/issue18326.that.diff
___
Python tracker
<http://bugs.python.org/issue18326>
___
___
Python-bug
Zachary Ware added the comment:
Since there's been another test added since the last version of this patch,
here's a new patch again. I'll also be attaching a patch to 3.3, which
includes backports of the 4 changesets mentioned in my last message, as well as
the changes
Changes by Zachary Ware :
Added file:
http://bugs.python.org/file30879/test_multiprocessing_discovery.v3-3.3.diff
___
Python tracker
<http://bugs.python.org/issue17
Zachary Ware added the comment:
No complaints here.
--
___
Python tracker
<http://bugs.python.org/issue17944>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
I'm not sure that moving the tcltk output dir into PCbuild is the right way to
go about making different versions of Tcl/Tk available to different Python
versions. For one, because it's not true if you're working out of a single
checkout for mu
New submission from Zachary Ware:
In a thread on python-ideas[1], Nick mentioned the idea of
``operator.by_symbol['+=']`` which would be an alternative method of getting
the operator.iadd function. The idea struck my fancy, so I implemented it
(regardless of the very real poss
Zachary Ware added the comment:
Just from a bit of testing without looking at the patch very much, there are a
couple of things that need to be fixed. First, the + and += links don't work,
tested on Firefox and Konqueror on Linux. Second, there are a couple of
symbols which should have
Zachary Ware added the comment:
I'm on 32 bit Windows 7 Pro, SP1, and have also reproduced the issue on 64 bit
Windows 7 Home Premium, SP1. I use the standard Command Prompt (cmd.exe) on
both.
--
___
Python tracker
<http://bugs.py
Zachary Ware added the comment:
The purpose is to make usage of the operator module more readable, particularly
for some of the more exotic operators. For instance, I find
``operator.get_op(">>=")`` to be a lot more obvious about what's going to
happen than ``operato
Zachary Ware added the comment:
I've done a small amount of testing on Windows (both with the issue18457 patch
applied and without), and there is no such crash there. Output isn't what is
expected (the cell is lengthened, but nothing is shown), but no crash.
--
nosy:
Zachary Ware added the comment:
Aside from '<>' still being present, the patch looks good to me. There are a
couple of issues with content, but those are separate from this issue. (For
instance, '~', '>>', and '<<' direct to t
Zachary Ware added the comment:
In looking at test_decimal for issue16748, I discovered that not all of the
doctests for _decimal are being tested. So, I fixed it (or at least tried to
:).
This patch does the following:
- Replace most inspect.isfunction checks in DocTestFinder with
Zachary Ware added the comment:
R. David Murray wrote:
> So, the fact that the tests don't run if discovery is used is still a
> bug. I'm not sure how we fix it, given the nature of the resource.
My preferred solution short of adding resource management to unittest is to add
New submission from Zachary Ware:
Here's a patch to implement the idea I posted in issue18258, msg193242. The
patch also removes usage of "support.use_resources = ['']" from the
test package since it is no longer needed.
(No test_main -> unittest.main conversions
Zachary Ware added the comment:
Done, issue18492.
I'll submit and updated patch here when (if :)) that one is applied.
I'm also looking into adding resource handling to unittest itself and it is
going pretty well; I hope to have a patch ready for review for
Zachary Ware added the comment:
Terry J. Reedy added the comment:
> The problem is that this permissiveness does not apply to subsidiary files
> discovered from and run by a main file, even though it should. The current
> workaround is to explicitly set use_resources for the b
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue18441>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Zachary Ware:
Here is an initial attempt at adding resource management/guarding to unittest,
a la test.support.requires.
The patch adds 6 new names to unittest.__all__; one function called
'registerResource' which explains itself, one function and one decorator
Zachary Ware added the comment:
(Apologies for the delay in replies, my available time evaporated without
notice...)
Antoine Pitrou wrote:
> Does registerResource() mutate some kind of global per-process state? This
> doesn't sound like a good idea.
It's not the greatest of
Zachary Ware added the comment:
Antoine Pitrou wrote:
> I've committed a fix to 2.7 (I hope it's really a fix, since I don't know how
> to test it).
> I'll let Benjamin and Barry decide whether to backport to 2.6 and 3.2.
> As for 3.1, it's pretty much dea
Zachary Ware added the comment:
Here's a new patch; test_json.__main__ now uses an absolute import rather than
trying to use a relative one. Also, Makefile.pre.in is fixed (thank you, Ned!).
--
Added file: http://bugs.python.org/file31190/test_json_discovery.v2-3.3
Zachary Ware added the comment:
That's a much better solution, thank you, Serhiy. Here's a new patch.
test.support is no longer changed at all, but regrtest.py still is; the extra
reference to the tests still causes issues, so it is removed.
--
Added file:
http://bugs.
Zachary Ware added the comment:
A lot of this discussion has flown a rather unfortunate distance over my head,
especially since I've barely had time to follow it. But it looks to me
like--given the number of other places that do the same thing as operator.index
currently does--there nee
Zachary Ware added the comment:
How about this?
--
Added file: http://bugs.python.org/file31385/issue18326.v2.diff
___
Python tracker
<http://bugs.python.org/issue18
Zachary Ware added the comment:
Ping!
Anyone able to do a review of this patch? It still applies cleanly to default
(or even 3.3, if this qualifies as a bug rather than a new feature).
--
___
Python tracker
<http://bugs.python.org/issue3
Zachary Ware added the comment:
Ping!
The buildbots still seem to be failing, are my proposed fixes acceptable? Both
patches still apply cleanly.
--
___
Python tracker
<http://bugs.python.org/issue17
Zachary Ware added the comment:
How about a combination of the two? It's still short, but gets the point
across without assuming the reader knows exactly what 'keyword-only argument'
or requiring further reading, while introducing the term and providing the link
for deepe
Changes by Zachary Ware :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue17326>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue18702>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
I took a stab at the doc changes, attached here and including Barry's patch.
--
components: +Library (Lib)
type: -> enhancement
versions: +Python 3.4
Added file: http://bugs.python.org/file31575/16662_with_
New submission from Zachary Ware:
Since test.support was moved into its own package, support.open_urlresource has
been unable to work. It expects <__file__ dir>/data to exist, but since
<__file__ dir> is now Lib/test/support instead of Lib/test, it doesn't unless
someone cr
Zachary Ware added the comment:
Here's an alternative fix, which just makes open_urlresource look one directory
higher than where __file__ lives.
--
Added file: http://bugs.python.org/file31638/fix_support_open_urlresource.diff
___
Python tr
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue6858>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Zachary Ware :
I was looking through the documentation source files for things I might be able
to fix, and stumbled across "XXX Add a bit on the difference between tuples and
lists." in Doc\tutorial\datastructures.rst. So I took a stab at adding some
prose to ad
Zachary Ware added the comment:
Perhaps an added line at the end, something like 'Of course, should you need an
immutable list, tuples are quite handy for that, too.'?
--
___
Python tracker
<http://bugs.python.o
Zachary Ware added the comment:
I'll go with foolhardy, or just "green" :P. I wasn't aware that this topic was
quite as contentious as it seems to be.
I agree that tuples and lists are similar. I was trying to keep my wording at
"here's another way to look a
Zachary Ware added the comment:
Ezio's version looks pretty good to me. About the only quibble I can think of
is the removal of the example uses; they still apply and do help the point.
Just tacking on "Classic examples of tuples include (x, y) coordinate pairs and
database record
New submission from Zachary Ware :
A couple months ago, I had never before heard of function annotations and came
across a function that had them (I don't remember where or what it was). I
spent a fair bit of time searching fruitlessly to figure out what the heck that
"->&quo
Zachary Ware added the comment:
Thanks for the review :). Replied and here's the updated patch.
--
Added file: http://bugs.python.org/file25708/annotations_tutorial.v2.patch
___
Python tracker
<http://bugs.python.org/is
New submission from Zachary Ware :
See: http://hg.python.org/cpython/file/d31e83497c5a/Doc/library/sqlite3.rst#l708
PEP 246 is headed by:
"""
Rejection Notice
I'm rejecting this PEP. Something much better is about to happen;
it's too early to say exactly wh
Zachary Ware added the comment:
I just tested on Python 3.2, and found something interesting; it seems a ^Z
character on a line that has other input read in as a character. Also, other
input after an EOF on its own means you still have to do two more EOFs to end.
Python 3.2.3 (default, Apr
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue14187>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue15102>
___
___
Python-bugs-list mailing list
Unsubscribe:
Zachary Ware added the comment:
I came across this issue and thought it might be within my means to attempt a
patch, so here's the first step towards one. I liked Terry's suggestion of
implementing __format__ using .as_decimal, so that's what I'm working towards
with this
Zachary Ware added the comment:
(Mark:)
>To the patch: It looks fine, as far as it goes. It needs tests.
I remembered tests about 5 minutes after I submitted the initial patch :P.
Here's a patch with some tests. Note that I've never really done tests, so
please let me know
Changes by Zachary Ware :
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.org/issue15783>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Zachary Ware:
There are several small inconsistencies in the winreg module documentation
(docstrings and winreg.rst). Mostly these are discrepancies between "res" and
"reserved", "sam" and "access", and whether or not those two ar
Zachary Ware added the comment:
Okie doke. I'll try to have a patch ready for review later this afternoon.
--
___
Python tracker
<http://bugs.python.org/is
Zachary Ware added the comment:
Here's the patch against 3.2, hopefully I caught everything I meant to :)
Unfortunately, I can't build Python or the docs on this machine, so I can't
guarantee I didn't break anything. I tried to be careful though, especially
with changi
Zachary Ware added the comment:
It occurs to me that I should have asked; should the documentation be changed
to match the code, or the code to match the documentation (with regards to the
default argument to the access parameter in a few functions
Zachary Ware added the comment:
That's what I figured, so that's what I did in the patch; but I've also seen
cases in Python where prior documentation has dictated how the code should
work. Thanks for the confirmation.
--
___
Python
Zachary Ware added the comment:
Thanks for the commit! 3.2 looks good now.
3.3 and default still need a little work, though; the docstrings still say
"WindowsError" instead of "OSError" and the docs say "a OSError" instead of "an
OSError".
The attached
Zachary Ware added the comment:
Éric Araujo wrote:
> From #20265:
Correction, this is #20265, that message was from #20266 :)
Kathleen: both Éric and I have left some review comments for you in Rietveld,
which should have sent you an email with the comments and links to the Rietveld
rev
Zachary Ware added the comment:
The problem with the previous approach and building inside Visual Studio was
that makefile.vc in both Tcl and Tk first checks for one of "MSDEVDIR",
"MSVCDIR", "VCINSTALLDIR", "MSSDK" or "WINDOWSSDKDIR" being
Zachary Ware added the comment:
I got a few failures on my Windows machine running `PCbuild\python_d.exe -m
test -j0 -rW` [1], only one of which looks relevant [2]:
==
FAIL: test_monotonic (test.test_time.TimeTestCase
Zachary Ware added the comment:
Victor Stinner wrote:
> Is it a virtual machine or a physical machine? Was your Windows busy?
> Did you run tests in parallel?
Physical, not really other than the tests, and I ran with -j0 (on a machine
with 2 single core CPUs).
I'm not sure what I t
Zachary Ware added the comment:
Unless I'm mistaken, this was already fixed in #20929. Since 3.4.0 was in RC
stage when you reported #20929 and the fix was not release-critical, it was not
cherry-picked into 3.4.0 final. It will be fixed in 3.4.1 and 3.5.
If I'm wrong and this is
Zachary Ware added the comment:
Fixed, thanks for the report!
--
nosy: +zach.ware
type: resource usage -> behavior
versions: -Python 3.1, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Zachary Ware added the comment:
I just installed 64-bit 3.4.0 on 64-bit Win7 with no trouble at all, and
python34.dll is sitting happily in C:\Windows\System32.
To try to figure out what you did that I didn't (or vice versa), I have a few
questions for you:
1) How did you run the inst
Changes by Zachary Ware :
--
stage: -> test needed
type: -> behavior
versions: +Python 3.5 -Python 3.1, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/i
Zachary Ware added the comment:
Hmmm, it looks like your patch is missing a file. You may need to run "hg
add", then create your patch again.
--
___
Python tracker
<http://bugs.python.o
Zachary Ware added the comment:
Whoops, that patch contains way more than you wanted :). I should have
suggested "hg add *.rst". Attaching what should be the right patch, review to
come.
--
Added file: http://bugs.python.org/file34525/kw-issue
Changes by Zachary Ware :
--
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue17442>
___
___
Python-bugs-list mailing list
Unsub
Changes by Zachary Ware :
--
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue19385>
___
___
Python-bugs-list mailing list
Unsub
Zachary Ware added the comment:
Review of kw-issue17846.diff:
setup.rst
- hunks 1 & 2 (@@ -49,9 and @@ -216,7):
Both changes should be reverted. The change from 3.4 -> 3.3 reverts a very
recent change made due to 3.4 becoming the newest maintenance branch. If
I'm not mistake
Zachary Ware added the comment:
If there are no objections before then, I'll split out the Tix parts of this
patch and commit the rest this weekend. I'll open a new issue for adding Tix
to the mix.
--
___
Python tracker
<http://bu
Zachary Ware added the comment:
It turns out that adding a slash to the end of the existing address was enough
to get the right redirect, so I went with that instead of your patch.
Either way, thanks for the report!
--
assignee: -> zach.ware
nosy: +zach.ware
resolution: ->
Zachary Ware added the comment:
Thanks for the #3158 addition, David :)
We've been a week with no more major changes; is this issue done?
--
___
Python tracker
<http://bugs.python.org/is
Zachary Ware added the comment:
The earlier in a release cycle we switch NEWS methods, the better. Does anyone
have any thoughts to share about this, either on Brett's newsworthy.py, my
news.py/news_release.py, or another approach entirely?
I've updated the playground branch
Changes by Zachary Ware :
--
keywords: +patch
Added file: http://bugs.python.org/file34536/0607c4a2e890.diff
___
Python tracker
<http://bugs.python.org/issue18
Zachary Ware added the comment:
It will have to be a separate patch, but can be done in this issue.
--
___
Python tracker
<http://bugs.python.org/issue17
Zachary Ware added the comment:
The `hg commit -l ...` tricks are just for those who tend to use exactly the
same text for commit message and NEWS, and I only point them out simply because
I don't know how many people are even aware of the -l option :). If you want
to use a NEWS entry
Zachary Ware added the comment:
R. David Murray wrote:
> I want no script asking me questions. Post-facto errors for omissions are
> fine (and if I have to positively say no in the input file, that's fine).
> tkinter is right out.
I have been planning a command line interface, s
Zachary Ware added the comment:
I've used the same installer on multiple machines with no problems, as have
many others; this leads me to believe that there is no problem with the MSI :)
Did you use the same MSI file on both machines? Try re-downloading, or
checking the size and md5s
Zachary Ware added the comment:
No, 3.4 uses VS 2010. Your patch changes the line from "hg update 3.4" to "hg
update 3.3", which is not a legitimate change, in fact it undoes a change that
Éric Araujo just made. With the release of 3.4.0, 3.4 became the current
mainte
Zachary Ware added the comment:
Committed. Instead of splitting out the Tix stuff, I just disabled building
Tix in Debug configuration. I will open a new issue for enabling the Debug Tix
build.
Thank you Martin and Tim for the votes of confidence, and Jeremy for starting
this off
New submission from Zachary Ware:
Here's a patch to be applied to svn.python.org/projects/external/tix-8.4.3.x to
enable building Tix in Debug configuration. It also eliminates some
superfluous warnings due to unrecognized command line options.
Closely related to #
Zachary Ware added the comment:
Here's the patch to cpython that will be needed to enable the debug Tix build.
--
keywords: +patch
Added file: http://bugs.python.org/file34561/issue21017-cpython.diff
___
Python tracker
<http://bugs.py
Zachary Ware added the comment:
Here's a slightly less ugly version of the patch. I would really appreciate
some review on this; this should solve a test_idle issue that was exacerbated
by issue #15968 (for unknown reasons).
--
priority: low -> normal
Added fi
1001 - 1100 of 2740 matches
Mail list logo
