Changes by Yury Selivanov :
--
nosy: -yselivanov
___
Python tracker
<http://bugs.python.org/issue25895>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Yury Selivanov:
The attached patch implements an opcode cache for LOAD_GLOBAL opcode, making it
2x faster.
The idea is to use the new co_extra field of code objects & PEP 509 to attach a
cache structure pointing directly to the resolved global name. When global
Yury Selivanov added the comment:
I had to rewrite the patch to make sure it reports correct position and covers
all cases where using async/await should trigger a warning.
Brett, could you please take a look at the patch?
--
Added file: http://bugs.python.org/file44669/issue_26182
Yury Selivanov added the comment:
INADA, would you be able to address my last review comments? Also, I'm
wondering what if we could implement __del__ and __repr__ in C too, so that we
could drop BaseFuture class?
--
___
Python tracker
Yury Selivanov added the comment:
> @Yury, do you think you could get to this before b1 goes out? It's a pure
> optimization (and a good one!).
LGTM. Will commit tomorrow.
--
assignee: -> yselivanov
___
Python tracker
<http:
Yury Selivanov added the comment:
> Implementing __del__ and __repr__ in C is bit hard task to me.
> I can't do it in this week. (maybe I can't do it in this month too.)
NP. I'll take a look myself after you upload the next i
Yury Selivanov added the comment:
> Does this prolongate the lifetime of cached global objects?
No. I store borrowed references. The idea is that if the state of
globals/builtins dict has changed, we invalidate the cache.
--
___
Python trac
Yury Selivanov added the comment:
Serhiy, feel free to review the patch. Guido and Ned okayed it to be committed
before 3.6b2.
Currently the patch only optimizes one opcode -- LOAD_GLOBAL, but cveal_cache.h
file provides the infrastructure to easily implement more opcode caches. I can
Yury Selivanov added the comment:
> The feature is pretty much required these days.
We have the feature. What Jim was asking is to make server_hostname argument
optional when check_hostname is False in the ssl context
--
___
Python tracker
&l
Yury Selivanov added the comment:
> It's a bad idea.
I thought so too :) I was actually going to ask you to review this request.
In any case, feel free to close this issue.
--
___
Python tracker
<http://bugs.python.org
Yury Selivanov added the comment:
I'm going to commit the patch now (I'm going on vacation tomorrow, and I want
to watch the buildbots).
--
___
Python tracker
<http://bugs.python.o
Yury Selivanov added the comment:
Merged.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
> > On the asyncio side, with debug turned on, we see nothing.
> Does someone see a way to log a message in such case? Maybe only in debug
> mode?
I'm not sure we can do anything here. @kevinconway, did you try to find out if
it'
New submission from Yury Selivanov:
Proxy issue for https://github.com/python/asyncio/pull/418
--
assignee: yselivanov
components: asyncio
messages: 276606
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: asyncio: Handle when
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issue28174>
___
___
Yury Selivanov added the comment:
Merged! Thank you!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
This issue was fixed in #28174.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
I think we can close this one.
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
Closing this one as no one has requested this for 2 years.
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
Closing this one. Thank you Mark for discovering the issue and suggesting a
solution (still hope we'll commit your patch in 3.7).
Thank you INADA Naoki for the patch!
--
resolution: -> fixed
stage: -> resolved
status: ope
Yury Selivanov added the comment:
I'm not sure this is still relevant for the latest asyncio in 3.6. Robert,
could you please test if this is still the case?
--
___
Python tracker
<http://bugs.python.org/is
Yury Selivanov added the comment:
Looks like we already have docs for readuntil. Mark, could you please check if
we have some docs missing (or just close the issue)?
--
___
Python tracker
<http://bugs.python.org/issue26
Yury Selivanov added the comment:
I think this has been already fixed. Please reopen if I missed something.
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
Looks like this is fixed now.
--
resolution: -> works for me
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Yury Selivanov :
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/issue28176>
___
___
Python-bugs-list mailing list
Unsubscrib
New submission from Yury Selivanov:
Proxy issue for https://github.com/python/asyncio/pull/366
--
assignee: yselivanov
components: asyncio
messages: 276628
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: Fix callbacks race in
Yury Selivanov added the comment:
I've fixed the remaining review comments & committed the patch. Thank you Mark!
BTW, this also fixes http://bugs.python.org/issue27386.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
Yury Selivanov added the comment:
It looks like this was fixed by #27759!. Jim, could you please verify?
--
___
Python tracker
<http://bugs.python.org/issue27
Yury Selivanov added the comment:
Closing this one. Haven't seen this in a while, probably it was a bug in libuv.
--
resolution: -> works for me
stage: test needed -> resolved
status: open -> closed
___
Python tracker
<http:
Yury Selivanov added the comment:
I'm going to commit this patch tomorrow.
--
___
Python tracker
<http://bugs.python.org/issue28158>
___
___
Python-bugs-l
Yury Selivanov added the comment:
BTW, this will also help to make warnings more friendly in #26182.
--
___
Python tracker
<http://bugs.python.org/issue28
Yury Selivanov added the comment:
-1 on exposing app_protocol. It's an implementation detail, starttls should be
implemented in asyncio (and while it's not, it's ok to use '_app_protocol'.
--
___
Python tracker
<http:
Changes by Yury Selivanov :
--
nosy: -yselivanov
___
Python tracker
<http://bugs.python.org/issue28240>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Isn't 3.4 in security fixes only mode?
--
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue27386>
___
Yury Selivanov added the comment:
> Jim ask for a backport.
Sorry Jim, was replying from my email client, didn't see all messages.
> This is arguably a security issue because it's a DoS vector.
Yeah, I can see why. I can commit this to 3.4 in a week. Christian, feel free
t
Yury Selivanov added the comment:
Berker, I think it's an OK workaround. The test is kind of unstable, to the
point of me thinking to just remove it (keeping the rest of the patch applied).
Feel free to apply it.
--
___
Python tracker
Yury Selivanov added the comment:
> I dislike the idea of a test for a race condition which skips itself if it
fails to reproduce the race condition :-/ I like the idea of removing he
unit test.
OK, let's remove the test. I can do that myself in a couple
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28368>
___
___
Python-bugs-list
New submission from Yury Selivanov:
Proxy issue for https://github.com/python/asyncio/pull/391
--
assignee: yselivanov
components: asyncio
messages: 278148
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: Refuse monitoring processes if
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28369>
___
___
Python-bugs-list
New submission from Yury Selivanov:
Proxy issue for https://github.com/python/asyncio/pull/420
--
assignee: yselivanov
components: asyncio
messages: 278152
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: Raise RuntimeError when
New submission from Yury Selivanov:
Proxy for https://github.com/python/asyncio/pull/395
--
assignee: yselivanov
components: asyncio
messages: 278154
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: Speedup
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28370>
___
___
Python-bugs-list
New submission from Yury Selivanov:
Proxy issue for https://github.com/python/asyncio/issues/334
--
assignee: yselivanov
components: asyncio
messages: 278156
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: Deprecate passing
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28371>
___
___
Python-bugs-list
New submission from Yury Selivanov:
Like the ones that were compiled with Cython.
--
assignee: yselivanov
components: asyncio
messages: 278159
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: Fix asyncio to support formatting of non
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28372>
___
___
Python-bugs-list
Yury Selivanov added the comment:
With the latest change it's possible to implement starttls
as a separate package on PyPI, or even by copying/pasting a small
snipped of code in your project.
It's expected that we'll figure out the API design for starttls
during 3.6, so that w
Yury Selivanov added the comment:
Closing this one. We added a lot of tests as part of the PEP 530 implementation.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
Closing this one. Seems we can live just fine without these new exceptions.
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
Christian, would you be able to look into this before b2?
--
___
Python tracker
<http://bugs.python.org/issue25292>
___
___
Pytho
Yury Selivanov added the comment:
Alright, I've backported the fix to 3.4. Closing this.
--
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.
Yury Selivanov added the comment:
AFAICT this issue was resolved in https://github.com/python/asyncio/pull/378.
Closing this one. Thanks, Jim!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python track
Yury Selivanov added the comment:
This is an interesting mind twister. The key problem is that
`self.runner_task` is blocked on *itself*: so Task._fut_waiter is set to the
Task.
Therefore when the task is being cancelled, `Task.cancel` simply recurses.
One way to solve this is to prohibit
Yury Selivanov added the comment:
The most recent patch segfaults... Will try to debug.
--
___
Python tracker
<http://bugs.python.org/issue26081>
___
___
Pytho
Yury Selivanov added the comment:
INADA, would you be able to take a look?
--
___
Python tracker
<http://bugs.python.org/issue26081>
___
___
Python-bugs-list m
Yury Selivanov added the comment:
> It's pretty perverse. But how would you detect this case?
In Task._step, we can check if the future the task is about to await on is
"self".
--
___
Python tracker
<http://bugs.
Yury Selivanov added the comment:
> Is that enough? What if the recursion involves several tasks waiting
for each other in a cycle?
I'm not sure... Maybe it's OK when two tasks await on each other, I think the
current Task implementation should be able to handle that. The prob
Yury Selivanov added the comment:
I quickly looked over the patch and I think it's good. If anything we still
have time to hunt down any bugs or even revert this before 3.6 final.
INADA, feel free to commit it before Monday to 3.6 and default bra
Yury Selivanov added the comment:
Thank you, INADA! Next task -- optimize asyncio.Task in C in 3.7. Another
10-15% performance improvement.
--
___
Python tracker
<http://bugs.python.org/issue26
Yury Selivanov added the comment:
I mean another optimization possibility.
--
___
Python tracker
<http://bugs.python.org/issue26081>
___
___
Python-bugs-list m
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28399>
___
___
Python-bugs-list
New submission from Yury Selivanov:
Proxy for https://github.com/python/asyncio/pull/441
--
assignee: yselivanov
components: asyncio
messages: 278367
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: Remove UNIX socket from FS before
Yury Selivanov added the comment:
Yes, I think it's a good idea.
--
___
Python tracker
<http://bugs.python.org/issue26081>
___
___
Python-bugs-list m
Yury Selivanov added the comment:
Thank you for reporting this! Closing the issue.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
No news entry is necessary for this.
--
___
Python tracker
<http://bugs.python.org/issue28428>
___
___
Python-bugs-list mailin
Yury Selivanov added the comment:
> C implemented Future should allow overriding _schedule_callbacks.
I'm not so sure about this. Maybe we can just fix _WaitCancelFuture somehow?
--
___
Python tracker
<http://bugs.python.org
Yury Selivanov added the comment:
LGTM
--
___
Python tracker
<http://bugs.python.org/issue28452>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Yury Selivanov:
The following Python program causes a segfault in Python 3.6b2:
import socket
import asyncio
loop = asyncio.get_event_loop()
sock = socket.socket()
sock.close()
async def client():
reader, writer = await
Yury Selivanov added the comment:
I have a patch already, writing a unittest.
--
___
Python tracker
<http://bugs.python.org/issue28471>
___
___
Python-bugs-list m
Yury Selivanov added the comment:
Attaching a patch to fix this. Please review.
--
keywords: +patch
Added file: http://bugs.python.org/file45136/issue28471.patch
___
Python tracker
<http://bugs.python.org/issue28
Yury Selivanov added the comment:
> LGTM, thanks Yury!
NP :) Should this be committed to 3.6/default, or in 3.5 too?
--
___
Python tracker
<http://bugs.python.org/issu
Yury Selivanov added the comment:
> In release mode, the check is disabled by default (can be enabled at
runtime), and I don't think that the code can crash.
It actually crashed in release mode for me. Maybe the exact location of SF was
different, but whatever...
Anyways, closing t
Yury Selivanov added the comment:
> I'm curious. I tested in release mode, the example does crash:
Well, since the GIL wasn't properly acquired, it's only a matter of time until
something else crashes.
--
___
Python tracker
<h
Yury Selivanov added the comment:
I think this patch should be reverted. It breaks backwards compatibility:
import socket
sock0 = socket.socket(socket.AF_INET, socket.SOCK_STREAM, 0)
sock = socket.socket(
socket.AF_INET, socket.SOCK_STREAM, 0, sock0.fileno())
sock0
Yury Selivanov added the comment:
IOW, what is happening in uvloop:
1. A user has a Python socket object and passes it asyncio (run with uvloop)
API.
2. uvloop extracts the FD of the socket, and passes it to low-level libuv.
3. At some point of time, libuv closes the FD.
4. When user tries
Yury Selivanov added the comment:
Another example: some asyncio (run with uvloop) code:
conn, _ = lsock.accept()
f = loop.create_task(
loop.connect_accepted_socket(
proto_factory, conn))
# More code
loop.run_forever
Yury Selivanov added the comment:
My proposal: ignore EBADF in socket.close(). It means that the socket is
closed already. It doesn't matter why.
--
___
Python tracker
<http://bugs.python.org/is
Yury Selivanov added the comment:
Maybe we should fix asyncio. Maybe if a user passes an existing socket object
into loop.create_connection, it should duplicate the socket.
--
___
Python tracker
<http://bugs.python.org/issue26
Yury Selivanov added the comment:
After thinking about this problem for a while, I arrived to the conclusion that
we need to fix asyncio. Essentially, when a user passes a socket object to the
event loop API like 'create_server', they give up the control of the socket to
the loop.
Yury Selivanov added the comment:
> Ah, you became reasonable :-D
Come on... :)
> Would you mind to open an issue specific for asyncio?
I'll open an issue on GH today to discuss with you/Guido/asyncio devs.
--
___
Python tra
Yury Selivanov added the comment:
>> Would you mind to open an issue specific for asyncio?
> I'll open an issue on GH today to discuss with you/Guido/asyncio devs.
Guido, Victor, please take a look: https://github.com/python/as
Yury Selivanov added the comment:
Thank you Stephane for bumping this issue up.
I've committed the patch. I've documented CO_ASYNC_GENERATOR in more detail,
and I also added "versionadded" tags to CO_COROUTINE and CO_ITERABLE_COROUTINE.
--
r
New submission from Yury Selivanov:
Specifically when the result of the Future is tuple.
--
components: asyncio
messages: 279070
nosy: gvanrossum, inada.naoki, yselivanov
priority: normal
severity: normal
status: open
title: C implementation of asyncio.Future doesn't set val
Yury Selivanov added the comment:
Inada-san, please take a look at my commit if you have time.
--
resolution: -> fixed
stage: -> commit review
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
Yury Selivanov added the comment:
Latest patch looks good.
--
___
Python tracker
<http://bugs.python.org/issue28448>
___
___
Python-bugs-list mailing list
Unsub
Yury Selivanov added the comment:
Thanks, Stéphane! Fixed.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker
<http://bugs.python
Changes by Yury Selivanov :
--
stage: commit review -> resolved
___
Python tracker
<http://bugs.python.org/issue28492>
___
___
Python-bugs-list mailing list
Un
Yury Selivanov added the comment:
The patch looks good. 2 things:
- It appears it also touches Misc/NEWS a bit too much. Please make sure to not
to commit that.
- I'd also add a comment explaining why we ignore values passed to FI.send()
and simply send None. The reason is how F
Yury Selivanov added the comment:
Closing this one. I don't think we want to expose/document _app_transport.
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Yury Selivanov added the comment:
> Seems that its not so hard - in loop.remove_reader add
If you have a patch in mind, please create a PR on github.com/python/asyncio
--
___
Python tracker
<http://bugs.python.org/issu
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28500>
___
___
Python-bugs-list
New submission from Yury Selivanov:
Proxy for https://github.com/python/asyncio/pull/447
--
assignee: yselivanov
components: asyncio
messages: 279154
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: pep 525/asyncio: Handle when async
Yury Selivanov added the comment:
Thank you, Johannes!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
Thank you, Hans!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
Christian, what's the status on this one?
--
___
Python tracker
<http://bugs.python.org/issue28414>
___
___
Python-bugs-l
New submission from Yury Selivanov:
The attached patch implements asyncio.Task in C. Besides that, it also
implements Argument Clinic for C Future.
Performance improvement on a simple echo server implementation using
asyncio.streams:
Python Future & Task | C Future & Py Task
Yury Selivanov added the comment:
Also, with this patch uvloop becomes ~3-5% faster too.
--
___
Python tracker
<http://bugs.python.org/issue28544>
___
___
Pytho
Yury Selivanov added the comment:
> Yury, would you like to merge this before 3.6b3?
Yes!
> I'll look this as soon as possible.
Thanks a lot!
--
___
Python tracker
<http://bugs.python.
Yury Selivanov added the comment:
Guido, Ned, thanks! Andrew already glanced through the code, let's see what
Inada-san says.
I'm uploading an updated patch addressing Andrew's review.
--
Added file: http://bugs.python.org/file452
2901 - 3000 of 3098 matches
Mail list logo
